--- Begin Message ---
On 28/01/2025 01:16, Fabian Grünbichler wrote:
> Hi!
>
> sorry it took so long to get back at this series! next will be faster :)
No worries! As you can see it took me a while to get back to this too... I've
implemented all the suggestions around style and will post the updated patches
soon.
> this doesn't work in pve-manager, since you want to use/call this module in
> pve-container/qemu-server and would end up having a circular dependency. it
> could either move to pve-cluster, or to pve-guest-common (the latter would be
> my preference, since it is guest-specific).
Thanks for catching this! I've moved it to a separate commit for
pve-guest-common.
> alternatively, we could also not expand the ranges when parsing, not sure
> whether that would make things easier or more complicated though..
I tried that at one point, but found it greatly complicated the code for
minimal gain considering that using a hash map should be fast enough in
practice. For example, 100,000 recorded IDs are handled with no perceivable
difference in performance compared to an empty ID list.
--- End Message ---
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
