Am 24.03.25 um 16:43 schrieb Wolfgang Bumiller:
> Just a short high level nit today, will have to look more closely at
> this and the series the next days:
>
> There's a `new()` which takes an $scfg + $storeid.
>
> But later there are some methods taking `$self` (which usually means the
> thing returned from `new()`), which also get a `$storeid` as additional
> parameter (but without any `$scfg`). IMO the `$storeid` should be
> dropped there.
Nice catch! Yeah, I think that was an oversight when I restructured in
an earlier version. In fact, my example implementations of those
functions even use $self->{storeid} already (or don't require the
storeid at all). I'll remove those left-overs in v6.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
