Re: [pve-devel] [PATCH manager] ui: fix height 'extra cpu flags' field in create wizard

2023-11-06 Thread Thomas Lamprecht
Am 07/11/2023 um 08:50 schrieb Dominik Csapak: > On 11/6/23 17:31, Thomas Lamprecht wrote: >> just out of interest, could setting a flex+maxHeight for the extra-flags >> also have been an option? > > AFAICS there is no way to do that. The columns in an inputpanel > are an 'anchor' layout, and I co

Re: [pve-devel] [PATCH manager] ui: fix height 'extra cpu flags' field in create wizard

2023-11-06 Thread Dominik Csapak
On 11/6/23 17:31, Thomas Lamprecht wrote: Am 15/06/2023 um 10:08 schrieb Dominik Csapak: this field has a fixed height, which is too tall for the create wizard, and one cannot see the last entry when scrolling all the way down. to fix this, make it 20px shorter was still broken in the german

Re: [pve-devel] [PATCH pve-manager 2/2] ui: add bulk suspend support

2023-11-06 Thread Dominik Csapak
On 11/6/23 19:32, Thomas Lamprecht wrote: Am 18/10/2023 um 12:34 schrieb Hannes Laimer: diff --git a/www/manager6/form/VMSelector.js b/www/manager6/form/VMSelector.js index d59847f2..ad0bfc03 100644 --- a/www/manager6/form/VMSelector.js +++ b/www/manager6/form/VMSelector.js @@ -233,6 +233,10 @@

[pve-devel] applied: [PATCH proxmox] apt: repositories: document status property for standard repository

2023-11-06 Thread Thomas Lamprecht
Am 29/09/2023 um 09:00 schrieb Fiona Ebner: > Suggested-by: Dietmar Maurer > Signed-off-by: Fiona Ebner > --- > proxmox-apt/src/repositories/standard.rs | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > applied, thanks! ___ pve-devel ma

[pve-devel] applied: [PATCH qemu-server 0/2] migration: fix sporadic nbd-server-stop timeout

2023-11-06 Thread Thomas Lamprecht
Am 29/09/2023 um 10:28 schrieb Alexandre Derumier: > We had some sporadic nbd-stop error when applied both patches, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-manager 2/2] ui: add bulk suspend support

2023-11-06 Thread Thomas Lamprecht
Am 18/10/2023 um 12:34 schrieb Hannes Laimer: > diff --git a/www/manager6/form/VMSelector.js b/www/manager6/form/VMSelector.js > index d59847f2..ad0bfc03 100644 > --- a/www/manager6/form/VMSelector.js > +++ b/www/manager6/form/VMSelector.js > @@ -233,6 +233,10 @@ Ext.define('PVE.form.VMSelector',

Re: [pve-devel] [PATCH pve-manager 1/2] api: add suspendall endpoint

2023-11-06 Thread Thomas Lamprecht
Am 18/10/2023 um 12:34 schrieb Hannes Laimer: > Signed-off-by: Hannes Laimer > --- > > code is mostly taken from the already existing stopal endpoint, since > all checks are basically the same for both suspend and stop. > > PVE/API2/Nodes.pm | 118 ++

[pve-devel] applied: [PATCH common v2] fix #4162: added `Auto-Submitted` header to email body

2023-11-06 Thread Thomas Lamprecht
Am 19/09/2023 um 09:35 schrieb Gabriel Goller: > `Auto-Submitted` is defined in the rfc 5436 [1] and describes how > an automatic response (f.e. ooo replies, etc.) should behave on the > emails. When using `Auto-Submitted: auto-generated` (or any value > other than `none`) automatic replies won't b

[pve-devel] applied: [PATCH common v3 1/1] PBSClient: add 'tar' parameter to file_restore_extract

2023-11-06 Thread Thomas Lamprecht
Am 19/10/2023 um 11:13 schrieb Dominik Csapak: > so that we can get a 'tar.zst' from proxmox-file-restore by giving > '--format tar --zstd' to the file-restore binary > > Signed-off-by: Dominik Csapak > --- > src/PVE/PBSClient.pm | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) >

[pve-devel] applied: [PATCH installer] install: install correct grub metapackage for the current boot-mode

2023-11-06 Thread Thomas Lamprecht
Am 28/09/2023 um 16:05 schrieb Stoiko Ivanov: > grub packages in debian split between: > * meta-packages, which handles (among other things) the reinstalling > grub to the actual device/ESP in case of a version upgrade (grub-pc, > grub-efi-amd64) > * bin-packages, which contain the actual boot-

[pve-devel] applied: [PATCH manager v3] fix #4631: ceph: osd: create: add osds-per-device

2023-11-06 Thread Thomas Lamprecht
Am 23/08/2023 um 11:44 schrieb Aaron Lauterer: > Allows to automatically create multiple OSDs per physical device. The > main use case are fast NVME drives that would be bottlenecked by a > single OSD service. > > By using the 'ceph-volume lvm batch' command instead of the 'ceph-volume > lvm creat

[pve-devel] applied: applied: [PATCH proxmox-resource-scheduling] pve static: add one to avoid boosting tiny relative differences

2023-11-06 Thread Thomas Lamprecht
Am 05/10/2023 um 11:50 schrieb Fiona Ebner: > Seems like only this single patch was applied, I don't see > proxmox-perl-rs ones there (still apply cleanly). you're right, applied now, thanks (for the patch and the reminder)! ___ pve-devel mailing list

[pve-devel] applied: [PATCH proxmox-widget-toolkit] panel: sendmail edit: don't translate 'Proxmox VE' in author field

2023-11-06 Thread Thomas Lamprecht
Am 09/10/2023 um 16:15 schrieb Lukas Wagner: > The default value is determined by the backend and is never > translated (which does not make sense any way for a product name). > This was likely just a copy/paste mistake from other from fields. > > Signed-off-by: Lukas Wagner > --- > src/panel/Se

[pve-devel] applied: [PATCH proxmox-widget-toolkit] schema: endpoint types: don't translate endpoint type names

2023-11-06 Thread Thomas Lamprecht
Am 09/10/2023 um 16:38 schrieb Lukas Wagner: > ... that are not really translatable. > > Signed-off-by: Lukas Wagner > --- > src/Schema.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > applied, thanks! ___ pve-devel mailing list p

[pve-devel] applied: [PATCH pve-manager 1/2] Refer to SDN subnets as 'Subnet' not as ID

2023-11-06 Thread Thomas Lamprecht
Am 10/10/2023 um 15:30 schrieb Stefan Lendl: > The Subnet's CIDR in the Edit view is called 'Subnet'. > Also refer to it as Subnet in the list view. > > Signed-off-by: Stefan Lendl > --- > www/manager6/sdn/SubnetView.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied both p

[pve-devel] applied: [PATCH kernel-helper/manager v3] check for fitting grub-meta package on uefi systems

2023-11-06 Thread Thomas Lamprecht
Am 11/10/2023 um 15:23 schrieb Stoiko Ivanov: > v2->v3: > * adapted Friedrich's feedback (huge thanks for the patience and attention > to semantically important details!!) - so that the pve7to8 warning is > actually understandable > > v1->v2: > * adapted Friedrich's feedback (huge thanks!) > *

[pve-devel] applied: [PATCH installer] Correct DNS IP check on management interface setup

2023-11-06 Thread Thomas Lamprecht
Am 16/10/2023 um 12:20 schrieb Filip Schauer: > Signed-off-by: Filip Schauer > --- > proxinstall | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.pr

Re: [pve-devel] [PATCH manager] ui: fix height 'extra cpu flags' field in create wizard

2023-11-06 Thread Thomas Lamprecht
Am 15/06/2023 um 10:08 schrieb Dominik Csapak: > this field has a fixed height, which is too tall for the create wizard, > and one cannot see the last entry when scrolling all the way down. > > to fix this, make it 20px shorter was still broken in the german translation, as that takes up more spa

[pve-devel] applied: [PATCH manager v2] ui: wizards: allow adding tags in the qemu/lxc create wizard

2023-11-06 Thread Thomas Lamprecht
Am 25/10/2023 um 13:09 schrieb Dominik Csapak: > in the general tab in the advanced section. > > For that to work, we introduce a new option for the TagEditContainer > named 'editOnly', which controls now the cancel/finish buttons, > automatically enter edit mode and disable enter/escape keypresse

Re: [pve-devel] [PATCH manager 1/2] ui: BulkActions: rework filters and include tags

2023-11-06 Thread Thomas Lamprecht
for the commit subject please: s/BulkActions/bulk actions/ Am 30/10/2023 um 13:58 schrieb Dominik Csapak: > This moves the filters out of the grid header for the BulkActions and > puts them into their own fieldset above the grid. With that, we can > easily include a tags filter (one include and on

[pve-devel] partially-applied: [PATCH installer v3 0/8] fix #4829: set up lower default limit for ZFS ARC in installer

2023-11-06 Thread Thomas Lamprecht
Am 31/10/2023 um 13:10 schrieb Christoph Heiss: > Christoph Heiss (8): > run env: add comment for query_total_memory() > tui: views: add optional suffix label for `NumericEditView`s > tui: bootdisk: simplify product handling by passing the config > directly > fix #4829: install: add new

Re: [pve-devel] [RFC manager 3/3] node console: lift root@pam restriction for commands

2023-11-06 Thread Thomas Lamprecht
Am 14/06/2023 um 12:42 schrieb Fabian Grünbichler: > instead, fallback to a plain login shell if the current user is not already > root. both current custom commands are effectively a root shell, so it's not > possible to allow them for regular users. > > note that the non-login commands via xterm

[pve-devel] applied: [PATCH manager 1/3] node console: restrict all non-login commands to root@pam

2023-11-06 Thread Thomas Lamprecht
Am 14/06/2023 um 12:42 schrieb Fabian Grünbichler: > and not just upgrade. > > note that the only other non-login command (ceph_install) is restricted to > root@pam in the web UI anyway, and that the termproxy endpoint is lacking this > check and thus always falls back to a login prompt for non-lo

[pve-devel] applied: [PATCH manager 2/3] node console: allow usage for non-pam realms

2023-11-06 Thread Thomas Lamprecht
Am 14/06/2023 um 12:42 schrieb Fabian Grünbichler: > non-login commands are still restricted to root@pam if they where before. > > Signed-off-by: Fabian Grünbichler > --- > PVE/API2/Nodes.pm | 10 +- > 1 file changed, 1 insertion(+), 9 deletions(-) > > applied, thanks! __

Re: [pve-devel] [RFC PATCH guest-common 1/1] add profiles section config plugin

2023-11-06 Thread Fiona Ebner
Am 06.11.23 um 11:38 schrieb Dominik Csapak: > On 11/6/23 11:12, Fiona Ebner wrote: >> Am 06.11.23 um 10:34 schrieb Dominik Csapak: >>> On 11/6/23 10:22, Fiona Ebner wrote: Am 03.11.23 um 12:53 schrieb Dominik Csapak: > +my $defaultData = { > +    propertyList => { > +    type => {

Re: [pve-devel] [RFC PATCH guest-common 1/1] add profiles section config plugin

2023-11-06 Thread Dominik Csapak
On 11/6/23 11:12, Fiona Ebner wrote: Am 06.11.23 um 10:34 schrieb Dominik Csapak: On 11/6/23 10:22, Fiona Ebner wrote: Am 03.11.23 um 12:53 schrieb Dominik Csapak: +my $defaultData = { +    propertyList => { +    type => { description => 'Profile type.' }, +    id => { +    type => 'string

Re: [pve-devel] [RFC PATCH guest-common 1/1] add profiles section config plugin

2023-11-06 Thread Fiona Ebner
Am 06.11.23 um 11:12 schrieb Fiona Ebner: > Am 06.11.23 um 10:34 schrieb Dominik Csapak: >> On 11/6/23 10:22, Fiona Ebner wrote: >>> Am 03.11.23 um 12:53 schrieb Dominik Csapak: +my $defaultData = { +    propertyList => { +    type => { description => 'Profile type.' }, +    id

Re: [pve-devel] [RFC PATCH guest-common 1/1] add profiles section config plugin

2023-11-06 Thread Fiona Ebner
Am 06.11.23 um 10:34 schrieb Dominik Csapak: > On 11/6/23 10:22, Fiona Ebner wrote: >> Am 03.11.23 um 12:53 schrieb Dominik Csapak: >>> +my $defaultData = { >>> +    propertyList => { >>> +    type => { description => 'Profile type.' }, >>> +    id => { >>> +    type => 'string', >>> +    d

Re: [pve-devel] [RFC PATCH cluster/guest-common/qemu-server/container/manager] add backend profile support

2023-11-06 Thread Dominik Csapak
On 11/6/23 09:53, Thomas Lamprecht wrote: Am 06/11/2023 um 09:17 schrieb Dominik Csapak: On 11/4/23 09:34, Thomas Lamprecht wrote: On 03/11/2023 12:53, Dominik Csapak wrote: Using a single section config for both VMs and CTs make handling the properties a bit weird. For now i prefix the option

Re: [pve-devel] [RFC PATCH guest-common 1/1] add profiles section config plugin

2023-11-06 Thread Dominik Csapak
On 11/6/23 10:22, Fiona Ebner wrote: Am 03.11.23 um 12:53 schrieb Dominik Csapak: +my $defaultData = { +propertyList => { + type => { description => 'Profile type.' }, + id => { + type => 'string', + description => "The ID of the profile.", + format

Re: [pve-devel] [RFC PATCH cluster/guest-common/qemu-server/container/manager] add backend profile support

2023-11-06 Thread Fiona Ebner
Am 06.11.23 um 09:17 schrieb Dominik Csapak: > thx for the answer! i'll see that i send a next version soon > > some more comment from me inline > > On 11/4/23 09:34, Thomas Lamprecht wrote: >> On 03/11/2023 12:53, Dominik Csapak wrote: >>> This series aims to provide profile support when creatin

Re: [pve-devel] [RFC PATCH guest-common 1/1] add profiles section config plugin

2023-11-06 Thread Fiona Ebner
Am 03.11.23 um 12:53 schrieb Dominik Csapak: > +my $defaultData = { > +propertyList => { > + type => { description => 'Profile type.' }, > + id => { > + type => 'string', > + description => "The ID of the profile.", > + format => 'pve-configid', > + }, The I

[pve-devel] [PATCH pve-access-control 1/1] add logging for ACL and user status change

2023-11-06 Thread Andrew A. Vasilyev
Signed-off-by: "Andrew A. Vasilyev" --- src/PVE/API2/ACL.pm | 2 ++ src/PVE/API2/User.pm | 4 2 files changed, 6 insertions(+) diff --git src/PVE/API2/ACL.pm src/PVE/API2/ACL.pm index f0c9efb..6ec23d7 100644 --- src/PVE/API2/ACL.pm +++ src/PVE/API2/ACL.pm @@ -183,8 +183,10 @@ __PACKAGE__->r

Re: [pve-devel] [RFC PATCH cluster/guest-common/qemu-server/container/manager] add backend profile support

2023-11-06 Thread Thomas Lamprecht
Am 06/11/2023 um 09:17 schrieb Dominik Csapak: > On 11/4/23 09:34, Thomas Lamprecht wrote: >> On 03/11/2023 12:53, Dominik Csapak wrote: >>> Using a single section config for both VMs and CTs make handling the >>> properties a bit weird. For now i prefix the options with "$type_" >>> so vm options

Re: [pve-devel] [RFC PATCH cluster/guest-common/qemu-server/container/manager] add backend profile support

2023-11-06 Thread Dominik Csapak
small correction inline: On 11/6/23 09:17, Dominik Csapak wrote: [snip] We could also go in a completely different direction and create a config per profile? (like we handle vm configs). Downside of that is, that the current guest config handling part is partly in pmxcfs, so we'd have to make th

Re: [pve-devel] [RFC PATCH cluster/guest-common/qemu-server/container/manager] add backend profile support

2023-11-06 Thread Dominik Csapak
thx for the answer! i'll see that i send a next version soon some more comment from me inline On 11/4/23 09:34, Thomas Lamprecht wrote: On 03/11/2023 12:53, Dominik Csapak wrote: This series aims to provide profile support when creating guests (ct/vm) so that users can reuse options without ha