Am 11/10/2023 um 15:23 schrieb Stoiko Ivanov: > v2->v3: > * adapted Friedrich's feedback (huge thanks for the patience and attention > to semantically important details!!) - so that the pve7to8 warning is > actually understandable > > v1->v2: > * adapted Friedrich's feedback (huge thanks!) > ** fixed the wrongly negated check for installed grub-efi-amd64 in the > boot-tool hook. > ** Rephrased the error-message in pve7to8 to 2 sentences. I tried adding a > newline as well, however this results in the message not being printed > in the warning color anymore (most likely due to [0]) - and I felt this > to be more important than having it on a separate line. > > [0] https://perldoc.perl.org/Term::ANSIColor#RESTRICTIONS > > original cover-letter for v1: > The following patchset is a followup to the one for the installer: > https://lists.proxmox.com/pipermail/pve-devel/2023-September/059270.html > > As suggested by Thomas - adding the check to proxmox-kernel-helper seems > like a good idea. While adding it to d/postinst I thought that this might > not be the best place - and that getting the warning upon every > kernel-upgrade would be better vs. upon every upgrade of > proxmox-kernel-helper (which are far less often). > (Can gladly send the version with d/postinst as well) > > If the pve-manager patch gets applied - I'd push the equivalent change to > pmg and provide one for pbs. > > Tested on legacy and uefi VMs installed with pve-8.0 iso and > grub-efi-amd64 (and systemd-boot) removed vs. installed. > > proxmox-kernel-helper > Stoiko Ivanov (2): > proxmox-boot-tool: do not exit early in kernel-hook > proxmox-boot-tool: check if correct grub metapackage is installed > > src/proxmox-boot/zz-proxmox-boot | 21 ++++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) > > pve-manager: > Stoiko Ivanov (1): > pve7to8: check for proper grub meta-package for bootmode > > PVE/CLI/pve7to8.pm | 39 +++++++++++++++++++++++---------------- > 1 file changed, 23 insertions(+), 16 deletions(-) >
applied, with Friedrich's R-b/T-b tags, thanks! I did some rewording for the kernel-helper, aligning it a bit more with the one from pve6to7 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
