Re: Now Playing & Urls

On Thursday 17 September 2009 18:05:59 you wrote: > Hi, > > Not all script engines (e.g. webkit) can use QPixmap from the data and > sometimes file path is useful (if artwork is not set I would like to show > jpg from the same dir). This patch adds Url & ArtUrl fields to data. Ok to > commit or

Re: Running queries via dbus

CC'ing plasma-devel, since this is an important point regarding runners that use D-Bus. Please keep any discussion on this issue at plasma-devel. On Tuesday 23 March 2010 17:26:54 Alex Merry wrote: > On Monday 22 March 2010 22:05:26 Jacopo De Simoi wrote: > > > In particular

Re: Running queries via dbus

On Tuesday 23 March 2010 22:03:30 Jacopo De Simoi wrote: > > CC'ing plasma-devel, since this is an important point regarding runners > > that use D-Bus. Please keep any discussion on this issue at > > plasma-devel. > > > > On Tuesday 23 March 2010 17:26:54 A

Re: Running queries via dbus

On Tuesday 23 March 2010 21:55:08 Alex Merry wrote: > Instead, you should use QDBusConnection::asyncCall. This can be used in > exactly the same way (implicit casting FTW), and casting to a QDBusReply > will cause the calling thread to block as you would expect. But, > important

Re: Running queries via dbus

On Tuesday 23 March 2010 23:47:10 Jacopo De Simoi wrote: > I just got a quite crazy idea; it might work though. > Since we are making the thread stall by waiting for the async reply we > could as well check that while we get the pending reply the context is > still valid and bail out discarding the

Re: Review Request: Add fade effect on the nowplaying text cycling

> On Aug. 21, 2012, 3:54 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 48ccff55dabc7ad9a173ee6b50d955c85e42aa27 by Martin Klapetek to branch > > KDE/4.9. I don't think this should really have gone into 4.9, as it is a feature, rather than a bug fix. - Alex --

Re: Moving screen locking away from krunner

On 03/12/12 14:42, Davide Bettio wrote: > Nice, I missed that change. Is it possible to backport any fix for > plasma-netbook? Hacky fix for old versions of plasma-netbook: http://randomguy3.wordpress.com/2011/09/04/screen-locking-with-the-plasma-netbook-interface/ Alex _

Re: Thoughts about a better Quality Management process for Plasma

On 14/01/13 10:22, Martin Gräßlin wrote: I think this would also be interesting for Plasma: * which Plasmoids are running * which containments are present * what are the settings of each Plasmoid Note that there are potential privacy issues here. Unlike KWin, there is a fair chance that plasmo

Re: Thoughts about a better Quality Management process for Plasma

On 14/01/13 15:21, Alex Fiestas wrote: On Sunday 13 January 2013 15:50:25 Martin Gräßlin wrote: *Every commit should be referenced to a bug* What is the motivation for a commit? It's either a bug fix or it is a new feature/improvement. If it's a bug it's clear that there has to be a bug report f

Re: Thoughts about a better Quality Management process for Plasma

On 14/01/13 15:24, Aaron J. Seigo wrote: * it means adopting bugzilla as our One True Workflow tool. that doesn't just sound beaurocratic, it is beaurocratic. if someone appears with a patch fixing some bug or implementing some feature that isn't in bugzilla, do we first send them to create one b

Images in packages

Plasma::Svg's image search doesn't appear to be able to find images in a plasmoid's package. There is code in Plasma::SvgPrivate::createRenderer that should attempt to find such an image, but (a) it is never called (because Plasma::SvgPrivate::elementRect is called first, and sets themeFailed) and

Re: Developing plasmoids with QML

On 02/02/13 14:40, Вика wrote: > > Hello. Trying to make my first QML-plasmoid I've faced with some > problems. I haven't found solutions in KDE tutorials and my googling > gave no results. Is plasma-devel a right place to ask for help with that? Yes, although it's probably worth trying #plasma o

Re: Now Listen plasmoid

On 19/03/13 23:38, Malcer wrote: > Hi Alex! How are you? I hope well. :) > > I'm going to the point: I'm the creator of Caledonia, a plasma theme, and I > like your plasmoid... but exist a problem. > > Since a few versions, I don't succeed to change the CD case in the plasmoid > if > the song

Re: Now Listen plasmoid

On 20/03/13 13:00, Aaron J. Seigo wrote: On Tuesday, March 19, 2013 23:44:37 Alex Merry wrote: I investigated this, and there does not seem to be an easy way to do it with QML plasmoids. If you just ask for something "from the theme", you can't provide a default in the pl

Re: Now Listen plasmoid

On 21/03/13 09:48, Aaron J. Seigo wrote: On Thursday, March 21, 2013 00:00:52 you wrote: PlasmaCore.SvgItem { svg: Svg("nocover") } yes, or Svg { source: "nocover" } Does that really work? When I did Svg { imagePath: "nocover" }, QML complained that Svg is not a type (it's a global func

Re: Now Listen plasmoid

On 21/03/13 09:48, Aaron J. Seigo wrote: > $PLASMOID_PACKAGE/images/ > $SYSTEM_SVG_THEME_PATH/ > $PLASMOID_PACKAGE/theme/$SYSTEM_SVG_THEME_NAME/ > $PLASMOID_PACKAGE/theme/ I've been trying to implement this, and have come across a hurdle: Plasma::Theme does not have a way of getting hold of the fa

Review Request 109859: Allow plasmoids to provide fallbacks for themed images

;content/images/nocover.svgz" and "content/theme/nocover.svgz" in the plasmoid, and that $KDEDIR/share/apps/desktoptheme/default/nocover.svgz overrides the latter. Thanks, Alex Merry ___ Plasma-devel mailing list Plasma-devel@kde.org https:/

Review Request 109857: Add the "theme" directory to the plasmoid directory structure

to override. Diffs - plasma/private/packages.cpp 1f346cc8af84ae10e4e7b878cf8c3a63c98c3509 Diff: http://git.reviewboard.kde.org/r/109857/diff/ Testing --- See RR 109859. Thanks, Alex Merry ___ Plasma-devel mailing list Plasma-devel

Re: Review Request 109857: Add the "theme" directory to the plasmoid directory structure

submitted with commit > 24c26aefacff274ac52d773e39fbbfa3b458e213 by Alex Merry to branch master. > > Has this ever been ported to plasma-framework? Now done: 33d41aea3dba1459de9db143a15dc20afea54f61 > and, it currently breaks unit tests Sorry about that, and sorry for not replying sooner; I was out of the coun

Re: [RFC] Moving Wishlist Items to Brainstorm

On 25/05/13 07:58, Martin Graesslin wrote: > For KWin I use the following template when we get a new feature request: Since you wanted feedback from native speakers on the other one (which was actually fine, by the way), I've tidied up this one (since the idea, I guess, is to copy-paste it into re

Review Request 113993: Remove the nowplaying dataengine

/playerinterface/xmms_p.h 10a6e51 Diff: http://git.reviewboard.kde.org/r/113993/diff/ Testing --- CMake still runs successfully. Thanks, Alex Merry ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 113993: Remove the nowplaying dataengine

On 21/11/13 11:02, Alex Merry wrote: > Review request for kde-workspace and Plasma. > By Alex Merry. > *Repository: * kde-workspace > > > Description > > Remove the nowplaying dataengine > > This has been superceded by the mpris2 dataengine. Oh, a question abou

Re: Review Request 113993: Remove the nowplaying dataengine

/dataengines/nowplaying/playerinterface/xmms.cpp da3e9db plasma/generic/dataengines/nowplaying/playerinterface/xmms_p.h 10a6e51 Diff: http://git.reviewboard.kde.org/r/113993/diff/ Testing --- CMake still runs successfully. Thanks, Alex Merry

Re: Framework licenses

On 23/12/13 18:46, Aurélien Gâteau wrote: > - plasma-framework: this framework uses multiple licenses, but majority is > LGPL (this is the case for many other frameworks). Should we use a LGPL 2.1 > COPYING.LIB file? A quick attack with git grep shows the majority of code to be LGPL 2 (+), with

Review Request 114683: Clean up target_link_libraries for KF5Plasma

Diff: https://git.reviewboard.kde.org/r/114683/diff/ Testing --- plasma-framework and kde-workspace both still compile. Thanks, Alex Merry ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114683: Clean up target_link_libraries for KF5Plasma

LINK_INTERFACE_LIBRARIES. Diffs - src/plasma/CMakeLists.txt 5a6ceabb3d6b95fb792e19aab034b87d0dd688a9 Diff: https://git.reviewboard.kde.org/r/114683/diff/ Testing --- plasma-framework and kde-workspace both still compile. Thanks, Alex Merry ___ Plasma

Re: Notes from "KRunner Breakout"

On 16/01/14 20:15, Vishesh Handa wrote: > * Discovering and managing runners is quite hard. A new KCM should be created > for that purpose. I would also add that runner help is quite hard to navigate at the moment; some thought probably needs to go into how that should work (it would be nice if i

Re: Review Request 114260: Port mouse dataengine

> On Dec. 8, 2013, 12:08 p.m., Bhushan Shah wrote: > > plasma/generic/dataengines/mouse/mouseengine.cpp, line 34 > > > > > > You should call init() here. Have a look at > > http://community.kde.org/Plasma/Porting

Re: Review Request 114260: Port mouse dataengine

> On Feb. 2, 2014, 11:42 a.m., Bhushan Shah wrote: > > Please test it with plasmaengineexplorer in my testing it shows no sources. Any progress on this? - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.

Review Request 116931: Make sure kdeinit starts kded

--- Thanks, Alex Merry ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116931: Make sure kdeinit starts kded

86abf5b68dc5717d9fc257e0d442242fc18d3058 Diff: https://git.reviewboard.kde.org/r/116931/diff/ Testing --- Thanks, Alex Merry ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116931: Make sure kdeinit starts kded

1/#review53532 --- On March 20, 2014, 4:04 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.re

Re: Review Request 116931: Make sure kdeinit starts kded

- plasma-workspace/startkde/startkde.cmake 86abf5b68dc5717d9fc257e0d442242fc18d3058 Diff: https://git.reviewboard.kde.org/r/116931/diff/ Testing --- Thanks, Alex Merry ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Review Request 117060: Explicitly specify link interface libraries for libKF5PlasmaQuick

https://git.reviewboard.kde.org/r/117060/diff/ Testing --- Builds and installs. kde-runtime and kde-workspace then also build. Thanks, Alex Merry ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 117059: Explicitly state link interface for libKF5Activites

then also build. Thanks, Alex Merry ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117059: Explicitly state link interface for libKF5Activites

/117059/diff/ Testing --- Compiles, installs. plasa-framework, kde-runtime and kde-workspace then also build. Thanks, Alex Merry ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117060: Explicitly specify link interface libraries for libKF5PlasmaQuick

Diffs - src/plasmaquick/CMakeLists.txt 83af22ecaf235c26115aa741d3c288bc71c269e9 Diff: https://git.reviewboard.kde.org/r/117060/diff/ Testing --- Builds and installs. kde-runtime and kde-workspace then also build. Thanks, Alex Merry ___ P

Re: Review Request 116907: Implemented "Player" MPRIS spec adaptor

/mpristester please? It's much more comprehensive than the now playing applet. - Alex Merry On March 25, 2014, 7:02 p.m., Ashish Madeti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.re

Re: Review Request 116907: Implemented "Player" MPRIS spec adaptor

got a KUrl in the added code... - Alex Merry On March 26, 2014, 5:23 p.m., Ashish Madeti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 116907: Implemented "Player" MPRIS spec adaptor

> On March 26, 2014, 6:09 p.m., Alex Merry wrote: > > All looks sane. Is this Qt4 or Qt5? Because you've got a KUrl in the > > added code... > > Bhushan Shah wrote: > Qt4 OK, that's fine then. - Alex

Review Request 117584: Standardise DBus service CMake code

installed to correct location. Visually inspected installed files. Thanks, Alex Merry ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117762: Improve XCB dependency handling

parate find_package call. - Alex Merry On April 25, 2014, 8:16 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 117584: Standardise DBus service CMake code

--- Configured, built, installed. Checked (in `make install` output) that files were installed to correct location. Visually inspected installed files. Thanks, Alex Merry ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Review Request 117762: Improve XCB dependency handling

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117762/#review56506 --- Ship it! Ship It! - Alex Merry On April 25, 2014, 9:17

Rebuild everything

Over the course of the KF5 sprint, we changed a bunch of installation directories, including those used by KService, KNotifications and KPluginLoader. As a result, I suggest you do a full rebuild from extra-cmake-modules upwards. If you only rebuild some stuff, important files may not be found and/

Re: Review Request 118155: adapt to ecm_add_tests so that tests can be found

don't need the NAME_PREFIX arguments any more, but I'll wait to see what people think of https://git.reviewboard.kde.org/r/118385/ first. - Alex Merry On May 15, 2014, 3 p.m., Patrick Spendrin wrote: > > --- > This

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

exist any more - there is an ecm_optional_add_subdirectory() in ECM if you include(ECMOptionalAddSubdirectory), though. However, I think an explicit option(), with a useful help-text, would be better. - Alex Merry On May 27, 2014, 5:27 a.m., Matthew Dawson

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

> On May 29, 2014, 3:02 p.m., Alex Merry wrote: > > Did you try compiling this? Because that macro doesn't exist any more - > > there is an ecm_optional_add_subdirectory() in ECM if you > > include(ECMOptionalAddSubdirectory), though. > > > > However

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

there isn't another release, because packagers can pick it up as an "official" patch if they want. But I'll let Ivan have the final say. - Alex Merry On May 31, 2014, 3:42 a.m., Matthew Dawson wrote: > > ---

Review Request 118476: Move kded module to kf5/kded subdirectory

9976fa3041a6c12fc4b3ce2146fb481181fa65b8 Diff: https://git.reviewboard.kde.org/r/118476/diff/ Testing --- qdbus org.kde.kded5 /kded loadModule kded_platformstatus succeeds Thanks, Alex Merry ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 118476: Move kded module to kf5/kded subdirectory

676a8be30df41b042758d55b58caa22fc6c89311 src/platformstatus/kded_platformstatus.desktop 9976fa3041a6c12fc4b3ce2146fb481181fa65b8 Diff: https://git.reviewboard.kde.org/r/118476/diff/ Testing --- qdbus org.kde.kded5 /kded loadModule kded_platformstatus succeeds Thanks, Alex Merry

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

This should probably move to the lib/konq/CMakeLists.txt file. CMakeLists.txt <https://git.reviewboard.kde.org/r/118851/#comment42290> This should probably move the the dolphin/src/CMakeLists.txt file - Alex Merry On June 20, 2014, 5:53 p.m

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

851/#comment42292> But now you'll want to put an actual version number in here (or remove the variable use altogether). - Alex Merry On June 20, 2014, 6:44 p.m., Scarlett Clark wrote: > > --- > This is an automatically

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118851/#review60620 --- Ship it! Ship It! - Alex Merry On June 20, 2014, 6:44 p.m

Re: Review Request 125843: Use KDE_INSTALL_DBUSINTERFACEDIR to install dbus interfaces

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125843/#review87614 --- Ship it! Ship It! - Alex Merry On Oct. 28, 2015, 5:31 p.m

Re: Review Request 125844: Use PATH_VARS feature of ecm_configure_package_config_file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125844/#review87615 --- Ship it! Ship It! - Alex Merry On Oct. 28, 2015, 5:40 p.m

Re: Review Request 125845: Use KDE_INSTALL_DBUSINTERFACEDIR to install dbus interfaces

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125845/#review87616 --- Ship it! Ship It! - Alex Merry On Oct. 28, 2015, 5:44 p.m

Re: Review Request 125811: detect gtk engine

> On Nov. 3, 2015, 5:38 p.m., Hrvoje Senjan wrote: > > cmake/FindGTKEngine.cmake, line 17 > > > > > > KDE_INSTALL_FULL_LIBDIR rather? Yes, that one, please. Otherwise bad things will happen if anyone specifies an

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126131/#review88691 --- Ship it! Ship It! - Alex Merry On Nov. 22, 2015, 1:57 a.m

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 3, 2015, 11:49 p.m., Aleix Pol Gonzalez wrote: > > kde-modules/KDETemplateMacro.cmake, line 1 > > > > > > You might want to add documentation. > > > > You can get inspired with > > `kde-modules/

Re: Review Request 126185: Make the KAppTemplate CMake module global

l, consider passing in the install destination as an argument, or at least allowing that as a possibility. The actual directory could (should?) be put into KDEInstallDirs.cmake as an extra variable. - Alex Merry On Dec. 3, 2015, 12:34 p.m., Marco Martin wrote: > > --

Re: Review Request 126185: Make the KAppTemplate CMake module global

ppen when you're reading the code - it will package the templates and install them. But I'm not going to force your hand on this if you'd rather not do it that way. - Alex Merry On Dec. 9, 2015, 12:12 p.m., Marco Martin

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:35 p.m., Alex Merry wrote: > > kde-modules/KDETemplateGenerator.cmake, line 52 > > <https://git.reviewboard.kde.org/r/126185/diff/4/?file=421458#file421458line52> > > > > Honestly, I'd just use ARG as the prefix - you're in a f

Re: Review Request 126185: Make the KAppTemplate CMake module global

you find the idea of writing a CMake-based unit test daunting, but you can look in the tests directory for inspiration. - Alex Merry On Dec. 9, 2015, 12:12 p.m., Marco Martin wrote: > > --- > This is an automatically generated e

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote:

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:35 p.m., Alex Merry wrote: > > kde-modules/KDETemplateGenerator.cmake, line 84 > > <https://git.reviewboard.kde.org/r/126185/diff/4/?file=421458#file421458line84> > > > > Use ``KDE_INSTALL_KTEMPLATESDIR`` instead of > > ``KTE

Re: Review Request 126185: Make the KAppTemplate CMake module global

tps://git.reviewboard.kde.org/r/126185/#comment61287> I'd prefer ``kde_package_app_templates`` (and the module to be called ``KDEPackageAppTemplates.cmake``). - Alex Merry On Dec. 15, 2015, 10:38 a.m., Marco Martin wrote: > >

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote:

Re: Review Request 126185: Make the KAppTemplate CMake module global

ght want to generate the documentation and look at it (you need the Sphinx documentation tool installed, then you just build extra-cmake-modules, and look in docs/html in the build directory). - Alex Merry On Dec. 16, 2015, 12:25 p.m., Marco Martin wrote: > > --

Re: Review Request 126185: Make the KAppTemplate CMake module global

/contents/ui/main.qml (lines 1 - 18) <https://git.reviewboard.kde.org/r/126185/#comment61372> BSD code only in extra-cmake-modules, please. Frankly, your app template can be complete rubbish, as long as it's packaged up properly. - Alex Merry On Dec. 16, 2015, 12:25 p.m., Marco M

Re: Review Request 126185: Make the KAppTemplate CMake module global

On Dec. 16, 2015, 7:14 p.m., Marco Martin wrote: > > You might want to generate the documentation and look at it (you need the > > Sphinx documentation tool installed, then you just build > > extra-cmake-modules, and look in docs/html in the build directory). In particular, you'll need to add

Re: Review Request 126185: Make the KAppTemplate CMake module global

bad about the sheer number of changes I'm throwing at you! If you want to make me do some of the work, you can create a feature branch and point me at it, but I'm hoping this review is setting you up for an easy ride if you want to contribute something else to e-c-m in the future. -

Re: Review Request 126185: Make the KAppTemplate CMake module global

() to untar the installed tarball, and examine the contents. I highly recommend you look at ECMInstallIconsTest. - Alex Merry On Dec. 17, 2015, 11:15 a.m., Marco Martin wrote: > > --- > This is an automatically generated e-

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote:

Re: Review Request 126185: Make the KAppTemplate CMake module global

he directory to install the template package to. In most cases you will want to use the variable KDE_INSTALL_KTEMPLATESDIR from :kde-module:`KDEInstallDirs`. And then put a blank line before the bit about TEMPLATES, so they're separate paragraphs. - Alex Merry On Dec. 18, 2015

Re: Review Request 126185: Make the KAppTemplate CMake module global

in. kde-modules/KDEPackageAppTemplates.cmake (line 19) <https://git.reviewboard.kde.org/r/126185/#comment61779> New paragraph, please. - Alex Merry On Dec. 28, 2015, 9:37 a.m., Marco Martin wrote: > > --- > This is a

Review Request: DataEngine: Add methods to allow disabling auto-deletion of data sources created on demand

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5312/ --- Review request for Plasma. Summary --- Allow DataEngine implementations

Re: Review Request: DataEngine: Add methods to allow disabling auto-deletion of data sources created on demand

-- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5312/#review7530 --- On 2010-09-10 23:30:32, Alex Merry wrote: > > ---

Re: Review Request: DataEngine: Add methods to allow disabling auto-deletion of data sources created on demand

> On 2010-09-10 23:56:04, Aaron Seigo wrote: > > if there is nothing connected to it, why would it want to fill that data? > > if nothing is connected, then there is precisely no reason to deliver that > > data. it sounds like the system monitor engine is doing something w

Re: Review Request: DataEngine: Add methods to allow disabling auto-deletion of data sources created on demand

> On 2010-09-10 23:56:04, Aaron Seigo wrote: > > if there is nothing connected to it, why would it want to fill that data? > > if nothing is connected, then there is precisely no reason to deliver that > > data. it sounds like the system monitor engine is doing something w

Re: Review Request: DataEngine: Add methods to allow disabling auto-deletion of data sources created on demand

> On 2010-09-10 23:56:04, Aaron Seigo wrote: > > if there is nothing connected to it, why would it want to fill that data? > > if nothing is connected, then there is precisely no reason to deliver that > > data. it sounds like the system monitor engine is doing something w

Review Request: Make custom colours work on the digital clock again

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5747/ --- Review request for Plasma. Summary --- Since the shadow was introduced

Re: Review Request: Make custom colours work on the digital clock again

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5747/ --- (Updated 2010-11-01 18:42:29.964037) Review request for Plasma. Changes --

Re: Review Request: Make custom colours work on the digital clock again

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5747/ --- (Updated 2010-11-04 02:07:24.050751) Review request for Plasma. Changes --

Re: Review Request: Make custom colours work on the digital clock again

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5747/ --- (Updated 2010-11-04 17:57:08.651004) Review request for Plasma. Changes --

Plasma::Svg::paint

I have a question about the way Plasma::Svg::paint is supposed to work when an elementId is given, but a size is not. The context for this is a bug I was fixing in bubblemon. The bubblemon SVG has three elements; the background, the glass and the bubble. The bubble is smaller than the other t

Review Request: Move screensaver and locking functionality to kwin from krunner

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101943/ --- Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin. Summa

Re: Review Request: Move screensaver and locking functionality to kwin from krunner

ine 236 > > <http://git.reviewboard.kde.org/r/101943/diff/1/?file=26943#file26943line236> > > > > should check KWIN_BUILD_SCREENSAVER? Yes. > On July 13, 2011, 12:54 p.m., Aaron J. Seigo wrote: > > kwin/workspace.cpp, line 516 > > <http://git.reviewb

Re: Review Request: Move screensaver and locking functionality to kwin from krunner

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101943/ --- (Updated July 13, 2011, 3:54 p.m.) Review request for kwin, Plasma, Aaron

Re: Review Request: Move screensaver and locking functionality to kwin from krunner

-- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101943/#review4689 ------- On July 13, 2011, 3:54 p.m., Alex Merry wrote: > > ---

Re: Review Request: Move screensaver and locking functionality to kwin from krunner

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101943/ --- (Updated July 13, 2011, 4:07 p.m.) Review request for kwin, Plasma, Aaron

Re: Review Request: Move screensaver and locking functionality to kwin from krunner

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101943/#review4741 ------- On July 13, 2011, 4:07 p.m., Alex Merry wrote: > > --

Review Request: Move the "Lock Session" shortcut to kwin from krunner

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102261/ --- Review request for kwin, Plasma, Aaron J. Seigo, Martin Gräßlin, and Farhad

Re: Review Request: Move screensaver and locking functionality to kwin from krunner

prefer the SoK commit as it doesn't add files to kwin's > > root directory (which I don't like any more and get's currently more and > > more changed) > > Alex Merry wrote: > The issue with the SoK version is that KRunner still maintains the > key

Re: Review Request: Move the "Lock Session" shortcut to kwin from krunner

cally generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102261/#review5548 ------- On Aug. 9, 2011, 12:52 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request: Move the "Lock Session" shortcut to kwin from krunner

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102261/ --- (Updated Aug. 9, 2011, 2:42 p.m.) Review request for kwin, Plasma, Aaron J

MPRIS2 dataengine

So, the nowplaying dataengine sucks, and I've basically given up maintaining it. It's broken by design, causes lots of wakeups and context switches etc etc etc. Also, trying to support half a dozen different ways of talking to a media player is crazy. However, MPRIS2 [0] provides a solution. Al

Review Request: Allow QML items to be associated with operations in Plasma::Service

plasmoidviewer. Thanks, Alex Merry ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Allow QML items to be associated with operations in Plasma::Service

hanks, Alex Merry ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

mpris2 engine and nowplaying QML applet

This is following up my previous email about the mpris2 engine, and asking for a formal review. I've lost track of how the review procedure has changed since the move to git, and I can't find documentation of it anywhere, so I apologise if I screw this up. The mpris2 engine, which I think should

  1   2   >