----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89618 -----------------------------------------------------------
kde-modules/KDEPackageAppTemplates.cmake (line 10) <https://git.reviewboard.kde.org/r/126185/#comment61369> Frameworks has a capital F. kde-modules/KDEPackageAppTemplates.cmake (line 14) <https://git.reviewboard.kde.org/r/126185/#comment61365> Signature is still wrong. kde-modules/KDEPackageAppTemplates.cmake (lines 16 - 37) <https://git.reviewboard.kde.org/r/126185/#comment61368> None of this should be indented. Beware of how Sphinx formats your list of placeholders, though. Consider doing the list in the same way as KDEInstallDirs.cmake lists its variables. kde-modules/KDEPackageAppTemplates.cmake (line 20) <https://git.reviewboard.kde.org/r/126185/#comment61366> "as if it was", instead of "as it was"? kde-modules/KDEPackageAppTemplates.cmake (line 22) <https://git.reviewboard.kde.org/r/126185/#comment61363> missing closing parenthesis )? You might want to generate the documentation and look at it (you need the Sphinx documentation tool installed, then you just build extra-cmake-modules, and look in docs/html in the build directory). - Alex Merry On Dec. 16, 2015, 12:25 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126185/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2015, 12:25 p.m.) > > > Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, > and Simon Wächter. > > > Repository: extra-cmake-modules > > > Description > ------- > > templates are very useful as teaching tool in order to make > a minimal application that uses a certain framework. > templates in the KAppTemplate repository will always get forgotten > (plus kapptemplate is not really necessary as they work in kdevelop as well) > An ideal situation would be frameworks having templates in their own repos > with templates of barebone apps using the main framework features. > In order to do that, the cmake stuff needed in order to correctly install > a template needs to be ported to a place avaiable to all frameworks > > > Diffs > ----- > > kde-modules/KDEInstallDirs.cmake b7cd34d > kde-modules/KDEPackageAppTemplates.cmake PRE-CREATION > tests/CMakeLists.txt 1a66f56 > tests/KDEPackageAppTemplatesTest/CMakeLists.txt PRE-CREATION > tests/KDEPackageAppTemplatesTest/qml-plasmoid/CMakeLists.txt PRE-CREATION > tests/KDEPackageAppTemplatesTest/qml-plasmoid/Messages.sh PRE-CREATION > tests/KDEPackageAppTemplatesTest/qml-plasmoid/README PRE-CREATION > > tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/images/pairs.svgz > PRE-CREATION > tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/ui/main.qml > PRE-CREATION > tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/metadata.desktop > PRE-CREATION > tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.kdevtemplate > PRE-CREATION > tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.png PRE-CREATION > tests/KDEPackageAppTemplatesTest/run_test.cmake.config PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126185/diff/ > > > Testing > ------- > > done some templates installed by plasma-framework > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
