----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89671 -----------------------------------------------------------
tests/CMakeLists.txt (line 43) <https://git.reviewboard.kde.org/r/126185/#comment61417> Use the add_test_macro command, rather than add_subdirectory. This will treat the subdirectory as an indepentend CMake project - running CMake on it, and make, and (optionally) make install. Just look further down the file at lines 124-131 for an example. tests/KDEPackageAppTemplatesTest/run_test.cmake.config (lines 1 - 11) <https://git.reviewboard.kde.org/r/126185/#comment61416> This should go in the CMakeLists.txt file, in place of the add_test command. All your run_test.cmake script needs to do is use execute_process() to untar the installed tarball, and examine the contents. I highly recommend you look at ECMInstallIconsTest. - Alex Merry On Dec. 17, 2015, 11:15 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126185/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2015, 11:15 a.m.) > > > Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, > and Simon Wächter. > > > Repository: extra-cmake-modules > > > Description > ------- > > templates are very useful as teaching tool in order to make > a minimal application that uses a certain framework. > templates in the KAppTemplate repository will always get forgotten > (plus kapptemplate is not really necessary as they work in kdevelop as well) > An ideal situation would be frameworks having templates in their own repos > with templates of barebone apps using the main framework features. > In order to do that, the cmake stuff needed in order to correctly install > a template needs to be ported to a place avaiable to all frameworks > > > Diffs > ----- > > tests/KDEPackageAppTemplatesTest/qml-plasmoid/Messages.sh PRE-CREATION > tests/KDEPackageAppTemplatesTest/qml-plasmoid/CMakeLists.txt PRE-CREATION > tests/KDEPackageAppTemplatesTest/CMakeLists.txt PRE-CREATION > kde-modules/KDEPackageAppTemplates.cmake PRE-CREATION > tests/CMakeLists.txt 1a66f56 > kde-modules/KDEInstallDirs.cmake b7cd34d > tests/KDEPackageAppTemplatesTest/qml-plasmoid/README PRE-CREATION > > tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/images/pairs.svgz > PRE-CREATION > tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/ui/main.qml > PRE-CREATION > tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/metadata.desktop > PRE-CREATION > tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.kdevtemplate > PRE-CREATION > tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.png PRE-CREATION > tests/KDEPackageAppTemplatesTest/run_test.cmake.config PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126185/diff/ > > > Testing > ------- > > done some templates installed by plasma-framework > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
