----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review90139 -----------------------------------------------------------
Sorry for the delay; Christmas happened :-) Just two more small (but important) things, and then we're ready to go! kde-modules/KDEPackageAppTemplates.cmake (line 1) <https://git.reviewboard.kde.org/r/126185/#comment61735> This documentation won't be added to the generated docs unless you put a link file in the `docs/kde-module` directory. It's pretty straightforward - just copy and edit one of the other files in that directory. kde-modules/KDEPackageAppTemplates.cmake (line 16) <https://git.reviewboard.kde.org/r/126185/#comment61734> I would phrase this as something like INSTALL_DIR is the directory to install the template package to. In most cases you will want to use the variable KDE_INSTALL_KTEMPLATESDIR from :kde-module:`KDEInstallDirs`. And then put a blank line before the bit about TEMPLATES, so they're separate paragraphs. - Alex Merry On Dec. 18, 2015, 10:55 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126185/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2015, 10:55 a.m.) > > > Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, > and Simon Wächter. > > > Repository: extra-cmake-modules > > > Description > ------- > > templates are very useful as teaching tool in order to make > a minimal application that uses a certain framework. > templates in the KAppTemplate repository will always get forgotten > (plus kapptemplate is not really necessary as they work in kdevelop as well) > An ideal situation would be frameworks having templates in their own repos > with templates of barebone apps using the main framework features. > In order to do that, the cmake stuff needed in order to correctly install > a template needs to be ported to a place avaiable to all frameworks > > > Diffs > ----- > > kde-modules/KDEInstallDirs.cmake b7cd34d > kde-modules/KDEPackageAppTemplates.cmake PRE-CREATION > tests/CMakeLists.txt 1a66f56 > tests/KDEPackageAppTemplatesTest/CMakeLists.txt PRE-CREATION > tests/KDEPackageAppTemplatesTest/check.cmake.in PRE-CREATION > tests/KDEPackageAppTemplatesTest/qml-plasmoid/CMakeLists.txt PRE-CREATION > tests/KDEPackageAppTemplatesTest/qml-plasmoid/Messages.sh PRE-CREATION > tests/KDEPackageAppTemplatesTest/qml-plasmoid/README PRE-CREATION > > tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/images/pairs.svgz > PRE-CREATION > tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/ui/main.qml > PRE-CREATION > tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/metadata.desktop > PRE-CREATION > tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.kdevtemplate > PRE-CREATION > tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.png PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126185/diff/ > > > Testing > ------- > > done some templates installed by plasma-framework > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
