knambiar added a comment.
Might this change fix this issue? https://bugs.kde.org/show_bug.cgi?id=370588
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3829
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: xuetianweng, davi
mart added a comment.
In https://phabricator.kde.org/D3822#71673, @davidedmundson wrote:
> Given the only member variable we use is m_screenPool-> shouldn't this just
be in ScreenPool?
>
> Also I don't understand how this is works:
>
> qxcbconnection::handleXcbEvent
>
> calls
mart updated this revision to Diff 9409.
mart added a comment.
- move in screenpool
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3822?vs=9385&id=9409
BRANCH
phab/nativeeventfilt
REVISION DETAIL
https://phabricator.kde.org/D3822
AFFECTED FI
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Frameworks
REVISION DETAIL
https://phabricator.kde.org/D3828
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasm
mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.
I think it's correct.
anyways, you don't need hinting when the font is so huge
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/oxygen-icons5%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/99/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 28 Dec 2016 11:04:23 +
Build duration: 1 min 0 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129697/
---
(Updated Dec. 28, 2016, 11:21 a.m.)
Status
--
This change has been m
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/oxygen-icons5%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/96/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 28 Dec 2016 11:05:48 +
Build duration: 6 min 24 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/501/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 28 Dec 2016 11:21:25 +
Build duration: 6 min 32 sec
CHANGE SET
Revision 27d71ef5f394f6a53aff3e022ae0145
On Tue, Dec 27, 2016 at 6:45 PM, Marco Martin wrote:
> On Tuesday 27 December 2016, Tomaz Canabrava wrote:
> > Hello good people,
> >
> > I started to port Subsurface to kirigami2 and I found some issues that
> are
> > interesting.
> >
> > If I try to run subsurface while plasma is not running, i
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
support both button order and decoration theme
of kwin when applying for a lnf theme. The deco
theme is compose
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
export also kwin theme to look and feel themes
including the button order
tabbox and desktoip switcher are fixe
mart added a dependent revision: D3833: export kwin theme to l&f.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3832
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, je
mart added a dependency: D3832: import kwin deco and button order in l&f.
REPOSITORY
R118 Plasma SDK
REVISION DETAIL
https://phabricator.kde.org/D3833
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed
mart updated the summary for this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3832
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts,
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Replace the convoluted make an object wi
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Frameworks.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We need to call updateYear/DecadeMode
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Frameworks
REVISION DETAIL
https://phabricator.kde.org/D3835
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasm
https://bugs.kde.org/show_bug.cgi?id=374255
Bug ID: 374255
Summary: Notes widget icons not visible depending on Notes
background and Plasma Shell Dark/Light variant
Product: Breeze
Version: 5.8.5
Platform: Other
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Frameworks.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
- Use QQmlParserStatus to avoid prema
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Frameworks.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
- Use a single global MouseArea and t
broulik added a comment.
We could show up to 5 entries and then a "xx more Places" sub menu or an
entry that expands to reveal the rest. However, this would massively complex
things, as we then would need to track which items the user uses frequently and
give priority to them, otherwise this
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R242 Plasma Frameworks
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3839
AFFECTE
davidedmundson added a comment.
> Unfortunately did not result in a noticeable speedup of first invocation
You've said this in two requests now. Whare are you using to profile?
INLINE COMMENTS
> calendar.cpp:319-323
> +if (needsModelReset) {
> +m_daysModel->update(DaysModel::
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Frameworks
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3839
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:2e944d53a32f: Avoid using deprecated Qt code
QAbstractItemModel::reset (authored by davidedmundson).
REPOSITORY
R242 Plasma Frameworks
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3839?v
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3834
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma,
graesslin added a comment.
I don't think the buttons should be set by a lnf package.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3832
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma
Cc: graesslin, plasma-
broulik updated the summary for this revision.
broulik updated the test plan for this revision.
broulik updated this revision to Diff 9422.
broulik added a comment.
- Limit number of places shown
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3815?vs
graesslin added inline comments.
INLINE COMMENTS
> lnflogic.cpp:160
> +defaultsConfigGroup = KConfigGroup(&defaultsConfigGroup,
> "org.kde.kdecoration2");
> +defaultsConfigGroup.writeEntry("library", systemCG.readEntry("library",
> QStringLiteral("org.kde.breeze")));
> +defaultsConf
mart added inline comments.
INLINE COMMENTS
> graesslin wrote in lnflogic.cpp:163
> like in the other request I don't like this being exported.
would empty string make it use the default?
REPOSITORY
R118 Plasma SDK
REVISION DETAIL
https://phabricator.kde.org/D3833
EMAIL PREFERENCES
http
mart added a comment.
In https://phabricator.kde.org/D3832#71855, @graesslin wrote:
> I don't think the buttons should be set by a lnf package.
the user request was to make possible the l&f themes to emulate a different
os (that is actually part of the design reason of l&f themes)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129716/
---
Review request for KDE Frameworks and Plasma.
Repository: kpackage
Desc
Lucas added a comment.
In https://phabricator.kde.org/D3832#71865, @mart wrote:
> In https://phabricator.kde.org/D3832#71855, @graesslin wrote:
>
> > I don't think the buttons should be set by a lnf package.
>
>
> the user request was to make possible the l&f themes to emulate a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129716/#review101629
---
Ship it!
Ship It!
- Marco Martin
On Dec. 28, 2016, 4:3
graesslin added inline comments.
INLINE COMMENTS
> mart wrote in lnflogic.cpp:163
> would empty string make it use the default?
no, empty string would result in no buttons at all.
REPOSITORY
R118 Plasma SDK
REVISION DETAIL
https://phabricator.kde.org/D3833
EMAIL PREFERENCES
https://pha
graesslin added a comment.
In https://phabricator.kde.org/D3832#71865, @mart wrote:
> In https://phabricator.kde.org/D3832#71855, @graesslin wrote:
>
> > I don't think the buttons should be set by a lnf package.
>
>
> the user request was to make possible the l&f themes to emulat
On Thursday, December 22, 2016 11:42:44 AM UTC Marco Martin wrote:
> On Thursday 22 December 2016 09:10:11 Sebastian Kügler wrote:
> > Go for it. And then let's talk where else we have to change things to
> > streamline our branding.
> >
> > I'm glad we have reached a consensus.
>
> done, the mos
https://bugs.kde.org/show_bug.cgi?id=366299
Sebastian Kügler changed:
What|Removed |Added
Component|general |general
CC|
xuetianweng added a comment.
In https://phabricator.kde.org/D3829#71714, @graesslin wrote:
> Could you explain the relationship to global shortcuts? That sounds to me
like a bug which needs to be fixed in kglobalaccel
I don't really sure about this. So basically XlibNotifications
xuetianweng added a comment.
In https://phabricator.kde.org/D3829#71724, @knambiar wrote:
> Might this change fix this issue?
https://bugs.kde.org/show_bug.cgi?id=370588
Yeah, I suspect so. I already put it in CCBUG, but I'd prefer reporter to
confirm it.
REPOSITORY
R119 Plasm
Hi,
I saw some commits from Kai to enhance the calendar code (both C++ and
QML), apparently for performance reasons. It's great to see people
interested in performance optimizations ;)
Some weeks ago i was watching cppcon videos. One video [1] got me
interested in playing with constructing a cale
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129697/#review101633
---
Sorry for being late to the party, I just saw this now. (I'm
> On Dec. 29, 2016, 12:38 a.m., Kai Uwe Broulik wrote:
> > Sorry for being late to the party, I just saw this now. (I'm all on phab
> > now)
> >
> > I think this entry should only be shown when plasmoid.immutability is
> > SystemImmutable. Yes, system administrator would probably disallow
> >
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129716/
---
(Updated Dec. 29, 2016, 12:25 a.m.)
Status
--
This change has been m
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/502/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 29 Dec 2016 00:23:22 +
Build duration: 7 min 28 sec
CHANGE SET
Revision de56e25395ac8835d578d027cf2aac8
pmuralidharan added inline comments.
INLINE COMMENTS
> screenpool.cpp:203
> +}
> +
> +
Wondering whether returning false always is correct. It feels wrong but I may
be missing something.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3822
EMAIL PREFERENCES
graesslin added a comment.
In https://phabricator.kde.org/D3829#71877, @xuetianweng wrote:
> In https://phabricator.kde.org/D3829#71714, @graesslin wrote:
>
> > Could you explain the relationship to global shortcuts? That sounds to me
like a bug which needs to be fixed in kglobalaccel
jsalatas created this revision.
jsalatas added a reviewer: Breeze.
jsalatas set the repository for this revision to R98 Breeze for Gtk.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
In eclipse running with SWT gtk2 the
49 matches
Mail list logo
