graesslin added inline comments.
INLINE COMMENTS
> lnflogic.cpp:160
> + defaultsConfigGroup = KConfigGroup(&defaultsConfigGroup,
> "org.kde.kdecoration2");
> + defaultsConfigGroup.writeEntry("library", systemCG.readEntry("library",
> QStringLiteral("org.kde.breeze")));
> + defaultsConfigGroup.writeEntry("theme", systemCG.readEntry("theme",
> QString()));
this is not the default used by kwin. KWin determines the default based on the
optional compile time dep on breeze
> lnflogic.cpp:163
> +
> + defaultsConfigGroup.writeEntry("ButtonsOnLeft",
> systemCG.readEntry("ButtonsOnLeft", "MS"));
> + defaultsConfigGroup.writeEntry("ButtonsOnRight",
> systemCG.readEntry("ButtonsOnRight", "HIAX"));
like in the other request I don't like this being exported.
REPOSITORY
R118 Plasma SDK
REVISION DETAIL
https://phabricator.kde.org/D3833
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas
