----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129697/#review101633 -----------------------------------------------------------
Sorry for being late to the party, I just saw this now. (I'm all on phab now) I think this entry should only be shown when plasmoid.immutability is SystemImmutable. Yes, system administrator would probably disallow uninstalling apps (needs root already anway) but we also hide the "Edit application" entry in this case. CMakeLists.txt (line 66) <https://git.reviewboard.kde.org/r/129697/#comment68052> I don't have 0.10.4 on neon dev unstable, just 0.10.3 applets/kicker/package/contents/config/main.xml <https://git.reviewboard.kde.org/r/129697/#comment68053> This key is also present in kickerdash (kdeplasma-addons) iirc applets/kicker/plugin/appentry.cpp (line 147) <https://git.reviewboard.kde.org/r/129697/#comment68054> Braces applets/kicker/plugin/appentry.cpp (line 151) <https://git.reviewboard.kde.org/r/129697/#comment68055> Join with QLatin1String, you lose the advantage of compile-time generated QStringLiteral when concatenating; also const &? applets/kicker/plugin/appentry.cpp (line 156) <https://git.reviewboard.kde.org/r/129697/#comment68056> QStringLiteral applets/kicker/plugin/appentry.cpp (line 200) <https://git.reviewboard.kde.org/r/129697/#comment68057> Braces - Kai Uwe Broulik On Dez. 28, 2016, 11:21 vorm., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129697/ > ----------------------------------------------------------- > > (Updated Dez. 28, 2016, 11:21 vorm.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > So far we had a (commented out) entry that was called `Remove <application > package>` that would open the configured application. > > * Instead of looking up the service files in PackageKit, it does so on > AppStream, allowing for a faster and sync approach. > * Renames the action to `Open <application name>`. > * Uses `appstream://` URI scheme, allowing for the system to decide which > application handles it rather than an awkward configuration entry. > * Drops PackageKit-Qt opcional dependency, adds a required AppstreamQt > dependency instead. > > This also means that applications coming from other sources than the > packaging system (i.e. Snappy, Flatpak or AppImage) would also be supported, > as long as it's supported by the package manager. > > > Diffs > ----- > > CMakeLists.txt 90aaa03e > applets/kicker/CMakeLists.txt 2e112e42 > applets/kicker/package/contents/config/main.xml bfd0d2db > applets/kicker/plugin/appentry.cpp 5efdb0d0 > applets/kicker/plugin/findpackagenamejob.h 9905182c > applets/kicker/plugin/findpackagenamejob.cpp aa3fd549 > applets/kickoff/package/contents/config/main.xml d7c51624 > config-workspace.h.cmake d0b48b94 > > Diff: https://git.reviewboard.kde.org/r/129697/diff/ > > > Testing > ------- > > Manual testing, opened few applications, all worked fine. > > > Thanks, > > Aleix Pol Gonzalez > >
