broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY - Use QQmlParserStatus to avoid premature initialization - Requires the days model to signal a model reset as by the time the Repeater in QML read the model for the first time it's empty (avoids boolean trap in "update" method signature by using an enum ;) - Don't signal weeks"Model" changed if it didn't - emitting a changing variant list / json array will cause QML to destroy and re-create all delegates TEST PLAN Calendar still seems to work. Week number column still works. Unfortunately did not result in a noticeable speedup of first invocation REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D3837 AFFECTED FILES src/declarativeimports/calendar/calendar.cpp src/declarativeimports/calendar/calendar.h src/declarativeimports/calendar/daysmodel.cpp src/declarativeimports/calendar/daysmodel.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
