Review Request 126791: plasma-framework: Fix list.svgz to use color from stylesheet

2016-01-18 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126791/ --- Review request for Plasma. Description --- Fixed the color for "list

Re: Review Request 126779: Fix for bug 358135: Media Player widget in expanded mode makes Amarok skip tracks

2016-01-18 Thread Eduardo Lara
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126779/ --- (Updated Jan. 18, 2016, 10:29 a.m.) Review request for Plasma and Kai Uwe

Re: Review Request 126767: Breeze Cursor (default) Update

2016-01-18 Thread Ken Vermette
> On Jan. 16, 2016, 11:04 a.m., Kai Uwe Broulik wrote: > > - The busy cursor looks unlike anything we use elsewhere and eerily similar > > to what Android has nowadays. It looks rather hectic and that the two lines > > briefly connect looks awkward. > > - The "shutter" effect draws even more at

Review Request 126792: IconItem: Try to load QIcon::fromTheme icons as svg

2016-01-18 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126792/ --- Review request for Plasma. Bugs: 353358 http://bugs.kde.org/show_bug.

Re: Review Request 126779: Fix for bug 358135: Media Player widget in expanded mode makes Amarok skip tracks

2016-01-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126779/#review91254 --- Fix it, then Ship it! Thanks again! Do you have commit ac

Re: Review Request 126767: Breeze Cursor (default) Update

2016-01-18 Thread Kai Uwe Broulik
> On Jan. 16, 2016, 11:04 vorm., Kai Uwe Broulik wrote: > > - The busy cursor looks unlike anything we use elsewhere and eerily similar > > to what Android has nowadays. It looks rather hectic and that the two lines > > briefly connect looks awkward. > > - The "shutter" effect draws even more a

Re: Review Request 124586: Dismiss logout dialog when clicking outside

2016-01-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124586/ --- (Updated Jan. 18, 2016, 11:08 a.m.) Status -- This change has been m

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 48 - Still Failing!

2016-01-18 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/48/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 18 Jan 2016 11:08:31 + Build duration: 1 min 56 sec CHANGE SET Revision 3dce39fd21eb36a1d91

Re: Review Request 126776: [Panel Containment] Hide applet if its status is Hidden

2016-01-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126776/ --- (Updated Jan. 18, 2016, 11:13 a.m.) Status -- This change has been m

Re: Review Request 126777: [Pager] Use HiddenStatus instead of size hack

2016-01-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126777/ --- (Updated Jan. 18, 2016, 11:13 a.m.) Status -- This change has been m

Review Request 126793: KF5 (Picture) Frame plasmoid

2016-01-18 Thread Lars Pontoppidan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126793/ --- Review request for Plasma. Repository: kdeplasma-addons Description ---

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-01-18 Thread Lars Pontoppidan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126793/ --- (Updated Jan. 18, 2016, 11:27 a.m.) Review request for Plasma. Changes

Re: Review Request 126792: IconItem: Try to load QIcon::fromTheme icons as svg

2016-01-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126792/#review91258 --- src/declarativeimports/core/iconitem.cpp (line 105)

Re: Review Request 126779: Fix for bug 358135: Media Player widget in expanded mode makes Amarok skip tracks

2016-01-18 Thread Eduardo Lara
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126779/ --- (Updated Jan. 18, 2016, 12:11 p.m.) Review request for Plasma and Kai Uwe

Review Request 126794: Use PlasmaCore.IconItem in WidgetExplorer and AlternativesDelegate

2016-01-18 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126794/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 126767: Breeze Cursor (default) Update

2016-01-18 Thread Ken Vermette
> On Jan. 16, 2016, 11:04 a.m., Kai Uwe Broulik wrote: > > - The busy cursor looks unlike anything we use elsewhere and eerily similar > > to what Android has nowadays. It looks rather hectic and that the two lines > > briefly connect looks awkward. > > - The "shutter" effect draws even more at

Re: Review Request 126786: Quicklaunch: Add option to show title

2016-01-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126786/#review91263 --- +1 applets/quicklaunch/package/contents/ui/ConfigGeneral.qm

Re: Review Request 126786: Quicklaunch: Add option to show title

2016-01-18 Thread David Rosca
> On Jan. 18, 2016, 2:23 p.m., Kai Uwe Broulik wrote: > > applets/quicklaunch/package/contents/ui/ConfigGeneral.qml, line 88 > > > > > > onCheckedChanged ? No, it should be executed only when the checkbox value i

Re: Review Request 126792: IconItem: Try to load QIcon::fromTheme icons as svg

2016-01-18 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126792/ --- (Updated Jan. 18, 2016, 3:21 p.m.) Review request for Plasma. Bugs: 353

Re: Review Request 126786: Quicklaunch: Add option to show title

2016-01-18 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126786/ --- (Updated Jan. 18, 2016, 3:26 p.m.) Review request for Plasma. Changes -

Re: Review Request 126786: Quicklaunch: Add option to show title

2016-01-18 Thread David Rosca
> On Jan. 18, 2016, 2:23 p.m., Kai Uwe Broulik wrote: > > applets/quicklaunch/package/contents/ui/main.qml, line 103 > > > > > > I think you can unset Plasma's default thing by setting height to > > undefined (Q

Re: Review Request 126786: Quicklaunch: Add option to show title

2016-01-18 Thread David Rosca
> On Jan. 18, 2016, 2:23 p.m., Kai Uwe Broulik wrote: > > applets/quicklaunch/package/contents/ui/main.qml, line 103 > > > > > > I think you can unset Plasma's default thing by setting height to > > undefined (Q

Re: Review Request 126786: Quicklaunch: Add option to show title

2016-01-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126786/#review91270 --- Ship it! Ship It! - Kai Uwe Broulik On Jan. 18, 2016, 3

Re: Review Request 126786: Quicklaunch: Add option to show title

2016-01-18 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126786/ --- (Updated Jan. 18, 2016, 3:48 p.m.) Status -- This change has been ma

Review Request 126800: AppletConfiguration: Use QIconItem for category icons

2016-01-18 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126800/ --- Review request for Plasma. Repository: plasma-desktop Description -

Review Request 126801: Don't show drop applet placeholder on desktop in immutable state

2016-01-18 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126801/ --- Review request for Plasma. Repository: plasma-desktop Description -

Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview

2016-01-18 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126802/ --- Review request for Plasma. Repository: plasma-desktop Description -

PSA: KAccounts now requires two env vars set

2016-01-18 Thread Martin Klapetek
Because of a co-installability issue with other DEs [1] that use the accounts-sso tech, I had to change the location of the provider and service files we ship. This was decided after discussing with upstream. To make KAccounts/libaccounts actually read those from the new locations, two new env var

Re: Review Request 126801: Don't show drop applet placeholder on desktop in immutable state

2016-01-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126801/#review91282 --- Can we perhaps go a step further and just reject a drop, ie.

Re: Review Request 126801: Don't show drop applet placeholder on desktop in immutable state

2016-01-18 Thread David Rosca
> On Jan. 18, 2016, 8:45 p.m., Kai Uwe Broulik wrote: > > Can we perhaps go a step further and just reject a drop, ie. disable the > > drop area? > > > > We have the problem of Firefox not opening a window because we eat the drop > > event. Of course doing that won't solve the root cause but a

Re: Review Request 126801: Don't show drop applet placeholder on desktop in immutable state

2016-01-18 Thread Sebastian Kügler
> On Jan. 18, 2016, 8:45 p.m., Kai Uwe Broulik wrote: > > Can we perhaps go a step further and just reject a drop, ie. disable the > > drop area? > > > > We have the problem of Firefox not opening a window because we eat the drop > > event. Of course doing that won't solve the root cause but a

Re: Review Request 126801: Don't show drop applet placeholder on desktop in immutable state

2016-01-18 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126801/#review91295 --- Ship it! Ship It! - Eike Hein On Jan. 18, 2016, 6:47 p.

Re: PSA: KAccounts now requires two env vars set

2016-01-18 Thread Weng Xuetian
I just wonder whether it is some work for startkde or something to be installed under /etc/xdg/plasma-workspace/env/ . If so maybe add a file to kaccounts and install it under /etc/xdg/plasma-workspace/env/ then you won't need to bother packagers to figure out how to make it work. On Mon, Jan 18,