-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126779/
-----------------------------------------------------------
(Updated Jan. 18, 2016, 12:11 p.m.)
Review request for Plasma and Kai Uwe Broulik.
Changes
-------
Addressing code formatting issues
Bugs: 358135
https://bugs.kde.org/show_bug.cgi?id=358135
Repository: plasma-workspace
Description
-------
Reset seek slider position when changing songs
The attached patch retrieves the position from the player when:
* a new maximum is set to the slider (most cases)
* the the slider is already at the end (when the same song is played again)
Note that adding 1 sec to the slider when the remaining is less than a second
sets the slider to maximum. Handling at that moment seemed to be too soon when
I tried it. Waiting for the next iteration looked to be a better transition
Diffs (updated)
-----
applets/mediacontroller/contents/ui/ExpandedRepresentation.qml 0b5c964
Diff: https://git.reviewboard.kde.org/r/126779/diff/
Testing
-------
Added a list of songs to Amarok that include transitions from a shorter song to
a longer song, from a longer song to a shorter song and the same song twice.
Tested with the Media Player in expanded mode on the desktop and then on a
panel (compact mode) while the expanded screen poped up.
Probably as importantly the test not done. I did not try with other players.
Thanks,
Eduardo Lara
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
