> On Jan. 18, 2016, 2:23 p.m., Kai Uwe Broulik wrote: > > applets/quicklaunch/package/contents/ui/ConfigGeneral.qml, line 88 > > <https://git.reviewboard.kde.org/r/126786/diff/1/?file=433341#file433341line88> > > > > onCheckedChanged ?
No, it should be executed only when the checkbox value is changed by user (not programatically). It works as expected even with keyboard (toggling the checkbox with space). If I change it to onCheckedChanged, the TextField gets focus when opening the settings dialog. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126786/#review91263 ----------------------------------------------------------- On Jan. 17, 2016, 9:35 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126786/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2016, 9:35 p.m.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > ------- > > Add option to show title just like Folder View applet. > > > Diffs > ----- > > applets/quicklaunch/package/contents/code/layout.js 70d82a6 > applets/quicklaunch/package/contents/config/main.xml 2ea19aa > applets/quicklaunch/package/contents/ui/ConfigGeneral.qml d8d9f7d > applets/quicklaunch/package/contents/ui/main.qml 8ada2fa > > Diff: https://git.reviewboard.kde.org/r/126786/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > quicklaunch-title.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/17/1b8ed953-e68c-4c16-99b2-240740904e5c__quicklaunch-title.png > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
