----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126786/#review91263 -----------------------------------------------------------
+1 applets/quicklaunch/package/contents/ui/ConfigGeneral.qml (line 85) <https://git.reviewboard.kde.org/r/126786/#comment62380> TextField has a length property, directly use this to avoid copying the text into the QML environment just to get its length. applets/quicklaunch/package/contents/ui/ConfigGeneral.qml (line 88) <https://git.reviewboard.kde.org/r/126786/#comment62381> onCheckedChanged ? applets/quicklaunch/package/contents/ui/main.qml (line 103) <https://git.reviewboard.kde.org/r/126786/#comment62378> I think you can unset Plasma's default thing by setting height to undefined (Q_PROPERTY RESET) applets/quicklaunch/package/contents/ui/main.qml (line 106) <https://git.reviewboard.kde.org/r/126786/#comment62379> wrapMode: Text.NoWrap also? - Kai Uwe Broulik On Jan. 17, 2016, 9:35 nachm., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126786/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2016, 9:35 nachm.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > ------- > > Add option to show title just like Folder View applet. > > > Diffs > ----- > > applets/quicklaunch/package/contents/code/layout.js 70d82a6 > applets/quicklaunch/package/contents/config/main.xml 2ea19aa > applets/quicklaunch/package/contents/ui/ConfigGeneral.qml d8d9f7d > applets/quicklaunch/package/contents/ui/main.qml 8ada2fa > > Diff: https://git.reviewboard.kde.org/r/126786/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > quicklaunch-title.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/17/1b8ed953-e68c-4c16-99b2-240740904e5c__quicklaunch-title.png > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
