On Fri, Jun 9, 2017 at 8:41 AM, Andrew Gierth
wrote:
>>>>>> "Thomas" == Thomas Munro writes:
>
> Thomas> So, afterTriggers.query_stack is used to handle the reentrancy
> Thomas> that results from triggers running further statements that
> T
On Thu, Jun 8, 2017 at 11:50 AM, Thomas Munro
wrote:
> On Thu, Jun 8, 2017 at 11:05 AM, Thomas Munro
> wrote:
>> 1. Keep the current behaviour. [...]
>>
>> 2. Make a code change that would split the 'new table' tuplestore in
>> two: an insert tuplestore
On Mon, May 22, 2017 at 5:51 PM, Amit Langote
wrote:
> On 2017/05/20 9:01, Thomas Munro wrote:
>> Sent too soon. Several variables should also be renamed to make clear
>> they refer to the transition capture state in effect, instead of vague
>> names like 'transition
On Wed, Jun 7, 2017 at 5:36 PM, Thomas Munro
wrote:
> I spent a couple of hours drafting a proof-of-concept to see if my
> hunch was right. It seems to work correctly so far and isn't huge
> (but certainly needs more testing and work):
>
> 6 files changed, 156 insertio
rted tuples.
On Fri, Jun 9, 2017 at 11:28 AM, Thomas Munro
wrote:
> I discussed this off-list with Andrew Gierth and we came up with a
> fourth way: Use separate insert and update tuplestores (as originally
> suggested by Peter) and use the (INSERT, UPDATE) to
> decide which one a
its hands on the QueryEnvironment required to do that. I
will look into this on Monday, but other ideas/clues welcome...
--
Thomas Munro
http://www.enterprisedb.com
fixes-for-enr-rte-review-v1.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ple capture.
Someone extending execReplication.c to support partitions and
statement triggers etc will need to think about creating a
TransitionCaptureState but I decided that was out of scope for the
transition table rescue project. In the new version of the #2 patch
that I'm about to post on t
implify this code. Maybe just change the outer "if" statement to if
> (row_trigger) and then Assert(transition_capture != NULL)?
Yeah, that was silly, and also the comment was misleading. It is
possible for row_trigger to be true and transition_capture to be NULL,
so I did it slightly
On Fri, Jun 9, 2017 at 4:10 PM, Thomas Munro
wrote:
> On Wed, Jun 7, 2017 at 10:47 AM, Peter Geoghegan wrote:
>> I suppose you'll need two tuplestores for the ON CONFLICT DO UPDATE
>> case -- one for updated tuples, and the other for inserted tuples.
>
> [...]
>
&
On Sun, Jun 11, 2017 at 11:11 PM, Thomas Munro
wrote:
> On Sun, Jun 11, 2017 at 6:25 PM, Noah Misch wrote:
>> This fourth point is not necessarily a defect: I wonder if RangeTblEntry is
>> the right place for enrtuples. It's a concept regularly seen in planner data
&
On Mon, Jun 12, 2017 at 2:40 PM, Thomas Munro
wrote:
> On Fri, Jun 9, 2017 at 4:10 PM, Thomas Munro
> wrote:
>> On Wed, Jun 7, 2017 at 10:47 AM, Peter Geoghegan wrote:
>>> I suppose you'll need two tuplestores for the ON CONFLICT DO UPDATE
>>> case -- one fo
On Tue, Jun 13, 2017 at 6:40 PM, Noah Misch wrote:
> On Mon, Jun 12, 2017 at 04:04:23PM +1200, Thomas Munro wrote:
>> On Sun, Jun 11, 2017 at 11:11 PM, Thomas Munro
>> wrote:
>> > On Sun, Jun 11, 2017 at 6:25 PM, Noah Misch wrote:
>> >> This fourth point is n
ngeTblEntry() . Here's a patch for that, to
apply on top of the -v1 patch above.
--
Thomas Munro
http://www.enterprisedb.com
add-enrtuples-to-node-funcs.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ay when there are no backends
attached (ie because there are no backends running) (if I understand
correctly that you want this DSA area to last as long as the whole
cluster).
By the way, in _PG_init() where you have
RequestAddinShmemSpace(1) I think you want
RequestAddinShmemSpace(sizeof(shared
his P.S. note is asking
> whether this is a good idea, or would we prefer that failing
> transactions are retried.
>
> I think it's pretty obvious that transactions that failed with
> some serializability problem should be retried.
+1 for retry with reporting of retry rates
--
Thom
cfloat[()] (T076)."
http://modern-sql.com/blog/2017-06/whats-new-in-sql-2016
So far it's supported only by DB2 (inventor) and FirebirdSQL has just
announced support in the next release.
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
synthesising one if no exact match). If you view
the former case as a kind of degenerate case of interpolation then it
doesn't feel like a "join" as we know it, but clearly it is. I had
never considered before that such things might belong inside the
database as a kind of join operat
On Fri, Jun 16, 2017 at 1:24 PM, Craig Ringer wrote:
> On 16 June 2017 at 05:42, Thomas Munro wrote:
>> Bumping this ancient thread to say that DECFLOAT appears to have
>> landed in the SQL standard. I haven't looked at SQL:2016 myself by I
>> just saw this on Marku
> TopMemoryContext. Try running the regression tests under
> force_parallel_mode - crashes immediately for me without fixing that.
Gah, right. Fixed.
> - SharedRecordTypmodRegistryInit() is called from GetSessionDsmHandle()
> which calls EnsureCurrentSession(), but
> SharedRecordTypmodRegis
On Wed, Aug 23, 2017 at 11:58 PM, Thomas Munro
wrote:
> On Wed, Aug 23, 2017 at 5:46 PM, Andres Freund wrote:
>> - Afaict GetSessionDsmHandle() uses the current rather than
>> TopMemoryContext. Try running the regression tests under
>> force_parallel_mode - crashes immed
Hi hackers,
I spotted a (harmless) thinko in dsa.c. Please see attached.
--
Thomas Munro
http://www.enterprisedb.com
dsa-alloc-no-oom.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http
On Wed, Aug 23, 2017 at 11:58 PM, Thomas Munro
wrote:
> On Wed, Aug 23, 2017 at 5:46 PM, Andres Freund wrote:
>> Notes for possible followup commits of the dshash API:
>> - nontrivial portions of dsahash are essentially critical sections lest
>> dynamic shared memory
= (byte - 1);
+}
+}
Sorry I didn't follow up with my threat[3] to provide a central
popcount() function to replace the implementations all over the tree.
[1] https://www.postgresql.org/message-id/25076.1489699457%40sss.pgh.pa.us
[2] http://www.cse.yorku.ca/~oz/hash.html
[3]
https:/
On Wed, Aug 30, 2017 at 1:00 PM, Peter Geoghegan wrote:
> On Tue, Aug 29, 2017 at 4:34 PM, Thomas Munro
> wrote:
>> Some drive-by comments on the lib patch:
>
> I was hoping that you'd look at this, since you'll probably want to
> use a bloom filter for paralle
he FIXME ;)
This must refer to a note about cleaning up skew buckets after they're
not needed, which I've now done.
Some other things:
Previously I failed to initialise the atomics in the shared skew hash
table correctly, and also I used memset to overwrite atomics when
loading a new ba
. You need to change this:
Form_pg_attribute att = RelationGetDescr(indexDesc)->attrs[i];
... to this:
Form_pg_attribute att = TupleDescAttr(RelationGetDescr(indexDesc), i);
Thanks!
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-ha
cd70845 and c6293249 you need to change expressions of
that format to, for example:
node->datumFormat = TupleDescAttr(curr->tts_tupleDescriptor,
tc->attNumP1 - 1);
Thanks!
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.
On Wed, Jun 28, 2017 at 11:21 AM, Thomas Munro
wrote:
> [ssi-parallel-v5.patch]
Rebased.
--
Thomas Munro
http://www.enterprisedb.com
ssi-parallel-v6.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscript
On Thu, Aug 31, 2017 at 2:12 PM, Tatsuro Yamada
wrote:
> Any comments or suggestion are welcome.
Although this patch updates src/test/regress/expected/rules.out I
think perhaps you included the wrong version? That regression test
fails for me
--
Thomas Munro
http://www.enterprisedb.
the meantime its bits have begun to rot. Michael, could you please rebase?
Thanks!
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Wed, Jun 28, 2017 at 1:11 PM, Thomas Munro
wrote:
> On Sat, Mar 25, 2017 at 7:27 AM, Thomas Munro
> wrote:
>> On Sat, Mar 25, 2017 at 3:11 AM, Anastasia Lubennikova
>> wrote:
>>> You claim that SLRUs now support five digit segment name, while in slru.h
>
On Sat, Sep 2, 2017 at 5:13 AM, Robert Haas wrote:
> On Thu, Aug 31, 2017 at 8:53 AM, Thomas Munro
> wrote:
>> Check out ExecReScanGather(): it shuts down and waits for all workers
>> to complete, which makes the assumptions in ExecReScanHashJoin() true.
>> If a node bel
On Sat, Sep 2, 2017 at 10:45 AM, Robert Haas wrote:
> On Fri, Sep 1, 2017 at 6:32 PM, Thomas Munro
> wrote:
>> On Sat, Sep 2, 2017 at 5:13 AM, Robert Haas wrote:
>>> On Thu, Aug 31, 2017 at 8:53 AM, Thomas Munro
>>> wrote:
>>>> Check out ExecReSca
x00010edeb785 postgres`ServerLoop + 597 at postmaster.c:1753
frame #19: 0x00010ede8f71 postgres`PostmasterMain(argc=8,
argv=0x7fe271403860) + 5553 at postmaster.c:1361
frame #20: 0x00010ed0ccd9 postgres`main(argc=8,
argv=0x7fe271403860) + 761 at main.c:228
frame #21: 0x7fff
se commit 81c5e46c490e just stole your OIDs:
make[3]: Entering directory
`/home/travis/build/postgresql-cfbot/postgresql/src/backend/catalog'
cd ../../../src/include/catalog && '/usr/bin/perl' ./duplicate_oids
772
972
make[3]: *** [postgres.bki] Error 1
--
Thomas Munro
http://www
d.(*)
Apparently ru_maxrss is in *pages* on Solaris-derived systems:
https://illumos.org/man/3c/getrusage
AIX seems to be like Linux and FreeBSD (kilobytes):
https://www.ibm.com/support/knowledgecenter/en/ssw_aix_61/com.ibm.aix.basetrf1/getrusage_64.htm
--
Thomas Munro
http://www.enterprisedb.c
gt; +}
> +
I'm less sure about this part. It seems like a slippery slope.
A couple of regression test failures:
inherit ... FAILED
rowsecurity ... FAILED
2 of 179 tests failed.
====
think it should be (size_t) 1, not UINT64CONST(1). See attached.
> I have noticed a typo in dshash.h for which a separate patch is attached.
+1
--
Thomas Munro
http://www.enterprisedb.com
fix_warning.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Andres Freund wrote:
> On 2017-08-21 11:02:52 +1200, Thomas Munro wrote:
>> 2. Andres didn't like what I did to DecrTupleDescRefCount, namely
>> allowing to run when there is no ResourceOwner. I now see that this
>> is probably an indication of a different problem; even
e_label.
"... in the example ..."
A few random whitespace changes:
- (errmsg("must be superuser to use raw page functions";
+ (errmsg("must be superuser to use raw page functions")))
+ );
- opaq->flags, GIN_META)));
+ opaq->flags, GIN_META))
+ );
- flags[nflags++] = DirectFunctionCall1(to_hex32, Int32GetDatum(flagbits));
+ flags[nflags++] = DirectFunctionCall1(to_hex32,
+ Int32GetDatum(flagbits));
- (GIN_DATA | GIN_LEAF | GIN_COMPRESSED;
+ (GIN_DATA | GIN_LEAF | GIN_COMPRESSED)))
+ );
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
'
# doesn't match '(?^:invalid filename)'
# Looks like you failed 3 tests of 42.
t/010_pg_archivecleanup.pl .. Dubious, test returned 3 (wstat 768, 0x300)
Failed 3/42 subtests
Test Summary Report
-------
t/010_pg_archivecleanup.pl (Wstat: 768 Tests: 42 Failed: 3)
mentation build, because
doc/src/sgml/release-9.6.sgml still contains but you removed that id.
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, Sep 1, 2017 at 1:51 PM, Haribabu Kommi wrote:
> Here I attached new set of patches that are rebased to the latest master.
Hi Haribabu,
Could you please post a new rebased version?
0007-Scan-functions-are-added-to-storage-AM.patch conflicts with
recent changes.
Thanks!
--
Thomas Mu
On Thu, Aug 10, 2017 at 2:02 PM, Thomas Munro
wrote:
> Rebased after conflicting commit 030273b7. Now using format-patch
> with a commit message to keep track of review/discussion history.
TAP test 006_logical_decoding.pl failed with that version. I had
missed some places that know
o go this far? Note that this is not involving
inheritance and constraint exclusion. I don't immediately see any
reason why not, but I'm not sure.
2. If yes, then this postgres_fdw test should be changed, because I
think it was trying to demonstrate that IS NOT NULL expressions are
sent t
YNC_STATE_CHANGE,
^
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, Sep 8, 2017 at 10:24 AM, Thomas Munro
wrote:
> On Wed, Aug 16, 2017 at 2:13 PM, Masahiko Sawada
> wrote:
>> The previous patch conflicts with current HEAD, I rebased the patch to
>> current HEAD.
>
> Hi Masahiko-san,
Hi Sawada-san,
I have just learned
he next commitfest.
>>
>> This patch needs to be rebased for the upcoming commit fest.
>
> Thanks for checking. Rebased patch is attached.
Hi Haribabu,
This patch breaks the documentation build, possibly because of these empty tags:
+--create option to dump <>
no longer applies, but it's in "Needs review" status in the
Commitfest. Could you please post a rebased version?
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://w
rn current;
422 }
(lldb) print *rb
(RBTree) $2 = {
root = 0x7fe7e4419b60
node_size = 40
comparator = 0x00010cffc310 (test_rbtree.so`cmp at int_rbtree.h:28)
combiner = 0x0000
allocfunc = 0x00010cffc340 (test_rbtree.so`alloc at int_rbtree.h:37)
freefunc = 0x
ake to run this here. It seems that to
use "database mdb" I'd need to add a config line to tell it the path
to load back_mdb.so from. I could have done, but I noticed that if I
tell it to use raw ldif files instead it's happy. Does this still
work for you on the syste
this one:
- buffer_size += user_name_size;
+ buffer_size += user_name_size - 2;
The algorithm is: start with buffer_size = 0; add user_name_size if
you see "%u" but otherwise just add one per character; finally add one
for the terminator. There is no reason to subtract 2, since we didn&
7;m not sure, but I feel like it deserves a proper name.
websearch_to_tsquery()?
I see that your AROUND(n) is an undocumented Google search syntax.
That's a good trick to know.
Please send a rebased version of the patch for people to review and
test as that one has bit-rotted.
--
Thomas Munr
Autum commitfest.
The patch didn't survive the Summer bitrotfest. Could you please rebase it?
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
t; +
>
> I understand the --drop-slot part. But I don't understand what it means
> to ignore a missing replication slot when running --start.
Also "--start" breaks the documentation build (missing
slash on the closing tag).
--
Thomas Munro
http://www.enterprisedb.com
On Mon, Sep 11, 2017 at 11:40 AM, Michael Paquier
wrote:
> Thomas Munro has hacked up a prototype of application testing
> automatically if patches submitted apply and build:
> http://commitfest.cputube.org/
>
> I would recommend have a look at it from time to time if you are a
>
hat branch. For now you have to
note the Commitfest entry ID, and then when find the corresponding
branch (ie commitfest/14/1234) on the page it dumps you on. It would
be nice to fix that.
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hacker
On Tue, Sep 12, 2017 at 11:57 AM, Bruce Momjian wrote:
> On Tue, Aug 1, 2017 at 08:53:51AM +1200, Thomas Munro wrote:
>> "Add AFTER trigger transition tables to record changed rows (Kevin Grittner)"
>>
>> Any chance I could ask for a secondary author credit here
ername. It's nice not to have to
escape any characters in URLs. I suppose more keywords could be added
in follow-up patches if someone thinks that would be useful
($hostname, $dbname, ...?). I got sick of that buffer sizing code and
changed it to use StringInfo. Here also are your test pa
sql/dbname.sql:
No such file
+ printf("target = %s\n",target);
Looks like a stray debugging message?
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Thu, Aug 17, 2017 at 2:11 PM, Thomas Munro
wrote:
> On Wed, Apr 12, 2017 at 7:08 PM, Tsunakawa, Takayuki
> wrote:
>> Oh, I got it now. Thanks. The revised patch is attached. The only
>> modified file is pg_ctl.c. The patch worked as expected.
>>
>> It is reg
patch
that's cfbot's fault, but if we were to nail down the acceptable
formats then it'd become your fault if it didn't understand your patch
:-D
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Eventually I'll
also teach it how to dump a backtrace out of gdb the tests leave a
smouldering core.
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
e this line:
! return exec_simple_check_node((Node *) ((ArrayCoerceExpr
*) node)->arg);
But you removed exec_simple_check_node in
00418c61244138bd8ac2de58076a1d0dd4f539f3, so this 02 patch needs to be
rebased.
> Also, at this point this should surely be just an experiment.
+1
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ake a while because it rotates through the
submissions at a rate of one submission every 5 minutes after a new
commit to master is detected, since I don't want to get in trouble for
generating excessive load against the Commitfest, Github or (mainly)
Travis CI. That's probably too cautiou
On Wed, Sep 13, 2017 at 1:55 AM, Peter Eisentraut
wrote:
> On 9/11/17 23:58, Thomas Munro wrote:
>> Sounds good. Here it is with $username. It's nice not to have to
>> escape any characters in URLs. I suppose more keywords could be added
>> in follow-up patches if so
oundtrips.
Hi Elvis,
FYI the recovery test 001_stream_rep.pl fails with this patch applied.
You can see that if you configure with --enable-tap-tests, build and
then cd into src/test/recovery and "make check".
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers ma
g it visible that the message comes from LDAP (rather than
>>> Postgres or anything else) is valuable. How about this?
>>>
>>> LOG: could not start LDAP TLS session: Protocol error
>>> DETAIL: LDAP diagnostics: unsupported extended operation.
>>>
_WAL but hasn't removed that reference to it.
I'm not sure what happened. Is it possible that your patch was not
created by diffing against master?
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
rg/html/rfc4511
3. A list containing only the OID "1.1" indicates that no
attributes are to be returned. If "1.1" is provided with other
attributeSelector values, the "1.1" attributeSelector is
ignored. This OID was chosen because it does not (and c
On Wed, Sep 13, 2017 at 9:11 PM, Thomas Munro
wrote:
> On Wed, Sep 13, 2017 at 8:58 PM, Ashutosh Sharma
> wrote:
>> I am getting the following error message when trying to build latest
>> PG source on Windows,
>>
>> Error 1 error C2065: 'LDAP_NO_ATTRS'
-s0" to try your new
column-aware pager from https://github.com/okbob/pspg for my regular
work. Wow! It could use some warning clean-up but it's a clever idea
and so far it works really well. Thanks for making this.
--
Thomas Munro
http://www.enterprisedb.com
--
Sent v
On Wed, Sep 6, 2017 at 11:14 PM, Ashutosh Bapat
wrote:
> On Fri, Jul 21, 2017 at 4:10 AM, Thomas Munro
> wrote:
>> That just leaves the question of whether we should try to handle the
>> empty RHS and single-value RHS cases using statistics. My intuition
>> is that w
skew hash table is present and tries to
probe it after batch 1. I have a fix for that and I will post a new
patch set just as soon as I have a good regression test figured out.
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.or
On Thu, Sep 14, 2017 at 11:57 AM, Thomas Munro
wrote:
> On Thu, Sep 14, 2017 at 12:51 AM, Prabhat Sahu
> wrote:
>> Setting with lower "shared_buffers" and "work_mem" as below, query getting
>> crash but able to see explain plan.
>
> Thanks Prabhat.
still be managed by humans and the new apply and build statuses would
be managed by faithful robot servants.
How exactly that would work, I don't know. One idea is that a future
cfbot, rewritten in better Python and adopted into the pginfra
universe, pokes CF via an HTTPS endpoint s
On Fri, Sep 15, 2017 at 3:03 PM, Andres Freund wrote:
> On 2017-09-04 18:14:39 +1200, Thomas Munro wrote:
>> Thanks for the review and commits so far. Here's a rebased, debugged
>> and pgindented version of the remaining patches.
>
> I've pushed this with
but I also see no reason to continue
> doing it.)
Done for all lines I touched in the patch.
Thanks for the review!
--
Thomas Munro
http://www.enterprisedb.com
0001-Improve-LDAP-cleanup-code-in-error-paths.patch
Description: Binary data
0002-Log-diagnostic-messages-if-errors-occur-duri
ep
getting distracted by other things catching on fire...
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
log2
> being not being initialized in ensure_valid_bucket_pointers.
Thanks. Will investigate.
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Sun, Sep 17, 2017 at 7:42 AM, Thomas Munro
wrote:
> On Sun, Sep 17, 2017 at 12:30 AM, Tomas Vondra
> wrote:
>> I've been running some regression tests under valgrind, and it seems
>> select_parallel triggers some uses of uninitialized values in dshash. If
>> I&#x
bably be pushed into the index scan.
FWIW I'd vote for 'skip' rather than 'loose' as a term to use in this
family of related features (DISTINCT being the easiest to build). It
seems more descriptive than the MySQL term. (DB2 added this a little
while ago and went with '
LLVM sanitizer stuff, valgrind, Coverity, more compilers, ... but I'm not sure what things really make sense. I may be
placing undue importance on things that I personally screwed up
recently :-D
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-ha
On Mon, Sep 18, 2017 at 2:39 PM, Andres Freund wrote:
> E.g. very little of the new stuff in
> https://codecov.io/gh/postgresql-cfbot/postgresql/commit/ceaa3dbece3c9b98abcaa28009320fde45a83f88
> is exercised.
Hoist by my own petard.
--
Thomas Munro
http://www.enterprisedb.com
--
On Sun, Sep 17, 2017 at 8:49 AM, Thomas Munro
wrote:
> On Sun, Sep 17, 2017 at 7:42 AM, Thomas Munro
> wrote:
>> On Sun, Sep 17, 2017 at 12:30 AM, Tomas Vondra
>> wrote:
>>> I've been running some regression tests under valgrind, and it seems
>>&
On Mon, Sep 18, 2017 at 5:39 PM, Thomas Munro
wrote:
> Here is a patch to fix that.
Here's a better one (same code, corrected commit message).
--
Thomas Munro
http://www.enterprisedb.com
0001-Fix-uninitialized-variable-in-dshash.c.patch
Description: Binary data
--
Sent via pgsql
ur command.
As far as I know these are misleading, it's really just an immediate
shutdown. There is no core file, so I don't believe anything actually
crashed.
Here's a version that's the same except it doesn't have
--enable-coverage. It passes:
https://travis-
On Fri, Sep 1, 2017 at 5:11 PM, Thomas Munro
wrote:
> On Wed, Jun 28, 2017 at 11:21 AM, Thomas Munro
> wrote:
>> [ssi-parallel-v5.patch]
>
> Rebased.
Rebased again.
--
Thomas Munro
http://www.enterprisedb.com
ssi-parallel-v7.patch
Description: Binary data
--
Sent via pgs
own at the bottom of the build log in the regression diffs file you can see:
! ERROR: cache lookup failed for relation 32893
https://travis-ci.org/postgresql-cfbot/postgresql/builds/277165907
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-h
ds/277376953 .
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Mon, Sep 18, 2017 at 10:18 PM, Andres Freund wrote:
> On 2017-09-18 21:57:04 +1200, Thomas Munro wrote:
>> WARNING: terminating connection because of crash of another server
>> process
>> DETAIL: The postmaster has commanded this server process to rol
area = dsa_attach(...);
MemoryContextSwitchTo(old_context);
You'll need to #include "utils/memutils.h".
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
to manage
multi-allocation operations if that turned out to be necessary.
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
n of reliable scoped cleanup
waiting to be discovered (as I think Craig was also getting at).
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ooner. Instead of r2[X=0], the executor sees
r2[X=0,Y=0] (we scanned the whole table, as if we read all objects, in
this case X and Y, even though we only asked to read X). Then the SSI
algorithm is able to detect a "dangerous structure" at w2[Y=10],
instead of later at commit
x27;t see its output,
maybe due to -Otarget, before the whole job is nuked by Travis for not
making progress).
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
exercises the
non-NULL code path because slapd rejects TLS by default with a
diagnostic message. I'm not sure if this is worth adding, since it
doesn't actually verify that the code path is reached (though you can
see that it is from the logs).
--
Thomas Munro
http://www.enterprisedb.c
On Thu, Aug 17, 2017 at 11:39 AM, Thomas Munro
wrote:
> On Thu, Jun 29, 2017 at 12:24 PM, Thomas Munro
> wrote:
>> fallocate-v5.patch
>
> Added to commitfest so we don't lose track of this.
Rebased due to collision with recent configure.in adjustments. I also
wro
t; topic is very deliberate and high level, which suggests that ours
> should be, too.
Very interesting and certainly relevant (the parts I've read so far),
though we don't have multiple consumers. Multiplexing one thread so
that it is both a consumer and a producer is an ext
ay
your test case behaves the same as non-parallel mode.
> I will continue my review on the latest patch and share any updates.
Thanks!
--
Thomas Munro
http://www.enterprisedb.com
ssi-parallel-v8.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgs
501 - 600 of 896 matches
Mail list logo
