On Fri, Sep 15, 2017 at 2:12 AM, Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > I think the ldap_unbind() changes should be in a separate preliminary > patch to be committed separately and backpatched.
OK, here it is split into two patches. > The other bits looks fine, with nitpicks > > 1. please move the new support function to the bottom of the section > dedicated to LDAP, and include a prototype OK. > 2. please wrap lines longer than 80 chars, other than error message > strings. (I don't know why this file plays fast & loose with > project-wide line length rules, but I also see no reason to continue > doing it.) Done for all lines I touched in the patch. Thanks for the review! -- Thomas Munro http://www.enterprisedb.com
0001-Improve-LDAP-cleanup-code-in-error-paths.patch
Description: Binary data
0002-Log-diagnostic-messages-if-errors-occur-during-LDAP-.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
