On Tue, Sep 12, 2017 at 11:23 PM, Ashutosh Bapat <ashutosh.ba...@enterprisedb.com> wrote: > On Wed, Aug 16, 2017 at 11:13 AM, Ashutosh Bapat > <ashutosh.ba...@enterprisedb.com> wrote: >> On Wed, Aug 16, 2017 at 8:44 AM, Alvaro Herrera >> <alvhe...@2ndquadrant.com> wrote: >>> Christoph Berg wrote: >>>> "Diagnostic message" doesn't really mean anything, and printing >>>> "DETAIL: Diagnostic message: <something>" seems redundant to me. Maybe >>>> drop that prefix? It should be clear from the context that this is a >>>> message from the LDAP layer. >>> >>> I think making it visible that the message comes from LDAP (rather than >>> Postgres or anything else) is valuable. How about this? >>> >>> LOG: could not start LDAP TLS session: Protocol error >>> DETAIL: LDAP diagnostics: unsupported extended operation. >>> >> +1, pretty neat.
Here is a new version adopting Alvaro's wording. I'll set this back to "Needs review" status. -- Thomas Munro http://www.enterprisedb.com
ldap-diagnostic-message-v4.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
