On Wed, Sep 13, 2017 at 3:48 AM, Elvis Pranskevichus <elpr...@gmail.com> wrote: > I incorporated those bits into your patch and rebased in onto master. > Please see attached. > > FWIW, I think that mixing the standby status and the default > transaction writability is suboptimal. They are related, yes, but not > the same thing. It is possible to have a master cluster in the > read-only mode, and with this patch it would be impossible to > distinguish from a hot-standby replica without also polling > pg_is_in_recovery(), which defeats the purpose of having to do no > database roundtrips.
Hi Elvis, FYI the recovery test 001_stream_rep.pl fails with this patch applied. You can see that if you configure with --enable-tap-tests, build and then cd into src/test/recovery and "make check". -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers