[HACKERS] Commitfest 201709 is now closed

We have now entered October, which marks the end of Commitfest 201709. All patches have now been dealt with and the commitfest is closed. Before starting on moving, and closing, patches the stat for this commitfest were: Needs review: 69. Waiting on Author: 22. Ready for

Re: [HACKERS] Fix number skipping in to_number

> On 25 Sep 2017, at 02:52, Nathan Wagner wrote: > > On Thu, Aug 17, 2017 at 12:33:02PM +0100, Oliver Ford wrote: > >> Ok I've made that change in the attached v3. I'm not sure as I'm on >> en_US.UTF-8 locale too. Maybe something Windows specific? > > This patch applies against master (8485a25a

Re: [HACKERS] generated columns

> On 12 Sep 2017, at 21:35, Jaime Casanova > wrote: > > On 10 September 2017 at 00:08, Jaime Casanova > wrote: >> >> During my own tests, though, i found some problems: > > a few more tests: > > create table t1 ( > id serial, > height_cm int, > height_in int generated always as (height_cm *

Re: [HACKERS] Support to COMMENT ON DATABASE CURRENT_DATABASE

> On 15 Sep 2017, at 16:36, Bossart, Nathan wrote: > > A few general comments. > > While this patch applies, I am still seeing some whitespace errors: > > comment_on_current_database_no_pgdump_v4.1.patch:488: trailing whitespace. > ColId > comment_on_current_database_no_

Re: [HACKERS] GSoC 2017: weekly progress reports (week 8)

> On 29 Sep 2017, at 00:59, Alexander Korotkov > wrote: > > On Thu, Sep 28, 2017 at 2:22 PM, Alexander Korotkov > mailto:a.korot...@postgrespro.ru>> wrote: > On Fri, Jul 28, 2017 at 7:58 AM, Shubham Barai > wrote: > I am attaching a patch for predicate locking

Re: [HACKERS] Transactions involving multiple postgres foreign servers

> On 02 Oct 2017, at 08:31, Masahiko Sawada wrote: > > On Sat, Sep 30, 2017 at 12:42 AM, Robert Haas wrote: >> On Wed, Sep 27, 2017 at 11:15 PM, Masahiko Sawada >> wrote: >>> I think that making a resolver process have connection caches to each >>> foreign server for a while can reduce the ove

Re: [HACKERS] Hooks to track changed pages for backup purposes

> On 13 Sep 2017, at 15:01, Tomas Vondra wrote: > > On 09/13/2017 07:53 AM, Andrey Borodin wrote: >>> * I see there are conditions like this: >>> >>>if(xlogreader->blocks[nblock].forknum == MAIN_FORKNUM) >>> >>> Why is it enough to restrict the block-tracking code to main fork? >>> Aren't w

Re: [HACKERS] Making clausesel.c Smarter

> On 07 Sep 2017, at 09:30, Daniel Gustafsson wrote: > >> On 06 Sep 2017, at 07:13, David Rowley wrote: >> >> On 6 September 2017 at 00:43, Daniel Gustafsson wrote: >>> This patch was moved to the currently open Commitfest. Given the above >>> comme

Re: [HACKERS] [PATCH] Assert that the correct locks are held when calling PageGetLSN()

> On 20 Sep 2017, at 00:29, Jacob Champion wrote: > > On Wed, Sep 6, 2017 at 8:37 AM, Jacob Champion wrote: >> On Tue, Sep 5, 2017 at 10:49 PM, Michael Paquier >> wrote: >>> In short, it seems to me that this patch should be rejected in its >>> current shape. >> >> Is the half of the patch tha

Re: [HACKERS] Patch: Write Amplification Reduction Method (WARM)

> On 28 Jul 2017, at 16:46, Robert Haas wrote: > > On Fri, Jul 28, 2017 at 12:39 AM, Pavan Deolasee > wrote: >> I see your point. But I would like to think this way: does the technology >> significantly help many common use cases, that are currently not addressed >> by HOT? It probably won't hel

Re: [HACKERS] PATCH: Batch/pipelining support for libpq

> On 13 Sep 2017, at 07:44, Vaishnavi Prabakaran > wrote: > > On Wed, Sep 13, 2017 at 3:33 PM, Craig Ringer > wrote: > > I really do not like calling it "commit" as that conflates with a database > commit. > > A batch can embed multiple BEGINs and COMMITs. It's

Re: [HACKERS] Parallel COPY FROM execution

> On 11 Aug 2017, at 20:07, Robert Haas wrote: > > On Fri, Aug 11, 2017 at 9:55 AM, Alex K wrote: >> - I have used both Latch and ConditionalVariable for the same >> purpose–wait until some signal >> occurs–and for me as an end user they perform quite similar. I >> looked into the condition_var

Re: [HACKERS] Explicit relation name in VACUUM VERBOSE log

> On 29 Aug 2017, at 17:21, Robert Haas wrote: > > On Tue, Aug 22, 2017 at 2:23 AM, Simon Riggs wrote: >> Yes, we can. I'm not sure why you would do this only for VACUUM >> though? I see many messages in various places that need same treatment > > I'm skeptical about the idea of doing this too

Re: [HACKERS] document and use SPI_result_code_string()

> On 06 Sep 2017, at 14:25, Tom Lane wrote: > > Michael Paquier writes: >> Fine for 0002. This reminds me of LockGXact and RemoveGXact in >> twophase.c, as well as _hash_squeezebucket that have some code paths >> that cannot return... Any thoughts about having some kind of >> PG_NOTREACHED defin

Re: [HACKERS] [PATCH v1] Add and report the new "in_hot_standby" GUC pseudo-variable.

> On 22 Sep 2017, at 18:57, Melanie Plageman wrote: > > On Tue, Sep 19, 2017 at 4:15 PM, Melanie Plageman > wrote: > The latest patch applies cleanly and builds (I am also seeing the failing TAP > tests), however, I have a concern. With a single server set up,

Re: [HACKERS] [WIP] Zipfian distribution in pgbench

> On 06 Sep 2017, at 08:42, Fabien COELHO wrote: > > Hello Alik, > > Applies, compiles, works for me. > > Some minor comments and suggestions. > > Two typos: > - "usinng" -> "using" > - "a rejection method used" -> "a rejection method is used" > > I'm not sure of "least_recently_used_i", this

Re: [HACKERS] Small patch for pg_basebackup argument parsing

> On 18 Sep 2017, at 23:18, Pierre Ducroquet wrote: > > On Monday, September 18, 2017 5:13:38 PM CEST Tom Lane wrote: >> Ryan Murphy writes: >>> Looked thru the diffs and it looks fine to me. >>> Changing a lot of a integer/long arguments that were being read directly >>> via atoi / atol to be r

Re: [HACKERS] Optional message to user when terminating/cancelling backend

> On 28 Sep 2017, at 14:55, Yugo Nagata wrote: > > On Sun, 3 Sep 2017 22:47:10 +0200 > Daniel Gustafsson wrote: > > I have reviewed your latest patch. > > I can apply this to the master branch and build this successfully, > and the behavior is as expected.

Re: [HACKERS] CLUSTER command progress monitor

> On 12 Sep 2017, at 14:57, Tatsuro Yamada wrote: > > On 2017/09/12 21:20, Tatsuro Yamada wrote: >> On 2017/09/11 23:38, Robert Haas wrote: >>> On Sun, Sep 10, 2017 at 10:36 PM, Tatsuro Yamada >>> wrote: Thanks for the comment. As you know, CLUSTER command uses SEQ SCAN or INDEX

Re: [HACKERS] Push down more UPDATEs/DELETEs in postgres_fdw

> On 08 Apr 2017, at 16:14, David Steele wrote: > > On 3/22/17 6:20 AM, Etsuro Fujita wrote: >> On 2017/02/22 19:57, Rushabh Lathia wrote: >>> Marked this as Ready for Committer. >> >> I noticed that this item in the CF app was incorrectly marked as >> Committed. This patch isn't committed, so

Re: [HACKERS] postgres_fdw: support parameterized foreign joins

> On 11 Apr 2017, at 10:55, Etsuro Fujita wrote: > > On 2017/04/07 22:54, Arthur Zakirov wrote: >> Marked the patch as "Ready for Commiter". But the patch should be >> commited only after the patch [1]. > > Thanks for reviewing! I'll continue to work on this for PG11. This patch has been marke

Re: [HACKERS] issue: record or row variable cannot be part of multiple-item INTO list

> On 20 Sep 2017, at 01:05, David G. Johnston > wrote: > > On Tue, Sep 19, 2017 at 11:29 AM, Tom Lane > wrote: > ​T​hat​ ​doesn't work today, and this patch doesn't fix it, but it does create > enough confusion that we never would be able to fix it. > > I'd be much h

Re: [HACKERS] parallelize queries containing initplans

> On 15 Sep 2017, at 04:45, Amit Kapila wrote: > > On Thu, Aug 31, 2017 at 11:23 AM, Amit Kapila wrote: >> On Mon, Aug 21, 2017 at 2:40 PM, Amit Kapila wrote: >>> On Mon, Aug 21, 2017 at 1:44 PM, Haribabu Kommi >>> wrote: Thanks for adding more details. It is easy to understan

Re: [HACKERS] Vacuum: allow usage of more than 1GB of work mem

> On 18 Aug 2017, at 13:39, Claudio Freire wrote: > > On Fri, Apr 7, 2017 at 10:51 PM, Claudio Freire > wrote: >> Indeed they do, and that's what motivated this patch. But I'd need >> TB-sized tables to set up something like that. I don't have the >> hardware or time available to do that (vacuu

Re: [HACKERS] Crash on promotion when recovery.conf is renamed

> On 02 Sep 2017, at 14:17, Michael Paquier wrote: > > On Fri, Sep 1, 2017 at 7:17 PM, Thomas Munro > wrote: >> On Sat, Aug 26, 2017 at 7:32 AM, Robert Haas wrote: >>> On Sat, Apr 8, 2017 at 10:05 AM, David Steele wrote: On 3/28/17 1:21 AM, Tsunakawa, Takayuki wrote: > Thanks, marked

Re: [HACKERS] Statement-level rollback

> On 15 Sep 2017, at 16:19, Daniel Gustafsson wrote: > >> On 01 Sep 2017, at 13:44, Simon Riggs wrote: >> >> On 14 August 2017 at 23:58, Peter Eisentraut >> wrote: >>> On 2/28/17 02:39, Tsunakawa, Takayuki wrote: >>>> The code for sto

Re: [HACKERS] ANALYZE command progress checker

> On 05 Apr 2017, at 03:17, Masahiko Sawada wrote: > > On Wed, Apr 5, 2017 at 1:49 AM, Robert Haas wrote: >> On Tue, Apr 4, 2017 at 4:57 AM, Amit Langote >> wrote: >>> Hmm, you're right. It could be counted with a separate variable >>> initialized to 0 and incremented every time we decide to a

Re: [HACKERS] pgbench: faster version of tpcb-like transaction

> On 27 Aug 2017, at 08:37, Fabien COELHO wrote: > > > About the patch: > > I'm generally in favor of providing more options to pgbench, especially if it > can give optimization ideas to the performance conscious user. > > I think that the name should be "tpcb-like-plfunc": the script does no

Re: [HACKERS] PATCH: psql show index with type info

> On 13 Sep 2017, at 01:24, Daniel Gustafsson wrote: > >> On 18 Apr 2017, at 05:13, Amos Bird wrote: >> >> Ah, thanks for the suggestions. I'll revise this patch soon :) > > Have you had a chance to revise the patch to address the review comments such >

Re: [HACKERS] [PATCH] Off-by-one error in logical slot resource retention

> On 15 Sep 2017, at 13:26, Daniel Gustafsson wrote: > >> On 01 Sep 2017, at 14:28, Aleksander Alekseev >> wrote: >> >> The following review has been posted through the commitfest application: >> make installcheck-world: not tested >> Implements f

Re: bgw_type (was Re: [HACKERS] Why does logical replication launcher set application_name?)

> On 31 Aug 2017, at 21:49, Peter Eisentraut > wrote: > > On 5/30/17 23:10, Peter Eisentraut wrote: >> Here is a proposed solution that splits bgw_name into bgw_type and >> bgw_name_extra. bgw_type shows up in pg_stat_activity.backend_type. >> Uses of application_name are removed, because they

Re: [HACKERS] Repetitive code in RI triggers

> On 26 Sep 2017, at 10:51, Maksim Milyutin wrote: > > On 19.09.2017 11:09, Daniel Gustafsson wrote: > >> Removing reviewer Maksim Milyutin from patch entry due to inactivity and >> community account email bouncing. Maksim: if you are indeed reviewing this >>

[HACKERS] Commitfest 201709 update

all for your contributions to PostgreSQL! Sincerely Daniel Gustafsson CFM201709 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] PoC: full merge join on comparison clause

> On 19 Sep 2017, at 15:18, Ashutosh Bapat > wrote: > > On Fri, Aug 25, 2017 at 10:11 PM, Alexander Kuzmenkov > wrote: >> Here is a new version of the patch, rebased to 749c7c41 and with some >> cosmetic changes. >> > > I looked at this patch briefly. This is a useful feature. This isn't a >

Re: [HACKERS] Repetitive code in RI triggers

> On 11 Apr 2017, at 03:41, Peter Eisentraut > wrote: > > On 4/10/17 11:55, Ildar Musin wrote: >> I was looking through the RI triggers code recently and noticed a few >> almost identical functions, e.g. ri_restrict_upd() and >> ri_restrict_del(). The following patch is an attempt to reduce so

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

> On 18 Sep 2017, at 15:31, Jan Michálek wrote: > > I have`t any new version recently, because i was waiting for new version. But > I will have some time on this in next months. How many time I have to next > freeze? The next commitfest runs from 2017-11-01 to 2017-11-30, I will move your patc

Re: [HACKERS] Should we cacheline align PGXACT?

> On 16 Sep 2017, at 01:51, Alexander Korotkov > wrote: > > On Tue, Sep 5, 2017 at 2:47 PM, Daniel Gustafsson <mailto:dan...@yesql.se>> wrote: > > On 04 Apr 2017, at 14:58, David Steele > <mailto:da...@pgmasters.net>> wrote: > > > > On 4/

Re: [HACKERS] postgres_fdw: evaluate placeholdervars on remote server

> On 15 Sep 2017, at 17:19, Robert Haas wrote: > > On Fri, Sep 15, 2017 at 10:15 AM, Daniel Gustafsson wrote: >> Have you had a chance to look at this such that we can expect a rebased >> version >> of this patch during the commitfest? > > Frankly, I th

Re: [HACKERS] Renaming PG_GETARG functions (was Re: PG_GETARG_GISTENTRY?)

> On 12 Sep 2017, at 22:07, Tom Lane wrote: > > [ changing subject line to possibly draw more attention ] > > Mark Dilger writes: >>> On Apr 5, 2017, at 9:23 AM, Tom Lane wrote: >>> In short, if you are supposed to write >>> FOO *val = PG_GETARG_FOO(n); >>> then the macro designer blew it

Re: [HACKERS] Statement-level rollback

> On 01 Sep 2017, at 13:44, Simon Riggs wrote: > > On 14 August 2017 at 23:58, Peter Eisentraut > wrote: >> On 2/28/17 02:39, Tsunakawa, Takayuki wrote: >>> The code for stored functions is not written yet, but I'd like your >>> feedback for the specification and design based on the current pat

Re: [HACKERS] postgres_fdw: evaluate placeholdervars on remote server

> On 15 Aug 2017, at 01:00, Peter Eisentraut > wrote: > > On 4/3/17 22:00, Etsuro Fujita wrote: >> On 2017/04/04 3:21, Andres Freund wrote: >>> On 2017-02-28 21:45:22 +0900, Etsuro Fujita wrote: Here is a patch for $subject. >>> >>> This is a nontrivial patch, submitted just before the sta

Re: [HACKERS] SQL/JSON in PostgreSQL

> On 15 Aug 2017, at 04:30, Peter Eisentraut > wrote: > > On 3/15/17 11:56, David Steele wrote: >>> This patch has been moved to CF 2017-07. >> >> I did not manage to move this patch when I said had. It is now moved. > > Unsurprisingly, this patch needs a major rebase. Can we expect a rebase

Re: [HACKERS] Allow INSTEAD OF DELETE triggers to modify the tuple for RETURNING

> On 05 Sep 2017, at 10:44, Haribabu Kommi wrote: > > On Mon, Aug 14, 2017 at 6:48 AM, Marko Tiikkaja > wrote: > On Fri, Jul 1, 2016 at 2:12 AM, I wrote: > Currently the tuple returned by INSTEAD OF triggers on DELETEs is only used > to determine whether to pretend that the

Re: [HACKERS] VACUUM and ANALYZE disagreeing on what reltuples means

> On 06 Sep 2017, at 09:45, Haribabu Kommi wrote: > > On Tue, Jul 25, 2017 at 9:33 PM, Tomas Vondra > wrote: > On 7/25/17 12:55 AM, Tom Lane wrote: > Tomas Vondra > writes: > It seems to me that VACUUM and ANALYZE somewha

Re: [HACKERS] [PATCH] Off-by-one error in logical slot resource retention

> On 01 Sep 2017, at 14:28, Aleksander Alekseev > wrote: > > The following review has been posted through the commitfest application: > make installcheck-world: not tested > Implements feature: not tested > Spec compliant: not tested > Documentation:not tested > > H

Re: [HACKERS] Patch: add --if-exists to pg_recvlogical

> On 09 Sep 2017, at 06:05, Thomas Munro wrote: > > On Sat, Sep 2, 2017 at 5:22 AM, Peter Eisentraut > wrote: >> >> + --if-exists >> + >> + >> +Do not error out when --drop-slot or >> --start are >> +specified and a slot with the specified name does not ex

Re: [HACKERS] Bug with pg_basebackup and 'shared' tablespace

> On 15 May 2017, at 07:26, Michael Paquier wrote: > > On Tue, May 2, 2017 at 2:28 AM, Pierre Ducroquet wrote: > >> I will submit this patch in the current commit fest. > > I have not spotted any flaws in the refactored logic. This patch no longer applies, could you take a look at it and subm

Re: [HACKERS] Patches that don't apply or don't compile: 2017-09-12

> On 13 Sep 2017, at 11:49, Aleksander Alekseev > wrote: > > Hi Tomas, > > I appreciate your feedback, although it doesn't seem to be completely > fair. I would like to stress one thing (and I am speaking only for myself here), this has been feedback and not criticism. Your (and everyone invo

Re: [HACKERS] Small patch for pg_basebackup argument parsing

> On 05 Jul 2017, at 08:32, Michael Paquier wrote: > > On Wed, Jul 5, 2017 at 2:57 PM, Ryan Murphy wrote: >> I tried to apply your patch to test it (though reading Robert's last comment >> it seems we wish to have it adjusted before committing)... but in any case I >> was not able to apply you

Re: [HACKERS] Replication status in logical replication

> On 30 May 2017, at 19:55, Peter Eisentraut > wrote: > > On 5/29/17 22:56, Noah Misch wrote: >> On Fri, May 19, 2017 at 11:33:48AM +0900, Masahiko Sawada wrote: >>> On Wed, Apr 12, 2017 at 5:31 AM, Simon Riggs wrote: Looks like a bug that we should fix in PG10, with backpatch to 9.4 (or >

Re: [HACKERS] Faster methods for getting SPI results

> On 12 Sep 2017, at 23:00, Tom Lane wrote: > > Chapman Flack writes: >> On 09/12/2017 03:41 PM, Tom Lane wrote: >>> So the conclusion at the end of the last commitfest was that this patch >>> should be marked Returned With Feedback, and no new work appears to have >>> been done on it since then

Re: [HACKERS] plpgsql - additional extra checks

> On 08 Apr 2017, at 15:46, David Steele wrote: > >> On 1/13/17 6:55 AM, Marko Tiikkaja wrote: >>> On Fri, Jan 13, 2017 at 2:46 AM, Jim Nasby >> > wrote: >>> >>>On 1/11/17 5:54 AM, Pavel Stehule wrote: >>> >>>+too_many_rows >>>+ >>>

Re: [HACKERS] PATCH: psql show index with type info

> On 18 Apr 2017, at 05:13, Amos Bird wrote: > > Ah, thanks for the suggestions. I'll revise this patch soon :) Have you had a chance to revise the patch to address the review comments such that the patch can move forward during this Commitfest? cheers ./daniel -- Sent via pgsql-hackers mail

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

> On 08 May 2017, at 12:02, Fabien COELHO > wrote: > > Hello Jan, > > Please give a number to submitted patches. I think that this was v3. > > The patch does NOT fix various issues I pointed out in my previous review: > > - tabs introduced in "doc/src/sgml/ref/psql-ref.sgml" > - too long help

Re: [HACKERS] [WIP] RE: DECLARE STATEMENT setting up a connection in ECPG

> On 30 Mar 2017, at 09:11, Ideriha, Takeshi > wrote: > > Thank you for prompt check! > > >As per above test steps, it doesn't produce the results and doesn't > >generate the error also. I feel this needs to be fixed. > > >As we are at the end of commitfest, it is better you can move it > >t

Re: [HACKERS] Patches that don't apply or don't compile: 2017-09-12

> On 12 Sep 2017, at 23:54, Tomas Vondra wrote: > > On 09/12/2017 04:14 PM, Aleksander Alekseev wrote: >> Hello, hackers! >> >> Thanks to the work of Thomas Munro now we have a CI for the patches on >> the commitfest [1]. Naturally there is still room for improvement, but >> in any case it's muc

Re: [HACKERS] PoC plpgsql - possibility to force custom or generic plan

> On 08 Sep 2017, at 19:14, Simon Riggs wrote: > > On 6 September 2017 at 07:43, Robert Haas wrote: > >> LET custom_plan_tries = 0 IN SELECT ... > > Tom has pointed me at this proposal, since on another thread I asked > for something very similar. (No need to reprise that discussion, but I > w

[HACKERS] Commitfest 201709 Progress

We are now a few days in on Commitfest 201709 and there has been lots of activity on the patches. 22% of the patches have been committed* with another 10% being marked Ready for Committer. Thank you all for the hard work! There is still a lot to do though, this fest has a recordbreaking 256 patc

Re: [HACKERS] Making clausesel.c Smarter

> On 06 Sep 2017, at 07:13, David Rowley wrote: > > On 6 September 2017 at 00:43, Daniel Gustafsson wrote: >> This patch was moved to the currently open Commitfest. Given the above >> comment, is the last patch in this thread still up for review, or are you >> work

Re: [HACKERS] Copyright in partition.h and partition.c

> On 06 Sep 2017, at 02:56, Amit Langote wrote: > > On 2017/09/05 21:14, Tom Lane wrote: >> Amit Langote writes: >>> On 2017/09/05 15:48, Etsuro Fujita wrote: Here is the copyright in partition.h: * Copyright (c) 2007-2017, PostgreSQL Global Development Group I think

Re: [HACKERS] A note about debugging TAP failures

> On 05 Sep 2017, at 18:37, Peter Eisentraut > wrote: > > On 4/25/17 11:00, Daniel Gustafsson wrote: >> Makes sense, assuming a “clean slate” to run on seems a reasonable assumption >> for the test and it makes for simpler code in PostgresNode. Updated the >>

Re: [HACKERS] Proposal for changes to recovery.conf API

> On 27 Mar 2017, at 10:27, Simon Riggs wrote: > > On 7 March 2017 at 23:31, Josh Berkus wrote: >> On 03/02/2017 07:13 AM, David Steele wrote: >>> Hi Simon, >>> >>> On 2/25/17 2:43 PM, Simon Riggs wrote: On 25 February 2017 at 13:58, Michael Paquier wrote: > - trigger_file

Re: [HACKERS] PoC plpgsql - possibility to force custom or generic plan

> On 08 Apr 2017, at 09:42, Pavel Stehule wrote: > > 2017-04-08 2:30 GMT+02:00 Peter Eisentraut >: > On 4/6/17 14:32, Pavel Stehule wrote: > > I like to see any proposals about syntax or implementation. > > > > Using PRAGMA is one variant - introduced by

Re: [HACKERS] Making clausesel.c Smarter

> On 09 Apr 2017, at 12:14, David Rowley wrote: > > On 8 April 2017 at 09:33, Claudio Freire wrote: >> Otherwise, the patch LGTM, but I'd like to solve the quadratic >> behavior too... are you going to try? Otherwise I could take a stab at >> it myself. It doesn't seem very difficult. > > I ha

Re: [HACKERS] Should we cacheline align PGXACT?

> On 04 Apr 2017, at 14:58, David Steele wrote: > > On 4/4/17 8:55 AM, Alexander Korotkov wrote: >> On Mon, Apr 3, 2017 at 9:58 PM, Andres Freund > >>I'm inclined to push this to the next CF, it seems we need a lot more >>benchmarking here. >> >> No objections. > > This submission has

Re: [HACKERS] [PROPOSAL] Use SnapshotAny in get_actual_variable_range

> On 18 Aug 2017, at 08:50, Andrey Borodin wrote: > > The following review has been posted through the commitfest application: > make installcheck-world: tested, failed > Implements feature: tested, failed > Spec compliant: tested, failed > Documentation:tested, faile

Re: [HACKERS] WAL logging problem in 9.4.3?

> On 13 Apr 2017, at 11:42, Kyotaro HORIGUCHI > wrote: > > At Thu, 13 Apr 2017 13:52:40 +0900, Michael Paquier > wrote in > >> On Tue, Apr 11, 2017 at 5:38 PM, Kyotaro HORIGUCHI >> wrote: >>> Sorry, what I have just sent was broken. >> >> You can use PROVE_TESTS when running make check to

Re: [HACKERS] Refactoring identifier checks to consistently use strcmp

> On 17 Aug 2017, at 11:08, Daniel Gustafsson wrote: > >> On 16 Aug 2017, at 17:51, Tom Lane wrote: >> >> Heikki Linnakangas writes: >>> This no longer works: >> >>> postgres=# CREATE TEXT SEARCH DICTIONARY public.simple_dict ( >&g

Re: [HACKERS] adding the commit to a patch's thread

> On 03 Sep 2017, at 21:12, Magnus Hagander wrote: > > On Sun, Sep 3, 2017 at 8:55 PM, Daniel Gustafsson <mailto:dan...@yesql.se>> wrote: > > That leaves us back at parsing/scraping -committers and adding the mailthread. > For this CF I can add the commits manuall

Re: [HACKERS] Optional message to user when terminating/cancelling backend

> On 02 Sep 2017, at 02:21, Thomas Munro wrote: > > On Fri, Jun 23, 2017 at 1:48 AM, Daniel Gustafsson wrote: >> Good point. I’ve attached a new version which issues a NOTICE on truncation >> and also addresses all other comments so far in this thread. Thanks a lot >

Re: [HACKERS] adding the commit to a patch's thread

> On 03 Sep 2017, at 19:33, Magnus Hagander wrote: > > On Sun, Sep 3, 2017 at 12:00 AM, Daniel Gustafsson <mailto:dan...@yesql.se>> wrote: > > On 01 Sep 2017, at 15:40, Robert Haas > <mailto:robertmh...@gmail.com>> wrote: > > > > On Fri, Sep 1,

Re: [HACKERS] adding the commit to a patch's thread

> On 01 Sep 2017, at 15:40, Robert Haas wrote: > > On Fri, Sep 1, 2017 at 4:26 AM, Alvaro Herrera > wrote: >> Erik Rijkers wrote: >>> Would it be possible to change the commitfest a bit and make it possible to >>> add the commit (or commit-message, or hash) to the thread in the >>> commitfest-a

Re: [HACKERS] GnuTLS support

> On 01 Sep 2017, at 20:00, Robert Haas wrote: > > On Fri, Sep 1, 2017 at 1:10 PM, Tom Lane wrote: >> Robert Haas writes: >>> On Thu, Aug 31, 2017 at 1:52 PM, Andreas Karlsson wrote: I have seen discussions from time to time about OpenSSL and its licensing issues so I decided to see

Re: [HACKERS] GnuTLS support

> On 01 Sep 2017, at 19:10, Tom Lane wrote: > > Robert Haas writes: >> On Thu, Aug 31, 2017 at 1:52 PM, Andreas Karlsson wrote: > >>> There are currently two failing SSL tests which at least to me seems more >>> like they test specific OpenSSL behaviors rather than something which need >>> to

Re: [HACKERS] Upcoming commit fest will begin soon

> On 01 Sep 2017, at 05:33, Michael Paquier wrote: > > Another question is: who would like to become the CF manager for this > time? This commit fest is very large, so it is going to be difficult > for one person to do the whole thing, hence at least 2 people would be > welcome. Please note that

Re: [HACKERS] Support for Secure Transport SSL library on macOS as OpenSSL alternative

> On 19 Aug 2017, at 23:13, Thomas Munro wrote: > > On Sun, Aug 20, 2017 at 8:10 AM, Thomas Munro > mailto:thomas.mu...@enterprisedb.com>> wrote: >> On Fri, Aug 18, 2017 at 2:14 AM, Daniel Gustafsson wrote: >>> Attached is an updated set of patches, rebased on t

Re: [HACKERS] Refactoring identifier checks to consistently use strcmp

> On 16 Aug 2017, at 17:51, Tom Lane wrote: > > Heikki Linnakangas writes: >> This no longer works: > >> postgres=# CREATE TEXT SEARCH DICTIONARY public.simple_dict ( >> TEMPLATE = pg_catalog.simple, >> "STOPWORds" = english >> ); >> ERROR: unrecognized simple dictionary parameter: "ST

Re: [HACKERS] Support for Secure Transport SSL library on macOS as OpenSSL alternative

> On 03 Aug 2017, at 19:27, Michael Paquier wrote: > > On Thu, Aug 3, 2017 at 12:02 PM, Daniel Gustafsson wrote: >> In https://postgr.es/m/69db7657-3f9d-4d30-8a4b-e06034251...@yesql.se I >> presented a WIP patch for adding support for the Apple Secure Transport SSL >&

Re: [HACKERS] Support for Secure Transport SSL library on macOS as OpenSSL alternative

> On 03 Aug 2017, at 13:06, Heikki Linnakangas wrote: > > On 08/03/2017 01:02 PM, Daniel Gustafsson wrote: >> >> The frontend has support for using PEM files for certificates and keys. It >> can >> also look up the key for the certificate in a Keychain, or bot

[HACKERS] Support for Secure Transport SSL library on macOS as OpenSSL alternative

In https://postgr.es/m/69db7657-3f9d-4d30-8a4b-e06034251...@yesql.se I presented a WIP patch for adding support for the Apple Secure Transport SSL library on macOS as, an alternative to OpenSSL. That patch got put on the backburner for a bit, but I’ve now found the time to make enough progress to

Re: [HACKERS] psql's \d and \dt are sending their complaints to different output files

> On 27 Jul 2017, at 19:40, Tom Lane wrote: > > Daniel Gustafsson writes: >>> On 19 Jun 2017, at 17:32, Tom Lane wrote: >>> So, if we're getting into enforcing consistency in describe.c, there's >>> lots to do. > >> Addressed in attached

Re: [HACKERS] pg_receivewal and messages printed in non-verbose mode

> On 14 Jun 2017, at 06:04, Michael Paquier wrote: > > On Tue, Jun 13, 2017 at 4:50 PM, Craig Ringer wrote: >> On 13 June 2017 at 14:33, Michael Paquier wrote: >>> Those come from stop_streaming in pg_receivewal.c. Shouldn't those >>> messages only show up to the user if --verbose is used? It s

Re: [HACKERS] psql's \d and \dt are sending their complaints to different output files

> On 19 Jun 2017, at 17:32, Tom Lane wrote: > > So, if we're getting into enforcing consistency in describe.c, there's > lots to do. > > * listDbRoleSettings does this for a server too old to have the desired > feature: > > fprintf(pset.queryFout, > _("No per-databas

Re: [HACKERS] Optional message to user when terminating/cancelling backend

> On 22 Jun 2017, at 17:52, Dilip Kumar wrote: > > On Thu, Jun 22, 2017 at 7:18 PM, Daniel Gustafsson wrote: >> Good point. I’ve attached a new version which issues a NOTICE on truncation >> and also addresses all other comments so far in this thread. Thanks a lot >

Re: [HACKERS] Multiple TO version in ALTER EXTENSION UPDATE

> On 22 Jun 2017, at 17:02, Tom Lane wrote: > > Robert Haas writes: >> On Wed, Mar 29, 2017 at 11:13 AM, Daniel Gustafsson wrote: >>> While reading I noticed that we allow multiple TO in ALTER >>> EXTENSION >>> UPDATE, and defer throwing a

Re: [HACKERS] Optional message to user when terminating/cancelling backend

> On 22 Jun 2017, at 10:24, Yugo Nagata wrote: > > On Thu, 22 Jun 2017 09:24:54 +0900 > Michael Paquier wrote: > >> On Wed, Jun 21, 2017 at 11:42 PM, Daniel Gustafsson wrote: >>> The message is truncated in SetBackendCancelMessage() for safety, but >>>

Re: [HACKERS] Optional message to user when terminating/cancelling backend

> On 21 Jun 2017, at 16:30, Yugo Nagata wrote: > > On Wed, 21 Jun 2017 12:06:33 +0900 > Michael Paquier wrote: > >> On Tue, Jun 20, 2017 at 3:24 AM, Daniel Gustafsson wrote: >>> The message is stored in a new shmem area which is checked when the session >&

[HACKERS] Optional message to user when terminating/cancelling backend

When terminating, or cancelling, a backend it’s currently not possible to let the signalled session know *why* it was dropped. This has nagged me in the past and now it happened to come up again, so I took a stab at this. The attached patch implements the ability to pass an optional text message

[HACKERS] Typos in comments

Spotted one “paramter” typo and git grep found two more, patch attached with s/paramter/parameter/ for these. cheers ./daniel typo-paramter.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.pos

[HACKERS] Typo in comment in ecpg datetime.c

Spotted s/fiedls/fields/ in src/interfaces/ecpg/pgtypeslib/datetime.c per the attached patch. cheers ./daniel typo-ecpg_datetime.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [JDBC] [HACKERS] Channel binding support for SCRAM-SHA-256

> On 30 May 2017, at 16:50, Tom Lane wrote: > > Robert Haas writes: >> On Sat, May 27, 2017 at 5:59 PM, Álvaro Hernández Tortosa >> wrote: >>> - tls-unique, as you mentioned, uses two undocumented APIs. This raises a >>> small flag about the stability and future of those APIs. > >> It seems to

Re: [JDBC] [HACKERS] Channel binding support for SCRAM-SHA-256

> On 30 May 2017, at 18:25, Michael Paquier wrote: > > On macos though it is another story, I am not seeing anything: > https://developer.apple.com/reference/security/secure_transport#symbols The Secure Transport documentation unfortunately excel at being incomplete and hard to search in. That

Re: [HACKERS] Bug when dumping "empty" operator classes

> On 26 May 2017, at 17:08, Tom Lane wrote: > > Daniel Gustafsson writes: >> While hacking on pg_upgrade in downstream Greenplum I ran into an error which >> seems like an old, and obscure, bug in pg_dump (unrelated to pg_upgrade). >> pg_dump generates incorrect SQL

[HACKERS] Bug when dumping "empty" operator classes

While hacking on pg_upgrade in downstream Greenplum I ran into an error which seems like an old, and obscure, bug in pg_dump (unrelated to pg_upgrade). pg_dump generates incorrect SQL for an operator class which has no operators or procedures, and which has the same column and storage types. While

[HACKERS] Typo in json.c

Spotted while reading code, patch attached. cheers ./daniel typo-json.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] A note about debugging TAP failures

> On 24 Apr 2017, at 17:19, Craig Ringer wrote: > > On 24 April 2017 at 20:01, Daniel Gustafsson wrote: > >> I’m np Perl expert though so there might be better/cleaner ways to achieve >> this, in testing it seems to work though. rmtree() is supported at least >>

Re: [HACKERS] A note about debugging TAP failures

> On 23 Apr 2017, at 15:05, Craig Ringer wrote: > > On 23 Apr. 2017 10:32, "Michael Paquier" <mailto:michael.paqu...@gmail.com>> wrote: > On Sun, Apr 23, 2017 at 7:48 AM, Daniel Gustafsson <mailto:dan...@yesql.se>> wrote: > > Skipping the tem

Re: [HACKERS] A note about debugging TAP failures

> On 23 Apr 2017, at 00:06, Andres Freund wrote: > > On 2017-04-22 23:59:11 +0200, Daniel Gustafsson wrote: >> Since we have the name of the running testscript, can’t we just add that to >> the >> tempdir to make the name more descriptive? With the attach

Re: [HACKERS] A note about debugging TAP failures

> On 22 Apr 2017, at 23:25, Tom Lane wrote: > > Andres Freund writes: >> On 2017-04-22 16:22:59 -0400, Tom Lane wrote: >>> In the particular case I was interested in here, the test script thought >>> everything was successful :-(. I'm working on fixing that little problem, >>> but I do not beli

Re: [HACKERS] Old versions of Test::More

> On 21 Apr 2017, at 15:08, Andrew Dunstan > wrote: > > As we discovered yesterday via jacana, very old versions of Test::More > don't support the note() function. It therefore seems prudent to specify > a minimum version number for the module in those scripts that use the > function. According

  1   2   >