‐‐‐ Original Message ‐‐‐
On Monday, February 1, 2021 1:18 PM, Masahiko Sawada
wrote:
> On Thu, Nov 12, 2020 at 2:54 AM Soumyadeep Chakraborty
> soumyadeep2...@gmail.com wrote:
>
> > Hey Georgios,
> > On Tue, Nov 10, 2020 at 6:20 AM gkokola...@pm.me wrote:
> >
> > > ‐‐‐ Original
‐‐‐ Original Message ‐‐‐
On Friday, February 19, 2021 4:57 PM, wrote:
>
>
> ‐‐‐ Original Message ‐‐‐
> On Monday, February 1, 2021 1:18 PM, Masahiko Sawada sawada.m...@gmail.com
> wrote:
>
> > On Thu, Nov 12, 2020 at 2:54 AM Soumyadeep Chakraborty
> > soumyadeep2...@gmail.c
‐‐‐ Original Message ‐‐‐
On Wednesday, February 24, 2021 3:34 PM, wrote:
>
>
> ‐‐‐ Original Message ‐‐‐
> On Friday, February 19, 2021 4:57 PM, gkokola...@pm.me wrote:
>
> > ‐‐‐ Original Message ‐‐‐
> > On Monday, February 1, 2021 1:18 PM, Masahiko Sawada sawada.m...@
Hi,
‐‐‐ Original Message ‐‐‐
On Monday, November 23, 2020 11:31 PM, Stephen Frost wrote:
> Greetings,
>
> - Anastasia Lubennikova (a.lubennik...@postgrespro.ru) wrote:
>
> > On 29.10.2020 17:19, Stephen Frost wrote:
> >
> > > - Georgios Kokolatos (gkokola...@protonmail.com) wrote:
‐‐‐ Original Message ‐‐‐
On Thursday, March 11, 2021 9:42 AM, Amit Langote
wrote:
> Hi Georgios,
>
> On Wed, Mar 10, 2021 at 9:30 PM Georgios gkokola...@protonmail.com wrote:
>
> > I continued looking a bit at the patch, yet I am either failing to see fix
> > or I am
> > looking a
‐‐‐ Original Message ‐‐‐
On Friday, March 12, 2021 3:45 AM, Amit Langote wrote:
> On Thu, Mar 11, 2021 at 8:36 PM gkokola...@pm.me wrote:
>
> > On Thursday, March 11, 2021 9:42 AM, Amit Langote amitlangot...@gmail.com
> > wrote:
> >
> > > On Wed, Mar 10, 2021 at 9:30 PM Georgios gko
‐‐‐ Original Message ‐‐‐
On Monday, March 15, 2021 7:10 AM, Michael Paquier wrote:
> On Wed, Feb 24, 2021 at 02:35:51PM +, gkokola...@pm.me wrote:
>
> > Now with attachment. Apologies for the chatter.
>
> The patch has no documentation for the two new functions, so it is a
> bit
‐‐‐ Original Message ‐‐‐
On Tuesday, March 16, 2021 6:13 AM, Amit Langote
wrote:
> Hi Georgios,
>
> On Fri, Mar 12, 2021 at 7:59 PM gkokola...@pm.me wrote:
>
> > On Friday, March 12, 2021 3:45 AM, Amit Langote amitlangot...@gmail.com
> > wrote:
> >
> > > On Thu, Mar 11, 2021 at 8:
‐‐‐ Original Message ‐‐‐
On Tuesday, March 16, 2021 9:59 AM, Amit Langote
wrote:
> Hi Georgios,
>
> On Tue, Mar 16, 2021 at 5:12 PM gkokola...@pm.me wrote:
>
> > On Tuesday, March 16, 2021 6:13 AM, Amit Langote amitlangot...@gmail.com
> > wrote:
> >
> > > On Fri, Mar 12, 2021 at 7
‐‐‐ Original Message ‐‐‐
On Sunday, October 25, 2020 8:01 PM, Anastasia Lubennikova
wrote:
> On 20.10.2020 10:30, gkokola...@pm.me wrote:
>
> > ‐‐‐ Original Message ‐‐‐
> >
> > > [snip]
> > > Wow, that was well in advance) I am willing to assist if you need any
> > > help.
‐‐‐ Original Message ‐‐‐
On Monday, November 9, 2020 7:50 PM, Soumyadeep Chakraborty
wrote:
> Hey Georgios,
>
> Thanks for looking for more avenues to invoke tableAM APIS! Please find
> my review below:
A great review Soumyadeep, it is much appreciated.
Please remember to add your
Hi,
‐‐‐ Original Message ‐‐‐
On Saturday, December 18th, 2021 at 12:29 PM, Michael Paquier
wrote:
>Hi all,
>(Added Georgios in CC.)
thank you for the shout out.
>When working on the support of LZ4 for pg_receivewal, walmethods.c has
>gained an extra parameter for the compression metho
On Wednesday, January 5th, 2022 at 9:00 AM, Michael Paquier
wrote:
> On Mon, Jan 03, 2022 at 03:35:57PM +, gkokola...@pm.me wrote:
> > I propose to initialize streamer to NULL when declared at the top of
> > CreateBackupStreamer().
>
> Yes, that may be noisy. Done this way.
Great.
> > You
‐‐‐ Original Message ‐‐‐
On Thursday, March 18, 2021 8:13 AM, Julien Rouhaud wrote:
> On Thu, Mar 18, 2021 at 03:58:46PM +0900, Michael Paquier wrote:
>
> > Well, as $subject tells, I just found confusing that \h does not
> > complete the so-said command, the only one using IMPORT a
‐‐‐ Original Message ‐‐‐
On Wednesday, March 17, 2021 6:35 AM, Michael Paquier
wrote:
> On Mon, Mar 15, 2021 at 03:10:59PM +0900, Michael Paquier wrote:
>
> > Anyway, as mentioned by other people upthread, I am not really
> > convinced either that we should have more flavors of siz
Hi all,
Admittedly quite ahead of time, I would like to volunteer as Commitfest manager
for 2020-11.
If the role is not filled and there are no objections, I can reach out again in
October for confirmation.
//Georgios
Hi all,
this minor patch is attempting to force the use of the tableam api in dbsize
where ever it is required.
Apparently something similar was introduced for toast relations only.
Intuitively it seems that the distinction between a table and a toast table is
not needed. This patch treats tab
‐‐‐ Original Message ‐‐‐
On Friday, 28 August 2020 03:22, Ranier Vilela wrote:
> Hi,
>
> Per Coverity.
>
> When "Prepare for toasting", it is necessary to turn off the flag
> TOAST_NEEDS_DELETE_OLD,
> if there is no need to delete external values from the old tuple, otherwise,
> th
‐‐‐ Original Message ‐‐‐
On Friday, 28 August 2020 15:43, Stephen Frost wrote:
> Greetings,
>
> - Georgios Kokolatos (gkokola...@protonmail.com) wrote:
>
> > The patch seems to be implementing a useful and requested feature.
> > The patch applies cleanly and passes the basic regre
‐‐‐ Original Message ‐‐‐
On Monday, 31 August 2020 08:00, Justin Pryzby wrote:
> The stats target can be set since commit d06215d03, but wasn't shown by psql.
> ALTER STATISISTICS .. SET STATISTICS n.
>
> Normal (1-D) stats targets are shown in \d+ table.
> Stats objects are shown i
‐‐‐ Original Message ‐‐‐
On Monday, 31 August 2020 02:20, Stephen Frost wrote:
> Greetings,
>
> - Stephen Frost (sfr...@snowman.net) wrote:
>
> > - Magnus Hagander (mag...@hagander.net) wrote:
> >
> > > On Fri, Aug 28, 2020 at 2:38 PM Stephen Frost sfr...@snowman.net wrote:
> > >
‐‐‐ Original Message ‐‐‐
On Tuesday, 1 September 2020 09:18, Jeff Davis wrote:
> A custom table access method might want to add a new reloption to
> control something specific to that table access method. Unfortunately,
> if you add a new option of type RELOPT_KIND_HEAP, it will imm
‐‐‐ Original Message ‐‐‐
On Tuesday, 1 September 2020 20:21, Jeff Davis wrote:
>
> I'm fine removing the "validate" parameter completely for the sake of
> consistency.
FWIW, the more I think about this, I would agree with the removal.
However, isn't this mechanism used for other t
‐‐‐ Original Message ‐‐‐
On Thursday, 27 August 2020 14:24, Kyotaro Horiguchi
wrote:
> At Wed, 26 Aug 2020 08:18:49 -0400, Tom Lane t...@sss.pgh.pa.us wrote in
>
> > Kyotaro Horiguchi horikyota@gmail.com writes:
> >
> > > At Tue, 25 Aug 2020 19:03:50 -0400, Bruce Momjian br...@m
‐‐‐ Original Message ‐‐‐
On Tuesday, 8 September 2020 16:49, John Naylor
wrote:
> On Thu, Aug 27, 2020 at 9:39 AM gkokola...@pm.me wrote:
>
> > Hi all,
> > this minor patch is attempting to force the use of the tableam api in
> > dbsize where ever it is required.
> > Apparently so
‐‐‐ Original Message ‐‐‐
On Tuesday, 8 September 2020 22:26, David Zhang wrote:
>
>
> I found the function "table_relation_size" is only used by buffer
> manager for "RELKIND_RELATION", "RELKIND_TOASTVALUE" and
> "RELKIND_MATVIEW", i.e.
>
> case RELKIND_RELATION:
> c
‐‐‐ Original Message ‐‐‐
On Saturday, September 18th, 2021 at 8:18 AM, Michael Paquier
wrote:
> On Fri, Sep 17, 2021 at 08:12:42AM +, gkokola...@pm.me wrote:
>
> I have been digging into the issue I saw in the TAP tests when closing
> a segment, and found the problem. The way you
‐‐‐ Original Message ‐‐‐
On Monday, November 1st, 2021 at 9:09 AM, Michael Paquier
wrote:
> On Fri, Oct 29, 2021 at 08:38:33PM +0900, Michael Paquier wrote:
>
> It would be good to test with many segments, but could we think about
> just relying on LZ4F_decompress() with a frame and
‐‐‐ Original Message ‐‐‐
On Tuesday, November 2nd, 2021 at 9:51 AM, Michael Paquier
wrote:
> On Tue, Nov 02, 2021 at 07:27:50AM +0900, Michael Paquier wrote:
> > On Mon, Nov 01, 2021 at 08:39:59AM +, gkokola...@pm.me wrote:
> > > Agreed.
> > >
> > > I have already started on v8 of
‐‐‐ Original Message ‐‐‐
On Wednesday, November 3rd, 2021 at 12:23 AM, Michael Paquier
wrote:
> On Tue, Nov 02, 2021 at 12:31:47PM -0400, Robert Haas wrote:
>> On Tue, Nov 2, 2021 at 8:17 AM Magnus Hagander mag...@hagander.net wrote:
>>> I think for the end user, it is strictly bette
‐‐‐ Original Message ‐‐‐
On Wednesday, November 3rd, 2021 at 9:05 AM, wrote:
> ‐‐‐ Original Message ‐‐‐
>
> On Wednesday, November 3rd, 2021 at 12:23 AM, Michael Paquier
> mich...@paquier.xyz wrote:
> > On Tue, Nov 02, 2021 at 12:31:47PM -0400, Robert Haas wrote:
> > > On Tue,
‐‐‐ Original Message ‐‐‐
On Thursday, November 4th, 2021 at 9:21 AM, Michael Paquier
wrote:
> On Thu, Nov 04, 2021 at 04:31:48PM +0900, Michael Paquier wrote:
> Thanks. I have looked at 0001 today, and applied it after fixing a
> couple of issues.
Great! Thank you very much.
> Fro
‐‐‐ Original Message ‐‐‐
On Thursday, November 4th, 2021 at 9:21 AM, Michael Paquier
wrote:
> > +#ifdef HAVE_LIBLZ4
> > +while (readp < readend)
> > +{
> > +size_tread_size = 1;
> > +size_tout_size = 1;
> > +
> > +status = LZ4F_decompress
‐‐‐ Original Message ‐‐‐
On Friday, November 5th, 2021 at 3:47 AM, Michael Paquier
wrote:
>
> I have spent an extra couple of hours staring at the code, and the
> whole looked fine, so applied. While on it, I have tested the new TAP
> tests with all the possible combinations of --wit
‐‐‐ Original Message ‐‐‐
On Friday, November 19th, 2021 at 3:07 AM, Michael Paquier
wrote:
> On Thu, Nov 18, 2021 at 07:54:37PM +0530, Jeevan Ladhe wrote:
>
> > In dir_open_for_write() I observe that we are writing the header
> > and then calling LZ4F_compressEnd() in case there is an e
--- Original Message ---
On Friday, February 24th, 2023 at 5:35 AM, Michael Paquier
wrote:
>
>
> On Thu, Feb 23, 2023 at 07:51:16PM -0600, Justin Pryzby wrote:
>
> > On Thu, Feb 23, 2023 at 09:24:46PM +0100, Tomas Vondra wrote:
> >
> > > I've now pushed 0002 and 0003, after mi
--- Original Message ---
On Sunday, February 26th, 2023 at 3:59 PM, Tomas Vondra
wrote:
>
>
>
>
> On 2/25/23 06:02, Justin Pryzby wrote:
>
> > I have some fixes (attached) and questions while polishing the patch for
> > zstd compression. The fixes are small and could be integ
--- Original Message ---
On Saturday, February 25th, 2023 at 3:05 PM, Justin Pryzby
wrote:
>
>
> On Fri, Feb 24, 2023 at 11:02:14PM -0600, Justin Pryzby wrote:
>
> > I have some fixes (attached) and questions while polishing the patch for
> > zstd compression. The fixes are sma
--- Original Message ---
On Wednesday, March 1st, 2023 at 12:58 AM, Justin Pryzby
wrote:
> I found that e9960732a broke writing of empty gzip-compressed data,
> specifically LOs. pg_dump succeeds, but then the restore fails:
>
> postgres=# SELECT lo_create(1234);
> lo_create | 12
--- Original Message ---
On Wednesday, March 1st, 2023 at 5:20 PM, Tomas Vondra
wrote:
>
>
>
>
> On 2/25/23 15:05, Justin Pryzby wrote:
>
> > On Fri, Feb 24, 2023 at 11:02:14PM -0600, Justin Pryzby wrote:
> >
> > > I have some fixes (attached) and questions while polishing th
--- Original Message ---
On Saturday, March 11th, 2023 at 7:00 AM, Alexander Lakhin
wrote:
> Hello,
> 23.02.2023 23:24, Tomas Vondra wrote:
>
> > On 2/23/23 16:26, Tomas Vondra wrote:
> >
> > > Thanks for v30 with the updated commit messages. I've pushed 0001 after
> > > fixing a comme
--- Original Message ---
On Monday, March 13th, 2023 at 10:47 PM, Tomas Vondra
wrote:
>
> > Change pg_fatal() to an assertion+comment;
>
>
> Yeah, that's reasonable. I'd even ditch the assert/comment, TBH. We
> could add such protections against "impossible" stuff to a zillion ot
--- Original Message ---
On Monday, March 13th, 2023 at 9:21 PM, Tomas Vondra
wrote:
>
>
>
>
> On 3/11/23 11:50, gkokola...@pm.me wrote:
>
> > --- Original Message ---
> > On Saturday, March 11th, 2023 at 7:00 AM, Alexander Lakhin
> > exclus...@gmail.com wrote:
> >
> > >
--- Original Message ---
On Tuesday, March 14th, 2023 at 4:32 PM, Tomas Vondra
wrote:
>
>
>
>
> On 3/14/23 16:18, gkokola...@pm.me wrote:
>
> > ...> Would you mind me trying to come with a patch to address your points?
>
>
> That'd be great, thanks. Please keep it split into sm
--- Original Message ---
On Thursday, March 16th, 2023 at 10:20 PM, Tomas Vondra
wrote:
>
>
>
>
> On 3/16/23 18:04, gkokola...@pm.me wrote:
>
> > --- Original Message ---
> > On Tuesday, March 14th, 2023 at 4:32 PM, Tomas Vondra
> > tomas.von...@enterprisedb.com wrote
--- Original Message ---
On Thursday, March 23rd, 2023 at 6:10 PM, Tomas Vondra
wrote:
>
> So pushed all three parts, after updating the commit messages a bit.
Thank you very much.
>
> This leaves the empty-data issue (which we have a fix for) and the
> switch to LZ4F. And th
--- Original Message ---
On Monday, December 19th, 2022 at 6:27 PM, Justin Pryzby
wrote:
>
>
> On Mon, Dec 19, 2022 at 05:03:21PM +, gkokola...@pm.me wrote:
>
> > > > 001 still doesn't compile on freebsd, and 002 doesn't compile on
> > > > windows. Have you checked test res
Oh, I didn’t realize you took over Justin? Why? After almost a year of work?
This is rather disheartening.
On Mon, Jan 16, 2023 at 02:56, Justin Pryzby wrote:
> On Mon, Jan 16, 2023 at 10:28:50AM +0900, Michael Paquier wrote:
>> On Sat, Jan 14, 2023 at 03:43:09PM -0600, Justin Pryzby wrote:
>>
--- Original Message ---
On Thursday, March 16th, 2023 at 11:30 PM, Tomas Vondra
wrote:
>
>
>
>
> On 3/16/23 01:20, Justin Pryzby wrote:
>
> > On Mon, Mar 13, 2023 at 10:47:12PM +0100, Tomas Vondra wrote:
> >
> > >
> > > Thanks. I don't want to annoy you too much, but could
--- Original Message ---
On Friday, March 24th, 2023 at 10:30 AM, gkokola...@pm.me
wrote:
>
> --- Original Message ---
> On Thursday, March 23rd, 2023 at 6:10 PM, Tomas Vondra
> tomas.von...@enterprisedb.com wrote:
>
> > This leaves the empty-data issue (which we have a f
--- Original Message ---
On Wednesday, March 29th, 2023 at 12:02 AM, Tomas Vondra
wrote:
>
>
> On 3/28/23 18:07, gkokola...@pm.me wrote:
>
> > --- Original Message ---
> > On Friday, March 24th, 2023 at 10:30 AM, gkokola...@pm.me gkokola...@pm.me
> > wrote:
> >
> > > -
--- Original Message ---
On Tuesday, April 25th, 2023 at 8:02 AM, Michael Paquier
wrote:
>
>
> On Wed, Apr 12, 2023 at 07:53:53PM -0500, Justin Pryzby wrote:
>
> > I doubt it - in the !HAVE_LIBZ case, it's currently an "if" statement
> > with nothing but a comment, which isn't
--- Original Message ---
On Friday, May 5th, 2023 at 8:00 AM, Alexander Lakhin
wrote:
>
>
> 23.03.2023 20:10, Tomas Vondra wrote:
>
> > So pushed all three parts, after updating the commit messages a bit.
> >
> > This leaves the empty-data issue (which we have a fix for) and th
--- Original Message ---
On Friday, May 5th, 2023 at 3:23 PM, Andrew Dunstan wrote:
> On 2023-05-05 Fr 06:02, gkokola...@pm.me wrote:
>
>> --- Original Message ---
>> On Friday, May 5th, 2023 at 8:00 AM, Alexander Lakhin
>> [](mailto:exclus...@gmail.com)
>> wrote:
>>
>>> 23.03.202
On Sat, May 6, 2023 at 04:51, Michael Paquier <[mich...@paquier.xyz](mailto:On
Sat, May 6, 2023 at 04:51, Michael Paquier < wrote:
> On Fri, May 05, 2023 at 02:13:28PM +, gkokola...@pm.me wrote:
>> Good point. I thought about it before submitting the patch. I
>> concluded that given the compl
--- Original Message ---
On Monday, May 8th, 2023 at 3:16 AM, Tom Lane wrote:
>
>
> I wrote:
>
> > Michael Paquier mich...@paquier.xyz writes:
> >
> > > While testing this patch, I have triggered an error pointing out that
> > > the decompression path of LZ4 is broken for table
--- Original Message ---
On Monday, May 8th, 2023 at 8:20 PM, Tomas Vondra
wrote:
>
>
>
>
> On 5/8/23 18:19, gkokola...@pm.me wrote:
>
> > --- Original Message ---
> > On Monday, May 8th, 2023 at 3:16 AM, Tom Lane t...@sss.pgh.pa.us wrote:
> >
> > > I wrote:
> > >
>
--- Original Message ---
On Tuesday, May 9th, 2023 at 2:54 PM, Tomas Vondra
wrote:
>
>
> On 5/9/23 00:10, Michael Paquier wrote:
>
> > On Mon, May 08, 2023 at 08:00:39PM +0200, Tomas Vondra wrote:
> >
> > > The LZ4Stream_write() forgot to move the pointer to the next chunk, so
--- Original Message ---
On Saturday, March 26th, 2022 at 12:13 AM, Rachel Heaton
wrote:
> On Fri, Mar 25, 2022 at 6:22 AM Justin Pryzby pry...@telsasoft.com wrote:
>
> > On Fri, Mar 25, 2022 at 01:20:47AM -0400, Greg Stark wrote:
> >
> > > It seems development on this has stalled. I
On Thursday, March 31st, 2022 at 4:34 AM, Michael Paquier
wrote:
> On Wed, Mar 30, 2022 at 03:32:55PM +, gkokola...@pm.me wrote:
> > On Wednesday, March 30th, 2022 at 7:54 AM, Michael Paquier
> > mich...@paquier.xyz wrote:
>
> Okay. 0002 looks fine as-is, and I don't mind the extra fatal()
>
--- Original Message ---
On Tuesday, April 5th, 2022 at 3:34 AM, Michael Paquier
wrote:
> On Fri, Apr 01, 2022 at 03:06:40PM +, gkokola...@pm.me wrote:
> Splitting the program and its arguments makes sense.
Great.
> At the end I am finishing with the attached. I also saw an ove
--- Original Message ---
On Tuesday, April 5th, 2022 at 12:55 PM, Michael Paquier
wrote:
> On Tue, Apr 05, 2022 at 07:13:35AM +, gkokola...@pm.me wrote:
> No need to carry it forward anymore, I think ;)
Thank you for committing!
Cheers,
//Georgios
> --
> Michael
On Monday, April 11th, 2022 at 8:52 AM, Michael Paquier
wrote:
> This is something I think we had better fix before beta1, because now
> we have binaries that use an inconsistent set of options. So,
> attached is a patch set aimed at rework this option set from the
> ground, taking advantage of
--- Original Message ---
On Wednesday, April 13th, 2022 at 7:25 AM, Michael Paquier
wrote:
>
>
> On Tue, Apr 12, 2022 at 06:22:48PM +0900, Michael Paquier wrote:
>
> > On Mon, Apr 11, 2022 at 12:46:02PM +, gkokola...@pm.me wrote:
> >
> > > It looks good. If you choose to discard
Hi,
I noticed a minor memleak in pg_dump. ReadStr() returns a malloc'ed pointer
which
should then be freed. While reading the Table of Contents, it was called as an
argument
within a function call, leading to a memleak.
Please accept the attached as a proposed fix.
Cheers,
//GeorgiosFrom 9473
On Wed, Nov 2, 2022 at 14:28, Justin Pryzby wrote:
> Checking if you'll be able to submit new patches soon ?
Thank you for checking up. Expect new versions within this commitfest cycle.
--- Original Message ---
On Monday, November 21st, 2022 at 12:13 AM, Michael Paquier
wrote:
>
>
> On Sun, Nov 20, 2022 at 11:26:11AM -0600, Justin Pryzby wrote:
>
> > I think this patch record should be closed for now. You can re-open the
> > existing patch record once a patch
--- Original Message ---
On Thursday, December 1st, 2022 at 3:05 AM, Michael Paquier
wrote:
>
>
> On Wed, Nov 30, 2022 at 05:11:44PM +, gkokola...@pm.me wrote:
>
> > Fair enough. The atteched v11 does that. 0001 introduces compression
> > specification and is using it throug
--- Original Message ---
On Thursday, January 19th, 2023 at 4:45 PM, Tomas Vondra
wrote:
>
>
> On 1/18/23 20:05, gkokola...@pm.me wrote:
>
> > --- Original Message ---
> > On Wednesday, January 18th, 2023 at 3:00 PM, Tomas Vondra
> > tomas.von...@enterprisedb.com wrote:
--- Original Message ---
On Friday, January 20th, 2023 at 12:34 AM, Tomas Vondra
wrote:
>
>
> On 1/19/23 18:55, Tomas Vondra wrote:
>
> > Hi,
> >
> > On 1/19/23 17:42, gkokola...@pm.me wrote:
> >
> > > ...
> > >
> > > Agreed. It was initially submitted as one patch. Then it
--- Original Message ---
On Wednesday, January 25th, 2023 at 6:28 PM, Tomas Vondra
wrote:
>
>
>
> On 1/25/23 16:37, gkokola...@pm.me wrote:
>
> > --- Original Message ---
> > On Wednesday, January 25th, 2023 at 2:42 AM, Justin Pryzby
> > pry...@telsasoft.com wrote:
>
--- Original Message ---
On Wednesday, January 25th, 2023 at 7:00 PM, Justin Pryzby
wrote:
>
>
> On Wed, Jan 25, 2023 at 03:37:12PM +, gkokola...@pm.me wrote:
>
> While looking at this, I realized that commit 5e73a6048 introduced a
> regression:
>
> @@ -3740,19 +3762,24 @
--- Original Message ---
On Friday, January 27th, 2023 at 6:23 PM, Justin Pryzby
wrote:
>
>
> On Thu, Jan 26, 2023 at 12:22:45PM -0600, Justin Pryzby wrote:
>
> > That commit also added this to pg-dump.c:
> >
> > + case PG_COMPRESSION_ZSTD:
> > + pg_fatal("compression with %s
Hi,
The program pg_receivewal can use gzip compression to store the received WAL.
This patch teaches it to be able to use lz4 compression if the binary is build
using the -llz4 flag.
Previously, the user had to use the option --compress with a value between [0-9]
to denote that gzip compression w
‐‐‐ Original Message ‐‐‐
On Thursday, July 1st, 2021 at 12:28, Magnus Hagander
wrote:
> On Wed, Jun 30, 2021 at 8:34 AM Dilip Kumar dilipbal...@gmail.com wrote:
>
> > On Tue, Jun 29, 2021 at 8:15 PM gkokola...@pm.me wrote:
> >
> > > Hi,
> > >
> > > The program pg_receivewal can use g
‐‐‐ Original Message ‐‐‐
On Thursday, July 1st, 2021 at 15:58, Magnus Hagander
wrote:
> On Thu, Jul 1, 2021 at 3:39 PM gkokola...@pm.me wrote:
>
> > ‐‐‐ Original Message ‐‐‐
> >
> > On Thursday, July 1st, 2021 at 12:28, Magnus Hagander mag...@hagander.net
> > wrote:
> >
> >
‐‐‐ Original Message ‐‐‐
On Friday, July 2nd, 2021 at 03:10, Michael Paquier wrote:
> On Thu, Jul 01, 2021 at 02:10:17PM +, gkokola...@pm.me wrote:
>
> > Micheal suggested on the same thread to move my entry in the help output so
> > that
> >
> > the output remains ordered. I wou
Hi,
please find v2 of the patch which tries to address the commends received so far.
Thank you all for your comments.
Michael Paquier wrote:
> Documentation is missing from the patch.
>
It has now been added.
> + LZ4F_compressionContext_t ctx;
> + size_t outbufCapacity;
> + void
‐‐‐ Original Message ‐‐‐
On Friday, July 9th, 2021 at 04:49, Michael Paquier wrote:
> On Thu, Jul 08, 2021 at 02:18:40PM +, gkokola...@pm.me wrote:
>
> > please find v2 of the patch which tries to address the commends
> >
> > received so far.
>
> Thanks!
>
> > Michael Paquier wrot
‐‐‐ Original Message ‐‐‐
On Monday, July 12th, 2021 at 07:56, Michael Paquier
wrote:
> On Mon, Jul 12, 2021 at 11:10:24AM +0530, Dilip Kumar wrote:
>
> > On Thu, Jul 8, 2021 at 7:48 PM gkokola...@pm.me wrote:
> >
> > > We can, though I am not in favour of doing so. There is seemingly
‐‐‐ Original Message ‐‐‐
On Monday, July 12th, 2021 at 08:42, Michael Paquier
wrote:
> On Fri, Jul 09, 2021 at 11:26:58AM +, Georgios wrote:
>
> > As suggested on a different thread [1], pg_receivewal can increase it's test
> >
> > coverage. There exists a non trivial amount of c
‐‐‐ Original Message ‐‐‐
On Monday, July 12th, 2021 at 11:42, wrote:
> ‐‐‐ Original Message ‐‐‐
>
> On Monday, July 12th, 2021 at 08:42, Michael Paquier mich...@paquier.xyz
> wrote:
>
> > On Fri, Jul 09, 2021 at 11:26:58AM +, Georgios wrote:
> >
> > > As suggested on a di
‐‐‐ Original Message ‐‐‐
On Monday, July 12th, 2021 at 11:56, wrote:
> ‐‐‐ Original Message ‐‐‐
>
> On Monday, July 12th, 2021 at 11:42, gkokola...@pm.me wrote:
>
> > ‐‐‐ Original Message ‐‐‐
> >
> > On Monday, July 12th, 2021 at 08:42, Michael Paquier mich...@paquier.x
‐‐‐ Original Message ‐‐‐
On Monday, July 12th, 2021 at 13:00, Gilles Darold wrote:
> Le 12/07/2021 à 12:27, gkokola...@pm.me a écrit :
>
> > > > > Shouldn't this be coded as a loop going through @gzip_wals?
> > > > >
> > > > > I would hope that there is only one gz file created. There
‐‐‐ Original Message ‐‐‐
On Monday, July 12th, 2021 at 13:04, Michael Paquier
wrote:
> On Mon, Jul 12, 2021 at 09:42:32AM +, gkokola...@pm.me wrote:
>
> > This to my understanding means that gzip is expected to exist.
> >
> > If this is correct, then simply checking for the header
‐‐‐ Original Message ‐‐‐
On Monday, July 12th, 2021 at 17:07, wrote:
> ‐‐‐ Original Message ‐‐‐
>
> On Monday, July 12th, 2021 at 13:04, Michael Paquier mich...@paquier.xyz
> wrote:
>
> > On Mon, Jul 12, 2021 at 09:42:32AM +, gkokola...@pm.me wrote:
> >
> > > This to my un
--- Original Message ---
On Sunday, June 26th, 2022 at 5:55 PM, Justin Pryzby
wrote:
>
>
> Hi,
>
> Will you be able to send a rebased patch for the next CF ?
Thank you for taking an interest in the PR. The plan is indeed to sent
a new version.
> If you update for the review comm
‐‐‐ Original Message ‐‐‐
On Sunday, September 5th, 2021 at 21:47, Pavel Luzanov
wrote:
Hi,
> Hi,
>
> On 03.09.2021 15:25, Georgios Kokolatos wrote:
>
> > On a high level I will recommend the addition of tests. There are similar
> > tests
>
> Tests added.
Thanks! The tests look good. A
Hi,
‐‐‐ Original Message ‐‐‐
On Tuesday, August 24th, 2021 at 13:20, Ranier Vilela
wrote:
> Em ter., 24 de ago. de 2021 às 03:11, Masahiko Sawada
> escreveu:
>
> > On Mon, Aug 23, 2021 at 10:46 AM Masahiko Sawada
> > wrote:
> >
> > >
> > > On Thu, Aug 19, 2021 at 10:52 PM Ranier Vil
‐‐‐ Original Message ‐‐‐
On Friday, July 9th, 2021 at 04:49, Michael Paquier wrote:
Hi,
please find v3 of the patch attached, rebased to the current head.
> > Michael Paquier wrote:
> >
>
> * http://www.zlib.org/rfc-gzip.html.
>
> - - For lz4 compressed segments
> */
>
‐‐‐ Original Message ‐‐‐
On Saturday, September 11th, 2021 at 07:02, Jian Guo wrote:
Hi,
thank you for looking at the patch.
> - LZ4F_decompressionContext_t ctx = NULL;
> - snprintf(fullpath, sizeof(fullpath), "%s/%s", basedir,
> dirent->d_name);
> -
‐‐‐ Original Message ‐‐‐
On Wednesday, September 15th, 2021 at 08:46, Michael Paquier
mich...@paquier.xyz wrote:
Hi,
thank you for the review.
> On Fri, Sep 10, 2021 at 08:21:51AM +, gkokola...@pm.me wrote:
>
> > Agreed. A default value of 5, which is in the middle point of options
‐‐‐ Original Message ‐‐‐
On Friday, September 17th, 2021 at 09:39, Michael Paquier
wrote:
> On Thu, Sep 16, 2021 at 03:17:15PM +, gkokola...@pm.me wrote:
>
> > Hopefully fixed.
>
> Thanks for the new version. I have put my hands on the patch, and
> began reviewing its internals w
‐‐‐ Original Message ‐‐‐
On Tuesday, July 13th, 2021 at 03:53, Michael Paquier
wrote:
> On Mon, Jul 12, 2021 at 04:46:29PM +, gkokola...@pm.me wrote:
>
> > On Monday, July 12th, 2021 at 17:07, gkokola...@pm.me wrote:
> >
> > > ‐‐‐ Original Message ‐‐‐
>
> Are you using ou
‐‐‐ Original Message ‐‐‐
On Tuesday, July 13th, 2021 at 09:37, Michael Paquier
wrote:
> On Tue, Jul 13, 2021 at 06:36:59AM +, gkokola...@pm.me wrote:
>
> > I am sorry this was not so clear. It is indeed running twice the binary
> > with different flags. However the goal is not to
‐‐‐ Original Message ‐‐‐
On Tuesday, July 13th, 2021 at 10:14, Michael Paquier
wrote:
> On Tue, Jul 13, 2021 at 04:37:53PM +0900, Michael Paquier wrote:
>
> Poking at this problem, I partially take this statement back as this
> requires an initial run of pg_receivewal --endpos to ens
‐‐‐ Original Message ‐‐‐
On Tuesday, July 13th, 2021 at 12:26, Michael Paquier
wrote:
> On Tue, Jul 13, 2021 at 08:28:44AM +, gkokola...@pm.me wrote:
> > Sounds great. Let me cook up v6 for this.
>
> Thanks. Could you use v5 I posted upthread as a base? There were
> some improvem
‐‐‐ Original Message ‐‐‐
On Wednesday, July 14th, 2021 at 04:17, Michael Paquier
wrote:
> On Tue, Jul 13, 2021 at 11:16:06AM +, gkokola...@pm.me wrote:
> > Agreed. For the record that is why I said v6 :)
> Okay, thanks.
Please find v6 attached.
Cheers,
//Georgios
>
‐‐‐ Original Message ‐‐‐
On Thursday, July 15th, 2021 at 09:00, Michael Paquier
wrote:
> On Wed, Jul 14, 2021 at 02:11:09PM +, gkokola...@pm.me wrote:
>
> > Please find v6 attached.
>
> Thanks. I have spent some time checking this stuff in details, and
> I did some tests on Windo
‐‐‐ Original Message ‐‐‐
On Thursday, July 15th, 2021 at 14:35, Michael Paquier
wrote:
> On Thu, Jul 15, 2021 at 08:35:27PM +0900, Michael Paquier wrote:
>
> > 2. curculio:
> > Looking at the OpenBSD code (usr.bin/compress/main.c), long options
> > are supported, where --version do
1 - 100 of 102 matches
Mail list logo
