On Wed, Feb 5, 2025 at 9:31 PM Ryo Kanbayashi wrote:
>
> Hi hackers,
>
> When I wrote patch of ecpg command notice bug, I recognized needs of
> regression tests for ecpg command notices and I say that I write the
> tests.
>
> https://commitfest.postgresql.org/52/5497/
>
On Wed, Feb 5, 2025 at 9:31 PM Ryo Kanbayashi wrote:
>
> Hi hackers,
>
> When I wrote patch of ecpg command notice bug, I recognized needs of
> regression tests for ecpg command notices and I say that I write the
> tests.
>
> https://commitfest.postgresql.org/52/5497/
>
ts by pg_regress accompanied with
needless PG server process execution. but pg_regress doesn't execute
test without it and making pg_regress require modification which has
not small scope of influence
---
Great regards,
Ryo Kanbayashi
https://github.com/ryogrid
diff --git a/src/interfaces/ecpg/test/ecp
{
"emoji": "😀",
"version": 1
}
Hi everyone,
I found a typo in comment of restrictinfo.c line 99.
(
https://github.com/postgres/postgres/blob/master/src/backend/optimizer/util/restrictinfo.c#L99
)
Not 'construcitng' but 'constructing' ?
--
Best regards,
Ryo Kanbayashi
kanbayashi@gmail.com
https://git
> On Thu, Jan 9, 2025 at 9:27 PM Ryo Kanbayashi
> wrote:
>
> > On 2025/01/09 20:34, Ryo Kanbayashi wrote:
> > > Dear Tom, Fujii-san, Kuroda-san,
> > >
> > > I saw comments of yours and recognized that better fix is below.
> > >
> > >
posed fix is better too.
So, I modified the patch.
With new patch, warning message is changed like below :)
ryo@DESKTOP-IOASPN6:~/work/postgres/src$ ../master/bin/ecpg
copy_from_should_be_warned.pgc
copy_from_should_be_warned.pgc:24: WARNING: COPY FROM STDIN/STDOUT is
not implemented
ryo@DESKTOP-I
On Thu, Jan 9, 2025 at 9:27 PM Ryo Kanbayashi wrote:
>
> > On 2025/01/09 20:34, Ryo Kanbayashi wrote:
> > > Dear Tom, Fujii-san, Kuroda-san,
> > >
> > > I saw comments of yours and recognized that better fix is below.
> > >
> > > - Fix of firs
On Sun, Jan 12, 2025 at 12:56 PM Fujii Masao
wrote:
>
>
>
> On 2025/01/12 2:04, Ryo Kanbayashi wrote:
> > I wrote a patch for release v13 - v17 additionally and tested it for
> > each release branch :)
> > As a result, two patch is needed for this fix.
>
>
On Fri, Jan 10, 2025 at 5:45 PM Ryo Kanbayashi wrote:
>
> On Thu, Jan 9, 2025 at 9:27 PM Ryo Kanbayashi
> wrote:
> >
> > > On 2025/01/09 20:34, Ryo Kanbayashi wrote:
> > > > Dear Tom, Fujii-san, Kuroda-san,
> > > >
> > > > I s
On Wed, Jan 15, 2025 at 1:34 AM Fujii Masao wrote:
>
>
>
> On 2025/01/12 18:27, Ryo Kanbayashi wrote:
> > Thank you for reviewing patch :)
> > The commit log matches with my recognition and has no problem.
>
> Pushed. Thanks!
>
> >>> check_patch
{
"emoji": "🙏",
"version": 1
}
ly patch, warning is shown.
(c source is generated as before)
ryo@DESKTOP-IOASPN6:~/work/postgres/src$ ../master/bin/ecpg
copy_from_should_be_warned.pgc
copy_from_should_be_warned.pgc:24: WARNING: COPY FROM STDIN is not implemented
ryo@DESKTOP-IOASPN6:~/work/postgres/src$
--
Best regards,
Ryo Kanba
> On 2025/01/09 20:34, Ryo Kanbayashi wrote:
> > Dear Tom, Fujii-san, Kuroda-san,
> >
> > I saw comments of yours and recognized that better fix is below.
> >
> > - Fix of first attached patch which does not change warning message
> >
> > And I c
to write patches for current supporting versions? (12.x - 17.x)
--
Best regards,
Ryo Kanbayashi
https://github.com/ryogrid
On Thu, Jan 9, 2025 at 4:53 PM Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Tom, Fujii-san,
>
> > > ISTM that ecpg supports COPY TO STDOUT and includes t
On Thu, Feb 13, 2025 at 10:49 PM Fujii Masao
wrote:
>
>
>
> On 2025/02/06 8:57, Ryo Kanbayashi wrote:
> > On Wed, Feb 5, 2025 at 9:31 PM Ryo Kanbayashi
> > wrote:
> >>
> >> Hi hackers,
> >>
> >> When I wrote patch of ecpg command noti
>On Mon, Mar 3, 2025 at 12:23 PM Fujii Masao
>wrote:
> On 2025/03/01 19:45, Ryo Kanbayashi wrote:
> >> +program_help_ok('ecpg');
> >> +program_version_ok('ecpg');
> >> +program_options_handling_ok('ecpg');
> >> +command_f
On Tue, Feb 18, 2025 at 12:49 PM Ryo Kanbayashi
wrote:
>
> On Thu, Feb 13, 2025 at 10:49 PM Fujii Masao
> wrote:
> >
> >
> >
> > On 2025/02/06 8:57, Ryo Kanbayashi wrote:
> > > On Wed, Feb 5, 2025 at 9:31 PM Ryo Kanbayashi
> > > wrote:
> &g
On Fri, Feb 28, 2025 at 11:27 PM Fujii Masao
wrote:
> On 2025/02/28 9:24, Ryo Kanbayashi wrote:
> > I have rewrote my patch on TAP test sttyle :)
> > File for build are also updated.
>
> Thanks for updating the patch!
Thanks for review:)
>
> +'tests&#x
lost.
TO: Mecael and other hackers,
There are any problem in light of community customs?
---
Great regards,
Ryo Kanbayashi
On Thu, Mar 13, 2025 at 9:42 AM Michael Paquier wrote:
>
> On Thu, Mar 13, 2025 at 08:53:49AM +0900, Ryo Kanbayashi wrote:
> > If you can't work for ther patch for a while because you are busy or
> > other some reason,
> > I can become additinal reviewer and appl
On Mon, Jan 27, 2025 at 2:01 PM Michael Paquier wrote:
> On Thu, Mar 13, 2025 at 08:53:49AM +0900, Ryo Kanbayashi wrote:
> > Putting a bit of context here. Most of the Postgres hackers based in
> > Japan had a meeting last Friday, and Kanbayashi-san has asked me about
> > p
On Thu, Mar 20, 2025 at 5:39 PM Ryo Kanbayashi wrote:
>
> On Mon, Jan 27, 2025 at 2:01 PM Michael Paquier wrote:
> > On Thu, Mar 13, 2025 at 08:53:49AM +0900, Ryo Kanbayashi wrote:
> > > Putting a bit of context here. Most of the Postgres hackers based in
> > > J
PGSYSCONFDIR is set, we could test one in
> isolation using the temporary folder created by the test.
I check and modify 0002 patch (adding servicefile option and its
regression tests)
in light of the above and committed 0001 patch (regression test of
existing features)
toward next release :)
---
Great Regards,
Ryo Kanbayashi
On Sat, Mar 22, 2025 at 4:46 PM Michael Paquier wrote:
>
> On Thu, Mar 20, 2025 at 06:16:44PM +0900, Ryo Kanbayashi wrote:
> > Sorry, I found a miss on 006_service.pl.
> > Fixed patch is attached...
>
> Please note that the commit fest app needs all the patches of a a s
On Sat, Mar 29, 2025 at 3:35 PM Ryo Kanbayashi wrote:
> On Fri, Mar 28, 2025 at 8:57 AM Michael Paquier wrote:
> > > I am not sure that I'll have the time to look at 0002 for this release
> > > cycle, could it be possible to get a rebase for it?
> > Here is a sim
718
- Your dummy node object introduced code works without problem and the
code is more strict than current code
I'll reflect your notice and suggestion to the patch current I'm working on :)
---
Great Regards,
Ryo Kanbayashi
On Mon, Apr 7, 2025 at 1:10 PM Michael Paquier wrote:
>
> On Thu, Apr 03, 2025 at 12:36:59AM +0900, Ryo Kanbayashi wrote:
> > I'll reflect your notice and suggestion to the patch current I'm
> > working on :)
>
> Thanks for that.
>
> And I have forgotten t
28 matches
Mail list logo
