On Sun, Jan 12, 2025 at 12:56 PM Fujii Masao <masao.fu...@oss.nttdata.com> wrote: > > > > On 2025/01/12 2:04, Ryo Kanbayashi wrote: > > I wrote a patch for release v13 - v17 additionally and tested it for > > each release branch :) > > As a result, two patch is needed for this fix. > > Thanks for the patches! Barring any objections, > I plan to commit them with the following commit log. > > ------------------- > ecpg: Restore detection of unsupported COPY FROM STDIN. > > The ecpg command includes code to warn about unsupported COPY FROM STDIN > statements in input files. However, since commit 3d009e45bd, > this functionality has been broken due to a bug introduced in that commit, > causing ecpg to fail to detect the statement. > > This commit resolves the issue, restoring ecpg's ability to detect > COPY FROM STDIN and issue a warning as intended. > > Back-patch to all supported versions. > > Author: Ryo Kanbayashi > Reviewed-by: Hayato Kuroda, Tom Lane > Discussion: > https://postgr.es/m/canon0ez_t5udcuev8c1yormisjiu5wu681eevzzgkwoeikh...@mail.gmail.com > -------------------
Thank you for reviewing patch :) The commit log matches with my recognition and has no problem. > > check_patches.sh -> utility script for testing above two patches on > > each target branches > > Should we add a regression test to ensure ecpg correctly reports errors > and warnings, including the warning for COPY FROM STDIN? This could help > catch similar bugs more effectively. If agreed, we could create this > as a separate patch. Of course there is no problem! I think a test like above becomes a good regression test too. -- Best regards, Ryo Kanbayashi https://github.com/ryogrid
