On Wed, Jan 15, 2025 at 1:34 AM Fujii Masao <masao.fu...@oss.nttdata.com> wrote: > > > > On 2025/01/12 18:27, Ryo Kanbayashi wrote: > > Thank you for reviewing patch :) > > The commit log matches with my recognition and has no problem. > > Pushed. Thanks! > > >>> check_patches.sh -> utility script for testing above two patches on > >>> each target branches > >> > >> Should we add a regression test to ensure ecpg correctly reports errors > >> and warnings, including the warning for COPY FROM STDIN? This could help > >> catch similar bugs more effectively. If agreed, we could create this > >> as a separate patch. > > > > Of course there is no problem! > > I think a test like above becomes a good regression test too. > > So, will you give creating the patch a try?
Yes. I try to write the patch for regression test of ecpg command warning and error notice :) BTW, How should we handle commit fest entry below? "ecpg command does not warn COPY ... FROM STDIN;" https://commitfest.postgresql.org/52/5497/ I think that the patch of regression test is not included the entry. --- Great regards, Ryo Kanbayashi https://github.com/ryogrid
