Re: Sort support for macaddr8

2019-06-03 Thread Peter Geoghegan
cular query and taking the median execution time as representative seems to be the best approach. -- Peter Geoghegan

Re: Sort support for macaddr8

2019-06-03 Thread Peter Geoghegan
y necessary to memset() at the equivalent point for macaddr8, since we cannot "run out of bytes from the authoritative representation" that go in the Datum/abbreviated key. I suppose that the memset() should simply be removed, since it is superfluous here. -- Peter Geoghegan

Re: Sort support for macaddr8

2019-06-03 Thread Peter Geoghegan
that that would make sense, but I don't think that this patch needs to do that. There is at least one pre-existing cases that does this -- macaddr. -- Peter Geoghegan

Re: Alter index rename concurrently to

2018-10-05 Thread Peter Eisentraut
. Code style: > +RenameRelationInternal(Oid myrelid, const char *newrelname, bool > is_internal, bool is_index) > This line is longer than 80 chars. pgindent leaves this line alone. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24

Re: transction_timestamp() inside of procedures

2018-10-05 Thread Peter Eisentraut
e but it seems to be the simplest way without doing major surgery to all this code. Attached is an updated patch with a test case. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services From a7b7c4094a54f9b217332809b1a

Re: Procedure calls are not tracked in pg_stat_user_functions / track_functions

2018-10-05 Thread Peter Eisentraut
ether with functions, since >> one can always join with pg_proc to determine whether something is a >> function or a procedure. > > Yea, that sounds wrong / not ideal to me. I think we should just fix > this, should be easy enough. Here is a patch. -- Peter Eisentraut

Re: [HACKERS] Support for Secure Transport SSL library on macOS as OpenSSL alternative

2018-10-05 Thread Peter Eisentraut
On 02/10/2018 15:40, Tom Lane wrote: > Peter Eisentraut writes: >> On 26/09/2018 23:19, Daniel Gustafsson wrote: >>> It’s not clear to me just how common it is to use GCC via homebrew on macOS. > >> I use that all the time. > > Hm, so did 5e2217131 break anythi

Re: automatic restore point

2018-10-05 Thread Peter Eisentraut
with event > triggers -- you have to create individual regular triggers on truncate > for each table (so you probably need yet another event trigger that > creates such triggers). I don't see why we couldn't add event triggers on TRUNCATE or other commands such as DELETE. -- Pete

Re: SCRAM with channel binding downgrade attack

2018-10-05 Thread Peter Eisentraut
g data, so the channel binding would detect this. Is that not correct? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Jsonb transform for pl/python

2018-10-05 Thread Peter Eisentraut
attached. Committed, thanks. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Procedure calls are not tracked in pg_stat_user_functions / track_functions

2018-10-08 Thread Peter Eisentraut
On 05/10/2018 14:15, Peter Eisentraut wrote: > On 04/10/2018 22:07, Andres Freund wrote: >> On 2018-10-04 12:15:28 -0700, Lukas Fittl wrote: >>> Was this intentional, or an oversight? >>> >>> If welcome, I would be happy to work on a patch. Whilst slightly

exclude tmp_check and tmp_install from pgindent

2018-10-08 Thread Peter Eisentraut
/exclude_file_patterns index 65c42c131d..c8efc9a913 100644 --- a/src/tools/pgindent/exclude_file_patterns +++ b/src/tools/pgindent/exclude_file_patterns @@ -6,3 +6,5 @@ /snowball/libstemmer/ /pl/plperl/ppport\.h$ /jit/llvmjit\.h$ +/tmp_check/ +/tmp_install/ -- Peter Eisentraut http://www

Re: SCRAM with channel binding downgrade attack

2018-10-08 Thread Peter Eisentraut
On 05/10/2018 19:01, Bruce Momjian wrote: > On Fri, Oct 5, 2018 at 04:53:34PM +0200, Peter Eisentraut wrote: >> On 23/05/2018 08:46, Heikki Linnakangas wrote: >>> "tls-unique" and "tls-server-end-point" are overly technical to users. >>> They don&

Re: chained transactions

2018-10-08 Thread Peter Eisentraut
On 02/10/2018 07:38, Michael Paquier wrote: > The patch set does not apply anymore, so this patch is moved to next CF, > waiting on author. Attached is a rebased patch set. No functionality changes. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development

Re: [HACKERS] [WIP] Zipfian distribution in pgbench

2018-10-08 Thread Peter Geoghegan
lly be fixed, though, since you have one point of contention for each of the really hot values at the far left of the leaf level. [1] https://commitfest.postgresql.org/20/1787/ -- Peter Geoghegan

Re: pgbench exit code

2018-10-09 Thread Peter Eisentraut
The patch removes a check that there was an output and that no > transactions where processed. ISTM it should be kept. If a different exit > status is chosen on abort, that would allow to keep it easily. fixed > Probably there should be some documentation changes as well? done New patc

Re: Some incorrect comments and out-dated README from run-time pruning

2018-10-09 Thread Peter Eisentraut
subplan_map[p] contains the I don't see what someone reading this comment would do with "as defined in the PartitionDesc". I don't see any PartitionDesc referenced or mentioned at or near that struct. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL

Re: Proposal for Signal Detection Refactoring

2018-10-09 Thread Peter Eisentraut
the enum values and do bit math > to know. You could use an actual C bit field, to make debugging easier. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Proposal for Signal Detection Refactoring

2018-10-09 Thread Peter Eisentraut
=== + +The approch to signal handling in PostgreSQL is designed to strictly conform +with the C89 standard and designed to run with as few platform assumptions as +possible. We use C99 now, so why would be design this to be conforming to C89? More generally, I'd

Re: TAP tests for pg_verify_checksums

2018-10-09 Thread Peter Eisentraut
sum checks not done"); The test name should be something like "fails with online cluster". I would also like to see a test that runs against a cluster without checksums enabled. Other than that, it appears to cover everything. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: chained transactions

2018-10-09 Thread Peter Eisentraut
On 05/04/2018 10:35, Heikki Linnakangas wrote: > On 15/03/18 18:39, Alvaro Herrera wrote: >>> From 517bc6d9fefdee9135857d9562f644f2984ace32 Mon Sep 17 00:00:00 2001 >>> From: Peter Eisentraut >>> Date: Sun, 18 Feb 2018 09:33:53 -0500 >>> Subject: [PATCH v1 6

Re: automatic restore point

2018-10-10 Thread Peter Eisentraut
On 05/10/2018 15:26, Peter Eisentraut wrote: > It looked for a moment that > > isCompleteQuery = (context <= PROCESS_UTILITY_QUERY) > > in ProcessUtilitySlow() might be a problem, since that omits > PROCESS_UTILITY_QUERY_NONATOMIC, but it's not actually a problem,

Re: file cloning in pg_upgrade and CREATE DATABASE

2018-10-11 Thread Peter Eisentraut
On 10/10/2018 21:50, Bruce Momjian wrote: >> I see. Peter is proposing to have a fourth mode, essentially >> --transfer-mode=clone-or-copy. > > Uh, if you use --link, and the two data directories are on different > file systems, it fails. No one has ever asked for link-or-

Re: pgbench exit code

2018-10-15 Thread Peter Eisentraut
On 12/10/2018 21:22, Fabien COELHO wrote: > No further remarks. I turned the patch as ready on the CF app. Committed, thanks. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Requesting advanced Group By support

2018-10-15 Thread Peter Eisentraut
that we can't record dependencies on not-null constraints. Some work on that has been in progress for many years. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: pageinspect: add tuple_data_record()

2018-10-16 Thread Peter Geoghegan
ot;data" field instead of a text "data" field.) -- Peter Geoghegan

Re: Multi-insert into a partitioned table with before insert row trigger causes server crash on latest HEAD

2018-10-17 Thread Peter Eisentraut
27;ve also added the relevant > test-case for it. Peter, David, Could you please have a look into the > attached patch and share your thoughts. Thank you. I have committed your fix and test, moving some code around a bit. Thanks. -- Peter Eisentraut http://www.2ndQuadrant.com/ P

Re: Large writable variables

2018-10-17 Thread Peter Eisentraut
Your version with __builtin_types_compatible_p() doesn't work for casting between char * and const char *, so it wouldn't be very useful. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services From 31576b3768

Re: Large writable variables

2018-10-17 Thread Peter Eisentraut
_types_compatible_p(const char *, char *) returns false (0) for me. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pg_stat_ssl additions

2018-10-17 Thread Peter Eisentraut
e existing "clientdn".) -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services From 9b039b0e111e5a782f8737e8d66f144e84efd1e4 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Tue, 2 Oct 2018 12:17:22 +020

Re: Alter index rename concurrently to

2018-10-17 Thread Peter Eisentraut
ve any concerns about the underlying principle of this patch? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Making all nbtree entries unique by having heap TIDs participate in comparisons

2018-10-18 Thread Peter Geoghegan
On Wed, Oct 3, 2018 at 4:39 PM Peter Geoghegan wrote: > I did find a pretty clear regression, though only with writes to > unique indexes. Attached is v6, which fixes the issue. More on that > below. I've been benchmarking my patch using oltpbench's TPC-C benchmark these pa

removing unnecessary get_att*() lsyscache functions

2018-10-18 Thread Peter Eisentraut
I noticed that get_attidentity() isn't really necessary because the information can be obtained from an existing tuple descriptor in each case. Also, get_atttypmod() hasn't been used since 2004. I propose the attached patches to remove these two functions. -- Peter Eisentraut

Re: Large writable variables

2018-10-18 Thread Peter Eisentraut
erlying_type, var) because the "var" doesn't actually have to be a variable. Attached is my previous patch adapted to your macro. I'm tempted to get rid of the stuff in dfmgr.c and just let the "older platforms" get the warning. -- Peter Eisentraut http://www

Re: Large writable variables

2018-10-18 Thread Peter Eisentraut
On 18/10/2018 22:17, Peter Eisentraut wrote: > On 17/10/2018 23:51, Andres Freund wrote: >>> __builtin_types_compatible_p(const char *, char *) returns false (0) for me. >> >> Right, that's why I added a const, inside the macro, to the type >> specified in

Re: Making all nbtree entries unique by having heap TIDs participate in comparisons

2018-10-18 Thread Peter Geoghegan
Shared_buffers is 10gb iirc. The server has 32gb of memory. Yes, 'public' is the patch case. Sorry for not mentioning it initially. -- Peter Geoghegan (Sent from my phone)

Re: Making all nbtree entries unique by having heap TIDs participate in comparisons

2018-10-18 Thread Peter Geoghegan
#x27;d make sense to hack up a patch that logs when evicting a > buffer while already holding another lwlock. That shouldn't be too hard. I'll look into this. Thanks -- Peter Geoghegan

Re: file cloning in pg_upgrade and CREATE DATABASE

2018-10-18 Thread Peter Eisentraut
On 11/10/2018 16:50, Peter Eisentraut wrote: > On 10/10/2018 21:50, Bruce Momjian wrote: >>> I see. Peter is proposing to have a fourth mode, essentially >>> --transfer-mode=clone-or-copy. >> >> Uh, if you use --link, and the two data directories are on differe

Re: Making all nbtree entries unique by having heap TIDs participate in comparisons

2018-10-19 Thread Peter Geoghegan
ant the extra LOG instrumentation to influence the outcome. -- Peter Geoghegan

Re: removing unnecessary get_att*() lsyscache functions

2018-10-22 Thread Peter Eisentraut
eadable in my opinion.. OK, slightly reworked version attached. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services >From d9a63e636cb5ad41d3105d62dce497141685ac22 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut

Re: removing unnecessary get_att*() lsyscache functions

2018-10-23 Thread Peter Eisentraut
On 23/10/2018 02:11, Michael Paquier wrote: > On Mon, Oct 22, 2018 at 07:12:28PM +0200, Peter Eisentraut wrote: >> OK, slightly reworked version attached. > > + attTup = (Form_pg_attribute) GETSTRUCT(tuple); > attnum = ((Form_pg_attribute) GETSTRUCT(tuple))->attnum;

Re: Making all nbtree entries unique by having heap TIDs participate in comparisons

2018-10-23 Thread Peter Geoghegan
's a particularly good target for my patch. I can find a way of only executing the read TPC-C queries, to see where they are on their own. TPC-C is particularly write-heavy, especially compared to the much more recent though less influential TPC-E benchmark. -- Peter Geoghegan

Remove obsolete pg_attrdef.adsrc column

2018-10-23 Thread Peter Eisentraut
I propose the attached patch to remove the long-unused catalog column pg_attrdef.adsrc. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services From df811a76e026be395a4309a1f0de75540dae5b11 Mon Sep 17 00:00:00 2001

Re: Large writable variables

2018-10-24 Thread Peter Eisentraut
On 18/10/2018 21:31, Andres Freund wrote: > On 2018-10-18 22:17:55 +0200, Peter Eisentraut wrote: >> I'd perhaps change the signature >> >> #define unconstify(underlying_type, var) >> >> because the "var" doesn't actually have to be a var

Re: Alter index rename concurrently to

2018-10-25 Thread Peter Eisentraut
On 17/10/2018 23:11, Peter Eisentraut wrote: > On 13/10/2018 04:01, Andres Freund wrote: >> I don't see how this could be argued. It has to be a self-conflicting >> lockmode, otherwise you'd end up doing renames of tables where you >> cannot see the previous state. A

Re: Remove obsolete pg_attrdef.adsrc column

2018-10-27 Thread Peter Eisentraut
On 23/10/2018 19:48, Daniel Gustafsson wrote: >> On 23 Oct 2018, at 15:17, Peter Eisentraut >> wrote: >> >> I propose the attached patch to remove the long-unused catalog column >> pg_attrdef.adsrc. > > +1, I ran into a bug in an app as recently as tod

Re: [HACKERS] Exclude schema during pg_restore

2018-10-29 Thread Peter Eisentraut
ified > |multiple times to select multiple objects. > > Patch attached. Committed to 10, 11, and master. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

PSA: rr recorder/debugger works well with Postgres + Linux

2018-10-30 Thread Peter Geoghegan
I'm debugging, but it does still make the process a bit easier. rr is supposed to be particularly helpful with non-deterministic or difficult to recreate bugs; hopefully I'll be able to apply it in that way when I gain some more experience with it. -- Peter Geoghegan

Re: [HACKERS] generated columns

2018-10-30 Thread Peter Eisentraut
On 30/10/2018 15:19, Erik Rijkers wrote: > On 2018-10-30 09:35, Peter Eisentraut wrote: > >> [v5-0001-Generated-columns.patch ] > > Hi, > > I couldn't get this to apply to current head. > > I tried: > > patch --dry-run --ignore-whitespace -p 0

Re: Remove obsolete pg_attrdef.adsrc column

2018-11-01 Thread Peter Eisentraut
On 27/10/2018 23:19, Daniel Gustafsson wrote: >> On 27 Oct 2018, at 12:57, Peter Eisentraut >> wrote: >> >> On 23/10/2018 19:48, Daniel Gustafsson wrote: >>>> On 23 Oct 2018, at 15:17, Peter Eisentraut >>>> wrote: >>>> >>>&g

Re: PG vs macOS Mojave

2018-11-01 Thread Peter Eisentraut
similar to what I did here, ie > what ends up in the configure output is How does that work when building against a non-system Perl or Tcl? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Small run-time pruning doc fix

2018-11-02 Thread Peter Eisentraut
are not implemented yet? Not sure we want to mention all of them. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: wal_dump output on CREATE DATABASE

2018-11-02 Thread Peter Eisentraut
like this desc: CREATE copy dir (ts/db) 1663/1 to 1663/16384 -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: bugfix: BUG #15477: Procedure call with named inout refcursor parameter - "invalid input syntax for type boolean"

2018-11-02 Thread Peter Eisentraut
poses to fix it? About the patch, I suspect printing out NOTICE: in the regression tests might lead to unstable results if there is concurrent activity. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: [PATCH] Change simple_heap_insert() to a macro

2018-11-02 Thread Peter Eisentraut
l here. I think there have been enough votes against this that I'll close this CF item. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Making all nbtree entries unique by having heap TIDs participate in comparisons

2018-11-02 Thread Peter Geoghegan
arch of a leaf page needs to last for a relatively long time. I'll look into it again, though. > Due to the optimization the _bt_binsrch() size has grown twice. May be > you move this to some service routine? Maybe. There are some tricky details that seem to work against it. I'll see if it's possible to polish that some more, though. -- Peter Geoghegan

Re: pgbench doc fix

2018-11-03 Thread Peter Eisentraut
e across just fine, I think. More details can be put in the reference page. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Making all nbtree entries unique by having heap TIDs participate in comparisons

2018-11-03 Thread Peter Geoghegan
On Fri, Nov 2, 2018 at 5:00 PM Peter Geoghegan wrote: > I had the opportunity to discuss this patch at length with Heikki > during pgConf.EU. > The DESC heap TID sort order thing probably needs to go. I'll probably > have to go fix the regression test failures that occur wh

Re: Making all nbtree entries unique by having heap TIDs participate in comparisons

2018-11-03 Thread Peter Geoghegan
d" order. I think that this is an example of the more general problem -- what you call the 'drop cascades to 62 other objects' problem is a more specific subproblem, or, if you prefer, a more specific symptom of the same problem. Since I'm going to have to fix the problem head-on, I'll have to study it in detail anyway. -- Peter Geoghegan

Re: Making all nbtree entries unique by having heap TIDs participate in comparisons

2018-11-04 Thread Peter Geoghegan
ause we also wrote regression tests that exercised the useful behavior. > May be you know any another problems of the patch? Just the lack of pg_upgrade support. That is progressing nicely, though. I'll probably have that part in the next revision of the patch. I've found what looks like a workable approach, though I need to work on a testing strategy for pg_upgrade. -- Peter Geoghegan

Re: bugfix: BUG #15477: Procedure call with named inout refcursor parameter - "invalid input syntax for type boolean"

2018-11-05 Thread Peter Eisentraut
T is not a . Note that parameter defaults with output parameters was only added in SQL:2016. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Reduce maintenance burden of alternative output files with \if \quit

2018-11-05 Thread Peter Eisentraut
n the xml case, some stuff still works if xml is not compiled in, and we need to check that. If it gets to complicated to maintain, then we can also split files. The collation tests are split like that. What specific cases do you have in mind? -- Peter Eisentraut http://www.2nd

Fixing findDependentObjects()'s dependency on scan order (regressions in DROP diagnostic messages)

2018-11-05 Thread Peter Geoghegan
epend on it -DETAIL: extension earthdistance depends on extension cube +DETAIL: extension earthdistance depends on function cube_out(cube) Can anyone think of a workable, scalable approach to fixing the processing order of this findDependentObjects() pg_depend scan so that we reliably get the

Re: [HACKERS] generated columns

2018-11-06 Thread Peter Eisentraut
tgres=# table test; > i | gen_stored | gen_virt > ---++-- > 1 ||2 > 2 ||4 > > Virtual columns was calculated on table read and its ok, but stored column > does not update table data. This is a small bug that I will fix in my next update. --

Re: [HACKERS] generated columns

2018-11-06 Thread Peter Eisentraut
olution would be to exclude generated columns from the replication stream altogether. Similar considerations also apply to foreign tables. What is the meaning of a stored generated column on a foreign table? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7

Re: [HACKERS] generated columns

2018-11-06 Thread Peter Eisentraut
27;t know whether the generation expression on the target is the same (or even if it looks the same, consider locale issues etc.), so we need to recompute the generated columns on the target anyway, so it's pointless to send the already computed stored values. -- Peter Eisentraut

Re: Why do pg_upgrade's test use the serial schedule?

2018-11-06 Thread Peter Eisentraut
n to not use installcheck-parallel? Probably worth trying. Using serial was probably just the conservative choice at the time. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Reduce maintenance burden of alternative output files with \if \quit

2018-11-06 Thread Peter Eisentraut
th the collation tests is different. They need a database with UTF8 encoding, which we cannot guarantee in the installcheck case. Otherwise we could run them automatically with a makefile conditional. (Early versions of the ICU patch did that, IIRC.) -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Support custom socket directory in pg_upgrade

2018-11-06 Thread Peter Eisentraut
t like the current directory is a particularly good choice anyway. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: file cloning in pg_upgrade and CREATE DATABASE

2018-11-07 Thread Peter Eisentraut
On 19/10/2018 01:50, Michael Paquier wrote: > On Thu, Oct 18, 2018 at 11:59:00PM +0200, Peter Eisentraut wrote: >> New patch that removes all the various reflink modes and adds a new >> option --clone that works similar to --link. I think it's much cleaner now. > >

Re: Connections hang indefinitely while taking a gin index's LWLock buffer_content lock

2018-11-07 Thread Peter Geoghegan
on gin page type into "can't happen" elog errors in places like scanPendingInsert() and ginInsertCleanup() would be a good start. Note that we already did similar Assert-elog(ERROR) promotion this for posting tree code, when similar bugs appeared way back in 2013. -- Peter Geoghegan

Re: Connections hang indefinitely while taking a gin index's LWLock buffer_content lock

2018-11-07 Thread Peter Geoghegan
t;--- deadlocks list, nlist, NULL); } Clearly this particular call to ginEntryInsert() from within ginInsertCleanup() is generally supposed to be a rare occurrence. It's not surprising that it's hard for you to hit this issue. BTW, I strongly doubt that disabling hugepages has fixed anything, though it may have accidentally masked the problem. This is an issue around the basic correctness of the locking protocols used by GIN. -- Peter Geoghegan

Re: Connections hang indefinitely while taking a gin index's LWLock buffer_content lock

2018-11-07 Thread Peter Geoghegan
c4ab97e from 2013 -- that detail is probably important, because it seems to be what breaks the subtree design (we don't delete in two phases or anything in GIN). I think that you have to be doing a multi-level delete for a deadlock to take place, which isn't particularly likely to coincide with a concurrent insertion in general. That may explain why it's taken a year to get a high-quality bug report. -- Peter Geoghegan

Re: Connections hang indefinitely while taking a gin index's LWLock buffer_content lock

2018-11-07 Thread Peter Geoghegan
On Wed, Nov 7, 2018 at 5:46 PM Peter Geoghegan wrote: > I think that you have to be doing a multi-level delete for a deadlock > to take place, which isn't particularly likely to coincide with a > concurrent insertion in general. That may explain why it's taken a > year to

Re: file cloning in pg_upgrade and CREATE DATABASE

2018-11-07 Thread Peter Eisentraut
On 07/11/2018 19:03, Tom Lane wrote: > Peter Eisentraut writes: >> Committed, thanks. > > It seems unfortunate that there is no test coverage in the committed > patch. I realize that it may be hard to test given the filesystem > dependency, but how will we know if it works

Re: PostgreSQL Limits and lack of documentation about them.

2018-11-08 Thread Peter Eisentraut
oned too. Could you adjust this to use fewer capital letters, unless they start sentences or similar? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: unused/redundant foreign key code

2018-11-10 Thread Peter Eisentraut
On 09/11/2018 21:37, Daniel Gustafsson wrote: >> On 8 Aug 2018, at 21:34, Peter Eisentraut >> wrote: >> >> I found some unused and some redundant code in ri_triggers.c that was >> left around by some previous changes that aimed to optimize away certain >>

Re: Connections hang indefinitely while taking a gin index's LWLock buffer_content lock

2018-11-10 Thread Peter Geoghegan
On Wed, Nov 7, 2018 at 5:46 PM Peter Geoghegan wrote: > Teodor: Do you think that the issue is fixable? It looks like there > are serious issues with the design of 218f51584d5 to me. I don't think > the general "there can't be any inserters at this subtree" thing

Re: Continue work on changes to recovery.conf API

2018-11-12 Thread Peter Eisentraut
t seems good to be consistent.) - Help strings in guc.c should end with a period. - Renaming the promote and fallback_promote files seems unnecessary for this patch, and I would take it out. Otherwise, the change in pg_ctl.c is out of date with the comment above it. -- Peter Eisentraut

Re: Small run-time pruning doc fix

2018-11-12 Thread Peter Eisentraut
On 04/11/2018 06:23, David Rowley wrote: > Thanks for looking at this. > > On 2 November 2018 at 20:30, Peter Eisentraut > wrote: >> >> - Execution-time partition pruning currently occurs for the >> + Execution-time partition pruning currently only

Re: Support custom socket directory in pg_upgrade

2018-11-12 Thread Peter Eisentraut
p/pg/ or some such). But, if the normal socket directory > is not /tmp, we might find that pg_upgrade can't write there. We do exactly that in pg_regress and it's never been a problem. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Usage of pg_waldump

2018-11-13 Thread Peter Eisentraut
On 01/05/2018 18:39, David G. Johnston wrote: > ​note: there is either an extra space between the two closing brackets > or a missing space before startseg I have committed a fix for this. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support,

Re: wal_dump output on CREATE DATABASE

2018-11-13 Thread Peter Eisentraut
ing on a particular fixed format. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Fixing findDependentObjects()'s dependency on scan order (regressions in DROP diagnostic messages)

2018-11-13 Thread Peter Geoghegan
e best way to fix the problem is to force the scan order to be the one that we accidentally depend on using some mechanism or other. Though not necessarily the one I've sketched out. [1] https://postgr.es/m/24279.1525401...@sss.pgh.pa.us -- Peter Geoghegan

Re: Fixing findDependentObjects()'s dependency on scan order (regressions in DROP diagnostic messages)

2018-11-13 Thread Peter Geoghegan
On Tue, Nov 13, 2018 at 1:29 PM Peter Geoghegan wrote: > A solution does occur to me that I'm kind of embarrassed to suggest, > but that would nonetheless probably do the job: > Why not vary the objsubid value among entries that don't use it > anyway, so that they h

Re: Alter index rename concurrently to

2018-11-14 Thread Peter Eisentraut
ny issue, so the patch looks in a very good shape. Committed, thanks all. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Fixing findDependentObjects()'s dependency on scan order (regressions in DROP diagnostic messages)

2018-11-15 Thread Peter Geoghegan
y changes along similar lines, since of course I'm only doing this with the pg_depend indexes, and not for every system catalog index. -- Peter Geoghegan From 7158fa1f93447d1f9bb296605a65b0fecfd54210 Mon Sep 17 00:00:00 2001 From: Peter Geoghegan Date: Tue, 13 Nov 2018 18:14:23

Re: Some incorrect comments and out-dated README from run-time pruning

2018-11-15 Thread Peter Eisentraut
On 09/10/2018 22:25, David Rowley wrote: > On 10 October 2018 at 02:38, Peter Eisentraut > wrote: >> - * subplan_map[] and subpart_map[] are indexed by partition index (where >> - * zero is the topmost partition, and non-leaf partitions must come before >> - * thei

Re: A small tweak to some comments for PartitionKeyData

2018-11-15 Thread Peter Eisentraut
e fields was the cause of CVE-2018-1052, so I think > it's worthwhile to mention how they should be used in the comments. > > Patch attached. committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

incorrect xlog.c coverage report

2018-11-20 Thread Peter Eisentraut
, etc.) are shown as never hit, even though there are explicit tests for this in src/test/recovery/t/003_recovery_targets.pl. I tried this locally and also with -O0 just in case, but I get the same results. Any ideas? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL

Re: wal_dump output on CREATE DATABASE

2018-11-20 Thread Peter Eisentraut
On 16/11/2018 17:28, Jean-Christophe Arnu wrote: > On the other hand, there's a consensus not to go further than the > initial patch. I have committed your original patch. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DB

Re: settings to control SSL/TLS protocol version

2018-11-20 Thread Peter Eisentraut
; -> '' that was discussed elsewhere in the thread. Thanks. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: pg_stat_ssl additions

2018-11-20 Thread Peter Eisentraut
gt; > clientdn, clientserial, issuerdn are the fields about client > certificates. Only the last one omits prefixing "client". But > "clientissuerdn" seems somewhat rotten... Counldn't we rename > clientdn to client_dn? I'd prefer renaming as well, but some people might not like that. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility.

2018-11-21 Thread Peter Eisentraut
; postgres=# \d+ pg_class > [...] > Indexe: > "pg_class_oid_index" UNIQUE, btree (oid) > > Now that oid is a proper column, shouldn't that be a PRIMARY KEY? > (Just for the looks.) This is an independent consideration. There was nothing before that prevented an index o

Re: Continue work on changes to recovery.conf API

2018-11-21 Thread Peter Eisentraut
setting. Btw., I'm not in love with the *.signal naming. I originally argued against naming them *.trigger, but I don't like the alternative either. But that's easy to change if someone has a better idea. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: pg_upgrade supported versions policy

2018-11-22 Thread Peter Eisentraut
#3. That's basically how we handle pg_dump, psql, etc. normally. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query

2018-11-22 Thread Peter Eisentraut
o be avoided. Can you show examples of what these would look like? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: [HACKERS] generated columns

2018-11-22 Thread Peter Eisentraut
or most fields, and adding one exception like this would create a lot of extra work and bloat the patch and create potential for future instability. Also note that a C char '\0' is represented as '' (empty string) in SQL, so this also creates a natural representation in SQL. -

Re: [HACKERS] generated columns

2018-11-22 Thread Peter Eisentraut
users will expect to work.) A serial column is not a generated column. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Connections hang indefinitely while taking a gin index's LWLock buffer_content lock

2018-11-23 Thread Peter Geoghegan
think that reverting commit 218f51584d5 is the only option on the table for the back branches. Its design is based on ideas on locking protocols that are fundamentally incorrect and unworkable. I don't have a lot of faith in our ability to retrofit a design that fixes the issue without causing problems elsewhere. -- Peter Geoghegan

<    24   25   26   27   28   29   30   31   32   33   >