On 07/11/2018 19:03, Tom Lane wrote: > Peter Eisentraut <peter.eisentr...@2ndquadrant.com> writes: >> Committed, thanks. > > It seems unfortunate that there is no test coverage in the committed > patch. I realize that it may be hard to test given the filesystem > dependency, but how will we know if it works at all?
You can use something like PG_UPGRADE_OPTS=--clone make -C src/bin/pg_upgrade check (--link is similarly untested.) If we do get the TAP tests for pg_upgrade set up, we can create smaller and faster test cases for this. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
