On 05/04/2018 10:35, Heikki Linnakangas wrote: > On 15/03/18 18:39, Alvaro Herrera wrote: >>> From 517bc6d9fefdee9135857d9562f644f2984ace32 Mon Sep 17 00:00:00 2001 >>> From: Peter Eisentraut<pete...@gmx.net> >>> Date: Sun, 18 Feb 2018 09:33:53 -0500 >>> Subject: [PATCH v1 6/8] Turn transaction_isolation into GUC enum >>> >>> XXX no idea why it was done the way it was, but this seems much simpler >>> and apparently doesn't change any functionality. >> Enums are recent -- 52a8d4f8f7e2, only 10 years old, and the commit >> didn't convert all cases, leaving some for later. Funnily enough, >> default_transaction_isolation was changed afterwards by ad6bf716baa7 but >> not this one ... I guess "later" is now upon us for it. > > With this patch, this stops working: > > set transaction_isolation='default'; > > Other than that, +1 on this patch. I haven't looked closely at the rest > of the patches yet.
Based on this, I have committed this part of the patch series. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
