On 09.03.22 11:29, Pavel Borisov wrote:
I've noticed that check_ok() in pg_upgrade.h has been declared two times.
Here's a one-line patch correcting this.
Fixed, thanks.
On 08.03.22 03:56, Andres Freund wrote:
Attached is v6 of the meson patchset. There are a lots of changes since the
last version posted. These include:
- python2 removal is now committed, so not needed in here anymore
- CI changed to be based on the CI now merged into postgres
- CI also tests sus
On 07.03.22 19:18, Robert Haas wrote:
That all said, permissions SHOULD BE strictly additive. If boss doesn't want
to be a member of pg_read_all_files allowing them to revoke themself from that
role seems like it should be acceptable. If there is fear in allowing someone
to revoke (not add)
A general question on this feature: AFAICT, you can only send the proxy
header once at the beginning of the connection. So this wouldn't be of
use for PostgreSQL-protocol connection poolers (pgbouncer, pgpool),
where the same server connection can be used for clients from different
source addr
t the attached?
From c7b408ba646c5ee5f8c6ae84bec04ca4059ed08f Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Thu, 10 Mar 2022 10:49:49 +0100
Subject: [PATCH] DefineCollation() code cleanup
Reorganize the code in DefineCollation() so that the parts using the
FROM clause and the parts not doing
reviewing later.From 43b0aa50d621f3b640e4285e4e329c361988a6c4 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Thu, 10 Mar 2022 12:02:56 +0100
Subject: [PATCH] fixup! Add support for decoding sequences to built-in
replication
---
src/bin/pg_dump/t/002_pg_dump.pl | 2 +-
src/interfaces/libpq/fe-
On 09.03.22 17:44, Andres Freund wrote:
v6-0009-prereq-make-unicode-targets-work-in-vpath-builds.patch.gz
Another directory issue
I think it's a tad different, in that it's fixing something that's currently
broken in VPATH builds.
Ok, I took another look at this.
-override CPPFLAGS := -DFRON
On 09.03.22 14:02, Robert Haas wrote:
On Wed, Mar 9, 2022 at 7:55 AM Peter Eisentraut
wrote:
Do we have subtractive permissions today?
Not in the GRANT/REVOKE sense, I think, but you can put a user in a
group and then mention that group in pg_hba.conf. And that line might
be "rejec
e thread I commented on some aspects of the new grammar
(e.g., do we need FOR ALL SEQUENCES?). I think this would be useful to
review again after all the new logical replication patches are in. I
don't want to hold up this patch for that at this point.From bdded82050841d3b71308ce821
On Fri, Feb 25, 2022 at 5:52 PM Peter Geoghegan wrote:
> There is an important practical way in which it makes sense to treat
> 0001 as separate to 0002. It is true that 0001 is independently quite
> useful. In practical terms, I'd be quite happy to just get 0001 into
> Postgres
ch locale provider of the
template database (c)
HINT: Use the same locale provider as in the template database, or use
template0 as template.
It feels strange to write "LOCALE_PROVIDER icu" and get "provider (i)" in the
error message. I think it would be better to emit the us
On Thu, Mar 10, 2022 at 5:49 AM Matthias van de Meent
wrote:
> I double-checked the changes, and to me it seems like that was the
> only place in the code where PageGetMaxOffsetNumber was not handled
> correctly. This was fixed in the latest patch (v8).
>
> Peter, would you have
g palloc0() rather than palloc()) makes
sense as a defensive measure. It depends on the specific code, of
course.
--
Peter Geoghegan
derlying
file can change while it is being read.
The requirements of pg_subscriber can be satisfied more easily: Just
call pg_ctl to start the server. You are already using that in
pg_subscriber. Is there a reason it can't be used here as well?From a0ad5fdaddc17ef74594bfd3c65c777649d1544b Mon Sep 17 0
On 14.03.22 19:57, Robert Haas wrote:
1. What will happen if I set the ICU collation to something that
doesn't match the libc collation? How bad are the consequences?
These are unrelated, so there are no consequences.
2. If I want to avoid a mismatch between the two, then I will need a
way
ystem to reach
xidStopLimit due to the target rel's relfrozenxid age crossing the
crucial xidStopLimit crossover point.
This patch makes this problem scenario virtually impossible. Right now
I'm only prepared to say it's very unlikely. I don't see a reason to
take any chances, tho
s now complete from my perspective.From 633d4aa0f762bf976e3ddc077cb9c34b58eeb4d5 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 16 Mar 2022 10:58:17 +0100
Subject: [PATCH v4] pgcrypto: Remove internal padding implementation
Use the padding provided by OpenSSL instead of doing it ourse
On 15.03.22 18:28, Robert Haas wrote:
On Tue, Mar 15, 2022 at 12:58 PM Peter Eisentraut
wrote:
On 14.03.22 19:57, Robert Haas wrote:
1. What will happen if I set the ICU collation to something that
doesn't match the libc collation? How bad are the consequences?
These are unrelated, so
894df74377bbc5aa624626c4e Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 16 Mar 2022 18:24:00 +0100
Subject: [PATCH v4] Make JSON path numeric literals more correct
Per ECMAScript standard (ECMA-262, referenced by SQL standard), the
syntax forms
.1
1.
should be allowed for decimal numeric
On 16.03.22 02:25, Kyotaro Horiguchi wrote:
Hello, this is a derived topic from [1], summarized as $SUBJECT.
This just removes useless hyphens from the words
"(crash|emergency)-recovery". We don't have such wordings for "archive
recovery" This patch fixes non-user-facing texts as well as
user-fa
On 15.03.22 08:41, Julien Rouhaud wrote:
The locale object in ICU is an identifier that specifies a particular locale
and has fields for language, country, and an optional code to specify further
variants or subdivisions. These fields also can be represented as a string
with the fields separated
On 16.03.22 21:27, samay sharma wrote:
The only goal of this patch wasn't to enable support for Azure AD.
That's just one client. Users might have a need to add or change auth
methods in the future and providing that extensibility so we don't need
to have core changes for each one of them would
On 17.03.22 13:01, Shinoda, Noriyoshi (PN Japan FSIP) wrote:
Thank you to all the developers.
I found that the description of the pg_database.daticulocale column was not
written in the documentation.
The attached small patch adds a description of the daticulocale column to
catalogs.sgml.
comm
On 17.03.22 14:12, Aleksander Alekseev wrote:
v19-0001 changes the format string for XIDs from %u to XID_FMT. This
refactoring allows us to switch to UINT64_FORMAT by changing one
#define in the future patches.
Kyotaro suggested using `errmsg("blah blah %lld ..", (long long)
xid)` instead in or
On 16.03.22 19:59, Mark Dilger wrote:
Informally, we often use "GUC" on this list, but that isn't used formally, leaving "configuration parameter" and "setting" as the
two obvious choices. I preferred "configuration parameter" originally and was argued out of it. My take on "setting" was also
On 16.03.22 19:47, Tom Lane wrote:
I'm also fairly allergic to the way that this patch has decided to assign
multi-word names to privilege types (ie SET VALUE, ALTER SYSTEM). There
is no existing precedent for that, and I think it's going to break
client-side code that we don't need to break. I
I notice that the publication.sql regression tests contain a number of
comments like
+-- error: replica identity "a" not included in the column list
+ALTER PUBLICATION testpub_fortable ADD TABLE testpub_tbl5 (b, c);
but the error doesn't actually happen, because of the way the replica
identity
On 12.03.22 17:27, Fabien COELHO wrote:
Are you planning to send a rebased patch for this commit fest?
Argh, I did it in a reply in another thread:-( Attached v15.
So as to help moves things forward, I'd suggest that we should not to
care too much about corner case repetition of some error
On Thu, Mar 17, 2022 at 6:15 AM Peter Eisentraut
wrote:
> committed, thanks
Glad that this finally happened. Thanks to everybody involved!
--
Peter Geoghegan
ou can complete partitioned indexes.From 18ad74bfc2b6d1a758eaab9d2332532f6abb074d Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Fri, 18 Mar 2022 11:44:16 +0100
Subject: [PATCH 1/2] fixup! MERGE SQL Command following SQL:2016
Add back serial commas.
---
doc/src/sgml/libpq.sgml
On 18.03.22 10:27, Julien Rouhaud wrote:
I'm attaching a patch that fixes both issues for me with ICU 50. Note that
there's already a test that would have failed for CREATE DATABASE if initdb
tests didn't fail first, so no new test needed.
I ended up copy/pasting icu_set_collation_attributes()
On Wed, Mar 9, 2022 at 4:46 PM Andres Freund wrote:
> On 2022-03-03 19:31:32 -0800, Peter Geoghegan wrote:
> > Attached is a new revision of my fix. This is more or less a
> > combination of my v4 fix from November 12 [1] and Andres'
> > already-committed fix (commit 18
On 19.03.22 05:14, Julien Rouhaud wrote:
On Fri, Mar 18, 2022 at 03:09:59PM -0700, Andres Freund wrote:
Hi,
On 2022-03-18 20:28:58 +0100, Peter Eisentraut wrote:
Why does your patch introduce a function check_icu_locale() that is only
called once? Did you have further plans for that?
I
On 19.03.22 18:53, Christoph Berg wrote:
Re: Peter Eisentraut
Since some (legacy) code still uses the libc locale facilities
directly, we still need to set the libc global locale settings even if
ICU is otherwise selected. So pg_database now has three
locale-related fields: the existing
y index tuples as a result of avoiding
an FPI. This second idea is also much more general than simply
avoiding FPIs in general.
--
Peter Geoghegan
ed to test 4 branches at once and to try
> to test every branch every 24 hours. Let's see how that goes.
Extravagance!
--
Peter Geoghegan
a very simple method of making the
same information more visible, that you could implement in only a few
minutes. Perhaps that was optimistic.
--
Peter Geoghegan
On 20.03.22 23:55, Tomas Vondra wrote:
Attached is a rebased patch, addressing most of the remaining issues.
This looks okay to me, if the two FIXMEs are addressed. Remember to
also update protocol.sgml if you change LOGICAL_REP_MSG_SEQUENCE.
On 18.03.22 16:14, Maxim Orlov wrote:
Here is v22. It addresses things mentioned by Tom and Kyotaro. Also
added Aleksander's changes from v21.
The v22-0002-Update-XID-formatting-in-the-.po-files.patch is not
necessary. That is done by a separate procedure.
I'm wondering about things like th
ing solutions that focus on limiting the
downside of not setting LP_DEAD bits, which is local information (not
system wide information) that is much easier to understand and target
in the implementation.
--
Peter Geoghegan
On 22.03.22 00:51, Nathan Bossart wrote:
On Wed, Mar 16, 2022 at 11:12:06AM +0100, Peter Eisentraut wrote:
Right, the previous behaviors were clearly faulty. I have updated the
commit message to call out the behavior change more clearly.
This patch is now complete from my perspective.
I
On 21.03.22 22:54, Tomas Vondra wrote:
On 3/21/22 14:05, Peter Eisentraut wrote:
On 20.03.22 23:55, Tomas Vondra wrote:
Attached is a rebased patch, addressing most of the remaining issues.
This looks okay to me, if the two FIXMEs are addressed. Remember to
also update protocol.sgml if you
On 17.03.22 19:04, Fabien COELHO wrote:
Hello Peter,
See attached v16 which removes the libpq workaround.
I suppose this depends on
https://www.postgresql.org/message-id/flat/ab4288f8-be5c-57fb-2400-e3e857f53e46%40enterprisedb.com
getting committed, because right now this makes the
On 17.03.22 19:04, Fabien COELHO wrote:
Indeed! The missing part was put back in v17.
Some unrelated notes on this v17 patch:
-use Test::More;
+use Test::More tests => 41;
The test counts are not needed/wanted anymore.
+
+\set ECHO none
+
This seems inappropriate.
+--
+-- autocommit
+--
On 23.03.22 17:33, Bharath Rupireddy wrote:
It looks like the following errmsg_plural in dependency.c is
unnecessary as numReportedClient > 1 always and numNotReportedClient
can never be < 0. Therefore plural version of the error message is
sufficient. Attached a patch to fix it.
Some languages
On 18.03.22 23:34, Andrew Dunstan wrote:
On 3/15/22 09:51, Peter Eisentraut wrote:
On 21.02.22 13:09, Euler Taveira wrote:
A new tool called pg_subscriber does this conversion and is tightly
integrated
with Postgres.
Are we comfortable with the name pg_subscriber? It seems too general.
Are
On 15.03.22 20:27, samay sharma wrote:
This patch-set adds the following:
* Allow multiple custom auth providers to be registered (Addressing
feedback from Aleksander and Andrew)
* Modify the test extension to use SCRAM to exchange secrets (Based on
Andres's suggestion)
* Add support for custo
On Sun, Mar 13, 2022 at 9:05 PM Peter Geoghegan wrote:
> Attached is v10. While this does still include the freezing patch,
> it's not in scope for Postgres 15. As I've said, I still think that it
> makes sense to maintain the patch series with the freezing stuff,
> s
unter that ends up being printed, there isn't a need to use int64 in
the first place. See attached patch for examples.From 9c5109c32b8702d14e42324cba027ee987df6cd0 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 23 Mar 2022 21:44:48 +0100
Subject: [PATCH] Change some variables to
eft behind by opportunistic pruning. We don't need a
cleanup in either lazy_scan_noprune (a share lock is all we need), nor
do we even need one in lazy_vacuum_heap_page (a regular exclusive lock
is all we need).
--
Peter Geoghegan
On 21.03.22 05:55, Thomas Munro wrote:
[04:30:50.630] pg_waldump.c:963:26: error: format ‘%u’ expects
argument of type ‘unsigned int *’, but argument 3 has type ‘ForkNumber
*’ [-Werror=format=]
[04:30:50.630] 963 | if (sscanf(optarg, "%u",
&config.filter_by_relation_forknum) != 1 ||
[04:30:50.630
ably 50 million XIDs behind
OldestXmin, the vacuum_freeze_min_age default). I don't see much
difference.
Anyway, this isn't important. I'll just drop the third patch.
--
Peter Geoghegan
making
relfrozenxid advancement unsafe.
It would be great if you could take a look v11-0002-*, Robert. Does it
make sense to you?
Thanks
--
Peter Geoghegan
On 23.03.22 10:51, Maxim Orlov wrote:
Thanks for updating the patchs. I have a little comment on 0002.
+ errmsg_internal("found xmax %llu" "
(infomask 0x%04x) not frozen, not multi, not normal",
+
hing.
Generational garbage collection influenced this work, too. It also
applies pragmatic assumptions about where garbage is likely to appear.
Assumptions that are based on nothing more than empirical observations
about what is likely to happen in the real world, that are validated
ct example of the kind of hardening that makes
sense to me. Clearly this kind of failure is a reasonably plausible
scenario (probably even a known real world scenario with catalog
corruption), and clearly we could do something about it that's pretty
simple and obviously low risk. It easily meets the standard that I
might apply here.
--
Peter Geoghegan
On 2020-11-30 22:15, Pavel Stehule wrote:
I would like some supporting documentation on this. So far we only
have
one stackoverflow question, and then this implementation, and they are
not even the same format. My worry is that if there is not precise
specification, then peo
r removing top-level SELECT INTO
altogether, but there is a nontrivial amount of code for handling it, so
there would be some gain if it could be removed eventually.
From a3ae4248340317ac1580c257472e1361841bd4b2 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 2 Dec 2020 12:09:39 +0100
x27;t specifically look for them.
From 05e5cf58e66072202707c6fddcd59768a26039be Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 2 Dec 2020 13:16:15 +0100
Subject: [PATCH] Convert elog(LOG) calls to ereport() where appropriate
User-visible log messages should go through ereport(), so the
tting
DYLD_LIBRARY_PATH, but the tests still work. Verification on other
system variantions welcome, of course.
Comments welcome. I think this direction is promising, but some details
need to be addressed.
From 28f2f9fc2234e3d993027fb014f1c85f7b3db6be Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: W
ase just git apply
--reverse that one if it is causing a problem.
Sorry for any inconvenience. I will add the missing functionality to
0009 as soon as I can.
Kind Regards,
Peter Smith.
Fujitsu Australia
On 2020-11-30 16:32, Alvaro Herrera wrote:
On 2020-Nov-30, Peter Eisentraut wrote:
Patch updated this way. I agree it's better that way.
Thanks, LGTM.
For a change like this, do we need to change the C symbol names, so that
there is no misbehavior if the shared library is not updat
been introduced by the original logical replication
patch, so there probably wasn't that much scrutiny on this detail then.
From 311f3c7e40b47ace182f1ad5e39a6a12ae80d23c Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Thu, 3 Dec 2020 10:40:57 +0100
Subject: [PATCH] Remove unnecessary gr
On 2020-12-02 18:58, Stephen Frost wrote:
I also found some gratuitous uses of SELECT INTO in various tests and
documentation (not ecpg or plpgsql of course). Here is a patch to adjust
those to CREATE TABLE AS.
If we aren't actually removing SELECT INTO then I don't know that it
makes sense to
On 2020-12-03 00:54, Michael Paquier wrote:
I got to wonder about the impact when migrating applications
though. SELECT INTO has a different meaning in Oracle, but SQL server
creates a new table like Postgres.
Interesting. This appears to be the case. SQL Server uses SELECT INTO
to create a
On 2020-12-02 23:13, Thomas Munro wrote:
I'm experimenting with Github's built in CI. All other ideas welcome.
You can run Linux builds on AppVeyor, too.
On 2020-12-03 16:34, Tom Lane wrote:
As I recall, a whole lot of the pain we have with INTO has to do
with the semantics we've chosen for INTO in a set-operation nest.
We think you can write something like
SELECT ... INTO foo FROM ... UNION SELECT ... FROM ...
but we insist on the INTO bein
A side comment on this patch: I think using enums as bit mask values is
bad style. So changing this:
-/* Reindex options */
-#define REINDEXOPT_VERBOSE (1 << 0) /* print progress info */
-#define REINDEXOPT_REPORT_PROGRESS (1 << 1) /* report pgstat progress */
-#define REINDEXOPT_MISSING_OK (1
On Thu, Dec 3, 2020 at 6:21 PM Peter Smith wrote:
> Sorry for any inconvenience. I will add the missing functionality to
> 0009 as soon as I can.
>
PSA a **replacement** patch for the previous v29-0009.
This should correct the recently reported trouble [1]
[1] =
https://www.postg
On 2020-12-02 15:04, Alvaro Herrera wrote:
- elog(LOG, "WSAIoctl(SIO_KEEPALIVE_VALS) failed: %ui",
-WSAGetLastError());
+ ereport(LOG,
+ (errmsg("WSAIoctl(SIO_KEEPALIVE_VALS) failed:
%ui",
+
On 2020-12-03 08:02, Michael Paquier wrote:
+ else
+ ereport(LOG,
+ (errmsg("checkpoint starting:%s%s%s%s%s%s%s%s",
Would it be better to add a note for translators here, in short that
all those %s are options related to checkpoint/restartpoints?
done
The ones in geqo_e
On 2020-12-03 08:55, Noah Misch wrote:
For the changes I didn't mention explicitly (most of them), I'm -0.5. Many of
them "can't happen", use source code terms of art, and/or breach guideline
"Avoid mentioning called function names, either; instead say what the code was
trying to do" (https://ww
w that I'll
be *far* more likely to use it if I don't have to waste time and
energy on that aspect every single time.
--
Peter Geoghegan
lse, but for me this is only a very small
inconvenience. Whereas the convenience of not having to think about
the performance impact seems huge.
--
Peter Geoghegan
maps used in memory (e.g., for parsing or
specific function APIs), where the actual bits don't really matter.
Bits that might go on disk weren't touched. There, defining the bits in
a more concrete way seems better.
From 21f7512bb37068e6a8f72d87d4cf31602ce78d9a Mon Sep 17 00:00:00 2001
gle tx with a temporary
slot as per current code
- Then the "apply" worker would be the *only* worker that actually
applies anything. (as its name suggests)
Thoughts?
---
Kind Regards,
Peter Smith.
Fujitsu Australia
6eabfa8145 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Mon, 7 Dec 2020 10:38:36 +0100
Subject: [PATCH] Change get_constraint_index() to use pg_constraint.conindid
It was still using a scan of pg_depend instead of using the conindid
column that has been added since.
---
src/backe
On 2020-10-03 08:40, Peter Eisentraut wrote:
Since we have ADD PRIMARY KEY USING INDEX, we can declare a primary key
for an existing index. So this doesn't have to affect the low-level
early bootstrapping. The attached patch adds those commands manually.
Another option might be to hav
On Mon, Dec 7, 2020 at 2:05 AM Andrey Borodin wrote:
> Here's version with tests and docs. I still have no idea how to print some
> useful information about tuples keys.
I suggest calling BuildIndexValueDescription() from your own custom
debug instrumentation code.
--
Peter Geoghegan
On 2020-12-07 18:53, Stephen Frost wrote:
* Michael Paquier (mich...@paquier.xyz) wrote:
On Sun, Dec 06, 2020 at 10:03:08AM -0500, Stephen Frost wrote:
* Alvaro Herrera (alvhe...@alvh.no-ip.org) wrote:
You keep making this statement, and I don't necessarily disagree, but if
that is the case, p
/message-id/flat/CAMGcDxeqEpWj3fTXwqhSwBdXd2RS9jzwWscO-XbeCfso6ts3%2BQ%40mail.gmail.com
---
Kind Regards,
Peter Smith.
Fujitsu Australia
## Not patched
2020-12-07 17:03:45.237 AEDT [26325] LOG: !!>> apply worker: called
process_syncing_tables
2020-12-07 17:03:46.237 AEDT [26325] LOG: !!&g
On 2020-12-09 07:37, Michael Paquier wrote:
Only thing I could think of is that it maybe could use a (small)
comment in the message on that/why get_constraint_index is moved to
utils/lsyscache from catalog/dependency, as that took me some time to
understand.
commit message could reasonably say
On 2020-12-03 20:26, Peter Eisentraut wrote:
On 2020-12-03 16:34, Tom Lane wrote:
As I recall, a whole lot of the pain we have with INTO has to do
with the semantics we've chosen for INTO in a set-operation nest.
We think you can write something like
SELECT ... INTO foo FROM ...
On Tue, Dec 8, 2020 at 9:14 PM Amit Kapila wrote:
>
> On Tue, Dec 8, 2020 at 11:53 AM Peter Smith wrote:
> >
> > Yes, I observed this same behavior.
> >
> > IIUC the only way for the tablesync worker to go from CATCHUP mode to
> > SYNCDONE is via the call t
On 2020-06-24 20:21, Peter Eisentraut wrote:
On 2020-06-24 10:12, Vik Fearing wrote:
On 6/24/20 8:35 AM, Peter Eisentraut wrote:
I was checking some loose ends in SQL conformance, when I noticed: We
support GRANT role ... GRANTED BY CURRENT_USER, but we don't support
CURRENT_ROLE in that
Many older tests where written in a style like
SELECT '' AS two, i.* FROM INT2_TBL ...
where the first column indicated the number of expected result rows.
This has gotten increasingly out of date, as the test data fixtures
have expanded, so a lot of these don't match anymore and are mislead
On 2020-12-05 02:30, Michael Paquier wrote:
On Fri, Dec 04, 2020 at 04:28:26PM -0300, Alvaro Herrera wrote:
FWIW I'm with Peter on this.
Okay, attached is a patch to adjust the enums for the set of utility
commands that is the set of things I have touched lately. Should that
be extended
the attached patch, and avoid the bit fiddling altogether.
From d3125b3bfb8a3dc23e38f38bcf850ca6fc36f492 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Sat, 12 Dec 2020 09:17:55 +0100
Subject: [PATCH] Convert reindex options to struct
---
src/backend/catalog/index.c | 19 ---
src
make it
a little more obvious. Still requires touching a lot of calls.
I think this sounds best, and also expand the documentation of these
flags a bit.
--
Peter Eisentraut
2ndQuadrant, an EDB company
https://www.2ndquadrant.com/
direction of simplification,
it should not make this other important task harder.
--
Peter Geoghegan
On Thu, Dec 10, 2020 at 8:49 PM Peter Smith wrote:
> So I will try to write a patch for the proposed Solution-1.
>
Hi Amit.
FYI, here is my v3 WIP patch for the Solution1.
This patch applies onto the v30 patch set [1] from the other 2PC thread:
[1]
https://www.postgresql.org/mess
rsion.
--
Peter Eisentraut
2ndQuadrant, an EDB company
https://www.2ndquadrant.com/
>From b40213b0d31b8ac55cda4658c21d06e701b6e273 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Tue, 15 Dec 2020 14:27:58 +0100
Subject: [PATCH v4] Change return type of EXTRACT to numeric
The previous implement
On 2020-12-15 23:13, Bruce Momjian wrote:
Do we really want to carry around confusing syntax for compatibility? I
doubt we would ever add INTO now, even for compatibility.
Right, we would very likely not add it now. But it doesn't seem to
cause a lot of ongoing maintenance burden, so if ther
[0]:
https://www.postgresql.org/message-id/flat/42b73d2d-da12-ba9f-570a-420e0cce1...@phystech.edu
From 4b9f7e7d46d26f2c163abdfbb40dabcb6d2927e9 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 16 Dec 2020 18:08:57 +0100
Subject: [PATCH] Change seconds argument of make_*() functions to nu
n via the storage parameter (presumably due to the
performance trade-off somehow not seeming useful), they cannot expect
to get back to an on-disk representation without posting list tuples,
unless and until they REINDEX.
--
Peter Geoghegan
ible downside. Even still, I think that adding
new rules is subject to sharp diminishing returns. There just aren't
that many things that work like that.
--
Peter Geoghegan
ent that
*some* combination of these two ideas (or other ideas) will work very
well. Right now we don't have the appropriate general framework.
> Any thoughts?
Nothing to add to what you said, really. I agree that it makes sense
to think of all of these things at the same time.
It'll be easier to see how far these different ideas can be pushed
once a prototype is available.
> I'm writing a PoC patch so will share it.
Great! I suggest starting a new thread for that.
--
Peter Geoghegan
DropSubscription. So this might be a problem to cleanup slots
and/or origin tracking belonging to those unknown workers.
* help / comments / cleanup
* There is temporary "!!>>" excessive logging of mine scattered around
which I added to help my testing during development
---
Kind Rega
On Wed, Dec 9, 2020 at 5:12 PM Peter Geoghegan wrote:
> Most of the real changes in v11 (compared to v10) are in heapam.c.
> I've completely replaced the table_compute_xid_horizon_for_tuples()
> interface with a new interface that supports all existing requirements
> (from ind
orks because GetTransactionSnapshot() will already have been called
> somewhere, before EnterParallelMode()?
It seems unlikely that InitializeParallelDSM() was ever intended to be
run in a background worker.
--
Peter Geoghegan
101 - 200 of 10890 matches
Mail list logo
