On Wed, Mar 23, 2022 at 1:53 PM Robert Haas <robertmh...@gmail.com> wrote: > I see what you mean about it depending on how you define "skipping". > But I think that DISABLE_PAGE_SKIPPING is intended as a sort of > emergency safeguard when you really, really don't want to leave > anything out.
I agree. > And therefore I favor defining it to mean that we don't > skip any work at all. But even today DISABLE_PAGE_SKIPPING won't do pruning when we cannot acquire a cleanup lock on a page, unless it happens to have XIDs from before FreezeLimit (which is probably 50 million XIDs behind OldestXmin, the vacuum_freeze_min_age default). I don't see much difference. Anyway, this isn't important. I'll just drop the third patch. -- Peter Geoghegan
