On Thu, Dec 3, 2020 at 6:21 PM Peter Smith <smithpb2...@gmail.com> wrote: > Sorry for any inconvenience. I will add the missing functionality to > 0009 as soon as I can. >
PSA a **replacement** patch for the previous v29-0009. This should correct the recently reported trouble [1] [1] = https://www.postgresql.org/message-id/CAD21AoBnZ6dYffVjOCdSvSohR_1ZNedqmb%3D6P9w_H6W0bK1s6g%40mail.gmail.com I observed after this patch: make check is all OK. cd src/test/subscription, then make check is all OK. ~ Note that the tablesync worker's (temporary) slot always uses two_phase *off*, regardless of the user setting. e.g. CREATE SUBSCRIPTION tap_sub CONNECTION 'host=localhost dbname=test_pub application_name=tap_sub' PUBLICATION tap_pub WITH (streaming = on, two_phase = on); will show in the logs that only the apply worker slot enabled the two_phase. STATEMENT: START_REPLICATION SLOT "tap_sub" LOGICAL 0/0 (proto_version '2', streaming 'on', two_phase 'on', publication_names '"tap_pub"') STATEMENT: START_REPLICATION SLOT "tap_sub_16395_sync_16385" LOGICAL 0/16076D8 (proto_version '2', streaming 'on', publication_names '"tap_pub"') --- Kind Regards, Peter Smith. Fujitsu Australia
v29-0009-Support-2PC-txn-Subscription-option.patch
Description: Binary data
