On 2020-12-03 08:55, Noah Misch wrote:
For the changes I didn't mention explicitly (most of them), I'm -0.5. Many of them "can't happen", use source code terms of art, and/or breach guideline "Avoid mentioning called function names, either; instead say what the code was trying to do" (https://www.postgresql.org/docs/devel/error-style-guide.html).
Thanks for the detailed feedback. I dialed back some of the changes based on your feedback.
