Re: nitpick about poor style in MergeAttributes

2019-05-23 Thread Mark Dilger
On Thu, May 23, 2019 at 5:24 PM Michael Paquier wrote: > > On Thu, May 23, 2019 at 08:27:19AM -0700, Mark Dilger wrote: > > On Thu, May 23, 2019 at 7:54 AM Tom Lane wrote: > >> Are we sure that's not just a newly-introduced bug, ie it has not > >> been te

Nitpick about assumptions in indexam and tableam

2019-05-24 Thread Mark Dilger
e_snapshot, so the fact that table_scan_update_snapshot then ignores the return value of RegisterSnapshot on that snapshot happens to be ok. If some other code were changed to call this function, it is not clear that it would work out so well. I propose that attached patch. mark snapshot.patch.1 Description: Binary data

Re: Zedstore - compressed in-core columnar storage

2019-05-24 Thread Mark Kirkwood
good improvement in load times and on disk footprint! Also note that I did not build with lz4 so looks like you guys have fixed the quirks with compression making things bigger. regards Mark

Re: [HACKERS] removing abstime, reltime, tinterval.c, spi/timetravel

2018-10-09 Thread Mark Dilger
o expire them to avoid breaking pg_upgrade and such? Retiring built-in types and functions seems rare enough that I've not seen how this is handled before. mark

Re: "SELECT ... FROM DUAL" is not quite as silly as it appears

2018-11-28 Thread Mark Dilger
The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: not tested Spec compliant: not tested Documentation:not tested Patch applies cleanly on master (b238527664ec6f6c9d00dba4cc2f3dab1c8b8b04

Re: "SELECT ... FROM DUAL" is not quite as silly as it appears

2018-11-28 Thread Mark Dilger
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: not tested Spec compliant: not tested Documentation:not tested Sorry about the prior review; I neglected to select all the appropriate

Re: pgbench - allow to specify scale as a size

2018-02-19 Thread Mark Wong
ata file sizes due to any architecture specific nuances or changes in the backend. But perhaps it might still offer a little more meaning to be able to say "50 gigabytes of bank account data" rather than "10 million rows of bank accounts" when thinking about size over cardinality. Regards, Mark -- Mark Wonghttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, RemoteDBA, Training & Services

Re: Changing default value of wal_sync_method to open_datasync on Linux

2018-02-19 Thread Mark Kirkwood
changed from its default replica to minimal and max_wal_senders must be set to 0 for O_DIRECT to be used. I think the use of 'nobarrier' is probably disabling most/all reliable writing to the devices. What do the numbers look like if use remove this option? regards Mark

Re: [HACKERS] Constifying numeric.c's local vars

2018-02-21 Thread Mark Dilger
to a server crash, at least on some architectures with some compilers. The idea that set_var_from_var might be called on const_zero (or const_one, etc.) is not hypothetical. It is being done in numeric.c. If this is safe, somebody needs to be a lot clearer about why that is so. There are no

Re: [HACKERS] Constifying numeric.c's local vars

2018-02-21 Thread Mark Dilger
> This patch got committed as c1898c3e1e235ae35b4759d233253eff221b976a > on Sun Sep 10 16:20:41 2017 -0700, but I've only just gotten around to > reviewing it. > > I believe this is wrong and should be reverted, at least in part. > > The NumericVar struct has the field 'digits' as non-const: >

Re: [HACKERS] PATCH: multivariate histograms and MCV lists

2018-02-24 Thread Mark Dilger
atches applied against postgres 10 sources with good results. mark

Re: [HACKERS] PATCH: multivariate histograms and MCV lists

2018-02-24 Thread Mark Dilger
ompare_scalars_simple rather than hardcoding the logic directly. mark

Re: zheap: a new storage format for PostgreSQL

2018-03-01 Thread Mark Kirkwood
and for PG 12. If he held onto the patches and waited - he'd get criticism of the form "you should have given a heads up earlier...". This is earlier :-) Best wishes Mark P.s: awesome work.

Re: [GSOC 18] Performance Farm Project

2018-03-02 Thread Mark Wong
better > visual effects? I prefer to keep things simple by not having any javascript, but I am open to being swayed otherwise by the potential consumers of this data. Regards, Mark -- Mark Wonghttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, RemoteDBA, Training & Services

Re: [GSOC 18] Performance Farm Project

2018-03-02 Thread Mark Wong
list page. That would probably help provide some context. I'll see what I can do about that... I've touched base with the pginfra team about hosting the Web site and database so I think I have that aspect covered. Regards, Mark > -- > Robert Haas > EnterpriseDB: http://ww

Re: zheap: a new storage format for PostgreSQL

2018-03-02 Thread Mark Kirkwood
telling people 'you can do it another way to' to avoid bloat - I guess it seems to be more intuitive to just to do it as described). regards Mark

Re: [GSOC 18] Discussion on the datatable

2018-03-07 Thread Mark Wong
Hi Hongyuan, On Tue, Mar 06, 2018 at 01:36:23AM +0800, Hongyuan Ma wrote: > Hi Mark, > In the past few days I have read some code in pgperffarm.git repository.I > look forward to discussing the project in detail with you and gradually > defining the datasheet structure and

Re: [HACKERS] PATCH: multivariate histograms and MCV lists

2018-03-10 Thread Mark Dilger
class AND objoid = i.indexrelid AND c.oid = i.indexrelid AND i.indrelid = 'ctlt_all'::regclass ORDER BY c.relname, objsubid; relname | objsubid | description Otherwise, perhaps you could include a comment about why STATS_EXT_MCV and STATS_EXT_HISTOGRAM are not handled in this case. mark

Re: [HACKERS] PATCH: multivariate histograms and MCV lists

2018-03-11 Thread Mark Dilger
are: d for n-distinct statistics, -f for functional dependency statistics +f for functional dependency statistics, +m for most common values (mcv) statistics, and +h for histogram statistics mark

Re: Re: Re: [GSOC 18] Performance Farm Project——Initialization Project

2018-03-14 Thread Mark Wong
just the default > > ''' > > Will PerfFarm have many test items so that the test item search function > > or even the test item sort function is expected to be provided? > > > > I don't know - Tomas or Mark are probably the best folks to ask about that

Re: Guiding principle for dropping LLVM versions?

2024-01-25 Thread Mark Wong
up the 4 or 6 under my name... Regards, Mark

Re: Should we remove -Wdeclaration-after-statement?

2024-01-29 Thread Mark Dilger
> On Jan 29, 2024, at 7:03 AM, Jelte Fennema-Nio wrote: > > So my suggestion is for people to respond with -1, -0.5, +-0, +0.5, or > +1 to indicate support against/for the change. -1 for me. -Infinity for refactoring the entire codebase and backpatching. — Mark Dilger Enterp

Re: Should we remove -Wdeclaration-after-statement?

2024-01-29 Thread Mark Dilger
> On Jan 29, 2024, at 7:35 AM, Isaac Morland wrote: > > On Mon, 29 Jan 2024 at 10:31, Mark Dilger > wrote: > > -Infinity for refactoring the entire codebase and backpatching. > > I don't think anybody is proposing re-working the existing codebase. I >

Re: Non-superuser subscription owners

2023-02-22 Thread Mark Dilger
still preventing either party from hijacking privileges of the other. — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Non-superuser subscription owners

2023-02-22 Thread Mark Dilger
> On Feb 22, 2023, at 10:49 AM, Jeff Davis wrote: > > On Wed, 2023-02-22 at 09:27 -0800, Mark Dilger wrote: >> Another option is to execute under the intersection of their >> privileges, where both the definer and the invoker need the >> privileges in order for t

Re: HOT chain validation in verify_heapam()

2023-03-07 Thread Mark Dilger
ges a bit. > > - Assorted cosmetic and comment changes. > > I think this is easier to follow and more nearly correct, but what do > you (and others) think? Thanks, Robert. Quickly skimming over this patch, it looks like something reviewable. Your changes to t/004_verify_heapam

Re: BUG: Postgres 14 + vacuum_defer_cleanup_age + FOR UPDATE + UPDATE

2023-03-09 Thread Mark Dilger
EZE shaves 10-12% off the tests. I didn't > change that, but we also fire off a psql for each tuple for heap_page_items(), > with offset $N no less. That seems to be another 500ms. I don't recall the reasoning. Feel free to optimize the tests. — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Transparent column encryption

2023-03-11 Thread Mark Dilger
ondering if you had a particular client use case in mind when you added this block? The new function pg_encrypted_in() appears totally untested, but I have to wonder if that's because we're not round-trip testing pg_dump with column encryption...? The code coverage in pg_dump looks fai

Re: BUG: Postgres 14 + vacuum_defer_cleanup_age + FOR UPDATE + UPDATE

2023-03-11 Thread Mark Dilger
ike > use constant ROWCOUNT => 17; > so I just made it a variable. Seems fair. I certainly don't mind. — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

FW: uuid-ossp source or binaries for Windows

2023-03-16 Thread Mark Hill
installed. The uuid-ossp source located here: ftp://ftp.ossp.org/pkg/lib/uuid/uuid-1.6.2.tar.gz is Unix-specific. Is there uuid-ossp source download for Windows or are uuid-ossp prebuilt binaries for Windows available? Thanks, Mark -Original Message----- From: Mark Hill Sent: Wednesday

Re: real/float example for testlibpq3

2023-03-21 Thread Mark Wong
On Mon, Mar 20, 2023 at 01:37:57PM -0400, Gregory Stark (as CFM) wrote: > On Mon, 23 Jan 2023 at 11:54, Mark Wong wrote: > fficient way to communicate useful information. > > > > Yeah, I will try to cover all the data types we ship. :) I'll keep at > > it and d

Re: running logical replication as the subscription owner

2023-03-24 Thread Mark Dilger
icious content into the publication. I think you are focused on all the bad actors on the subscription-side database and what they can do to each other. That's also valid, but I get the impression that you're losing sight of the risk posed by malicious publishers. Or maybe you ar

Re: running logical replication as the subscription owner

2023-03-24 Thread Mark Dilger
f a privilege deescalation than a privilege escalation, so where's the risk? That's not a rhetorical question. Is there a risk here? Or are we just concerned that most users will set up replication with superuser or some other high-privilege user, and we're trying to protect them from the consequences of that choice? — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: BitmapHeapScan streaming read user and prelim refactoring

2024-02-13 Thread Mark Dilger
synchronous feedback per block. Thus, this table AM function > must change its meaning. > > I think the way the patches are split up could be improved. I will > think more about this. There are also probably a few mistakes with > which comments are updated in whi

Re: BitmapHeapScan streaming read user and prelim refactoring

2024-02-14 Thread Mark Dilger
oes implement those two functions and does use the TBMIterateResult *tbmres argument, yes. I would deal with the issue in very much the same way that your patches modify heapam. I don't really have any additional comments about that. — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: BUG: Postgres 14 + vacuum_defer_cleanup_age + FOR UPDATE + UPDATE

2023-01-09 Thread Mark Dilger
id 0 gets used. Thanks — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: BUG: Postgres 14 + vacuum_defer_cleanup_age + FOR UPDATE + UPDATE

2023-01-09 Thread Mark Dilger
he > amcheck/pg_amcheck tests. Ok, I can confirm that. I find the assertion Assert(epoch != (uint32)-1); a bit simpler to reason about, but either way, I agree it is a bug. Thanks for finding this. — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Transparent column encryption

2023-01-10 Thread Mark Dilger
e such "salt"ing (again, maybe the wrong word) because I'm just trying to discuss the general feature, not get into the weeds about which cryptographic algorithm to select. Thoughts? — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Transparent column encryption

2023-01-10 Thread Mark Dilger
> On Jan 10, 2023, at 9:26 AM, Mark Dilger wrote: > >-- Cryptographically connected to the encrypted record >patient_id BIGINT NOT NULL, >patient_ssn CHAR(11), > >-- The encrypted record >patient_record TEXT ENCRYPTED WITH (colu

Re: real/float example for testlibpq3

2023-01-13 Thread Mark Wong
ed to get aggressive, we could move most of the nitpicky details > about datatype text formatting (e.g., the array quoting rules) there too. > I'm not set on that, but it'd make datatype.sgml smaller which could > hardly be a bad thing. > > > I suppose figuring out exactly wh

Re: Non-superuser subscription owners

2023-01-18 Thread Mark Dilger
ckly switched my focus elsewhere. > , and (b) what people think of (1)-(3) above There are different ways of solving (1), and Jeff and I discussed them in Dec 2021. My recollection was that idea (3) was the cleanest. Other ideas might be simpler than (3), or they may just appear simpler bu

Re: Non-superuser subscription owners

2023-01-18 Thread Mark Dilger
do, because at some point in the future we might extend what things are allowed in that string, and we have to keep everything that contemplates that string in sync. I may have been overly hesitant to tackle that problem. Or maybe I just ran short of round tuits. — Mark Dilger

Re: [PATCH] Allow Postgres to pick an unused port to listen

2023-04-12 Thread Mark Dilger
e server itself, all the test infrastructure can use a single, shared solution. As for the implementation, I just briefly scanned the patch. — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

benchmark results comparing versions 15.2 and 16

2023-05-05 Thread MARK CALLAGHAN
ibench.beelink.pg16b.1u.1tno.1g/all.html#summary r5) 4 tables, 4 clients - https://mdcallag.github.io/reports/23_05_04_ibench.beelink.pg16b.4u.1tno.1g/all.html#summary r6) 1 table, 4 clients - https://mdcallag.github.io/reports/23_05_04_ibench.beelink.pg16b.4u.1tyes.1g/all.html#summary --

Re: benchmark results comparing versions 15.2 and 16

2023-05-05 Thread MARK CALLAGHAN
in <= 16G. But that is a problem for another day. The IPS vs time graphs are not a flat line, but I am not ready to pursue that as problem unless it shows multi-second write-stalls (fortunately it does not). -- Mark Callaghan mdcal...@gmail.com

Re: benchmark results comparing versions 15.2 and 16

2023-05-09 Thread MARK CALLAGHAN
On Fri, May 5, 2023 at 10:01 PM MARK CALLAGHAN wrote: > I have two more runs of the benchmark in progress so we will have 3 > results for each of the test cases to confirm that the small regressions > are repeatable. > They get similar results. Then I tried Linux perf but the hiera

Re: Large files for relations

2023-05-12 Thread MARK CALLAGHAN
t; anyway, right?), but perhaps that could depend on a GUC. Likewise for > base backup. Etc. Then someone concerned about hitting the 16TB > limit on ext4 could opt out. Or something like that. It seems funny > though, that's exactly the user who should want this feature (they > have 16,000 relation segment files). > > > -- Mark Callaghan mdcal...@gmail.com

Re: Granting SET and ALTER SYSTE privileges for GUCs

2022-03-24 Thread Mark Dilger
> On Mar 24, 2022, at 12:06 PM, Andrew Dunstan wrote: > > > On 3/24/22 12:49, Mark Dilger wrote: >> >>> On Mar 17, 2022, at 8:41 AM, Andrew Dunstan wrote: >>> >>> If we abandoned that for this form of GRANT/REVOKE I think we could >>&g

Re: pg14 psql broke \d datname.nspname.relname

2022-03-25 Thread Mark Dilger
s trying to use regular expression characters in a place where they > are not allowed to do that. I argue that we should instead just be > comparing "}" against the database name and see whether it happens to > match. I think your change is fine, so I've rolled it int

Re: Granting SET and ALTER SYSTE privileges for GUCs

2022-03-28 Thread Mark Dilger
ER SYSTEM, but I'm not sure there's much point in that. How about putting them under src/test/modules/unsafe_tests ? — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Granting SET and ALTER SYSTE privileges for GUCs

2022-03-28 Thread Mark Dilger
her GRANT/REVOKE operation calls such a hook. I think ALTER DEFAULT PRIVILEGES does, though that's not quite the same thing. I don't have a strong opinion on this. Joshua, what's your take? — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Granting SET and ALTER SYSTE privileges for GUCs

2022-03-28 Thread Mark Dilger
27;ll let you make the change. I don't see a problem with what you are proposing. — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Granting SET and ALTER SYSTE privileges for GUCs

2022-03-30 Thread Mark Dilger
s v15. We should review the conversation from December and January which included some arguments for allowing revokes of SET on USERSET from PUBLIC. I don't want to keep going around in circles on this. — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Granting SET and ALTER SYSTE privileges for GUCs

2022-03-30 Thread Mark Dilger
> On Mar 30, 2022, at 6:59 AM, Mark Dilger wrote: > > We should review the conversation from December and January which included > some arguments for allowing revokes of SET on USERSET from PUBLIC. I don't > want to keep going around in circles on this. Hmm, I guess t

Re: Granting SET and ALTER SYSTE privileges for GUCs

2022-04-04 Thread Mark Dilger
> On Apr 4, 2022, at 8:36 AM, Tom Lane wrote: > > Mark Dilger writes: >> If we want to backtrack to v8, that's fine. I can rebase that, port >> some of the other changes from v14 to it, and repost it as v15. > > Are you working on that? I've set as

Re: New Object Access Type hooks

2022-04-04 Thread Mark Dilger
> On Mar 21, 2022, at 10:03 PM, Thomas Munro wrote: > > On Fri, Mar 18, 2022 at 4:22 PM Mark Dilger > wrote: >> (FYI, I got a test failure from src/test/recovery/t/013_crash_restart.pl >> when testing v1-0001. I'm not sure yet what that is about.) > >

Re: Run pg_amcheck in 002_pg_upgrade.pl and 027_stream_regress.pl?

2022-04-04 Thread Mark Dilger
o this in the postgres 15 development cycle. Alas, that did not happen. Worse, I have several other projects that will keep me busy for the next few months, at least. — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: New Object Access Type hooks

2022-04-04 Thread Mark Dilger
d and not yet restarted, won't things go off the rails? I'm writing a parallel test just for this. Will get back to you. — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: New Object Access Type hooks

2022-04-04 Thread Mark Dilger
ou just got this failure, could you look in the log to > see if there's a pump_until report? I was running `make -j12 check-world` against my local patched version of master: commit 80399fa5f208c4acd4ec194c47e534ba8dd3ae7c (HEAD -> 0001) Author: Mark Dilger Date: Mon Mar 28 13:35:11

Re: New Object Access Type hooks

2022-04-04 Thread Mark Dilger
> On Apr 4, 2022, at 11:07 AM, Tom Lane wrote: > > I was hoping to see regress_log_013_crash_restart, though. regress_log_013_crash_restart Description: Binary data — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: New Object Access Type hooks

2022-04-04 Thread Mark Dilger
> On Apr 4, 2022, at 10:44 AM, Mark Dilger wrote: > > I'm writing a parallel test just for this. Will get back to you. Ok, that experiment didn't accomplish anything, beyond refreshing my memory regarding Cluster.pm preferring sockets over ports. — Mark Dilger

Re: New Object Access Type hooks

2022-04-04 Thread Mark Dilger
ceive data from server" from pqsecure_raw_read()? It's a bit hard to prove to myself which paths might be followed through this code. Thoughts? — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: New Object Access Type hooks

2022-04-04 Thread Mark Dilger
not libpq behavior, so I'm inclined > to just make it lax. +1. I've gotten this test failure only a few times in perhaps the last six months, so if we narrow the opportunity for test failure without closing it entirely, we're just making the test failures that much harder to

Re: Granting SET and ALTER SYSTE privileges for GUCs

2022-04-04 Thread Mark Dilger
ng a catalog search. > > Thoughts? That sounds right. Do you already have something like that coded, or would you like me to post a patch? — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Granting SET and ALTER SYSTE privileges for GUCs

2022-04-04 Thread Mark Dilger
> On Apr 4, 2022, at 5:12 PM, Tom Lane wrote: > > Wrote it already, no need for you to do it. Thanks! — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: pg14 psql broke \d datname.nspname.relname

2022-04-06 Thread Mark Dilger
ccomplish the same thing > with less code? We don't *quite* want the literal left string. If it is quoted, we still want the quotes removed. For example: \d "robert.haas".accounts.acme needs to return robert.haas (without the quotes) as the database name. Likewise, for em

buildfarm failures, src/test/recovery

2022-04-06 Thread Mark Dilger
GED TABLE test_parallel_jsonb_value AS +CREATE TABLE test_parallel_jsonb_value AS SELECT i::text::jsonb AS js FROM generate_series(1, 50) i; — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: How about a psql backslash command to show GUCs?

2022-04-06 Thread Mark Dilger
as been revoked. So yes, +1 from me. — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: trigger example for plsample

2022-04-06 Thread Mark Wong
On Thu, Mar 10, 2022 at 06:36:44PM -0500, Chapman Flack wrote: > On 03/02/22 15:12, Mark Wong wrote: > > > I've attached v2, which reduces the output: > > > > * Removing the notices for the text body, and the "compile" message. > > * Replaced the not

Re: How about a psql backslash command to show GUCs?

2022-04-06 Thread Mark Dilger
ot a "config". If we're going to use a single letter, I'd prefer /p/. — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: trigger example for plsample

2022-04-07 Thread Mark Wong
On Thu, Apr 07, 2022 at 10:30:13AM -0400, c...@anastigmatix.net wrote: > On 2022-04-06 16:44, Mark Wong wrote: > > I think I've applied all of these suggestions and attached a new patch. > > That looks good to me, though I wonder about the pfree(source). > In the simplest

Re: How about a psql backslash command to show GUCs?

2022-04-07 Thread Mark Dilger
the build configuration (as in the "pg_config" tool), text search configuration, etc. While grep'ing through doc/src/sgml, I see no instances of "conf" ever referring to configuration parameters. It only ever refers to configuration files. I'd prefer not adding it to the list of synonyms. — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: How about a psql backslash command to show GUCs?

2022-04-07 Thread Mark Dilger
'm not going to kick up a fuss about \dconf. — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: How about a psql backslash command to show GUCs?

2022-04-07 Thread Mark Dilger
te to get the list of parameters. I frequently can't recall the exact spelling of them. — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: pg14 psql broke \d datname.nspname.relname

2022-04-07 Thread Mark Dilger
, and you can pg_fatal(...) or ereport(ERROR, ...) or whatever. It looks like I'll need to post a new version of the patch with an argument telling the function to ignore dots, but I'm not prepared to say that for sure. — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: trigger example for plsample

2022-04-08 Thread Mark Wong
ent immediately above, > and (2) if you have to print it anyway to avoid compiler warnings, > you're just creating confusing inconsistency between the two > handler functions. Sounds good to me, thanks! Regards, Mark

Re: pg14 psql broke \d datname.nspname.relname

2022-04-18 Thread Mark Dilger
been any agreement on that point, I've just rebased the patch to apply cleanly against the current master: v9-0001-Reject-patterns-with-too-many-parts-or-wrong-db.patch Description: Binary data — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Postgres perl module namespace

2022-04-18 Thread Mark Dilger
s a new node, this global variable prevents the new node from getting the port already assigned to the old stopped node, except when port assignment wraps around. Without sharing the global, wrap-around need not happen for port collisions. Or am I reading the code wrong? — Mark Dilger

Re: Postgres perl module namespace

2022-04-18 Thread Mark Dilger
> On Apr 18, 2022, at 1:19 PM, Andrew Dunstan wrote: > > that seems quite separate from the present issue. Thanks for the clarification. I agree, given your comments, that it is unrelated to this thread. — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise P

Re: GSoC: Database Load Stress Benchmark (2022)

2022-04-19 Thread Mark Wong
*Database > Load Stress Benchmark" *project. > > Link: > https://docs.google.com/document/d/1TThl7ODGD301GkjITY2k4OU88fZIhc1XvJYGqPCnOns/edit?usp=sharing > > I would appreciate any feedback or guidance that you are able to provide. I think you've covered all the bases here. Good luck! Regards, Mark

Re: DBT-5 Stored Procedure Development (2022)

2022-04-19 Thread Mark Wong
with other tools As some of tasks proposed are actually in place, one other task could be updating egen (the TPC supplied code.) The kit was last developed again 1.12 and 1.14 is current as this email. Regards, Mark

Re: DBT-5 Stored Procedure Development (2022)

2022-04-26 Thread Mark Wong
On Tue, Apr 19, 2022 at 05:20:50PM -0700, Peter Geoghegan wrote: > On Tue, Apr 19, 2022 at 11:31 AM Mark Wong wrote: > > As some of tasks proposed are actually in place, one other task could be > > updating egen (the TPC supplied code.) The kit was last developed again >

Re: Unstable tests for recovery conflict handling

2022-04-27 Thread Mark Dilger
without the other.) I wasn't going to report this yet, having not yet completely narrowed this down, but I wonder if anybody else is seeing this? I'll try again on master — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Unstable tests for recovery conflict handling

2022-04-27 Thread Mark Dilger
> On Apr 27, 2022, at 10:11 AM, Mark Dilger > wrote: > > I'll try again on master Still with coverage and dtrace enabled, I get the same thing, except that master formats the logs a bit differently: # Postmaster PID for node "primary" is 19797 psql::1: E

Re: LLVM 16 (opaque pointers)

2023-10-20 Thread Mark Wong
-llvm > > was literally just turned on, so there is no reason to think that this > > would have worked before or this work is relevant. Strange though -- > > we must be able to JIT further than that on s390x because we have > > crash reports in other threads (ie we made it pa

Re: LLVM 16 (opaque pointers)

2023-10-23 Thread Mark Wong
15.0.7 AlmaLinux 9.2 whiting: 6.0.0 Ubuntu 18.04.5 LTS vimba: 6.0.0 Ubuntu 18.04.5 LTS splitfin: 10.0.0 Ubuntu 20.04.6 LTS rudd: 10.0.0 Ubuntu 20.04.6 LTS turbot: 14.0.0 Ubuntu 22.04.3 LTS shiner: 14.0.0 Ubuntu 22.04.3 LTS ziege: 16.0.6 CentOS Stream 8 chevrotain: 11.0.1 Debian GNU/Linux 11 Regards, Mark

Re: LLVM 16 (opaque pointers)

2023-10-23 Thread Mark Wong
On Tue, Oct 24, 2023 at 10:17:22AM +1300, Thomas Munro wrote: > On Tue, Oct 24, 2023 at 4:27 AM Mark Wong wrote: > > I haven't gotten around to disabling llvm on any of my animals with llvm > > < 7 yet. Do you still want to hold on that? > > Yes, please disable -

Re: LLVM 16 (opaque pointers)

2023-10-24 Thread Mark Wong
fedora in the buildfarm... > > +1. It's good to test old LTS distros, but Fedora releases have a > short shelf life by design. I'll start retiring those old Fedora ones I have. :) Regards, Mark

Regression on pg_restore to 16.0: DOMAIN not available to SQL function

2023-11-03 Thread Mark Hills
se 15.4 for this one-off task so will have to kick this can down the road. But I think it worth reporting that something in 16.0 appears to be failing on valid data (or maybe there is an incompatibility with a dump from 13.5?) Thanks -- Mark $ export DUMP="$HOME/tmp/production.pgdum

Re: Regression on pg_restore to 16.0: DOMAIN not available to SQL function

2023-11-03 Thread Mark Hills
On Fri, 3 Nov 2023, Tom Lane wrote: > Mark Hills writes: > > I'm having errors restoring with pg_restore to v16.0, it appears to be a > > regression or bug. The same file restored to v15.4 without problem. > > > During the restore: > > > pg_restore:

Re: Regression on pg_restore to 16.0: DOMAIN not available to SQL function

2023-11-06 Thread Mark Hills
On Fri, 3 Nov 2023, Tom Lane wrote: > Mark Hills writes: > > On Fri, 3 Nov 2023, Tom Lane wrote: > >> However, then it's not clear why it would've worked > >> in 15.4 which does the same thing. I wonder whether you are > >> using this function in a

Re: Table AM Interface Enhancements

2023-11-24 Thread Mark Dilger
loptions for tables and indexes. This could use some regression tests to exercise the custom reloptions. — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Table AM Interface Enhancements

2023-11-27 Thread Mark Dilger
uld at least refactor to pass the minimum amount of state information through the table AM API. — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Escape output of pg_amcheck test

2024-01-08 Thread Mark Dilger
purpose of the patch, at least for my perl version, perl 5, version 28, subversion 1 (v5.28.1). With just the /aeg modifier, it works fine. -- Mark Dilger

Re: Escape output of pg_amcheck test

2024-01-08 Thread Mark Dilger
> On Jan 8, 2024, at 5:41 AM, Mark Dilger wrote: > > The /r modifier defeats the purpose of the patch, at least for my perl > version, perl 5, version 28, subversion 1 (v5.28.1). With just the /aeg > modifier, it works fine. Nevermind. I might be wrong about that. I did

Re: Buildfarm failures on urocryon

2023-09-01 Thread Mark Wong
t; Urocryon has been failing for the last 17 days. > > I think ICU libraries need to be installed in urocryon to fix this issue. Oops, that's when I upgraded the build farm client (from v14 to v17). I think it's fixed now... Regards, Mark

pg*.dll and *.pdb files in psqlODBC have no version numbers

2023-10-02 Thread Mark Hill
sion numbers? I checked earlier build and the same holds for ODBC 12.02.0000. Thanks, Mark

Re: GSOC 2020 - Develop Performance Farm Benchmarks and Website (2020)

2020-03-11 Thread Mark Wong
stand the project? I suggest reaching out on the #gsoc2020-students slack channel. Details on that, and other Postgres specific GSoC information, if you haven't already seen it: https://wiki.postgresql.org/wiki/GSoC Regards, Mark -- Mark Wong 2ndQuadrant - PostgreSQL Solutions for the Enterpri

Adding test coverage for ALTER SEQUENCE .. SET SCHEMA

2020-03-16 Thread Mark Dilger
Description: Binary data — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Adding missing object access hook invocations

2020-03-16 Thread Mark Dilger
hether not invoking the hook in these cases is defensible. Does anybody have any recollection of an intentional choice not to invoke in these locations? Patch attached. v1-0001-Adding-missing-Object-Access-hook-invocations.patch Description: Binary data — Mark Dilger EnterpriseDB: http://www.enterp

<    1   2   3   4   5   6   7   8   9   10   >