> On Apr 4, 2022, at 12:05 PM, Tom Lane <t...@sss.pgh.pa.us> wrote:
> 
> I wrote:
>> The "terminating connection" warning absolutely should get through,
> 
> ... oh, no, that's not guaranteed at all, since it's sent from quickdie().
> So scratch that.  Maybe we'd better add "could not send data to server"
> to the regex?

If it fails in pqsecure_raw_write(), you get either "server closed the 
connection unexpectedly" or "could not send data to server".  Do we need to 
support pgtls_write() or pg_GSS_write(), which have different error messages?  
Can anybody run the tests with TLS or GSS enabled?  I assume the test framework 
prevents this, but I didn't check too closely....

Is it possible that pgFlush will call pqSendSome which calls pqReadData before 
trying to write anything, and get back a "could not receive data from server" 
from pqsecure_raw_read()?

It's a bit hard to prove to myself which paths might be followed through this 
code.  Thoughts?

—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





Reply via email to