On Thu, Mar 22, 2018 at 12:28 AM, Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> On 3/21/18 03:40, Michael Paquier wrote:
> >>> Moreover, I wonder whether we shouldn't remove the branch where
> >>> conn->connhost is NULL. When would that be the case? The current
> >>> behavior is
On Sun, Mar 25, 2018 at 12:56 AM, Michael Paquier
wrote:
> On Sat, Mar 24, 2018 at 01:49:28AM +1100, Haribabu Kommi wrote:
> > Here I attached the updated patch that returns either the connected
> > host/hostaddr
> > or NULL in case if the connection is not established.
On Mon, Mar 26, 2018 at 4:17 PM, Michael Paquier
wrote:
> On Mon, Mar 26, 2018 at 11:28:41AM +0900, Kyotaro HORIGUCHI wrote:
> > At Sun, 25 Mar 2018 22:27:09 +1100, Haribabu Kommi <
> kommi.harib...@gmail.com> wrote in wna+nve_ypukzbdaqrmut9...@mail.gmail.com>
> >>
On Mon, Mar 26, 2018 at 6:34 PM, Kyotaro HORIGUCHI <
horiguchi.kyot...@lab.ntt.co.jp> wrote:
> Hello.
>
> At Mon, 26 Mar 2018 17:49:22 +1100, Haribabu Kommi <
> kommi.harib...@gmail.com> wrote in sgsfmjgvberjh0n9w8ry24...@mail.gmail.com>
>
>
Thanks for the review
On Tue, Mar 27, 2018 at 12:23 AM, Michael Paquier
wrote:
> On Mon, Mar 26, 2018 at 11:39:51PM +1100, Haribabu Kommi wrote:
> > And if we are not going to change the above, then PQhost() function
> > returns 3 values,
> > - NULL when the conn==NULL
> > - Actual hos
On Tue, Mar 27, 2018 at 3:03 PM, David G. Johnston <
david.g.johns...@gmail.com> wrote:
> On Mon, Mar 26, 2018 at 8:24 PM, Michael Paquier
> wrote:
>
>> On Tue, Mar 27, 2018 at 11:43:27AM +1100, Haribabu Kommi wrote:
>> > Patch attached with the above behavior
On Wed, Mar 28, 2018 at 3:35 AM, Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> On 3/27/18 02:20, Michael Paquier wrote:
> > On Tue, Mar 27, 2018 at 04:47:41PM +1100, Haribabu Kommi wrote:
> >> updated patch attached with additional doc updates as per the
On Tue, Jan 30, 2018 at 4:02 PM, Michael Paquier
wrote:
> On Tue, Jan 30, 2018 at 03:10:12PM +1100, Haribabu Kommi wrote:
> > Ok, understood. As the libpq gives preference to hostaddr connection
> > parameter than host while connecting. How about going with one column
> &g
On Wed, Mar 28, 2018 at 12:54 PM, Michael Paquier
wrote:
> On Wed, Mar 28, 2018 at 11:28:32AM +1100, Haribabu Kommi wrote:
> > I updated the pg_stat_wal_receiver patch with the new PQhost() function
> > behavior and updated the view with two columns, (remote_server and
> >
On Mon, Mar 26, 2018 at 9:32 AM, Andrew Dunstan wrote:
>
>
> Thanks for this, all looks good. Here is the consolidate patch
> rebased. If there are no further comments I propose to commit this in
> a few days time.
I have some comments with the committed patch.
@@ -663,7 +671,23 @@ ExecFetchSlo
On Fri, Mar 30, 2018 at 7:26 AM, Fujii Masao wrote:
> On Wed, Mar 28, 2018 at 3:09 PM, Michael Paquier
> wrote:
> > On Wed, Mar 28, 2018 at 03:41:33PM +1100, Haribabu Kommi wrote:
> >> On Wed, Mar 28, 2018 at 12:54 PM, Michael Paquier
> >> wrote:
> >> Upd
On Sat, Mar 31, 2018 at 10:08 AM, Fujii Masao wrote:
> On Fri, Mar 30, 2018 at 9:34 AM, Michael Paquier
> wrote:
> > On Fri, Mar 30, 2018 at 10:52:02AM +1100, Haribabu Kommi wrote:
> >> On Fri, Mar 30, 2018 at 7:26 AM, Fujii Masao
> wrote:
> >>
The jitflags in the PlannedStmt structure of type "int", but in _out and
_read functions it is treated as of "bool" type.
WRITE_BOOL_FIELD(jitFlags);
READ_BOOL_FIELD(jitFlags);
I am thinking of it is a copy paste mistake as the other members around the
initflags are of "bool" type or is there any
ations. I also
thought of implementing our own smgr implementation to support transparent
data encryption on the disk based on tablespace mapping.
Regards,
Haribabu Kommi
Fujitsu Australia
WAL needs to be encrypted, so this should
be
done at the WAL insertion not at WAL write to disk, because some entries are
not encrypted and some not. Or may be something like encrypting entire WAL
even if one object is set for encryption.
Regards,
Haribabu Kommi
Fujitsu Australia
be
preferred if not explicitly specified the access method during the table
creation.
This discussion raises a point that, in case if the user wants to change the
access method of a table later once it is created, currently there is no
option.
currently there are no other alternative table access methods that are
available
for the user to switch, but definitely it may be required later.
I will provide a patch to alter the access method of a table for v13.
Regards,
Haribabu Kommi
Fujitsu Australia
On Mon, Mar 4, 2019 at 3:23 PM Kyotaro HORIGUCHI <
horiguchi.kyot...@lab.ntt.co.jp> wrote:
> Hello.
>
> At Tue, 6 Nov 2018 15:53:37 +1100, Haribabu Kommi <
> kommi.harib...@gmail.com> wrote in <
> cajrrpgcxzi4z_sttnuuvyoaw+sadk7+cjgypuf7ao43vujl...@mail.gmail.com&g
test patch series in the COPY command.
I am not sure whether the problem is with the reduce of tableOid patch
problem,
Will check it and correct the problem.
Regards,
Haribabu Kommi
Fujitsu Australia
0010-Table-access-method-API-explanation.patch
Description: Binary data
0001-Reduce-the-use-of
t fails, and also the files inside the data folder follows the
permissions of the
upstream data directory.
usually production systems follows same permissions are of upstream, I don't
see a problem in following the same for development environment also?
comments?
Regards,
Haribabu Kommi
Fujitsu Australia
On Sat, Mar 9, 2019 at 2:18 PM Andres Freund wrote:
> Hi,
>
> On 2019-03-09 11:03:21 +1100, Haribabu Kommi wrote:
> > Here I attached the rebased patches that I shared earlier. I am adding
> the
> > comments to explain the API's in the code, will share those patches
On Fri, Mar 15, 2019 at 10:33 AM Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> On 2019-03-09 02:19, Haribabu Kommi wrote:
> > Yes, I agree that it may be a problem if the existing data directory
> > permissions
> > are 0700 to changing it to 0750. But
On Tue, Mar 12, 2019 at 5:03 PM Michael Paquier wrote:
> On Tue, Feb 26, 2019 at 12:22:53PM +1100, Haribabu Kommi wrote:
> > I checked the code why the current_logfiles is not implemented as
> > shared memory and found that the current syslogger doesn't attach to
> >
once.
And I reviewed the 0002 patch, which is a pretty simple and it can be
committed.
Regards,
Haribabu Kommi
Fujitsu Australia
0001-table-access-methods-typos-correction.patch
Description: Binary data
On Thu, Feb 28, 2019 at 1:00 PM Tsunakawa, Takayuki <
tsunakawa.ta...@jp.fujitsu.com> wrote:
> From: Haribabu Kommi [mailto:kommi.harib...@gmail.com]
> > Attached are the updated patches.
>
> Thanks, all look fixed.
>
>
> > The target_server_type option yet to
On Mon, Mar 18, 2019 at 1:58 PM Masahiko Sawada
wrote:
> On Tue, Feb 26, 2019 at 7:20 PM Masahiko Sawada
> wrote:
> >
> > On Tue, Feb 26, 2019 at 1:35 PM Haribabu Kommi
> wrote:
> > >
> > > On Thu, Feb 14, 2019 at 9:17 PM Masahiko Sawada
> wrote:
>
ed TableTupleUpdated
> #define HeapTupleDeleted TableTupleDeleted
> #define HeapTupleBeingUpdated TableTupleBeingModified
> #define HeapTupleWouldBlock TableTupleWouldBlock
>
> in heapam.h (whereas the above is in tableam.h), for backward
> compat. But I'm not sure it's worth it.
>
These old macros are pretty much used in the internal code, and I doubt
that any one depends directly on those macros. I vote for removal of
these backward compatibility macros.
Regards,
Haribabu Kommi
Fujitsu Australia
oup-access --> copies the contents of the src
directory
(with no group access) even for the root directory.
So the default behavior works for many people, others that needs restrict
behavior
can use the new option.
Regards,
Haribabu Kommi
Fujitsu Australia
ommit from pg_stat_database where datname =
> 'postgres';
> xact_commit
> -
> 161
> (1 row)
>
Thanks for the test and confirmation.
Regards,
Haribabu Kommi
Fujitsu Australia
On Tue, Mar 19, 2019 at 6:47 PM Jamison, Kirk
wrote:
> Hi Hari-san,
>
>
>
> On Sunday, February 10, 2019 2:25 PM (GMT+9), Haribabu Kommi wrote:
>
> > I try to fix it by adding a check for parallel worker or not and based
> on it
>
> > count them into stats. P
the supported branches are possible to
compile with VS 2017.
comments?
Regards,
Haribabu Kommi
Fujitsu Australia
0001-Support-building-with-visual-studio-2019.patch
Description: Binary data
On Wed, Mar 20, 2019 at 4:33 PM Michael Paquier wrote:
> On Fri, Mar 15, 2019 at 06:51:37PM +1100, Haribabu Kommi wrote:
> > IMO, this update is just a recommendation to the user, and sometimes it
> is
> > still possible that there may be strict permissions for the log file
#x27;s not actually the case for 9.5 and 9.4 if
> you don't back-patch f2ab389 further down.
>
The commit f2ab389 is later back-patch to version till 9.3 in commit
19acfd65.
I guess that building the windows installer for all the versions using the
same
visual studio is may be the reaso
On Thu, Mar 21, 2019 at 12:41 PM Haribabu Kommi
wrote:
>
> On Wed, Mar 20, 2019 at 4:33 PM Michael Paquier
> wrote:
>
>> And actually it seems to me that you have a race condition in that
>> stuff. I think that you had better use umask(), then fopen, and then
>>
On Sat, Mar 16, 2019 at 5:43 PM Haribabu Kommi
wrote:
>
>
> On Sat, Mar 9, 2019 at 2:13 PM Andres Freund wrote:
>
>> Hi,
>>
>> While 0001 is pretty bulky, the interesting bits concentrate on a
>> comparatively small area. I'd appreciate if somebody coul
t;Name",
CASE amtype WHEN 'i' THEN 'Index' WHEN 't' THEN 'Table' END AS
"Type"
FROM pg_catalog.pg_am ...
Anyone feels that it requires a separate query for servers < 12?
Regards,
Haribabu Kommi
Fujitsu Australia
0001-dA-to-show-Table-type-access-method.patch
Description: Binary data
On Wed, Mar 20, 2019 at 7:38 PM Amit Kapila wrote:
> On Sun, Feb 10, 2019 at 10:54 AM Haribabu Kommi
> wrote:
> > On Sat, Feb 9, 2019 at 4:07 PM Amit Kapila
> wrote:
> >>
> >> I don't think so. It seems to me that we should consider it as a
> >>
e options should check whether server is
running in recovery mode or not
instead of checking whether server accepts read-only connections or not?
Regards,
Haribabu Kommi
Fujitsu Australia
eTupleOk, but also probably a
> s/TableTuple/TableMod/
>
> - I'll probably move TUPLE_LOCK_FLAG_LOCK_* into tableam.h
>
> - two more passes through the patch
>
Thanks for the corrections.
> On 2019-03-21 15:07:04 +1100, Haribabu Kommi wrote:
> > As you are modifyin
On Thu, Mar 21, 2019 at 3:02 AM Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> On 2019-03-19 08:34, Haribabu Kommi wrote:
> > How about the following change?
> >
> > pg_basebackup --> copies the contents of the src directory (with group
> > acc
On Fri, Mar 22, 2019 at 6:57 AM Robert Haas wrote:
> On Thu, Mar 21, 2019 at 2:26 AM Haribabu Kommi
> wrote:
> > Based on the above new options that can be added to target_session_attrs,
> >
> > primary - it is just an alias to the read-write option.
> > standby,
On Fri, Mar 22, 2019 at 12:24 PM Michael Paquier
wrote:
> On Thu, Mar 21, 2019 at 12:52:14PM +1100, Haribabu Kommi wrote:
> > Earlier attached patch is wrong.
>
> - oumask = umask(pg_file_create_mode);
> + oumask = umask(pg_mode_mask);
> Indeed that was wrong.
>
&g
directory permissions.
Default - permissions are same as primary
--allow-group-access - standby directory have group access permissions
--no-group--access - standby directory doesn't have group permissions
The last two options behave irrespective of the primary directory
permissions.
opinions?
Regards,
Haribabu Kommi
Fujitsu Australia
On Fri, Mar 22, 2019 at 7:32 AM Haribabu Kommi
wrote:
>
> On Fri, Mar 22, 2019 at 6:57 AM Robert Haas wrote:
>
>> On Thu, Mar 21, 2019 at 2:26 AM Haribabu Kommi
>> wrote:
>> > Based on the above new options that can be added to
>> target_session_attrs,
>
On Sat, Mar 23, 2019 at 2:23 AM Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> On 2019-03-22 05:00, Michael Paquier wrote:
> > On Fri, Mar 22, 2019 at 02:45:24PM +1100, Haribabu Kommi wrote:
> >> How about letting the pg_basebackup to decide group permiss
On Sun, Mar 24, 2019 at 11:16 PM Michael Paquier
wrote:
> On Fri, Mar 22, 2019 at 01:01:44PM +0900, Michael Paquier wrote:
> > On Fri, Mar 22, 2019 at 02:35:41PM +1100, Haribabu Kommi wrote:
> > > Thanks for the correction. Yes, that is correct and it works fine.
> &g
On Fri, Mar 22, 2019 at 6:07 PM Haribabu Kommi
wrote:
>
> On Fri, Mar 22, 2019 at 7:32 AM Haribabu Kommi
> wrote:
>
>>
>> On Fri, Mar 22, 2019 at 6:57 AM Robert Haas
>> wrote:
>>
>>> On Thu, Mar 21, 2019 at 2:26 AM Haribabu Kommi
>>> w
y transactions information.
How about adding additional two columns that provides all the internal
and background worker transactions into that column?
Regards,
Haribabu Kommi
Fujitsu Australia
parallel vacuum can
work, so just setting the above parameters doesn't stop the parallel
workers, user must
pass the PARALLEL option also. So mentioning that also will be helpful
later when we
start supporting it or some one who is reading the code can understand.
Regards,
Haribabu Kommi
Fujitsu Australia
On Tue, Mar 26, 2019 at 1:27 PM Michael Paquier wrote:
> On Sun, Mar 24, 2019 at 10:30:47PM +1100, Haribabu Kommi wrote:
> > With the above additional options, the pg_basebackup is able to control
> > the access permissions of the backup files, but when it comes to tar mode
> &
On Wed, Mar 27, 2019 at 3:03 AM Andrew Dunstan <
andrew.duns...@2ndquadrant.com> wrote:
>
> On 3/20/19 8:36 PM, Haribabu Kommi wrote:
> > Hi Hackers,
> >
> > Here I attached a patch that supports building of PostgreSQL with VS
> 2019.
> > VS 2019 is going
On Tue, Mar 26, 2019 at 9:08 PM Amit Kapila wrote:
> On Mon, Mar 25, 2019 at 6:55 PM Haribabu Kommi
> wrote:
> >
> >
> > Thanks to everyone for their opinions and suggestions to improve.
> >
> > Without parallel workers, there aren't many internal impl
On Wed, Mar 27, 2019 at 1:31 AM Masahiko Sawada
wrote:
> On Tue, Mar 26, 2019 at 10:19 AM Haribabu Kommi
> wrote:
> >
> >
> > + for (i = 0; i < nindexes; i++)
> > + {
> > + LVIndStats *s = &(copied_indstats[i]);
> > +
> > + if (s->updat
On Wed, Mar 27, 2019 at 11:27 PM Amit Kapila
wrote:
> On Wed, Mar 27, 2019 at 6:53 AM Haribabu Kommi
> wrote:
> > On Tue, Mar 26, 2019 at 9:08 PM Amit Kapila
> wrote:
> >>
> >> As part of this thread, maybe we can
> >> just fix the ca
on variable, I see a
lot of code addition just
for this variable, is this worth it?
[1] -
https://www.postgresql.org/message-id/2239254.dtfY1H9x0t%40hammer.magicstack.net
Regards,
Haribabu Kommi
Fujitsu Australia
From aa812716104b3fbd787dae4483341894c9e5ed9a Mon Sep 17 00:00:00 2001
From: Hari Bab
version
> bump.
>
> It seems possible that some other AM might want to generalize the
> prefetch logic from heapam.c, but I think it's fair to defer that until
> such an AM wants to do so
>
As I see that your are fixing some typos of the code that is committed,
I just wan
On Fri, Dec 22, 2017 at 4:55 PM, Michael Paquier
wrote:
> On Fri, Dec 22, 2017 at 03:11:07PM +1100, Haribabu Kommi wrote:
> > Updated patch attached with tests and doc changes.
>
>
Thanks for the review.
> +
> + primary_hostname
> + text
> + Host na
On Wed, Jan 3, 2018 at 12:25 PM, Haribabu Kommi
wrote:
>
>
> update patch attached.
>
Last patch has undefined symbol, corrected patch attached.
Regards,
Hari Babu
Fujitsu Australia
pg_stat_wal_receiver-to-display-connected-host_v3.patch
Description: Binary data
On Thu, Jan 4, 2018 at 10:00 AM, Alexander Korotkov <
a.korot...@postgrespro.ru> wrote:
> On Wed, Jan 3, 2018 at 10:08 AM, Haribabu Kommi
> wrote:
>
>>
>> On Wed, Dec 27, 2017 at 11:33 PM, Alexander Korotkov <
>> a.korot...@postgrespro.ru> wrote:
On Thu, Jan 4, 2018 at 11:53 AM, Michael Paquier
wrote:
> On Wed, Jan 03, 2018 at 06:48:07PM +1100, Haribabu Kommi wrote:
> > On Wed, Jan 3, 2018 at 12:25 PM, Haribabu Kommi <
> kommi.harib...@gmail.com>
> > Last patch has undefined symbol, corrected patch attached.
On Fri, Jan 5, 2018 at 9:55 AM, Alexander Korotkov <
a.korot...@postgrespro.ru> wrote:
> On Thu, Jan 4, 2018 at 8:03 AM, Haribabu Kommi
> wrote:
>
>> On Thu, Jan 4, 2018 at 10:00 AM, Alexander Korotkov <
>> a.korot...@postgrespro.ru> wrote:
>>
>>>
On Fri, Jan 5, 2018 at 12:05 AM, Michael Paquier
wrote:
> On Thu, Jan 04, 2018 at 08:54:37AM -0300, Alvaro Herrera wrote:
> > I think more attention should be given to the libpq side of this patch;
> > maybe have a 0001 with only the new libpq function, to easily verify
> > that it does all it ne
On Fri, Jan 5, 2018 at 2:54 PM, Vaishnavi Prabakaran <
vaishnaviprabaka...@gmail.com> wrote:
>
> On Wed, Dec 13, 2017 at 1:50 PM, Haribabu Kommi
> wrote:
>
>> Rebased patch attached that fixes the documentation build problem.
>>
>> Latest patch applies wi
On Fri, Jan 5, 2018 at 11:15 PM, Alvaro Herrera
wrote:
> Haribabu Kommi wrote:
>
> > or
> >
> > write two new functions PQconnhost() and PQconnhostaddr() to return the
> > connected host and hostaddr and reuse the PQport() function.
>
> How about using an
On Tue, Jan 9, 2018 at 12:15 PM, Michael Paquier
wrote:
> On Fri, Jan 05, 2018 at 09:15:36AM -0300, Alvaro Herrera wrote:
> > Haribabu Kommi wrote:
> >
> > > And also not returning "default host" details, because for the conninfo
> > > without any host
On Tue, Nov 7, 2017 at 4:10 PM, Thomas Munro
wrote:
> Hi hackers,
>
> I have often wanted $SUBJECT and was happy to find that Fujii-san had
> posted a patch five years ago[1]. The reception then seemed positive.
> So here is a refurbished and (hopefully) improved version of his patch
> with a ne
On Thu, Jan 11, 2018 at 10:00 PM, Thomas Munro <
thomas.mu...@enterprisedb.com> wrote:
> On Thu, Jan 11, 2018 at 7:36 PM, Haribabu Kommi
> wrote:
>
> > +OUT plans int8,
> >
> > Addition of this column is good to find out how many time the plan is
> >
On Fri, Jan 12, 2018 at 3:26 PM, Michael Paquier
wrote:
> On Fri, Jan 12, 2018 at 11:37:22AM +0900, Michael Paquier wrote:
> > I have redone my set of previous tests and can confirm that PQhost is
> > behaving as I would expect it should, and those results are the same as
> > yours.
>
> if (c
On Fri, Jan 12, 2018 at 4:06 PM, Michael Paquier
wrote:
> On Fri, Jan 12, 2018 at 03:55:04PM +1100, Haribabu Kommi wrote:
> > Before posting the patch, first I did the same, upon further study
> > I didn't find any scenario where the value is not present in
> > conn
While working on [1], we find out the inconsistency in PQHost() behavior
if the connecting string that is passed to connect to the server contains
multiple hosts with both host and hostaddr types. For example,
host=host1,host2 hostaddr=127.0.0.1,127.0.0.1 port=5434,5432
As the hostaddr is given p
On Mon, Jan 8, 2018 at 3:32 PM, Haribabu Kommi
wrote:
>
>
> On Fri, Jan 5, 2018 at 11:15 PM, Alvaro Herrera
> wrote:
>
>> Haribabu Kommi wrote:
>>
>> > or
>> >
>> > write two new functions PQconnhost() and PQconnhostaddr() to return the
[ Including Hackers as earlier mail mistakenly removed it ]
On Tue, Jan 16, 2018 at 2:55 PM, Michael Paquier
wrote:
> On Mon, Jan 15, 2018 at 05:51:58PM +1100, Haribabu Kommi wrote:
> > Instead of effective_conninfo, I changed the column name as
> > remote_serve_info and
>
On Thu, Jan 18, 2018 at 8:25 AM, Tom Lane wrote:
> Haribabu Kommi writes:
> > [ pg_dump-and-pg_dumpall-database-handling-refactoring_v12.patch ]
>
> I started to look through this, and almost immediately found that the
> diff in t/002_pg_dump.pl doesn't seem necessary --
On Fri, Jan 19, 2018 at 10:35 AM, Tom Lane wrote:
> I wrote:
> > What I think we should do for the time being is to have pg_dump treat
> > database tablespace as a property it can't adjust after creation, just
> > as it can't adjust locale or encoding. That's a loss of functionality
> > for pg_d
On Tue, Jan 23, 2018 at 8:56 AM, Tom Lane wrote:
> I wrote:
> > Specifically, I see failures like this on machines where the prevailing
> > locale isn't C or US:
>
> > pg_restore: [archiver (db)] Error while PROCESSING TOC:
> > pg_restore: [archiver (db)] Error from TOC entry 4871; 2618 34337 RUL
On Tue, Jan 16, 2018 at 5:56 PM, Haribabu Kommi
wrote:
>
> On Tue, Jan 16, 2018 at 2:55 PM, Michael Paquier <
> michael.paqu...@gmail.com> wrote:
>
>>
>> Note that I still find this API confusing, it seems to me that just
>> sorting out the confusion problems
On Mon, Jan 29, 2018 at 7:06 PM, Michael Paquier
wrote:
> On Tue, Jan 16, 2018 at 05:56:22PM +1100, Haribabu Kommi wrote:
> > Without PQhostaddr() function, for the connections where the host is not
> > specified, it will be difficult to find out to remote server.
>
> Tha
On Tue, Jan 9, 2018 at 11:42 PM, Haribabu Kommi
wrote:
>
> Updated patches are attached.
>
To integrate the columnar store with the pluggable storage API, I found that
there are couple of other things also that needs to be supported.
1. Choosing the right table access method for a p
On Sun, Jan 14, 2018 at 9:44 PM, Michael Paquier
wrote:
> On Sun, Jan 14, 2018 at 02:19:26PM +1100, Haribabu Kommi wrote:
> > While working on [1], we find out the inconsistency in PQHost() behavior
> > if the connecting string that is passed to connect to the server contains
>
On Tue, Apr 2, 2019 at 10:18 AM Andres Freund wrote:
> Hi,
>
> On 2019-03-16 23:21:31 +1100, Haribabu Kommi wrote:
> > updated patches are attached.
>
> Now that nearly all of the tableam patches are committed (with the
> exception of the copy.c changes which are for
On Tue, Apr 2, 2019 at 11:53 AM Andres Freund wrote:
> Hi,
>
> On 2019-04-02 11:39:57 +1100, Haribabu Kommi wrote:
> > > What made you rename indexam.sgml to am.sgml, instead of creating a
> > > separate tableam.sgml? Seems easier to just have a separate file?
>
On Wed, Apr 3, 2019 at 1:59 PM Amit Kapila wrote:
> On Thu, Mar 28, 2019 at 11:43 AM Haribabu Kommi
> wrote:
> >
> > On Wed, Mar 27, 2019 at 11:27 PM Amit Kapila
> wrote:
> >>
> >> On Wed, Mar 27, 2019 at 6:53 AM Haribabu Kommi <
> kommi.harib...@
oblem.
>From understanding of the thread discussion,
+1 by:
Michael Paquier
Robert Haas
Haribabu Kommi
-1 by:
Magnus Hagander
Peter Eisentraut
Does any one want to weigh their opinion on this patch to consider best
option for controlling the existing standby data directory permissions.
Regards,
Haribabu Kommi
Fujitsu Australia
On Thu, Apr 4, 2019 at 3:29 PM Amit Kapila wrote:
> On Wed, Apr 3, 2019 at 10:45 AM Haribabu Kommi
> wrote:
> >
> > Thanks for the review.
> >
> > While changing the approach to use the is_parallel_worker_flag, I thought
> > that the rest of the stats are
ainly a bit crummy.
>
I got the same doubt when i looked into some of the UNDO patches
where it tries to modify the core code to add UNDO specific WAL types.
Different AM's may need different set of operations to be WAL logged,
so it may be better for the AM's to register their own types?
Regards,
Haribabu Kommi
Fujitsu Australia
On Wed, Mar 27, 2019 at 11:42 AM Haribabu Kommi
wrote:
>
> On Wed, Mar 27, 2019 at 3:03 AM Andrew Dunstan <
> andrew.duns...@2ndquadrant.com> wrote:
>
>>
>> On 3/20/19 8:36 PM, Haribabu Kommi wrote:
>> > Hi Hackers,
>> >
>> > Here I atta
ccess
> > methods (i.e. the default_table_access_method GUC and the USING clause
> > for CREATE TABLE etc), adds a basic chapter about the table access
> > method interface, and adds a note to storage.sgml that it's contents
> > don't necessarily apply for non-builtin AMs.
> >
&
> this fix?
> >
>
> Pushed.
>
Thanks Amit.
Will look into it further to handle all the internally generated
transactions.
Regards,
Haribabu Kommi
Fujitsu Australia
about adding the new functions
> in postgres.c like RecoveryConflictInterrupt()?
>
>
> (7) 0008
> + if (pid != 0)
> + {
> + (void) SendProcSignal(pid, reason,
> procvxid.backendId);
> + }
>
> The braces
view easier,
> but
> first I'd like to hear if anything is seriously wrong about this
> design. Thanks.
>
I didn't check the code, but it is good to combine all the 3 page read
functions
into one instead of spreading the logic.
Regards,
Haribabu Kommi
Fujitsu Australia
pages.
Definitely this approach does't work for full instance encryption.
Any opinions/comments/problems in evaluating the encryption with an
extesnion
approach?
Regards,
Haribabu Kommi
Fujitsu Australia
On Tue, May 21, 2019 at 8:17 AM Andres Freund wrote:
>
>
>Add command to create
>new table types (Haribabu Kommi, Andres Freund, Álvaro Herrera,
>Dimitri Dolgov)
>
>
> A few points:
>
> 1) Is this really source code, given
rned value be '14.20' for Visual Studio 2019?
>
Yes, that will be good to return Visual Studio 2019, updated.
Updated patches are attached for all branches.
Regards,
Haribabu Kommi
Fujitsu Australia
0001-Support-building-with-visual-studio-2019_HEAD.patch
Description: Binary d
On Mon, May 27, 2019 at 8:14 PM Juan José Santamaría Flecha <
juanjo.santama...@gmail.com> wrote:
>
> On Thu, May 23, 2019 at 3:44 AM Haribabu Kommi
> wrote:
>
>>
>> Updated patches are attached for all branches.
>>
>>
> I have gone through all patch
yScan supports to return a partial composite type,
> it needs similar infrastructure that can be used for a better composite
> type support on columnar storage.
>
There is another issue related to the columnar store that needs targeted
columns for projection from the scan is discussed in zedstore [1].
Projecting all columns from a columnar store is quite expensive than
the row store.
[1] -
https://www.postgresql.org/message-id/CALfoeivu-n5o8Juz9wW%2BkTjnis6_%2BrfMf%2BzOTky1LiTVk-ZFjA%40mail.gmail.com
Regards,
Haribabu Kommi
Fujitsu Australia
On Thu, Apr 11, 2019 at 9:13 AM Haribabu Kommi
wrote:
> I fixed all the comments that you have raised above and attached the
> updated
> patches.
>
Rebased patches are attached.
Regards,
Haribabu Kommi
Fujitsu Australia
0001-New-pg_basebackup-g-option-to-control-the-grou
On Wed, Oct 3, 2018 at 3:16 PM Andres Freund wrote:
> On 2018-09-27 20:03:58 -0700, Andres Freund wrote:
> > On 2018-09-28 12:21:08 +1000, Haribabu Kommi wrote:
> > > Here I attached further cleanup patches.
> > > 1. Re-arrange the GUC variable
> > >
On Fri, Sep 21, 2018 at 5:09 PM Haribabu Kommi
wrote:
> On Thu, Sep 20, 2018 at 3:18 PM Kyotaro HORIGUCHI <
> horiguchi.kyot...@lab.ntt.co.jp> wrote:
>
>> Hello.
>>
>> At Mon, 17 Sep 2018 16:49:41 +1000, Haribabu Kommi <
>> kommi.harib.
On Tue, Oct 9, 2018 at 1:46 PM Haribabu Kommi
wrote:
> On Wed, Oct 3, 2018 at 3:16 PM Andres Freund wrote:
>
>> On 2018-09-27 20:03:58 -0700, Andres Freund wrote:
>> > On 2018-09-28 12:21:08 +1000, Haribabu Kommi wrote:
>> > > Here I attached further cleanup
On Sat, Oct 13, 2018 at 3:57 AM Robert Haas wrote:
> On Wed, Oct 10, 2018 at 8:27 AM Haribabu Kommi
> wrote:
> > Here is the patch as per the above discussion.
>
> One potential problem with this is that we could add more control-file
> attributes in the future, and it wi
On Tue, Oct 9, 2018 at 1:46 PM Haribabu Kommi
wrote:
> On Wed, Oct 3, 2018 at 3:16 PM Andres Freund wrote:
>
>> On 2018-09-27 20:03:58 -0700, Andres Freund wrote:
>> > On 2018-09-28 12:21:08 +1000, Haribabu Kommi wrote:
>> > > Here I attached further cleanup
1 - 100 of 247 matches
Mail list logo
