On Thu, Jan 18, 2018 at 8:25 AM, Tom Lane <t...@sss.pgh.pa.us> wrote:
> Haribabu Kommi <kommi.harib...@gmail.com> writes: > > [ pg_dump-and-pg_dumpall-database-handling-refactoring_v12.patch ] > > I started to look through this, and almost immediately found that the > diff in t/002_pg_dump.pl doesn't seem necessary --- the test passes > for me without applying that hunk. Is that a leftover from a previous > patch iteration, or is there some platform dependency in the test? > If it's not necessary, I'd be inclined to leave it as it was. > Thanks for the review. Yes, it is a left over from previous patch iteration. The test used to fail with this patch earlier. Now there is no problem in test even after removing the hunk from my side also. There is no platform dependency. Attached is an updated patch after removing the test changes. Regards, Hari Babu Fujitsu Australia
pg_dump-and-pg_dumpall-database-handling-refactoring_v13.patch
Description: Binary data
