On Wed, Mar 27, 2019 at 1:31 AM Masahiko Sawada <sawada.m...@gmail.com>
wrote:
> On Tue, Mar 26, 2019 at 10:19 AM Haribabu Kommi
> <kommi.harib...@gmail.com> wrote:
> >
> >
> > + for (i = 0; i < nindexes; i++)
> > + {
> > + LVIndStats *s = &(copied_indstats[i]);
> > +
> > + if (s->updated)
> > + lazy_update_index_statistics(Irel[i], &(s->stats));
> > + }
> > +
> > + pfree(copied_indstats);
> >
> > why can't we use the shared memory directly to update the stats once all
> the workers
> > are finished, instead of copying them to a local memory?
>
> Since we cannot use heap_inplace_update() which is called by
> vac_update_relstats() during parallel mode I copied the stats. Is that
> safe if we destroy the parallel context *after* exited parallel mode?
>
OK, understood the reason behind the copy.
Thanks for the updated patches. I reviewed them again and they
are fine. I marked the patch as "ready for committer".
Regards,
Haribabu Kommi
Fujitsu Australia
