On Sat, Mar 31, 2018 at 10:08 AM, Fujii Masao <masao.fu...@gmail.com> wrote:
> On Fri, Mar 30, 2018 at 9:34 AM, Michael Paquier <mich...@paquier.xyz> > wrote: > > On Fri, Mar 30, 2018 at 10:52:02AM +1100, Haribabu Kommi wrote: > >> On Fri, Mar 30, 2018 at 7:26 AM, Fujii Masao <masao.fu...@gmail.com> > wrote: > >>> @@ -753,4 +753,6 @@ CREATE VIEW pg_stat_wal_receiver AS > >>> s.latest_end_time, > >>> s.slot_name, > >>> + s.remote_server, > >>> + s.remote_port, > >>> > >>> As the column names, aren't sender_host and sender_port more intuitive > >>> rather than remote_server and remote_port? > >> > >> OK. Changed accordingly. > > > > No problems with those names. > > > > + ret = PQhost(conn->streamConn); > > + if (ret && (strcmp(ret,"") != 0)) > > + *sender_host = pstrdup(ret); > > The code tends to use more strlen to check for empty strings, > > particularly libpq. A small nit it is. > > Ok, updated the patch so strlen is used. > > I pushed the patch. Many thanks to Haribabu and Michael! > Thanks for the changes and commit and thanks Michael for the review. Regards, Hari Babu Fujitsu Australia
