Re: Extensions not dumped when --schema is used

2021-02-18 Thread Guillaume Lelarge
Le mar. 26 janv. 2021 à 13:42, Guillaume Lelarge a écrit : > Le mar. 26 janv. 2021 à 13:41, Guillaume Lelarge > a écrit : > >> Le mar. 26 janv. 2021 à 05:10, Julien Rouhaud a >> écrit : >> >>> On Mon, Jan 25, 2021 at 9:34 PM Guillaume Lelarge >>>

Re: Extensions not dumped when --schema is used

2021-02-20 Thread Guillaume Lelarge
Le sam. 20 févr. 2021 à 13:25, Michael Paquier a écrit : > On Thu, Feb 18, 2021 at 11:13:06AM +0100, Guillaume Lelarge wrote: > > I finally managed to get a working TAP test for my patch. I have no idea > if > > it's good, and if it's enough. Anyway, new version o

Re: Extensions not dumped when --schema is used

2021-02-20 Thread Guillaume Lelarge
Le sam. 20 févr. 2021 à 17:31, Tom Lane a écrit : > Michael Paquier writes: > > As presented in this patch, specifying both --extension and > > --table/--schema means that pg_dump will dump both tables and > > extensions matching the pattern passed down. But shouldn't extensions > > not be dump

Re: Extensions not dumped when --schema is used

2021-03-15 Thread Guillaume Lelarge
Le lun. 15 mars 2021 à 06:00, Michael Paquier a écrit : > On Sun, Feb 21, 2021 at 08:14:45AM +0900, Michael Paquier wrote: > > Okay, that sounds fine to me. Thanks for confirming. > > Guillaume, it has been a couple of weeks since your last update. Are > you planning to send a new version of th

Re: Extensions not dumped when --schema is used

2021-03-15 Thread Guillaume Lelarge
Le lun. 15 mars 2021 à 11:32, Julien Rouhaud a écrit : > Le lun. 15 mars 2021 à 18:25, Michael Paquier a > écrit : > >> On Mon, Mar 15, 2021 at 06:21:55PM +0800, Julien Rouhaud wrote: >> > Is that a feature you really want to see in pg14? If yes and if you're >> sure >> > you won't have time to

Re: Extensions not dumped when --schema is used

2021-01-25 Thread Guillaume Lelarge
Hi, Le sam. 23 mai 2020 à 14:53, Guillaume Lelarge a écrit : > Le mer. 20 mai 2020 à 16:39, Tom Lane a écrit : > >> Guillaume Lelarge writes: >> > Le mer. 20 mai 2020 à 11:26, Daniel Gustafsson a >> écrit : >> >> The question is what --extensions sh

Re: Extensions not dumped when --schema is used

2021-01-26 Thread Guillaume Lelarge
Le mar. 26 janv. 2021 à 05:10, Julien Rouhaud a écrit : > On Mon, Jan 25, 2021 at 9:34 PM Guillaume Lelarge > wrote: > > > > "Anytime soon" was a long long time ago, and I eventually completely > forgot this, sorry. As nobody worked on it yet, I took a s

Re: Extensions not dumped when --schema is used

2021-01-26 Thread Guillaume Lelarge
Le mar. 26 janv. 2021 à 13:41, Guillaume Lelarge a écrit : > Le mar. 26 janv. 2021 à 05:10, Julien Rouhaud a > écrit : > >> On Mon, Jan 25, 2021 at 9:34 PM Guillaume Lelarge >> wrote: >> > >> > "Anytime soon" was a long long time ago, and

Re: Extensions not dumped when --schema is used

2021-02-03 Thread Guillaume Lelarge
Hi, Thanks for the review. Le mer. 3 févr. 2021 à 18:33, Asif Rehman a écrit : > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: not tested > Documentation:

Probable memory leak with ECPG and AIX

2021-12-10 Thread Guillaume Lelarge
Hello, Our customer thinks he has found a memory leak on ECPG and AIX. The code is quite simple. It declares a cursor, opens it, and fetches the only line available in the table many times. After some time, the client crashes with a segfault error. According to him, it consumed around 256MB. What

Re: Probable memory leak with ECPG and AIX

2021-12-10 Thread Guillaume Lelarge
Le sam. 11 déc. 2021 à 07:52, Justin Pryzby a écrit : > On Fri, Dec 10, 2021 at 03:40:50PM +0100, Guillaume Lelarge wrote: > > Hello, > > > > Our customer thinks he has found a memory leak on ECPG and AIX. > > > > The code is quite simple. It declares a cursor, o

Autovacuum and idle_session_timeout

2021-12-30 Thread Guillaume Lelarge
Hello, I've been reading the autovacuum code (the launcher and the worker) on the 14 branch. As previously, I've seen some configuration at the beginning, especially for statement_timeout, lock_timeout and idle_in_transaction_session_timeout, and I was surprised to discover there was no configurat

Re: Autovacuum and idle_session_timeout

2021-12-30 Thread Guillaume Lelarge
Le jeu. 30 déc. 2021 à 11:44, Japin Li a écrit : > > On Thu, 30 Dec 2021 at 17:18, Guillaume Lelarge > wrote: > > Hello, > > > > I've been reading the autovacuum code (the launcher and the worker) on > the > > 14 branch. As previously, I&#x

Re: Autovacuum and idle_session_timeout

2021-12-30 Thread Guillaume Lelarge
Le jeu. 30 déc. 2021 à 12:01, Japin Li a écrit : > > On Thu, 30 Dec 2021 at 18:53, Guillaume Lelarge > wrote: > > Le jeu. 30 déc. 2021 à 11:44, Japin Li a écrit : > > > >> > > pg_dump works in a single transaction, so it's already dealt with > &

Re: Autovacuum and idle_session_timeout

2021-12-30 Thread Guillaume Lelarge
Le jeu. 30 déc. 2021 à 17:25, Tom Lane a écrit : > Japin Li writes: > > On Thu, 30 Dec 2021 at 18:53, Guillaume Lelarge > wrote: > >> pg_dump works in a single transaction, so it's already dealt with > >> idle_in_transaction_timeout. Though I guess setting

Re: Extensions not dumped when --schema is used

2021-03-30 Thread Guillaume Lelarge
Le mer. 31 mars 2021 à 02:37, Michael Paquier a écrit : > On Tue, Mar 30, 2021 at 12:02:45PM +0900, Michael Paquier wrote: > > Okay. So I have looked at that stuff in details, and after fixing > > all the issues reported upthread in the code, docs and tests I am > > finishing with the attached.

Lots of memory allocated when reassigning Large Objects

2021-11-29 Thread Guillaume Lelarge
Hi, One of our customers had a very bad issue while trying to reassign objects from user A to user B. He had a lot of them, and the backend got very hungry for memory. It finally all went down when the linux kernel decided to kill the backend (-9 of course). I attach three shell scripts showing t

Re: Lots of memory allocated when reassigning Large Objects

2021-11-29 Thread Guillaume Lelarge
Le lun. 29 nov. 2021 à 19:40, Tom Lane a écrit : > Justin Pryzby writes: > > I reproduced the issue like this. > > > psql postgres -c 'CREATE ROLE two WITH login superuser' > > psql postgres two -c "SELECT lo_import('/dev/null') FROM > generate_series(1,22111)" >/dev/null > > psql postgres -c 'S

Re: Lots of memory allocated when reassigning Large Objects

2021-11-29 Thread Guillaume Lelarge
Le lun. 29 nov. 2021 à 20:39, Tom Lane a écrit : > Guillaume Lelarge writes: > > I've tried Justin's patch but it didn't help with my memory allocation > > issue. FWIW, I attach the patch I used in v14. > > [ looks closer ... ] Ah, that patch is a bit buggy:

Re: Lots of memory allocated when reassigning Large Objects

2021-11-29 Thread Guillaume Lelarge
Le lun. 29 nov. 2021 à 22:27, Tom Lane a écrit : > Guillaume Lelarge writes: > > Le lun. 29 nov. 2021 à 20:39, Tom Lane a écrit : > >> [ looks closer ... ] Ah, that patch is a bit buggy: it fails to do the > >> right thing in the cases where the loop does

Re: Lots of memory allocated when reassigning Large Objects

2021-11-29 Thread Guillaume Lelarge
Le lun. 29 nov. 2021 à 22:47, Tom Lane a écrit : > Guillaume Lelarge writes: > > Le lun. 29 nov. 2021 à 22:27, Tom Lane a écrit : > >> I'm checking it in HEAD though; perhaps there's something else wrong > >> in the back branches? > > > That'

Re: Lots of memory allocated when reassigning Large Objects

2021-11-30 Thread Guillaume Lelarge
Le mar. 30 nov. 2021 à 00:25, Tom Lane a écrit : > Guillaume Lelarge writes: > > Le lun. 29 nov. 2021 à 22:27, Tom Lane a écrit : > >> I'm checking it in HEAD though; perhaps there's something else wrong > >> in the back branches? > > > That'

Re: Lots of memory allocated when reassigning Large Objects

2021-12-01 Thread Guillaume Lelarge
Le mer. 1 déc. 2021 à 19:48, Tom Lane a écrit : > Justin Pryzby writes: > > @Guillaume: Even if memory use with the patch isn't constant, I imagine > it's > > enough to have avoided OOM. > > I think it's good enough in HEAD. In the back branches, the sinval > queue growth is bad enough that the

Re: Expose lock group leader pid in pg_stat_activity

2019-12-26 Thread Guillaume Lelarge
Le mer. 25 déc. 2019 à 19:30, Julien Rouhaud a écrit : > On Wed, Dec 25, 2019 at 7:03 PM Julien Rouhaud wrote: > > > > Guillaume (in Cc) recently pointed out [1] that it's currently not > > possible to retrieve the list of parallel workers for a given backend > > at the SQL level. His use case

Re: Expose lock group leader pid in pg_stat_activity

2019-12-26 Thread Guillaume Lelarge
Le jeu. 26 déc. 2019 à 09:49, Julien Rouhaud a écrit : > On Thu, Dec 26, 2019 at 9:08 AM Guillaume Lelarge > wrote: > > > > Le mer. 25 déc. 2019 à 19:30, Julien Rouhaud a > écrit : > >> > >> On Wed, Dec 25, 2019 at 7:03 PM Julien Rouhaud > wrote

Re: Expose lock group leader pid in pg_stat_activity

2019-12-26 Thread Guillaume Lelarge
Le jeu. 26 déc. 2019 à 10:26, Julien Rouhaud a écrit : > On Thu, Dec 26, 2019 at 10:20 AM Guillaume Lelarge > wrote: > > > > Le jeu. 26 déc. 2019 à 09:49, Julien Rouhaud a > écrit : > >> > >> On Thu, Dec 26, 2019 at 9:08 AM Guillaume Lelarge > >>

Re: parallel vacuum options/syntax

2020-01-02 Thread Guillaume Lelarge
Le jeu. 2 janv. 2020 à 13:09, Amit Kapila a écrit : > Hi, > > I am starting a new thread for some of the decisions for a parallel vacuum > in the hope to get feedback from more people. There are mainly two points > for which we need some feedback. > > 1. Tomas Vondra has pointed out on the main

Re: parallel vacuum options/syntax

2020-01-03 Thread Guillaume Lelarge
Le ven. 3 janv. 2020 à 09:06, Amit Kapila a écrit : > On Thu, Jan 2, 2020 at 7:09 PM Guillaume Lelarge > wrote: > > > > Le jeu. 2 janv. 2020 à 13:09, Amit Kapila a > écrit : > >> > >> If parallel vacuum is *not* enabled by default, then I think the >

Quick doc typo fix

2019-05-28 Thread Guillaume Lelarge
Issue found while translating the v12 manual. I also fixed something that was missing, as far as I understand it (first fix, the typo is the second fix). See patch attached. Thanks. -- Guillaume. diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml index 4c7e93892a..f81f3d4160

Re: Quick doc typo fix

2019-05-28 Thread Guillaume Lelarge
Le mar. 28 mai 2019 à 21:28, Michael Paquier a écrit : > On Tue, May 28, 2019 at 05:05:10PM +0200, Guillaume Lelarge wrote: > > > > linkend="catalog-pg-am">pg_am > > - index access methods > > + table and index access methods

Re: Quick doc typo fix

2019-05-29 Thread Guillaume Lelarge
Le mar. 28 mai 2019 à 21:46, Guillaume Lelarge a écrit : > Le mar. 28 mai 2019 à 21:28, Michael Paquier a > écrit : > >> On Tue, May 28, 2019 at 05:05:10PM +0200, Guillaume Lelarge wrote: >> > >> >> linkend="catalog-pg-am">pg_am &

Re: Quick doc typo fix

2019-05-29 Thread Guillaume Lelarge
Le mer. 29 mai 2019 19:45, Michael Paquier a écrit : > On Wed, May 29, 2019 at 05:30:33PM +0200, Guillaume Lelarge wrote: > > And here is another one. See patch attached. > > Are you still going through some parts of the documentation? Perhaps > you may notice something else?

Re: Quick doc typo fix

2019-05-29 Thread Guillaume Lelarge
Le mer. 29 mai 2019 19:52, Michael Paquier a écrit : > On Wed, May 29, 2019 at 07:47:12PM +0200, Guillaume Lelarge wrote: > > Yeah, I still have quite a lot to process. That might be better to do it > > all in once. > > OK, thanks! Could you ping me on this thread once you

Re: Issue attaching a table to a partitioned table with an auto-referenced foreign key

2023-03-22 Thread Guillaume Lelarge
One last ping, hoping someone will have more time now than in january. Perhaps my test is wrong, but I'd like to know why. Thanks. Le mar. 17 janv. 2023 à 16:53, Guillaume Lelarge a écrit : > Quick ping, just to make sure someone can get a look at this issue :) > Thanks. > >

Issue attaching a table to a partitioned table with an auto-referenced foreign key

2023-01-06 Thread Guillaume Lelarge
Hello, One of our customers has an issue with partitions and foreign keys. He works on a v13, but the issue is also present on v15. I attach a SQL script showing the issue, and the results on 13.7, 13.9, and 15.1. But I'll explain the script here, and its behaviour on 13.9. There is one partitio

Re: Issue attaching a table to a partitioned table with an auto-referenced foreign key

2023-01-17 Thread Guillaume Lelarge
Quick ping, just to make sure someone can get a look at this issue :) Thanks. Le ven. 6 janv. 2023 à 11:07, Guillaume Lelarge a écrit : > Hello, > > One of our customers has an issue with partitions and foreign keys. He > works on a v13, but the issue is also present on v15. > &

Re: Probable memory leak with ECPG and AIX

2022-03-25 Thread Guillaume Lelarge
Le dim. 2 janv. 2022 à 01:07, Noah Misch a écrit : > On Sat, Jan 01, 2022 at 11:35:02AM -0500, Tom Lane wrote: > > Noah Misch writes: > > > I get the same results. The leak arises because AIX freelocale() > doesn't free > > > all memory allocated in newlocale(). The following program uses > tr

Re: Probable memory leak with ECPG and AIX

2022-03-25 Thread Guillaume Lelarge
Le ven. 25 mars 2022, 14:25, Tom Lane a écrit : > Guillaume Lelarge writes: > > Did this get anywhere? Is there something we could do to make this move > > forward? > > No. Write a patch? > I wouldn't have asked if I could write such a patch :-)

Re: REINDEX blocks virtually any queries but some prepared queries.

2022-04-07 Thread Guillaume Lelarge
Le jeu. 7 avr. 2022 à 15:44, Frédéric Yhuel a écrit : > > > On 4/7/22 14:40, Justin Pryzby wrote: > > On Thu, Apr 07, 2022 at 01:37:57PM +0200, Frédéric Yhuel wrote: > >> Maybe something along this line? (patch attached) > > Some language fixes. > > Thank you Justin! I applied your fixes in the v

pgbench translation

2022-04-13 Thread Guillaume Lelarge
Hello, I've been working yesterday on the translation of v15 .po french files. Once again, I've found that there was no .po file for oid2name, pgbench, and vacuumlo. I suppose that's because they are contrib applications. But pgbench is no longer a contrib application. It's now located in the "sr

Re: pgbench translation

2022-04-13 Thread Guillaume Lelarge
Le mer. 13 avr. 2022 à 11:29, Alvaro Herrera a écrit : > On 2022-Apr-13, Guillaume Lelarge wrote: > > > Once again, I've found that there was no .po file for oid2name, pgbench, > > and vacuumlo. I suppose that's because they are contrib applications. But > &

Re: Extensions not dumped when --schema is used

2021-04-15 Thread Guillaume Lelarge
Le jeu. 15 avr. 2021 à 09:58, Michael Paquier a écrit : > On Wed, Apr 14, 2021 at 05:31:15AM -0700, Noah Misch wrote: > > The name "without_extension_explicit_schema" arose because that test > differs > > from the "without_extension" test by adding --schema=public. The test > named > > "without_

"Multiple table synchronizations are processed serially" still happens

2021-04-28 Thread Guillaume Lelarge
Hi, One of my customers has an issue with logical replication. As $SUBJECT says, multiple table synchronization happens serially. To be honest, it doesn't do this every time. It happens when the tables are big enough. This issue was already described on this thread (from 2017): https://www.postgr

Re: "Multiple table synchronizations are processed serially" still happens

2021-04-28 Thread Guillaume Lelarge
Le mer. 28 avr. 2021 à 11:12, Guillaume Lelarge a écrit : > Hi, > > One of my customers has an issue with logical replication. As $SUBJECT > says, multiple table synchronization happens serially. To be honest, it > doesn't do this every time. It happens when the tables are

Re: "Multiple table synchronizations are processed serially" still happens

2021-05-11 Thread Guillaume Lelarge
Le mer. 28 avr. 2021 à 11:37, Guillaume Lelarge a écrit : > Le mer. 28 avr. 2021 à 11:12, Guillaume Lelarge > a écrit : > >> Hi, >> >> One of my customers has an issue with logical replication. As $SUBJECT >> says, multiple table synchronization happens seriall

Re: "Multiple table synchronizations are processed serially" still happens

2021-05-20 Thread Guillaume Lelarge
Hi, Le jeu. 20 mai 2021 à 12:09, Amit Kapila a écrit : > On Wed, Apr 28, 2021 at 2:43 PM Guillaume Lelarge > wrote: > > > > And it logs the "still waiting" message as long as the first table is > being synchronized. Once this is done, it releases the lock, a

Re: "Multiple table synchronizations are processed serially" still happens

2021-05-21 Thread Guillaume Lelarge
Le ven. 21 mai 2021 à 05:43, Amit Kapila a écrit : > On Fri, May 21, 2021 at 1:30 AM Guillaume Lelarge > wrote: > > > > > >> If so, the > >> problem might be that copying the data of the first table creates a > >> transaction which bloc

Issue on catalogs.sgml

2021-05-24 Thread Guillaume Lelarge
Hey, While working on the french translation of the manual, I found that one column of pg_stats_ext was on the pg_stats columns' list. Here is a quick patch to fix this. Regards. -- Guillaume. diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml index 8aebc4d12f..1063168646 100

Re: Issue on catalogs.sgml

2021-05-24 Thread Guillaume Lelarge
Le mar. 25 mai 2021 à 00:05, Tom Lane a écrit : > Guillaume Lelarge writes: > > While working on the french translation of the manual, I found that one > > column of pg_stats_ext was on the pg_stats columns' list. Here is a quick > > patch to fix this. > > Ri

Weird use of parentheses in the manual

2021-06-24 Thread Guillaume Lelarge
Hey, I was translating logicaldecoding.sgml, and I saw this sentence: There are multiple required streaming callbacks (stream_start_cb, stream_stop_cb, stream_abort_cb, stream_commit_cb and stream_change_cb) and two optional callbacks (stream_message_cb) and (stream_truncate_cb). The two last se

Re: Weird use of parentheses in the manual

2021-06-25 Thread Guillaume Lelarge
Le ven. 25 juin 2021 à 08:55, Amit Kapila a écrit : > On Thu, Jun 24, 2021 at 6:38 PM Amit Kapila > wrote: > > > > On Thu, Jun 24, 2021 at 5:27 PM Guillaume Lelarge > > wrote: > > > > > > Really tiny patch attached to fix this if it really is

Re: New committers: Daniel Gustafsson and John Naylor

2021-07-01 Thread Guillaume Lelarge
Le mer. 30 juin 2021 à 22:44, Tom Lane a écrit : > The Core Team would like to extend our congratulations to > Daniel Gustafsson and John Naylor, who have accepted invitations > to become our newest Postgres committers. > > Please join me in wishing them much success and few bugs. > > Congrats to

Re: Proposal: adding a better description in psql command about large objects

2022-06-05 Thread Guillaume Lelarge
Le ven. 3 juin 2022 à 19:29, Nathan Bossart a écrit : > On Fri, Jun 03, 2022 at 12:56:20PM -0400, Tom Lane wrote: > > Nathan Bossart writes: > >> Another option could be to move it after the "Input/Output" section so > that > >> it's closer to some other commands that involve files. I can't say

Add parallel columns for seq scan and index scan on pg_stat_all_tables and _indexes

2024-08-29 Thread Guillaume Lelarge
ive work with Benoit Lobréau, Jehan-Guillaume de Rorthais, and Franck Boudehen. Thanks. Regards. [1] https://www.postgresql.org/message-id/flat/b4220d15-2e21-0e98-921b-b9892543cc93%40dalibo.com [2] https://www.postgresql.org/message-id/flat/d657df20-c4bf-63f6-e74c-cb85a81d0383%40dalibo.com --

Add parallel columns for pg_stat_statements

2024-08-29 Thread Guillaume Lelarge
.postgresql.org/message-id/flat/d657df20-c4bf-63f6-e74c-cb85a81d0383%40dalibo.com [3] https://www.postgresql.org/message-id/flat/6acbe570-068e-bd8e-95d5-00c737b865e8%40gmail.com -- Guillaume. From 59fd586cac8f0bafb1fa66548424f2dab0b38f31 Mon Sep 17 00:00:00 2001 From: Guillaume Lelarge Date: Wed, 28 Aug

Re: Add parallel columns for seq scan and index scan on pg_stat_all_tables and _indexes

2024-09-04 Thread Guillaume Lelarge
Hi, Le mer. 4 sept. 2024 à 10:47, Bertrand Drouvot a écrit : > Hi, > > On Thu, Aug 29, 2024 at 04:04:05PM +0200, Guillaume Lelarge wrote: > > Hello, > > > > This patch was a bit discussed on [1], and with more details on [2]. It > > introduces four

Re: Add parallel columns for seq scan and index scan on pg_stat_all_tables and _indexes

2024-09-04 Thread Guillaume Lelarge
Le mer. 4 sept. 2024 à 14:58, Bertrand Drouvot a écrit : > Hi, > > On Wed, Sep 04, 2024 at 02:51:51PM +0200, Guillaume Lelarge wrote: > > Le mer. 4 sept. 2024 ą 10:47, Bertrand Drouvot < > bertranddrouvot...@gmail.com> > > a écrit : > > > > > I don&#x

Re: Add parallel columns for seq scan and index scan on pg_stat_all_tables and _indexes

2024-09-04 Thread Guillaume Lelarge
Hi, Le mer. 4 sept. 2024 à 16:18, Bertrand Drouvot a écrit : > Hi, > > On Wed, Sep 04, 2024 at 02:51:51PM +0200, Guillaume Lelarge wrote: > > Hi, > > > > Le mer. 4 sept. 2024 à 10:47, Bertrand Drouvot < > bertranddrouvot...@gmail.com> > > a écri

Re: Add parallel columns for seq scan and index scan on pg_stat_all_tables and _indexes

2024-09-04 Thread Guillaume Lelarge
Le jeu. 5 sept. 2024 à 07:36, Bertrand Drouvot a écrit : > Hi, > > On Wed, Sep 04, 2024 at 04:37:19PM +0200, Guillaume Lelarge wrote: > > Hi, > > > > Le mer. 4 sept. 2024 à 16:18, Bertrand Drouvot < > bertranddrouvot...@gmail.com> > > a écrit : > &g

Quick doc patch

2020-07-07 Thread Guillaume Lelarge
Hi, Here is a quick issue I found on the BRIN documentation. I'm not a 100% sure I'm right but it looks like a failed copy/paste from the GIN documentation. Cheers. -- Guillaume. diff --git a/doc/src/sgml/brin.sgml b/doc/src/sgml/brin.sgml index 4c5eeb875f..55b6272db6 100644 --- a/doc/src/sgml

Re: min_wal_size > max_wal_size is accepted

2020-05-07 Thread Guillaume Lelarge
Hi, Le jeu. 7 mai 2020 à 11:13, Marc Rechté a écrit : > Hello, > > It is possible to startup an instance with min > max, without the system > complaining: > > mrechte=# show min_wal_size ; > > 2020-05-07 11:12:11.422 CEST [11098] LOG: durée : 0.279 ms > > min_wal_size > > -- > >

Extensions not dumped when --schema is used

2020-05-20 Thread Guillaume Lelarge
Hello, I've discovered something today that I didn't really expect. When a user dumps a database with the --schema flag of pg_dump, extensions in this schema aren't dumped. As far as I can tell, the documentation isn't clear about this ("Dump only schemas matching pattern; this selects both the sc

Re: Extensions not dumped when --schema is used

2020-05-20 Thread Guillaume Lelarge
Le mer. 20 mai 2020 à 11:26, Daniel Gustafsson a écrit : > > On 20 May 2020, at 10:06, Guillaume Lelarge > wrote: > > > I was wondering the reason behind this choice. If anyone knows, I'd be > happy to hear about it. > > Extensions were dumped unconditiona

Re: Extensions not dumped when --schema is used

2020-05-23 Thread Guillaume Lelarge
Le mer. 20 mai 2020 à 16:39, Tom Lane a écrit : > Guillaume Lelarge writes: > > Le mer. 20 mai 2020 à 11:26, Daniel Gustafsson a > écrit : > >> The question is what --extensions should do: only dump any > >> extensions that objects in the schema depend on

Re: Default gucs for EXPLAIN

2020-05-25 Thread Guillaume Lelarge
Le mar. 26 mai 2020 à 04:27, Stephen Frost a écrit : > Greetings, > > * Michael Paquier (mich...@paquier.xyz) wrote: > > On Mon, May 25, 2020 at 09:36:50PM -0400, Bruce Momjian wrote: > > > I am not excited about this new feature. Why do it only for EXPLAIN? > > Would probably help to understand

Re: Default gucs for EXPLAIN

2020-05-26 Thread Guillaume Lelarge
Le mar. 26 mai 2020 à 16:25, Stephen Frost a écrit : > Greetings, > > * Guillaume Lelarge (guilla...@lelarge.info) wrote: > > Le mar. 26 mai 2020 à 04:27, Stephen Frost a écrit > : > > > To that end- what if this was done client-side with '\explain' or >

Re: Default gucs for EXPLAIN

2020-06-02 Thread Guillaume Lelarge
Le mer. 3 juin 2020 à 04:16, David Fetter a écrit : > On Tue, Jun 02, 2020 at 09:28:48PM +0200, Vik Fearing wrote: > > On 6/2/20 7:54 PM, David G. Johnston wrote: > > > At this point, given the original goal of the patch was to try and > > > grease a smoother path to changing the default for BUFF

Re: Quick doc typo fix

2019-06-08 Thread Guillaume Lelarge
Le sam. 8 juin 2019 à 15:44, Julien Rouhaud a écrit : > On Sat, Jun 8, 2019 at 3:33 PM Michael Paquier > wrote: > > > > Hi Guillaume, > > > > On Wed, May 29, 2019 at 08:28:59PM +0200, Guillaume Lelarge wrote: > > > Sure. > > > > I hav

Re: Quick doc typo fix

2019-06-10 Thread Guillaume Lelarge
Le dim. 9 juin 2019 à 04:27, Michael Paquier a écrit : > On Sat, Jun 08, 2019 at 04:23:55PM +0200, Guillaume Lelarge wrote: > > We might find more typos, but it will take time. Applying this patch now > > (if it fits you) is probably better. > > I can imagine that it is a

Re: Quitting the thes

2019-06-12 Thread Guillaume Lelarge
Le mer. 12 juin 2019 à 20:45, Alvaro Herrera a écrit : > On 2019-May-14, Michael Paquier wrote: > > > Thanks, committed. I have noticed an extra one in reorderbuffer.c. > > Some grepping found a bit more; patch attached. > > Thanks a lot, this is very good. I've got some fixes to do :) -- Gui

Re: Add parallel columns for pg_stat_statements

2024-10-08 Thread Guillaume Lelarge
Le mer. 9 oct. 2024 à 01:33, Michael Paquier a écrit : > On Tue, Oct 08, 2024 at 03:53:16PM +0200, Guillaume Lelarge wrote: > > I've done a bit of testing with the three patches, and didn't find any > > issue with them. > > Okay, applied 0001 and 0002 then aft

Re: Add parallel columns for pg_stat_statements

2024-10-08 Thread Guillaume Lelarge
Hi, Le mar. 8 oct. 2024 à 09:29, Michael Paquier a écrit : > On Mon, Oct 07, 2024 at 10:00:13AM +0200, Guillaume Lelarge wrote: > > Le lun. 7 oct. 2024 à 02:18, Michael Paquier a > écrit : > >> I'd recommend to split that into more independent patches: > >&

Re: Parallel workers stats in pg_stat_database

2024-10-11 Thread Guillaume Lelarge
Le mar. 8 oct. 2024 à 14:03, Benoit Lobréau a écrit : > On 10/7/24 10:19, Guillaume Lelarge wrote: > > I've done the split, but I didn't go any further than that. > > Thank you Guillaume. I have done the rest of the reformatting > suggested by Michael but I decided to

Re: Add parallel columns for seq scan and index scan on pg_stat_all_tables and _indexes

2024-10-06 Thread Guillaume Lelarge
Le lun. 7 oct. 2024 à 02:41, Michael Paquier a écrit : > On Mon, Oct 07, 2024 at 12:43:18AM +0300, Alena Rybakina wrote: > > Maybe I'm not aware of the whole context of the thread and maybe my > > questions will seem a bit stupid, but honestly > > it's not entirely clear to me how this statistics

Re: Add parallel columns for pg_stat_statements

2024-10-07 Thread Guillaume Lelarge
Le lun. 7 oct. 2024 à 02:18, Michael Paquier a écrit : > On Sun, Oct 06, 2024 at 03:32:02PM +0200, Guillaume Lelarge wrote: > > I'm not sure I follow. That would mean that every time a query is > executed, > > it always gets the same amount of workers. Which is not gu

Re: Parallel workers stats in pg_stat_database

2024-10-07 Thread Guillaume Lelarge
adds the metrics (same patch than v3-0001 for pg_stat_statements) * v5-0002 handles the metrics for pg_stat_database. "make check" works, and I also did a few other tests without any issues. Regards. -- Guillaume. From 9413829616bdc0806970647c15d7d6bbd96489d1 Mon Sep 17 00:00:00 2001 Fro

Re: Add parallel columns for pg_stat_statements

2024-10-06 Thread Guillaume Lelarge
Hi Michael, Le jeu. 3 oct. 2024 à 09:15, Michael Paquier a écrit : > On Thu, Aug 29, 2024 at 10:08:23PM +0200, Guillaume Lelarge wrote: > > This patch was a bit discussed on [1], and with more details on [2]. It's > > based on another patch sent in 2022 (see [3]). It

Re: Add parallel columns for seq scan and index scan on pg_stat_all_tables and _indexes

2024-10-06 Thread Guillaume Lelarge
Hello, Le jeu. 5 sept. 2024 à 08:19, Guillaume Lelarge a écrit : > Le jeu. 5 sept. 2024 à 07:36, Bertrand Drouvot < > bertranddrouvot...@gmail.com> a écrit : > >> Hi, >> >> On Wed, Sep 04, 2024 at 04:37:19PM +0200, Guillaume Lelarge wrote: >> >

Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE

2024-11-11 Thread Guillaume Lelarge
Hi, Le mer. 6 nov. 2024 à 17:57, Michael Christofides a écrit : > [...] > I agree. In the past 6 versions, 5 new parameters have been added. > SETTINGS in v12, WAL in v13, GENERIC_PLAN in v16, SERIALIZE in > v17, and MEMORY in v17. It feels like we should have some easier way > to get everything

Re: Add parallel columns for seq scan and index scan on pg_stat_all_tables and _indexes

2024-11-11 Thread Guillaume Lelarge
Le lun. 11 nov. 2024 à 03:05, Michael Paquier a écrit : > On Tue, Oct 08, 2024 at 06:24:54PM +0300, Alena Rybakina wrote: > > yes, I agree with you. Even when I experimented with vacuum settings for > > database and used my vacuum statistics patch [0] for analyzes , I first > > looked at this cha

Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE

2024-11-12 Thread Guillaume Lelarge
Le mar. 12 nov. 2024 à 16:35, Guillaume Lelarge a écrit : > Le mar. 12 nov. 2024 à 16:21, Robert Haas a > écrit : > >> On Mon, Nov 11, 2024 at 3:59 PM Guillaume Lelarge >> wrote: >> > Agreed. Having an "EXPLAIN (ALL)" would be a great addition. I could &

Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE

2024-11-12 Thread Guillaume Lelarge
Le mar. 12 nov. 2024 à 16:21, Robert Haas a écrit : > On Mon, Nov 11, 2024 at 3:59 PM Guillaume Lelarge > wrote: > > Agreed. Having an "EXPLAIN (ALL)" would be a great addition. I could > tell a customer to do an "EXPLAIN (ALL)", rather than first asking th

Re: Add parallel columns for pg_stat_statements

2024-11-07 Thread Guillaume Lelarge
Le jeu. 7 nov. 2024 à 04:19, Michael Paquier a écrit : > On Wed, Oct 09, 2024 at 08:32:52AM +0900, Michael Paquier wrote: > > Okay, applied 0001 and 0002 then after a second lookup. I'll spend > > some more time thinking about 0003 and the other threads. > > Considered 0003, and I'm still not su

Re: Logging parallel worker draught

2024-11-29 Thread Guillaume Lelarge
Hi, Le sam. 19 oct. 2024 à 06:46, Benoit Lobréau a écrit : > On 10/15/24 09:52, Benoit Lobréau wrote: > > Thank you, it's a lot cleaner that way. > > I'll add this asap. > > This is an updated version with the suggested changes. > > AFAICT, Benoit answered to all questions and requests. Is there

Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE

2024-11-19 Thread Guillaume Lelarge
Hello, Le mar. 12 nov. 2024 à 22:21, Robert Haas a écrit : > On Tue, Nov 12, 2024 at 4:02 PM Guillaume Lelarge > wrote: > > Sure looks easy enough to do (though it still lacks doc and tests > changes). See patch attached. > > Yep, that's very small. I'm a

Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE

2024-11-20 Thread Guillaume Lelarge
Le mer. 20 nov. 2024 à 16:51, Greg Sabino Mullane a écrit : > On Wed, Nov 20, 2024 at 1:26 AM Guillaume Lelarge > wrote: > >> OK, but I'm not sure which example I should pick to add dirtied and >> written shared buffers. It looks kinda artificial. Should I choose one &

Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE

2024-11-19 Thread Guillaume Lelarge
ain queries to run > cross-version), and BUFFERS OFF outside of analyze is meaningless. > > Done in v3 with David's idea. -- Guillaume. From 5b815f71e874522bcc5947a29623328fdc76104b Mon Sep 17 00:00:00 2001 From: Guillaume Lelarge Date: Tue, 12 Nov 2024 21:59:14 +0100 Subject:

Add a warning message when using unencrypted passwords

2024-12-07 Thread Guillaume Lelarge
tever fits better for him/her. I'm interested in any comments about this. I didn't create a commitfest entry yet, I'm mostly waiting on your comments. Thanks. Regards. [1] https://postgresql.life/post/divya_sharma/ -- Guillaume. From 6415a0dcf0a2735ee160c648b9452f3aa5d52e9c Mon

Re: Add a warning message when using unencrypted passwords

2024-12-09 Thread Guillaume Lelarge
Hi, Le lun. 9 déc. 2024 à 14:40, Daniel Gustafsson a écrit : > > On 9 Dec 2024, at 14:26, Greg Sabino Mullane wrote: > > > -1 to throwing an ERROR - that's not really an error, and not our call > to make, so a WARNING is sufficient. > > Agreed, regardless of how bad it's considered, it's not an

Re: Log connection establishment timings

2025-01-06 Thread Guillaume Lelarge
Hello, Le lun. 16 déc. 2024 à 22:00, Melanie Plageman a écrit : > Hi, > > Users wishing to debug slow connection establishment have little > visibility into which steps take the most time. We don't expose any > stats and none of the logging includes durations. > > The attached patch logs duratio

Re: Add a warning message when using unencrypted passwords

2025-02-04 Thread Guillaume Lelarge
On 09/12/2024 15:58, Guillaume Lelarge wrote: Hi, Le lun. 9 déc. 2024 à 14:40, Daniel Gustafsson <mailto:dan...@yesql.se>> a écrit : > On 9 Dec 2024, at 14:26, Greg Sabino Mullane mailto:htamf...@gmail.com>> wrote: > -1 to throwing an ERROR - that's not re

Re: Add a warning message when using unencrypted passwords

2025-02-04 Thread Guillaume Lelarge
On 04/02/2025 17:59, Tom Lane wrote: Guillaume Lelarge writes: v2 is attached. This seems pretty much entirely useless to me. The password has already been leaked to the log (*and* the network, if session is unencrypted), so what's the point of a warning? And as already noted, this ig

Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE

2024-12-11 Thread Guillaume Lelarge
Le mer. 11 déc. 2024 à 21:41, Jelte Fennema-Nio a écrit : > On Wed, 11 Dec 2024 at 10:38, David Rowley wrote: > > I've pushed the main patch. I'm not planning on pushing the > > auto_explain.log_buffers default change unless there's a bit more > > discussion about it. > > FreeBSD CFBot seems bro

Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE

2024-12-11 Thread Guillaume Lelarge
Le mer. 11 déc. 2024 à 15:00, jian he a écrit : > do we also need to update doc/src/sgml/rules.sgml? > > https://www.postgresql.org/docs/current/rules-materializedviews.html > Yes, you're right. Here is a fix. (Not a patch with a commit message as I don't know if David will want to commit everyt

Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE

2024-12-11 Thread Guillaume Lelarge
Le mer. 11 déc. 2024 à 12:16, David Rowley a écrit : > On Wed, 11 Dec 2024 at 22:38, David Rowley wrote: > > I've pushed the main patch. I'm not planning on pushing the > > auto_explain.log_buffers default change unless there's a bit more > > discussion about it. > > There were a few places that

Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE

2024-12-10 Thread Guillaume Lelarge
Hello, Le mar. 10 déc. 2024 à 03:57, David Rowley a écrit : > On Thu, 21 Nov 2024 at 08:30, Guillaume Lelarge > wrote: > > OK, I'm fine with this. v4 patch attached with one plan showing read, > written, and dirtied buffers. > > Today I spent more time polishing th

Re: explain analyze rows=%.0f

2025-01-11 Thread Guillaume Lelarge
Le sam. 11 janv. 2025 à 12:10, Ilia Evdokimov a écrit : > > On 11.01.2025 12:15, Guillaume Lelarge wrote: > > > > Thanks for your patch, this looks like a very interesting feature that I'd > like to see in a future release. > > It did a quick run: patch OK, ma

Re: improve DEBUG1 logging of parallel workers for CREATE INDEX?

2025-01-11 Thread Guillaume Lelarge
Le jeu. 9 janv. 2025 à 04:24, Sami Imseih a écrit : > > Of course, a patch for that would be a few orders of magnitude > > larger than what you've got here :-(. But if you're looking > > for a framework for reporting these sorts of details, I'd > > much rather go in that direction than follow th

Re: explain analyze rows=%.0f

2025-01-11 Thread Guillaume Lelarge
Hello, Le jeu. 12 déc. 2024 à 12:57, Ilia Evdokimov a écrit : > > On 01.08.2023 23:29, Daniel Gustafsson wrote: > >> On 3 Jul 2023, at 18:34, Daniel Gustafsson wrote: > >> > >>> On 8 Jun 2023, at 19:49, Ibrar Ahmed wrote: > >>> On Mon, Mar 20, 2023 at 7:56 PM Gregory Stark (as CFM) < > stark..

Re: improve DEBUG1 logging of parallel workers for CREATE INDEX?

2025-01-08 Thread Guillaume Lelarge
Hi, Le mer. 8 janv. 2025 à 18:37, Sami Imseih a écrit : > > s/parallel vacuum workers for index vacuuming/parallel workers for index > creation/? > > oops, that's my oversight from copying the message from vacuum. fixed. > > > I'd add "in parallel" to match its counterpart "serially" above. That

  1   2   >