On Mon, Mar 7, 2022, at 4:59 PM, Álvaro Herrera wrote:
> I attach v13 here. This version includes a 0002 that's does the split of
> nodeModifyTable.c routines, then 0003 implements MERGE on top of that. 0001
> is as before.
In 0002, I've opted to have two separate s
logic as UPDATE?
>
> I think explanation should be given.
Actually, the routine in question is only handling insert, not UPDATE,
so MERGE is not relevant to the function. I have removed the comment.
This was probably a leftover from work prior to 86dc90056dfd; that
commit made it
artition to use ItemPointerSetMovedPartitions
instead of doing ItemPointerSet directly. But that looks mostly
pointless, since the extensibility aspect of this interface has been
superseded by table AM work. I agree we should just remove the macro
and update the comment as you suggest.
--
Álvaro Herrera Valdivia, Chile
Here's an updated patch.
I haven't added commentary or documentation to account for the new
assumption, per Matthias' comment and Robert's discussion thereof.
--
Álvaro Herrera39°49'30"S 73°17'W
"Cada quien es cada cual y b
On 2021-Feb-21, Michael Paquier wrote:
> On Sat, Feb 20, 2021 at 12:25:58PM -0300, Álvaro Herrera wrote:
> > Hmm. Alternatively, maybe it'd make sense to change
> > HeapTupleHeaderSetMovedPartition to use ItemPointerSetMovedPartitions
> > instead of doing ItemPoin
On 2021-Feb-22, Álvaro Herrera wrote:
> Here's an updated patch.
>
> I haven't added commentary or documentation to account for the new
> assumption, per Matthias' comment and Robert's discussion thereof.
Done that. I also restructured the code a bit, since one
he end
effect should be the same. But if we want to make that claim to save
that one assignment, we can make it in a separate commit. However,
given that this comparison and assignment is outside the locked area, I
don't think it's worth bothering with.
Thanks for the input! I have pushed
I tweaked this code a little bit more. I didn't like that libpq-trace.h was
exposing all the internal details of the API to the world; and I liked it even
less that libpq-int.h had to include the file, exposing everything everywhere.
I added some forward struct declarations in libpq-int.h to avo
It appears that something is still wrong. I applied lipq pipeline v27 from [1]
and ran src/test/modules/test_libpq/pipeline singlerow, after patching it to do
PQtrace() after PQconn(). Below is the output I get from that. The noteworthy
point is that "ParseComplete" messages appear multiple tim
This assert I added?
> +static bool
> +pqTraceMaybeBreakLine(int size, PGconn *conn)
> +{
> + Assert(conn->be_msg->length > 0);
It breaks. Maybe there's a good reason, maybe there ain't, but in the
meantime I just removed it.
--
Álvaro Herrera Valdivia
Thanks Amit for working on this fix! It seems correct to me, so I pushed it
with trivial changes. Thanks Bertrand for reporting the problem.
In addition to backpatching the code fix to pg12, I backpatched the test case
to pg11. It worked fine for me (with no code changes), but it seems good to
unction. What do you think?
That's a good idea. Pushed with that change, thanks.
Thanks also to Dmitry and Hamid for the reviews.
--
Álvaro Herrera39°49'30"S 73°17'W
On 2021-Jan-12, Álvaro Herrera wrote:
> > For the 0001 patch, since ReindexIndexInfo is used only within
> > ReindexRelationConcurrently() I think it’s a function-local structure
> > type. So we can declare it within the function. What do you think?
>
> That's a
On 2021-Jan-12, Álvaro Herrera wrote:
> On 2021-Jan-12, Álvaro Herrera wrote:
>
> > > For the 0001 patch, since ReindexIndexInfo is used only within
> > > ReindexRelationConcurrently() I think it’s a function-local structure
> > > type. So we can declare it withi
So one last remaining improvement was to have VACUUM ignore processes
doing CIC and RC to compute the Xid horizon of tuples to remove. I
think we can do something simple like the attached patch.
--
Álvaro Herrera Valdivia, Chile
"Aprender sin pensar es inútil; pensar sin apr
table during the initial index build process (which is
> currently guaranteed through the use of a snapshot).
VACUUM cannot run concurrently with CIC or RI in a table -- both acquire
ShareUpdateExclusiveLock, which conflicts with itself, so this cannot
occur.
I do wonder if the problem you suggest
On 2021-Jan-18, Matthias van de Meent wrote:
> On Fri, 15 Jan 2021 at 15:29, Álvaro Herrera wrote:
> Would this not need to be the following? Right now, it resets
> potentially older h->catalog_oldest_nonremovable (which is set in the
> PROC_IN_SAFE_IC branch).
>
&
uld use in an automated check
somewhere (next to stuff like perlcritic, perhaps). I don't know what,
though.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Cuando no hay humildad las personas se degradan" (A. Christie)
On 2021-Feb-24, Michael Paquier wrote:
> On Mon, Feb 22, 2021 at 05:15:57PM -0300, Álvaro Herrera wrote:
> > I changed my mind on this after noticing that
> > ItemPointerIndicatesMovedPartitions has a few callers; leaving the
> > interface incomplete/asymmetric would be worse
serious problem actually. I think it
represents a gap in testing. Thanks for reporting.
--
Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/
the regression tests.
(Don't get me wrong -- I don't think this is terribly useful
functionality. I just think that if the code is already prepared to
handle it, we may as well let it.)
One thing I didn't quite like is that the count of affected tuples seems
off, but IIRC that's already the case for trigger-redirected tuples in
legacy-style partitioning, so I'm not too worried about that.
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
wise it work correctly.
> In any case, I have a feeling that the planner would catch any
> problematic cases if there're any while converting MergeAction
> expressions into the individual child table layouts.
Yeah, AFAICS it worked fine for the case I tried. Maybe there are more
ut, but in array context it gives you a map, so you should be able
> to say things like:
>
> my %node_config = $node->config_data;
Hi, it looks to me like these were forgotten?
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
Thanks for re-reviewing! This one I hope is the last version.
On Wed, Apr 28, 2021, at 10:21 AM, Amit Langote wrote:
> I noticed that rd_partdesc_nodetached_xmin can sometimes end up with
> value 0. While you seem to be already aware of that, because otherwise
> you wouldn't have added Transaction
Pushed that now, with a one-line addition to the docs that only one
partition can be marked detached.
--
Álvaro Herrera39°49'30"S 73°17'W
"That sort of implies that there are Emacs keystrokes which aren't obscure.
I've been using it dail
#x27;s get rid of that.
Are you getting this set pushed, or would you like me to handle it?
(There seems to be some minor conflict in 13)
--
Álvaro Herrera Valdivia, Chile
"Pido que me den el Nobel por razones humanitarias" (Nicanor Parra)
>From 7f31b0ec12e52b6c96704738435389553816
you're using repeatable read
transactions. I didn't see it as terribly critical since it's supposed
to be very transient, but I may be wrong.
--
Álvaro Herrera Valdivia, Chile
"Hay quien adquiere la mala costumbre de ser infeliz" (M. A. Evans)
7;m not sure it's worth pointing this out in this paragraph.
> May be make sense to add some details about DETACH CONCURRENTLY to the
> section '5.11.2.2. Partition Maintenance' and completely remove this point?
Maybe you're right, though.
--
Álvaro Herrera
I also tweaked the wording to match the surrounding text a bit better,
at least IMO. Feel free to suggest improvements.
Thanks!
--
Álvaro Herrera39°49'30"S 73°17'W
"That sort of implies that there are Emacs keystrokes which aren't obscure.
I
es covered with this. I would like to at least see it in master,
to gather some reactions from buildfarm.
--
Álvaro Herrera Valdivia, Chile
It does it in a really, really complicated way
why does it need to be complicated?
Because it's MakeMaker.
>From f296a5b880a5688656d308300d1
On 2021-Jun-10, Álvaro Herrera wrote:
> I wrote a test (0002) to cover the case of signalling a walsender, which
> is currently not covered (we only deal with the case of a standby that's
> not running). There are some sharp edges in this code -- I had to make
> it use backgrou
On 2021-Jun-10, Álvaro Herrera wrote:
> Here's a version that I feel is committable (0001). There was an issue
> when returning from the inner loop, if in a previous iteration we had
> released the lock. In that case we need to return with the lock not
> held, so that the call
On 2021-Apr-07, Andres Freund wrote:
> After this I don't see a reason to have SAB_Inquire - as far as I can
> tell it's practically impossible to use without race conditions? Except
> for raising an error - which is "builtin"...
Pushed 0002.
On 2021-Jun-11, Álvaro Herrera wrote:
> I tried hard to make this stable, but it just isn't (it works fine one
> thousand runs, then I grab some coffee and run it once more and that one
> fails. Why? that's not clear to me). Attached is the last one I have,
> in case som
Apologies, I inadvertently sent the version before I added a maximum
number of iterations in the final loop.
--
Álvaro Herrera Valdivia, Chile
"La fuerza no está en los medios físicos
sino que reside en una voluntad indomable" (Gandhi)
>From 1492e9468ecd86167a1253c4a2e9b311398
Hah, desmoxytes failed once:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=desmoxytes&dt=2021-06-19%2003%3A06%3A04
I'll revert it and investigate later. There have been no other
failures.
--
Álvaro Herrera39°49'30"S 73°17'W
not after.
I accounted for all those things and pushed again.
--
Álvaro Herrera Valdivia, Chile
"I can see support will not be a problem. 10 out of 10."(Simon Wittber)
(http://archives.postgresql.org/pgsql-general/2004-12/msg00159.php)
_class
> field suddenly becomes false.
Uh, ouch.
I'll look into this shortly.
--
Álvaro HerreraValdivia, Chile
https://www.EnterpriseDB.com/
ticed that part of that comment seems to be a leftover from ... I
don't know when: "We do not analyze index columns if there was an
explicit column list in the ANALYZE command, however." I suppose this
is about some code that was removed, but I didn't dig into it.
--
Álvaro
still pass true when there are indexes.
Please don't forget to trim the text of the email you're replying to.
--
Álvaro HerreraValdivia, Chile
https://www.EnterpriseDB.com/
n't think it's a readability improvement.
> My thinking is that without hasindex, the code is easier to maintain.
You have one less variable but one additional concept (negative
nindexes). It doesn't seem easier to me, TBH, rather the opposite.
--
Álvaro Herrera
hat with RelationGetIndexList() and checking if the list
is nonempty, specifically for the partitioned table case. Pushed now.
Thanks for reporting and fixing this, and to Zhihong Yu for reviewing.
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
"Investigación es lo que hago
On 2021-Jul-05, vignesh C wrote:
> On Wed, Jun 23, 2021 at 7:32 PM Álvaro Herrera
> wrote:
> >
> > On 2021-Jun-20, Tom Lane wrote:
> >
> > > Actually ... isn't there a second race, in the opposite direction?
> > > IIUC, the point of this is that
On Fri, Jun 10, 2022, at 8:25 AM, Kyotaro Horiguchi wrote:
>
> The current implement of PQsendQueryInternal looks like the result of
> a misunderstanding of the doc. In the regression tests, that path is
> excercised only for an error case, where no CloseComplete comes.
>
> The attached adds a t
On Wed, Jun 1, 2022, at 5:28 PM, Alvaro Herrera wrote:
> Re-reading the modified paragraph, I propose "see X for a thorough
> explanation on the behavior of MERGE under concurrency". However, in
> the proposed patch the link goes to Chapter 13 "Concurrency Control",
> and the explanation that we i
The comment atop config_data still mentions $option, but after the patch that's
no longer a name used in the function. (I have to admit that using @_ in the
body of the function was a little bit confusing to me at first. Did you do that
in order to allow multiple options to be passed?)
Also: if
specific commands, which is where I believe it belongs.
Thanks!
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
Thou shalt study thy libraries and strive not to reinvent them without
cause, that thy code may be short and readable and thy days pleasant
and productive
On 2022-Aug-01, Justin Pryzby wrote:
> On Tue, Jun 14, 2022 at 11:27:06AM +0200, Álvaro Herrera wrote:
> > @@ -448,9 +448,9 @@ COMMIT;
> > and execute the first one that succeeds.
> > If MERGE attempts an INSERT
> > and a unique index is present and a du
On 2022-Aug-01, Álvaro Herrera wrote:
> > > If MERGE attempts an INSERT
> > > and a unique index is present and a duplicate row is concurrently
> > > +inserted, then a uniqueness violation error is raised;
> > > +MERGE does not attemp
On 2021-Aug-27, Justin Pryzby wrote:
> I noticed that for \dP+ since 1c5d9270e, regclass is written without
> "pg_catalog." (Alvaro and I failed to notice it in 421a2c483, too).
Oops, will fix shortly.
--
Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/
cuum | 0
I don't disagree, but it's not easy to implement this at present. I
think almost all counters should be nulls for partitioned tables. For
some of them one could make a case that it'd be more convenient to
propagate numbers up from partitions.
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
Here is a proposal for 14. This patch has four main changes:
* The mod counts are only propagated to the topmost parent, not to each
ancestor. This means that we'll only analyze the topmost partitioned table and
not each intermediate partitioned table; seems a good compromise to avoid
samplin
On 2021-Aug-13, Álvaro Herrera wrote:
> Some doc changes are pending, and some more commentary in parts of the
> code, but I think this is much more sensible. I do lament the lack of
> a syscache for pg_inherits.
Thinking about this again, this one here is the killer problem, I th
Here's the reversal patch for the 14 branch. (It applies cleanly to
master, but the unused member of PgStat_StatTabEntry needs to be
removed and catversion bumped).
--
Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/
Maybe there's lots of
t I meant with the patch being for v14 and
a tweak needed for this in master.
A catversion bump would be required to change the definition of
pg_stat_user_tables, which the patch being reverted originally changed
to include relkind 'p'. A straight revert would remove that, but in my
revers
that?
1. Do nothing. If somebody finds in that situation, they can use
ALTER TABLE .. RESET ...
to remove the settings.
2. Silently accept the option and do nothing.
3. Accept the option and throw a warning that it's a no-op.
4. Something else
Opinions?
--
Álvaro Herrera
On 2021-Aug-16, Álvaro Herrera wrote:
> Here's the reversal patch for the 14 branch. (It applies cleanly to
> master, but the unused member of PgStat_StatTabEntry needs to be
> removed and catversion bumped).
I have pushed this to both branches. (I did not remove the item fr
ywhere. I hope this isn't too confusing.
The standard's text on this, in section "4.13 Columns, fields, and
attributes", is
Every column has a nullability characteristic that indicates whether
the value from that column can be the null value. A nullability
cha
ALTER TABLE DETACH CONCURRENTLY had to deal with this also, and it did it by
having a COMPLETE option you can run later in case things got stuck the first
time around. I suppose we could do something similar, where the server
automatically does the needful, whatever that is.
On 2023-Jul-01, Thom Brown wrote:
> On Thu, 29 Jun 2023, 14:45 Álvaro Herrera, wrote:
>
> > ALTER TABLE DETACH CONCURRENTLY had to deal with this also, and it did it
> > by having a COMPLETE option you can run later in case things got stuck the
> > first time aroun
m
> could make things easier for a bgworker implementation, perhaps?
TBH I don't understand what you are thinking about.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"I can see support will not be a problem. 10 out of 10."(Simon Wittber
On 2020-Oct-05, Heikki Linnakangas wrote:
> The code in sendFile() in basebackup.c seems suspicious in that regard. It
> calls DataChecksumsNeedVerify() once before starting to read the file. Isn't
> it possible for the checksums flag to change while it's reading the file and
> sending it to the c
copy_statement_fmt = "copy %s from stdin with (freeze
> on)";
can be "&& get_table_relkind(con, table) == RELKIND_RELATION"
which I think is more natural.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
Checks stores the wrong thing. No?) Or maybe use
AddRelationNewConstraints() instead, which is an already exposed function.
What I'm saying is just that we should be more watchful of what we put
in our .h files.
Note: I didn't actually review the patch.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
the table-listing code for publications skip any foreign
tables. For instance, GetPubPartitionOptionRelations() and
PublicationAddTables() should skip tables with relkind RELKIND_FOREIGN.
The sync code should also silently ignore all foreign tables.
--
Álvaro Herrera 48
;d rather not burden translators with figuring
> out what to do with that. Is it worth creating pg_log_error_internal,
> equivalently to elog and errmsg_internal in the backend?
At this point I would just add a "translator:" comment that explains
that the ??? bit is for unexpected cas
w sorting patches by total additions/deletions (added together
> for total lines changed)
Seems reasonable, though I don't see much of an use-case for this.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Postgres is bloatware by design: it was built t
t the difference is small on Intel chips and that
Jenkins' hash is better on AMD chips.
https://github.com/google/cityhash
Anyway if you wanted to try your luck at improving things, here's your
chance.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
TION), and whether there are any publications that are FOR ALL
TABLES that would be affected.
(If we later figure out a way to allow publish_via_partition_root and
skip the tuples in foreign partitions, it's easy to remove the
restriction.)
--
Álvaro Herrera 4
t for others: during the FOSDEM
> meeting 4 was a column on the commitfest page, but I reverted that
> after the feedback there)
>
> So, I guess clutter wise the current staging is acceptable to you.
Check.
> On Tue, 4 Feb 2025 at 17:27, Álvaro Herrera wrote:
> > 2. a per
gt; trying to look up the string, but surely we aren't concerned
> about that here --- we just want to not burden translators
> with the string.
Yeah, okay, that seems good enough for me. I agree that the cost of an
unnecessary gettext() call is negligible.
--
Álvaro Herrera
methods, we go look in pg_am for one with amtype='c' and the given name.
That gives you the function that initializes the Copy state.
This is convenient enough because system administrators can add COPY
formats that anyone can use, and doesn't allow to call arbitrary
functions
ny such comments. Those would
typically be elog() or the errfoo_internal() cases, I think.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"El sudor es la mejor cura para un pensamiento enfermo" (Bardia)
mam\303\241,
Anyway, at least the bytes appear to be interpreted the same by both
openssl and this new function, so that's good news.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Having your biases confirmed independently is how scientific progress is
made, and hence made our great society what it is today" (Mary Gardiner)
lues are
> ARCHIVER,
> +AUTOVACUUM, BACKEND,
> +BGWORKER, BGWRITER,
> +CHECKPOINTER, LOGGER,
> +SLOTSYNCWORKER, WALRECEIVER,
> +WALSENDER, WALSUMMARIZER, and
> +WALWRITER.
--
Álvaro HerreraBreisgau, Deutschland — https://www.EnterpriseDB.com/
"No necesitamos banderas
No reconocemos fronteras" (Jorge González)
ng
all the bits in the value, um.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
On 2025-Feb-06, Álvaro Herrera wrote:
> On 2025-Feb-06, Zhang Mingli wrote:
>
> > Added support for CREATE FOREIGN TABLE LIKE to enable the creation of
> > foreign tables based on the column definitions, constraints of
> > existing source tables.
> > This feature
range
and probably unnecessary.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Cuando mañana llegue pelearemos segun lo que mañana exija" (Mowgli)
m Level Backup
Start current 25.2 with a few additional words: "An older and largely
deprecated technique to take a backup is to directly copy the files ... "
--
Álvaro HerreraBreisgau, Deutschland — https://www.EnterpriseDB.com/
"Nunca confiaré en un traidor. Ni siquiera si el traidor lo he creado yo"
(Barón Vladimir Harkonnen)
tory, but maintainer-clean is not. But if you first configure with
different options and then run uninstall, then it won't remove the
library you had installed previously. Maybe what you really wanted was
to zap the entire install directory.
--
Álvaro Herrera 48°01'N
e you can't drop an AM if tables are using it; but
you can't use COPY in rules or anything like that that's going to be
stored permanently. Perhaps you're right that we don't need this for
extensible COPY FORMAT.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
owever, WAL streaming mode (-X stream) only works with server
> version 9.3 and later, and tar format (--format=tar) only works with server
> version 9.5 and later.
Yes, absolutely.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
On Mon, Feb 10, 2025, at 7:03 AM, Amul Sul wrote:
> Attached patch implemented this behaviour. To achieve this, we have to
> revert (see 0007) some committed code and relax the restriction that
> the NOT ENFORCED constraint must also be NOT VALID. Now, NOT ENFORCED
> and NOT VALID are independent s
ell, yes. You have kinda the same issue with any other system catalog
column that's a 'char', I guess. Maybe this is more of a problem here
because it's more user-visible than most other catalogs, not sure.
--
Álvaro HerreraBreisgau, Deutschland — https://www.EnterpriseDB.com/
e
more useful one, I thought, so what's going on?
I'm baffled.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
Officer Krupke, what are we to do?
Gee, officer Krupke, Krup you! (West Side Story, "Gee, Officer Krupke")
n't check what other changes there were
afterwards.)
About the GUC name -- query_id_const_merge -- I think this is too much a
hacker's name. How about
query_id_merge_values
query_id_merge_value_lists
query_id_squash_constant_lists
--
Álvaro HerreraBreisgau, Deutschland — htt
de walker.
Maybe something like statext_is_compatible_clause_internal() can be an
inspiration (and even that is far more complex than we need here.)
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"If it is not right, do not do it.
If it is not true, do not say it." (Marcus Aurelius, Meditations)
entries can be matched to pg_stat_statement entries by query_id.
Looking to commit 0001 soon.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"On the other flipper, one wrong move and we're Fatal Exceptions"
(T.U.X.: Term Unit X - http://www.thelinuxreview.com/TUX/)
was supported at
early stages of the patch, and now I'm really curious about that
implementation because what IsMergeableConstList sees is a FuncExpr that
invokes the cast function for float8 to int4.)
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"La fuerza no está en los medios físicos
sino que reside en una voluntad indomable" (Gandhi)
se it's far too easy to misuse and they will get
wrong query results, possibly without knowing for who knows how long.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"El número de instalaciones de UNIX se ha elevado a 10,
y se espera que este número aumente" (UPM, 1972)
ign tables, it can get
> pretty tedious and mistakes happen easily.
Sure. Did you consider IMPORT FOREIGN SCHEMA?
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
[…] indem ich in meinem Leben oft an euch gedacht, euch glücklich zu machen.
Seyd es!
the foreign table
> using CREATE FOREIGN TABLE and copy the column definitions one by one.
Eh yeah, I guess for this use case it makes sense to allow a LIKE clause
on CREATE FOREIGN TABLE. Were you going to submit a patch?
--
Álvaro HerreraBreisgau, Deutschland — https://www.E
t init_steps might be reasonable, at least
if we allowed partitionedness of tables to vary in other ways (eg. if we
made pgbench_history partitioned), but I don't think it conflicts with
Sergey's patch in spirit.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.E
ctually considered.
> right?
Right. The parent one because it has conparentid = 0, the others
because their parent constraint is in the list.
--
Álvaro HerreraBreisgau, Deutschland — https://www.EnterpriseDB.com/
oth in Postgres and elsewhere.)
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
should not attempt to revalidate the constraint on
grandchild1, because it's known valid; but I don't think I see code that
would skip validation there. That is, QueueFKConstraintValidation does
its thing unconditionally (esp. recursing to children), which seems
wrong.
--
Álva
index for the partitioned table is created with the INVALID
> flag.
Yes. You need to attach child indexes on all partitions so that this
index becomes valid.
--
Álvaro HerreraBreisgau, Deutschland — https://www.EnterpriseDB.com/
with some trivial
amendments.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Java is clearly an example of money oriented programming" (A. Stepanov)
On Sat, Jan 25, 2025, at 6:00 AM, Alexander Lakhin wrote:
> Hello Álvaro,
>
> Please look at the script that produces an error starting from b663b9436:
Ah yes, this is my bug: I moved a CCI where it became conditional. Will fix,
thanks for the test case.
e want this or something
similar.
I wonder if the reason that committers stay away from it is that
reviewing it fully (and thus taking responsibility for it) seems such a
daunting task. I might be wrong, but I think this may be the largest
patch since FTS.
--
Álvaro Herrera
1 - 100 of 357 matches
Mail list logo
