On Mon, 24 Oct 2022 at 13:15, Peter Smith wrote:
>
> Hi hackers.
>
> There is a docs Logical Replication section "31.10 Configuration
> Settings" [1] which describes some logical replication GUCs, and
> details on how they interact with each other and how to take that into
> account when setting t
On Fri, 11 Nov 2022 at 11:13, wangw.f...@fujitsu.com
wrote:
>
> On Fri, Oct 21, 2022 at 17:02 PM Peter Smith wrote:
> >
>
> Thanks for your comments. Sorry for not replying in time.
>
> > On Mon, Oct 17, 2022 at 4:49 PM wangw.f...@fujitsu.com
> > wrote:
> > >
> > > On Wed, Oct 5, 2022 at 11:08
On Wed, 16 Nov 2022 at 09:34, Ian Lawrence Barwick wrote:
>
> 2022年11月7日(月) 22:39 vignesh C :
> >
> > On Fri, 4 Nov 2022 at 08:19, Ian Lawrence Barwick wrote:
> > >
> > > Hi
> > >
> > > cfbot reports the patch no longer applies [1]. As Comm
On Tue, 15 Nov 2022 at 11:17, Peter Smith wrote:
>
> On Sun, Nov 13, 2022 at 11:47 AM vignesh C wrote:
> >
> > On Mon, 24 Oct 2022 at 13:15, Peter Smith wrote:
> > >
> > > Hi hackers.
> > >
> > > There is a docs Logical Replication
On Wed, 16 Nov 2022 at 14:28, wangw.f...@fujitsu.com
wrote:
>
> On Mon, Nov 14, 2022 at 0:56 AM vignesh C wrote:
> > >
> > > Attach new patches.
> >
>
> Thanks for your comments.
>
> > Here we are having tables list to store the relids and table_infos
Hi,
When I was reviewing one of the patches, I found a typo in the
comments of SH_LOOKUP and SH_LOOKUP_HASH. I felt "lookup up" should
have been "lookup".
Attached a patch to modify it.
Regards,
Vignesh
From 03feb3121dbd9a78547a15cf5998e44ffb65626e Mon Sep 17 00:00:00 2001
F
On Thu, 17 Nov 2022 at 17:48, Daniel Gustafsson wrote:
>
> > On 17 Nov 2022, at 10:56, vignesh C wrote:
>
> > When I was reviewing one of the patches, I found a typo in the
> > comments of SH_LOOKUP and SH_LOOKUP_HASH. I felt "lookup up" should
> > hav
On Tue, 22 Nov 2022 at 05:59, Michael Paquier wrote:
>
> On Fri, Oct 28, 2022 at 05:34:37PM +0530, vignesh C wrote:
> > Those also should be handled, attached v2 version includes the changes
> > for the same.
>
> The basic options supported by PROCEDURE are a subset of ROU
On Mon, 14 Nov 2022 at 12:14, Amit Kapila wrote:
>
> Hi,
>
> The thread title doesn't really convey the topic under discussion, so
> changed it. IIRC, this has been mentioned by others as well in the
> thread.
>
> On Sat, Nov 12, 2022 at 7:21 PM vignesh C wrote:
&
On Sun, 20 Nov 2022 at 09:29, vignesh C wrote:
>
> On Fri, 11 Nov 2022 at 11:03, Peter Smith wrote:
> >
> > On Fri, Nov 11, 2022 at 4:17 PM Peter Smith wrote:
> > >
> > > On Fri, Nov 11, 2022 at 4:09 PM Peter Smith wrote:
> > > >
>
On Fri, 25 Nov 2022 at 11:47, vignesh C wrote:
>
> On Sun, 20 Nov 2022 at 09:29, vignesh C wrote:
> >
> > On Fri, 11 Nov 2022 at 11:03, Peter Smith wrote:
> > >
> > > On Fri, Nov 11, 2022 at 4:17 PM Peter Smith wrote:
> > > >
> > > >
Hi,
Tab completion for ALTER EXTENSION ADD and DROP was missing, this
patch adds the tab completion for the same.
Regards,
Vignesh
From 35e9e8bd22ae8767baa95a04c41ee8f68a9c5338 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Sat, 26 Nov 2022 20:18:58 +0530
Subject: [PATCH v1] Missing tab
Hi,
While reviewing/testing one of the patches I found the following Assert:
#0 0x55c6312ba639 in pgstat_unlink_relation (rel=0x7fb73bcbac58)
at pgstat_relation.c:161
#1 0x55c6312bbb5a in pgstat_relation_delete_pending_cb
(entry_ref=0x55c6335563a8) at pgstat_relation.c:839
#2 0x55c6
Hi,
While reviewing/testing one of the patches I found the following Assert:
#0 __pthread_kill_implementation (no_tid=0, signo=6,
threadid=139624429171648) at ./nptl/pthread_kill.c:44
#1 __pthread_kill_internal (signo=6, threadid=139624429171648) at
./nptl/pthread_kill.c:78
#2 __GI___pthread_ki
On Tue, 29 Nov 2022 at 17:51, li jie wrote:
>
> I will continue to give feedback for this patch.
Thanks a lot, that will be very helpful for us.
> 1. LIKE STORAGE
> ```
> CREATE TABLE ctlt (a text, c text);
> ALTER TABLE ctlt ALTER COLUMN c SET STORAGE EXTERNAL;
> CREATE TABLE ctlt_storage (LIK
d in more than one
place.
The attached v4 patch is rebased on top of HEAD.
Regards,
Vignesh
From c1436c498d1d939384999ecb508d5da3403abc90 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Wed, 7 Dec 2022 00:27:37 +0530
Subject: [PATCH v4] Tab completion for ALTER FUNCTION/
Hi,
The Commitfest 2022-11 status still shows as "In Progress", Shouldn't
the status be changed to "Closed" and the entries be moved to the next
commitfest.
Regards,
Vignesh
On Wed, 16 Nov 2022 at 18:30, Ian Lawrence Barwick wrote:
>
> 2022年11月14日(月) 22:38 Ian Lawrence Barwick :
> >
> > 2022年11
On Wed, 7 Dec 2022 at 17:50, Alvaro Herrera wrote:
>
> I think this patch is split badly.
>
> You have:
>
> 0001 an enormous patch including some required infrastructure, plus the
> DDL deparsing bits themselves.
>
> 0002 another enormous (though not as much) patch, this time for
> DDL replication
On Wed, Apr 14, 2021 at 7:52 AM Masahiko Sawada wrote:
>
> On Tue, Apr 13, 2021 at 5:07 PM vignesh C wrote:
> >
> > On Mon, Apr 12, 2021 at 7:03 PM Masahiko Sawada
> > wrote:
> > >
> > > On Mon, Apr 12, 2021 at 9:36 PM Amit Kapila
> > > wro
On Wed, Apr 14, 2021 at 12:09 PM Amit Kapila wrote:
>
> On Tue, Apr 13, 2021 at 1:37 PM vignesh C wrote:
> >
> > On Mon, Apr 12, 2021 at 7:03 PM Masahiko Sawada
> > wrote:
> > >
> > >
> > > The following test for the latest v8 patch seems t
On Thu, Apr 15, 2021 at 11:52 AM Amit Kapila wrote:
>
> On Wed, Apr 14, 2021 at 5:52 PM vignesh C wrote:
> >
>
> I have made minor changes to the 0001 and 0002 patches. Attached is
> the combined patch for them, I think we can push them as one patch.
> Changes made
On Thu, Apr 15, 2021 at 2:46 PM Amit Kapila wrote:
>
> On Thu, Apr 15, 2021 at 1:13 PM Masahiko Sawada wrote:
> >
> > On Thu, Apr 15, 2021 at 3:22 PM Amit Kapila wrote:
> > >
> > Thank you for updating the patch.
> >
> > I have one question on the doc change:
> >
> > +so the counter is n
On Fri, Apr 16, 2021 at 3:16 PM Amit Kapila wrote:
>
> On Mon, Apr 12, 2021 at 2:57 PM vignesh C wrote:
> >
> > On Sat, Mar 20, 2021 at 9:26 AM Amit Kapila wrote:
> > >
> > > On Sat, Mar 20, 2021 at 12:22 AM Andres Freund wrote:
> > > >
&
On Fri, Apr 16, 2021 at 11:28 AM Amit Kapila wrote:
>
> On Thu, Apr 15, 2021 at 4:35 PM Masahiko Sawada wrote:
> >
> > Thank you for the update! The patch looks good to me.
> >
>
> I have pushed the first patch. Comments on the next patch
> v13-0001-Use-HTAB-for-replication-slot-statistics:
Also
On Sun, Apr 18, 2021 at 3:51 AM Tom Lane wrote:
>
> I wrote:
> > The buildfarm suggests that this isn't entirely stable:
> > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=anole&dt=2021-04-17%2011%3A14%3A49
> > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bichir&dt=2021-04-17%2
On Sun, Apr 18, 2021 at 8:43 AM Amit Kapila wrote:
>
> On Sun, Apr 18, 2021 at 7:36 AM vignesh C wrote:
> >
> > On Sun, Apr 18, 2021 at 3:51 AM Tom Lane wrote:
> > >
> > > I wrote:
> > > > The buildfarm suggests that this isn't entirely sta
On Sun, Apr 18, 2021 at 9:02 AM vignesh C wrote:
>
> On Sun, Apr 18, 2021 at 8:43 AM Amit Kapila wrote:
> >
> > On Sun, Apr 18, 2021 at 7:36 AM vignesh C wrote:
> > >
> > > On Sun, Apr 18, 2021 at 3:51 AM Tom Lane wrote:
> > > >
> > > &g
On Fri, Apr 16, 2021 at 3:16 PM Amit Kapila wrote:
>
> On Mon, Apr 12, 2021 at 2:57 PM vignesh C wrote:
> >
> > On Sat, Mar 20, 2021 at 9:26 AM Amit Kapila wrote:
> > >
> > > On Sat, Mar 20, 2021 at 12:22 AM Andres Freund wrote:
> > > >
&
On Wed, Mar 31, 2021 at 5:47 PM vignesh C wrote:
>
> On Wed, Mar 31, 2021 at 2:35 PM Ajin Cherian wrote:
> >
> > The patch applies fine on HEAD and "make check" passes fine. No major
> > comments on the patch, just a minor comment:
> >
> > If you c
On Tue, Apr 20, 2021 at 9:08 AM Masahiko Sawada wrote:
>
> On Mon, Apr 19, 2021 at 4:48 PM Masahiko Sawada wrote:
> >
> > On Mon, Apr 19, 2021 at 2:14 PM Amit Kapila wrote:
> > >
> > > On Mon, Apr 19, 2021 at 9:00 AM Masahiko Sawada
> > > wrote:
> > > >
> > > > On Fri, Apr 16, 2021 at 2:58 PM
On Tue, Apr 20, 2021 at 7:54 PM Masahiko Sawada wrote:
>
> On Tue, Apr 20, 2021 at 7:22 PM vignesh C wrote:
> >
> > On Tue, Apr 20, 2021 at 9:08 AM Masahiko Sawada
> > wrote:
> > >
> > > On Mon, Apr 19, 2021 at 4:48 PM Masahiko Sawada
> > >
On Wed, Apr 21, 2021 at 9:47 AM Amit Kapila wrote:
>
> On Wed, Apr 21, 2021 at 9:39 AM vignesh C wrote:
> >
> > I feel we can change CATALOG_VERSION_NO so that we will get this error
> > "The database cluster was initialized with CATALOG_VERSION_NO
> > 2021
On Wed, Apr 21, 2021 at 12:13 PM Peter Smith wrote:
>
> On Tue, Apr 20, 2021 at 3:45 PM Peter Smith wrote:
> >
> > Please find attached the latest patch set v73`*
> >
> > Differences from v72* are:
> >
> > * Rebased to HEAD @ today (required because v72-0001 no longer applied
> > cleanly)
> >
>
Hi,
While reviewing one of the logical replication patches, I found that
we do not include hint messages to display the actual option which has
been specified more than once in case of redundant option error. I
felt including this will help in easily identifying the error, users
will not have to s
On Mon, Apr 26, 2021 at 5:49 PM Bharath Rupireddy
wrote:
>
> On Mon, Apr 26, 2021 at 5:29 PM vignesh C wrote:
> >
> > Hi,
> >
> > While reviewing one of the logical replication patches, I found that
> > we do not include hint messages to display the actual
On Mon, Apr 26, 2021 at 6:18 PM Dilip Kumar wrote:
>
> On Mon, Apr 26, 2021 at 5:49 PM Bharath Rupireddy
> wrote:
> >
> > On Mon, Apr 26, 2021 at 5:29 PM vignesh C wrote:
> > >
> > > Hi,
> > >
> > > While reviewing one of the logical
On Mon, Apr 26, 2021 at 8:42 AM Amit Kapila wrote:
>
> On Mon, Apr 26, 2021 at 8:01 AM Masahiko Sawada wrote:
> >
> > On Fri, Apr 23, 2021 at 6:15 PM Amit Kapila wrote:
> > >
> > > On Mon, Apr 19, 2021 at 4:28 PM vignesh C wrote:
> > > &g
On Wed, Apr 21, 2021 at 12:13 PM Peter Smith wrote:
>
> On Tue, Apr 20, 2021 at 3:45 PM Peter Smith wrote:
> >
> > Please find attached the latest patch set v73`*
> >
> > Differences from v72* are:
> >
> > * Rebased to HEAD @ today (required because v72-0001 no longer applied
> > cleanly)
> >
>
On Tue, Apr 27, 2021 at 9:43 AM Amit Kapila wrote:
>
> On Tue, Apr 27, 2021 at 9:17 AM Masahiko Sawada wrote:
> >
> > On Tue, Apr 27, 2021 at 11:31 AM vignesh C wrote:
> > >
> > > > > And I think there is
> > > > > also a
On Tue, Apr 27, 2021 at 9:48 AM vignesh C wrote:
>
> On Tue, Apr 27, 2021 at 9:43 AM Amit Kapila wrote:
> >
> > On Tue, Apr 27, 2021 at 9:17 AM Masahiko Sawada
> > wrote:
> > >
> > > On Tue, Apr 27, 2021 at 11:31 AM vignesh C wrote:
> > > &g
On Wed, Apr 21, 2021 at 12:13 PM Peter Smith wrote:
>
> On Tue, Apr 20, 2021 at 3:45 PM Peter Smith wrote:
> >
> > Please find attached the latest patch set v73`*
> >
> > Differences from v72* are:
> >
> > * Rebased to HEAD @ today (required because v72-0001 no longer applied
> > cleanly)
> >
>
On Wed, Apr 28, 2021 at 8:28 AM Amit Kapila wrote:
>
> On Tue, Apr 27, 2021 at 8:28 PM Masahiko Sawada wrote:
> >
> > On Tue, Apr 27, 2021 at 11:29 PM Amit Kapila
> > wrote:
> > >
> > > On Tue, Apr 27, 2021 at 5:40 PM Amit Kapila
> > > wrote:
> > > >
> > >
> > > I am not sure if the timeout h
On Wed, Apr 28, 2021 at 8:59 AM Amit Kapila wrote:
>
> On Tue, Apr 27, 2021 at 11:02 AM vignesh C wrote:
> >
> > On Tue, Apr 27, 2021 at 9:48 AM vignesh C wrote:
> > >
> >
> > Attached patch has the changes to update statistics during
> > spill/st
On Wed, Apr 28, 2021 at 9:37 AM Masahiko Sawada wrote:
>
> On Wed, Apr 28, 2021 at 12:29 PM Amit Kapila wrote:
> >
> > On Tue, Apr 27, 2021 at 11:02 AM vignesh C wrote:
> > >
> > > On Tue, Apr 27, 2021 at 9:48 AM vignesh C wrote:
> > > >
>
On Thu, Apr 29, 2021 at 11:14 AM Masahiko Sawada wrote:
>
> On Thu, Apr 29, 2021 at 11:55 AM Amit Kapila wrote:
> >
> > On Thu, Apr 29, 2021 at 4:58 AM Masahiko Sawada
> > wrote:
> > >
> > > On Thu, Apr 29, 2021 at 5:41 AM Tom Lane wrote:
> > > >
> > > > It seems that the test case added by f5
On Thu, Apr 29, 2021 at 3:06 PM Amit Kapila wrote:
>
> On Wed, Apr 28, 2021 at 5:01 PM Amit Kapila
wrote:
> >
> > On Wed, Apr 28, 2021 at 4:51 PM Masahiko Sawada
wrote:
> > >
> > > On Wed, Apr 28, 2021 at 6:39 PM Amit Kapila
wrote:
> >
> > @@ -1369,7 +1369,7 @@ ReorderBufferIterTXNNext(ReorderB
Hi,
While debugging one of the logical decoding issues, I found that xid was
not included in restoring reorder buffer changes from disk log messages.
Attached a patch for it. I felt including the XID will be helpful in
debugging. Thoughts?
Regards,
Vignesh
From 9d3ee45b7b2c0d625af888579035a0fb9a1
On Mon, Apr 26, 2021 at 9:24 PM Alvaro Herrera wrote:
>
> On 2021-Apr-26, Bharath Rupireddy wrote:
>
> > I agree that we can just be clear about the problem. Looks like the
> > majority of the errors "conflicting or redundant options" are for
> > redundant options. So, wherever "conflicting or red
On Fri, Apr 30, 2021 at 5:55 AM Masahiko Sawada wrote:
>
> On Thu, Apr 29, 2021 at 9:44 PM vignesh C wrote:
> >
> >
> >
> > On Thu, Apr 29, 2021 at 3:06 PM Amit Kapila wrote:
> > >
> > > On Wed, Apr 28, 2021 at 5:01 PM Amit Kapila
> > &g
On Tue, Apr 13, 2021 at 8:01 PM Bharath Rupireddy
wrote:
>
> On Tue, Apr 13, 2021 at 6:22 PM vignesh C wrote:
> > > 2) How about
> > > + Specifies whether the subscriber must verify the
> > > publications that are
> > > + being subs
On Sat, May 1, 2021 at 10:47 AM Dilip Kumar wrote:
>
> On Sat, May 1, 2021 at 10:43 AM Bharath Rupireddy
> wrote:
> >
> > On Fri, Apr 30, 2021 at 2:49 PM Dilip Kumar wrote:
> > > Looking into this again, why not as shown below? IMHO, this way the
> > > code will be logically the same as it was
On Thu, Apr 29, 2021 at 10:44 PM Alvaro Herrera wrote:
>
> On 2021-Apr-29, vignesh C wrote:
>
> > Thanks for the comments, please find the attached v3 patch which has
> > the change for the first part.
>
> Looks good to me. I would only add parser_errposition() to th
On Sun, May 2, 2021 at 4:27 AM Alvaro Herrera wrote:
>
> On 2021-May-01, Bharath Rupireddy wrote:
>
> > IMO, it's not good to change the function API just for showing up
> > parse_position (which is there for cosmetic reasons I feel) in an error
> > which actually has the option name clearly menti
On Sat, May 1, 2021 at 10:54 PM Alvaro Herrera wrote:
>
> On 2021-May-01, vignesh C wrote:
>
> > On Thu, Apr 29, 2021 at 10:44 PM Alvaro Herrera
> > wrote:
> > >
> > > On 2021-Apr-29, vignesh C wrote:
> > >
> > > > Thanks for the comme
On Sat, May 1, 2021 at 9:02 PM Bharath Rupireddy
wrote:
>
> On Sat, May 1, 2021 at 7:25 PM vignesh C wrote:
> > > > I'm not attaching above one line change as a patch, maybe Vignesh can
> > > > merge this into the main patch.
> >
> > Thanks for
On Sat, May 1, 2021 at 7:58 PM Bharath Rupireddy
wrote:
>
> On Sat, May 1, 2021 at 12:49 PM vignesh C wrote:
> > Thanks for the comments, Attached patch has the fixes for the same.
> > Thoughts?
>
> Few more comments on v5:
>
> 1) Deletion of be
On Mon, May 3, 2021 at 12:08 PM Bharath Rupireddy
wrote:
>
> On Sun, May 2, 2021 at 8:44 PM vignesh C wrote:
> >
> > On Sat, May 1, 2021 at 9:02 PM Bharath Rupireddy
> > wrote:
> > >
> > > On Sat, May 1, 2021 at 7:25 PM vignesh C wrote:
> > >
On Mon, May 3, 2021 at 1:46 PM Dilip Kumar wrote:
>
> On Mon, May 3, 2021 at 10:48 AM Dilip Kumar wrote:
> >
> > On Sun, May 2, 2021 at 10:04 PM vignesh C wrote:
> > >
> > > Thanks for the comments.
> > > The Attached patch has the fixes for the sa
On Mon, May 3, 2021 at 11:11 AM Bharath Rupireddy
wrote:
>
> On Sun, May 2, 2021 at 10:04 PM vignesh C wrote:
> > > 5) Instead of adding a new file 021_validate_publications.pl for
> > > tests, spawning a new test database which would make the overall
> > > reg
On Tue, May 4, 2021 at 9:48 AM Masahiko Sawada wrote:
>
> On Mon, May 3, 2021 at 10:21 PM Amit Kapila wrote:
> >
> > On Mon, May 3, 2021 at 5:48 PM Masahiko Sawada
> > wrote:
> > >
> > > On Mon, May 3, 2021 at 2:27 PM Amit Kapila
> > > wrote:
> > > >
> > > > On Thu, Apr 29, 2021 at 10:37 AM A
On Tue, May 4, 2021 at 2:37 PM Bharath Rupireddy
wrote:
>
> On Mon, May 3, 2021 at 7:59 PM vignesh C wrote:
> > Thanks for the comments, these comments are handle in the v7 patch
> > posted in my earlier mail.
>
> Thanks. Some comments on v7 patch:
>
> 1) How abo
On Wed, Feb 3, 2021 at 3:24 PM Bharath Rupireddy
wrote:
>
> On Wed, Feb 3, 2021 at 1:49 PM vignesh C wrote:
> >
> > On Wed, Feb 3, 2021 at 1:00 PM Tom Lane wrote:
> > >
> > > vignesh C writes:
> > > > On Mon, Feb 1, 2021 at 11:04 AM Bhar
On Thu, May 6, 2021 at 9:39 AM Amit Kapila wrote:
>
> On Thu, May 6, 2021 at 6:15 AM Masahiko Sawada wrote:
> >
> > After more thought, I'm concerned that my patch's approach might be
> > invasive for PG14. Given that Vignesh’s patch would cover most cases,
> >
>
> I am not sure if your patch is
On Thu, May 6, 2021 at 1:30 PM Masahiko Sawada wrote:
>
> On Thu, May 6, 2021 at 4:03 PM Amit Kapila wrote:
> >
> > On Thu, May 6, 2021 at 10:55 AM Masahiko Sawada
> > wrote:
> > >
> > > On Thu, May 6, 2021 at 1:09 PM Amit Kapila
> > > wrote:
> > > >
> > >
> > > > In the attached, I have com
On Thu, May 6, 2021 at 9:08 AM Japin Li wrote:
>
>
> On Tue, 04 May 2021 at 21:20, vignesh C wrote:
> > On Tue, May 4, 2021 at 2:37 PM Bharath Rupireddy
> > wrote:
> >>
> >> On Mon, May 3, 2021 at 7:59 PM vignesh C wrote:
> >> > Thanks fo
On Thu, May 6, 2021 at 7:43 AM Justin Pryzby wrote:
>
> Here's a cleaned-up copy of the doc text.
>
> Send a request to the backend with the specified process ID to log its
> backtrace.
> The backtrace will be logged at message level LOG.
> It will appear in the server log based on the log config
On Fri, May 7, 2021 at 5:44 PM Dilip Kumar wrote:
>
> On Fri, May 7, 2021 at 5:38 PM Bharath Rupireddy
> wrote:
> >
> > On Fri, May 7, 2021 at 11:50 AM Dilip Kumar wrote:
> > >
> > > On Thu, May 6, 2021 at 7:22 PM vignesh C wrote:
> > > >
&g
On Sat, May 8, 2021 at 2:20 PM Bharath Rupireddy
wrote:
>
> On Sat, May 8, 2021 at 12:01 PM houzj.f...@fujitsu.com
> wrote:
> >
> > > > > Thanks! The v5 patch looks good to me. Let's see if all agree on the
> > > > > goto duplicate_error approach which could reduce the LOC by ~80.
> > > >
> > > >
Hi,
For some of the logical replication messages the data type documented
was not correct, especially for lsn and xid. For lsn actual datatype
used is uint64 but is documented as int64, similarly for xid, datatype
used is uint32 but documented as int32.
Attached is a patch which has the fix for th
On Thu, Apr 29, 2021 at 2:23 PM Peter Smith wrote:
>
> Please find attached the latest patch set v74*
>
> Differences from v73* are:
>
> * Rebased to HEAD @ 2 days ago.
>
> * v74 addresses most of the feedback comments from Vignesh posts [1][2][3].
>
Thanks for the updated patch.
Few comments:
1)
On Mon, May 10, 2021 at 10:51 AM Peter Smith wrote:
>
> On Mon, May 10, 2021 at 1:31 PM vignesh C wrote:
> >
>
> > 4) Should we change this to "The end LSN of the prepared transaction"
> > just to avoid any confusion of it meaning commit/rollback.
> >
On Mon, May 10, 2021 at 6:00 AM houzj.f...@fujitsu.com
wrote:
>
> > > > > > > > Thanks! The v5 patch looks good to me. Let's see if all
> > > > > > > > agree on the goto duplicate_error approach which could reduce
> > the LOC by ~80.
> > > > > > >
> > > > > > > I think the "goto duplicate_error" a
On Sun, May 9, 2021 at 6:54 PM Euler Taveira wrote:
>
> On Sun, May 9, 2021, at 9:37 AM, vignesh C wrote:
>
> For some of the logical replication messages the data type documented
> was not correct, especially for lsn and xid. For lsn actual datatype
> used is uint64 but is d
On Sun, May 9, 2021 at 6:44 PM Peter Smith wrote:
>
> On Sun, May 9, 2021 at 10:38 PM vignesh C wrote:
> >
> > Hi,
> >
> > For some of the logical replication messages the data type documented
> > was not correct, especially for lsn and xid. For lsn actua
On Tue, May 11, 2021 at 2:47 AM Alvaro Herrera wrote:
>
> On 2021-May-10, vignesh C wrote:
>
> > That sounds fine to me, Attached v6 patch which has the changes for the
> > same.
>
> What about defining a function (maybe a static inline function in
> defrem.
On Tue, May 11, 2021 at 8:06 AM Peter Smith wrote:
>
> On Mon, May 10, 2021 at 11:46 PM vignesh C wrote:
> >
> > On Sun, May 9, 2021 at 6:54 PM Euler Taveira wrote:
> > >
> > > On Sun, May 9, 2021, at 9:37 AM, vignesh C wrote:
> > >
> > >
On Tue, May 11, 2021 at 9:09 AM Euler Taveira wrote:
>
> On Mon, May 10, 2021, at 10:45 AM, vignesh C wrote:
>
> I agree to specifying the actual dataypes like XLogRecPtr for lsn,
> TimestampTz for timestamp, TransactionId for xid and Oid for the
> object id. Attached v2 patch w
On Wed, May 12, 2021 at 9:08 AM Amit Kapila wrote:
>
> On Wed, May 12, 2021 at 7:53 AM Amit Kapila wrote:
> >
> > On Wed, May 12, 2021 at 4:00 AM Masahiko Sawada
> > wrote:
> > >
> > > Ugh, since by commit 592f00f8de we send slot stats every after
> > > spil/stream it’s possible that we report
On Wed, May 12, 2021 at 9:59 AM Tom Lane wrote:
>
> vignesh C writes:
> > I agree with your analysis to remove that test. Attached patch has the
> > changes for the same.
>
> Is there any value in converting the test case into a TAP test that
> could be more flexibl
On Wed, May 12, 2021 at 3:36 AM Peter Smith wrote:
>
> On Wed, May 12, 2021 at 1:02 AM vignesh C wrote:
> >
> > Thanks for the comments, Attached v3 patch has the changes as suggested.
>
> This v3 mostly looks good to me now except for some minor comments
> about the f
Hi,
While I was reviewing one of the logical decoding features, I found a
few issues in alter subscription drop publication.
Alter subscription drop publication does not support copy_data option,
that needs to be removed from tab completion.
Dropping all the publications present in the subscript
On Thu, May 13, 2021 at 11:21 AM Amit Kapila wrote:
>
> On Wed, May 12, 2021 at 4:02 PM Masahiko Sawada wrote:
> >
> > On Wed, May 12, 2021 at 1:19 PM vignesh C wrote:
> > >
> > > > I think the part of the test that tests the stats after resetting it
>
On Thu, May 13, 2021 at 3:12 PM Amit Kapila wrote:
>
> I noticed $SUBJECT in curculio.
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=curculio&dt=2021-05-11%2018%3A30%3A23
>
> The failure test report:
> t/020_messages.pl(Wstat: 7424 Tests: 1 Failed: 0)
> Non-zero exit
On Thu, May 13, 2021 at 4:41 PM Michael Paquier wrote:
>
> On Thu, May 13, 2021 at 04:14:55PM +0530, vignesh C wrote:
> > +$node_publisher->wait_for_catchup('tap_sub');
> > +
> > # Ensure a transactional logical decoding message shows up on the slot
>
On Thu, May 13, 2021 at 4:41 PM Michael Paquier wrote:
>
> On Thu, May 13, 2021 at 04:14:55PM +0530, vignesh C wrote:
> > +$node_publisher->wait_for_catchup('tap_sub');
> > +
> > # Ensure a transactional logical decoding message shows up on the slot
>
On Wed, May 12, 2021 at 10:15 PM Bharath Rupireddy
wrote:
>
> On Wed, May 12, 2021 at 9:55 PM vignesh C wrote:
> > While I was reviewing one of the logical decoding features, I found a
> > few issues in alter subscription drop publication.
>
> Thanks!
>
> > Al
On Thu, May 13, 2021 at 4:58 AM Alvaro Herrera wrote:
>
> You can avoid duplicating the ereport like this:
>
> + ereport(ERROR,
> + (errcode(ERRCODE_SYNTAX_ERROR),
> +errmsg("option \"%s\" specified more than
> once", def
Hi,
While I was reviewing one of the logical decoding features, I found
Streaming and binary options were missing in tab completion for the
alter subscription set option, the attached patch has the changes for
the same.
Thoughts?
Regards,
Vignesh
From 84a0c07760c913576ef38d74ab37ffd9ee3ad686 Mon
On Fri, May 14, 2021 at 12:25 PM Bharath Rupireddy
wrote:
>
> On Fri, May 14, 2021 at 12:00 PM vignesh C wrote:
> >
> > Hi,
> >
> > While I was reviewing one of the logical decoding features, I found
> > Streaming and binary options were missing in tab compl
On Thu, May 13, 2021 at 8:13 PM Bharath Rupireddy
wrote:
>
> On Thu, May 13, 2021 at 7:43 PM vignesh C wrote:
> > I have separated the Drop publication documentation contents. There
> > are some duplicate contents but the readability is slightly better.
> > Thoughts?
>
On Fri, May 14, 2021 at 7:41 AM Japin Li wrote:
>
>
> On Thu, 13 May 2021 at 22:13, vignesh C wrote:
> > On Wed, May 12, 2021 at 10:15 PM Bharath Rupireddy
> > wrote:
> >>
> >> On Wed, May 12, 2021 at 9:55 PM vignesh C wrote:
> >> > While I wa
On Fri, May 14, 2021 at 8:56 PM Tom Lane wrote:
>
> Bharath Rupireddy writes:
> > On Fri, May 14, 2021 at 7:58 PM vignesh C wrote:
> >> I have changed it to:
> >> ADD adds additional publications,
> >> - DROP removes publications from the list of
&
On Fri, May 14, 2021 at 7:10 PM Bharath Rupireddy <
bharath.rupireddyforpostg...@gmail.com> wrote:
>
> On Fri, May 14, 2021 at 6:51 PM vignesh C wrote:
> >
> > On Fri, May 14, 2021 at 12:25 PM Bharath Rupireddy
> > wrote:
> > >
> > > O
On Sat, May 15, 2021 at 2:58 PM Bharath Rupireddy <
bharath.rupireddyforpostg...@gmail.com> wrote:
>
> On Fri, May 14, 2021 at 11:02 PM vignesh C wrote:
> >
> > On Fri, May 14, 2021 at 8:56 PM Tom Lane wrote:
> > >
> > > Bharath Rupireddy writes:
>
On Mon, May 17, 2021 at 10:40 AM Amit Kapila wrote:
>
> On Mon, May 17, 2021 at 9:06 AM Amit Kapila wrote:
> >
> > On Thu, May 13, 2021 at 7:06 PM vignesh C wrote:
> > >
> > > On Thu, May 13, 2021 at 4:41 PM Michael Paquier
> > > wrote:
On Thu, May 13, 2021 at 5:57 AM Peter Smith wrote:
>
> On Wed, May 12, 2021 at 11:09 PM vignesh C wrote:
> ...
> >
> > Thanks for the comments. Attached v4 patch has the fix for the same.
> >
>
> I have not tried this patch so I cannot confirm whether it applie
On Mon, May 17, 2021 at 6:10 PM Ajin Cherian wrote:
>
> The above patch had some changes missing which resulted in some tap
> tests failing. Sending an updated patchset. Keeping the patchset
> version the same.
Thanks for the updated patch, the updated patch fixes the tap test failures.
Regards,
On Tue, May 18, 2021 at 9:09 AM Amit Kapila wrote:
>
> On Mon, May 17, 2021 at 5:48 PM vignesh C wrote:
> >
> > On Mon, May 17, 2021 at 10:40 AM Amit Kapila
> > wrote:
> > >
> > > One more point:
> > > + $node_publisher->wait_for_catchu
On Wed, May 19, 2021 at 10:28 AM Amit Kapila wrote:
>
> On Tue, May 18, 2021 at 11:25 AM vignesh C wrote:
> >
> > Thanks for the comments, the attached patch has the changes for the same.
> >
>
> Thanks, I have pushed your patch after making minor changes in the
On Tue, May 18, 2021 at 9:20 PM Alvaro Herrera wrote:
>
> On 2021-May-14, vignesh C wrote:
>
> > While I was reviewing one of the logical decoding features, I found
> > Streaming and binary options were missing in tab completion for the
> > alter subscription set opt
901 - 1000 of 1854 matches
Mail list logo
