On Sun, May 9, 2021 at 6:44 PM Peter Smith <smithpb2...@gmail.com> wrote: > > On Sun, May 9, 2021 at 10:38 PM vignesh C <vignes...@gmail.com> wrote: > > > > Hi, > > > > For some of the logical replication messages the data type documented > > was not correct, especially for lsn and xid. For lsn actual datatype > > used is uint64 but is documented as int64, similarly for xid, datatype > > used is uint32 but documented as int32. > > Attached is a patch which has the fix for the same. > > Thoughts? > > If you want to do this then there are more - e.g. Flags should be > Uint8 instead of Int8.
Thanks for the comments. I have made this change in v2 patch posted at [1]. This also includes the fix to specify uint8(0) at appropriate places. [1] - https://www.postgresql.org/message-id/CALDaNm2G_BJ9G%3DCxy9A6ht-TXPn4nB8W9_BcawuA1uxsNvoWfQ%40mail.gmail.com Regards, Vignesh
