On Thu, May 13, 2021 at 11:21 AM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Wed, May 12, 2021 at 4:02 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > > > On Wed, May 12, 2021 at 1:19 PM vignesh C <vignes...@gmail.com> wrote: > > > > > > > I think the part of the test that tests the stats after resetting it > > > > might give different results. This can happen because in the previous > > > > test we spill multiple times (spill_count is 12 in my testing) and it > > > > is possible that some of the spill stats messages is received by stats > > > > collector after the reset message. If this theory is correct then it > > > > better that we remove the test for reset stats and the test after it > > > > "decode and check stats again.". This is not directly related to your > > > > patch or buildfarm failure but I guess this can happen and we might > > > > see such a failure in future. > > > > Good point. I agree to remove this test. > > > > > > > > I agree with your analysis to remove that test. Attached patch has the > > > changes for the same. > > > > Thank you for the patch. The patch looks good to me. I also agree that > > removing the test doesn't reduce the test coverage. > > > > Thanks, I have pushed the patch. >
Thanks for pushing the patch. Regards, Vignesh
