Re: Logical replication - schema change not invalidating the relation cache

On Fri, Jul 16, 2021 at 10:51 PM vignesh C wrote: > > On Sat, Jul 3, 2021 at 11:23 AM Dilip Kumar wrote: > > > > On Fri, Jul 2, 2021 at 12:03 PM Dilip Kumar wrote: > > > > > > Yeah, this looks like a bug. I will look at the patch. > > > > >

Re: Added schema level support for publication.

On Thu, Aug 26, 2021 at 7:52 AM tanghy.f...@fujitsu.com wrote: > > On Wednesday, August 25, 2021 5:37 PM vignesh C wrote: > > > > Attached v21 patch has the changes based on the new syntax and fixes > > few of the other review comments provided by reviewers. > > &g

Re: Added schema level support for publication.

On Fri, Aug 27, 2021 at 4:57 PM Amit Kapila wrote: > > On Fri, Aug 27, 2021 at 11:43 AM vignesh C wrote: > > > > On Wed, Aug 25, 2021 at 3:07 PM vignesh C wrote: > > > > I have implemented this in the 0003 patch, I have kept it separate to > > reduce th

Re: Added schema level support for publication.

On Sat, Aug 28, 2021 at 3:19 PM Amit Kapila wrote: > > On Fri, Aug 27, 2021 at 6:09 PM vignesh C wrote: > > > > On Fri, Aug 27, 2021 at 4:57 PM Amit Kapila wrote: > > > > > > On Fri, Aug 27, 2021 at 11:43 AM vignesh C wrote: > > > > > >

Re: Added schema level support for publication.

On Mon, Aug 30, 2021 at 8:23 AM Greg Nancarrow wrote: > > On Fri, Aug 27, 2021 at 4:13 PM vignesh C wrote: > > > > I have implemented this in the 0003 patch, I have kept it separate to > > reduce the testing effort and also it will be easier if someone > > disagrees

Re: Added schema level support for publication.

On Mon, Aug 30, 2021 at 9:10 AM houzj.f...@fujitsu.com wrote: > > On Friday, August 27, 2021 2:13 PM vignesh C wrote: > > > > I have implemented this in the 0003 patch, I have kept it separate to > > reduce the > > testing effort and also it will be easier

Re: Added schema level support for publication.

On Mon, Aug 30, 2021 at 1:31 PM tanghy.f...@fujitsu.com wrote: > > On Friday, August 27, 2021 2:13 PM vignesh C wrote: > > > > I have implemented this in the 0003 patch, I have kept it separate to > > reduce the testing effort and also it will be easier if someone >

Added missing invalidations for all tables publication

gnesh From fd58e547c22723856a2f18c306b17ab6e59cddb1 Mon Sep 17 00:00:00 2001 From: Vignesh C Date: Mon, 30 Aug 2021 22:29:07 +0530 Subject: [PATCH v1] Added missing invalidations for all tables publication. Relation invalidation was missing in case of create publication and drop publication of "FOR ALL TABL

Re: Added missing invalidations for all tables publication

On Tue, Aug 31, 2021 at 7:40 AM houzj.f...@fujitsu.com wrote: > > From Tuesday, August 31, 2021 1:10 AM vignesh C wrote: > > Hi, > > > > Relation invalidation was missing in case of create publication and drop > > publication of "FOR ALL TABLES" pu

Re: Added schema level support for publication.

On Mon, Aug 30, 2021 at 2:14 PM Greg Nancarrow wrote: > > On Fri, Aug 27, 2021 at 4:13 PM vignesh C wrote: > > > > I have implemented this in the 0003 patch, I have kept it separate to > > reduce the testing effort and also it will be easier if someone > > disagrees

Re: Added schema level support for publication.

On Mon, Aug 30, 2021 at 12:12 PM Amit Kapila wrote: > > > Okay, I got it but let's add few comments in the code related to it. > Also, I noticed that the code in InvalidatePublicationRels() already > exists in AlterPublicationOptions(). You can try to refactor the > existing code as a separate ini

Re: Added schema level support for publication.

On Tue, Aug 31, 2021 at 4:27 PM Amit Kapila wrote: > > On Tue, Aug 31, 2021 at 10:50 AM Greg Nancarrow wrote: > > > > On Tue, Aug 31, 2021 at 1:41 PM vignesh C wrote: > > > > > > > > > > > I notice that "CREATE PUBLICATION pub1 FOR ALL T

Re: Added missing invalidations for all tables publication

On Tue, Aug 31, 2021 at 2:00 PM Kyotaro Horiguchi wrote: > > At Tue, 31 Aug 2021 08:31:05 +0530, vignesh C wrote in > > On Tue, Aug 31, 2021 at 7:40 AM houzj.f...@fujitsu.com > > wrote: > > Thanks for the comment, I have slightly modified the test case which > &g

Re: Added schema level support for publication.

On Sat, Aug 28, 2021 at 3:19 PM Amit Kapila wrote: > > Don't you think some users might want to know all the schema names for > a publication? I am not completely sure on this point but I think it > is good to have information for users. It might be also useful to have > pg_publication_objects whe

Re: Added schema level support for publication.

On Wed, Sep 1, 2021 at 6:58 AM houzj.f...@fujitsu.com wrote: > > Here are some other comments for v23-000x patches. > > 1) > > @@ -6225,6 +6342,9 @@ describePublications(const char *pattern) > boolhas_pubtruncate; > boolhas_pubviaroot; > > + PQExpBuffe

Re: Added schema level support for publication.

On Wed, Sep 1, 2021 at 11:14 AM tanghy.f...@fujitsu.com wrote: > > > On Monday, August 30, 2021 11:28 PM vignesh C wrote: > > > > I have fixed these comments as part of v23 patch attached at [1]. > > [1] - https://www.postgresql.org/message- > > id/CALDaN

Re: Added schema level support for publication.

On Fri, Sep 3, 2021 at 3:12 PM Amit Kapila wrote: > > On Mon, Aug 30, 2021 at 8:56 PM vignesh C wrote: > > > > On Mon, Aug 30, 2021 at 9:10 AM houzj.f...@fujitsu.com > > wrote: > > > > > > > > 5) > > > +

Re: Added schema level support for publication.

On Mon, Sep 6, 2021 at 6:56 AM houzj.f...@fujitsu.com wrote: > > From Thur, Sep 2, 2021 7:42 PM Amit Kapila wrote: > > On Thu, Sep 2, 2021 at 11:58 AM vignesh C wrote: > > > > > > > Below are few comments on v23. If you have already addressed anything in >

Re: Added schema level support for publication.

On Fri, Sep 3, 2021 at 4:49 PM Amit Kapila wrote: > > On Thu, Sep 2, 2021 at 5:12 PM Amit Kapila wrote: > > > > On Thu, Sep 2, 2021 at 11:58 AM vignesh C wrote: > > > > > > > Below are few comments on v23. If you have already addressed anything > >

Re: Added schema level support for publication.

On Fri, Sep 3, 2021 at 4:06 PM Amit Kapila wrote: > > On Wed, Sep 1, 2021 at 12:05 PM Amit Kapila wrote: > > > > On Wed, Sep 1, 2021 at 8:52 AM Greg Nancarrow wrote: > > > > > > > > I'd expect a lot of users to naturally think that "ALTER PUBLICATION > > > pub1 DROP ALL TABLES IN SCHEMA sc1;" wo

Re: Added schema level support for publication.

On Tue, Sep 7, 2021 at 5:10 PM Amit Kapila wrote: > > On Tue, Sep 7, 2021 at 12:45 PM vignesh C wrote: > > > > On Fri, Sep 3, 2021 at 4:49 PM Amit Kapila wrote: > > > > > > > > 5. > > > If I modify the search path to remove public schema then

Re: Added schema level support for publication.

On Mon, Sep 6, 2021 at 6:56 AM houzj.f...@fujitsu.com wrote: > > From Thur, Sep 2, 2021 2:33 PM vignesh C wrote: > > On Wed, Sep 1, 2021 at 6:58 AM houzj.f...@fujitsu.com > > wrote: > > > > > > Here are some other co

Re: Added schema level support for publication.

On Mon, Sep 13, 2021 at 7:06 PM tanghy.f...@fujitsu.com wrote: > > On Sunday, September 12, 2021 11:13 PM vignesh C wrote: > > > > Thanks for the changes, the suggested changes make the parsing code > > simpler. I have merged the changes to the main patch. Attached v27 &

Re: Added schema level support for publication.

On Tue, Sep 14, 2021 at 6:31 AM houzj.f...@fujitsu.com wrote: > > From Sun, Sept 12, 2021 11:13 PM vignesh C wrote: > > On Fri, Sep 10, 2021 at 11:21 AM Hou Zhijie wrote: > > > Attach the without-flag version and add comments about the pubobj_name. > > > > Than

Re: [BUG] Unexpected action when publishing partition tables

On Tue, Sep 7, 2021 at 11:38 AM houzj.f...@fujitsu.com wrote: > > From Tues, Sep 7, 2021 12:02 PM Amit Kapila wrote: > > On Mon, Sep 6, 2021 at 1:49 PM houzj.f...@fujitsu.com > > wrote: > > > > > > I can reproduce this bug. > > > > > > I think the reason is it didn't invalidate all the leaf par

Re: Column Filtering in Logical Replication

On Wed, Sep 15, 2021 at 5:20 PM Alvaro Herrera wrote: > > On 2021-Sep-15, Amit Kapila wrote: > > > On Mon, Sep 6, 2021 at 11:21 PM Alvaro Herrera > > wrote: > > > > > > I pushed the clerical part of this -- namely the addition of > > > PublicationTable node and PublicationRelInfo struct. > > > >

Re: Column Filtering in Logical Replication

On Thu, Sep 16, 2021 at 8:45 AM Amit Kapila wrote: > > On Wed, Sep 15, 2021 at 6:06 PM Alvaro Herrera > wrote: > > > > On 2021-Sep-15, vignesh C wrote: > > > The patch > > > Generic_object_type_parser_002_table_schema_publication.patch has the > > &

Re: Column Filtering in Logical Replication

On Thu, Sep 16, 2021 at 7:20 PM Alvaro Herrera wrote: > > On 2021-Sep-16, vignesh C wrote: > > > diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y > > index e3068a374e..c50bb570ea 100644 > > --- a/src/backend/parser/gram.y > > +++ b/src/backend/p

Re: Added schema level support for publication.

On Thu, Sep 16, 2021 at 8:59 AM houzj.f...@fujitsu.com wrote: > > On Tuesday, September 14, 2021 4:39 PM vignesh C wrote: > > > > I have handled this in the patch attached. > > Thanks for updating the patch. > Here are some comments. > > 1) > +st

Re: Added schema level support for publication.

On Thu, Sep 16, 2021 at 9:54 AM Amit Kapila wrote: > > On Wed, Sep 15, 2021 at 12:30 PM Amit Kapila wrote: > > > > On Tue, Sep 14, 2021 at 2:08 PM vignesh C wrote: > > > > > > I have handled this in the patch attached. > >

Re: Added schema level support for publication.

On Thu, Sep 16, 2021 at 11:24 AM Amit Kapila wrote: > > On Wed, Sep 15, 2021 at 4:45 PM Greg Nancarrow wrote: > > > > On Tue, Sep 14, 2021 at 6:38 PM vignesh C wrote: > > > > > > I have handled this in the patch attached. > > > > > > &g

Re: Added schema level support for publication.

On Mon, Sep 20, 2021 at 3:57 PM Amit Kapila wrote: > > On Fri, Sep 17, 2021 at 5:40 PM vignesh C wrote: > > > > On Thu, Sep 16, 2021 at 9:54 AM Amit Kapila wrote: > > > > > > I think there is one more similar locking problem. > > > AlterPublicati

Re: Added schema level support for publication.

On Tue, Sep 21, 2021 at 9:03 AM Greg Nancarrow wrote: > > On Fri, Sep 17, 2021 at 10:09 PM vignesh C wrote: > > > > Attached v29 patch has the fixes for the same. > > > > Some minor comments on the v29-0002 patch: > > (1) > In get_object_address_

Re: Added schema level support for publication.

On Mon, Sep 20, 2021 at 4:20 PM vignesh C wrote: > > On Mon, Sep 20, 2021 at 3:57 PM Amit Kapila wrote: > > > > On Fri, Sep 17, 2021 at 5:40 PM vignesh C wrote: > > > > > > On Thu, Sep 16, 2021 at 9:54 AM Amit Kapila > > > wrote: > > &g

Re: Added schema level support for publication.

On Tue, Sep 21, 2021 at 9:03 AM Greg Nancarrow wrote: > > On Fri, Sep 17, 2021 at 10:09 PM vignesh C wrote: > > > > Attached v29 patch has the fixes for the same. > > > > Some minor comments on the v29-0002 patch: > > (1) > In get_object_address_

Re: Added schema level support for publication.

On Tue, Sep 21, 2021 at 6:05 PM Greg Nancarrow wrote: > > On Tue, Sep 21, 2021 at 4:12 PM vignesh C wrote: > > > > > (1) > > > In get_object_address_publication_schema(), the error message: > > > > > > + errmsg("publication tables of sch

Re: Column Filtering in Logical Replication

On Fri, Sep 24, 2021 at 8:40 AM Amit Kapila wrote: > > On Fri, Sep 24, 2021 at 12:45 AM Tomas Vondra > wrote: > > > > Hi, > > > > I wanted to do a review of this patch, but I'm a bit confused about > > which patch(es) to review. There's the v5 patch, and then these two > > patches - which seem to

Re: Added schema level support for publication.

On Wed, Sep 22, 2021 at 8:52 AM Masahiko Sawada wrote: > > On Wed, Sep 22, 2021 at 3:02 AM vignesh C wrote: > > > > > > Attached v30 patch has the fixes for the same. > > > > Thank you for updating the patches. > > Here are random comments on v30-0002

Re: Added schema level support for publication.

On Wed, Sep 22, 2021 at 11:27 AM tanghy.f...@fujitsu.com wrote: > > On Wednesday, September 22, 2021 11:22 AM Masahiko Sawada > wrote: > > > > --- > > + if (!IsA(node, String)) > > + ereport(ERROR, > > +

Re: Added schema level support for publication.

On Wed, Sep 22, 2021 at 11:31 AM Amit Kapila wrote: > > On Tue, Sep 21, 2021 at 11:39 PM vignesh C wrote: > > > > On Tue, Sep 21, 2021 at 9:03 AM Greg Nancarrow wrote: > > > > > > On Fri, Sep 17, 2021 at 10:09 PM vignesh C wrote: > > > > >

Re: Added schema level support for publication.

On Thu, Sep 23, 2021 at 12:22 PM houzj.f...@fujitsu.com wrote: > > From Thurs, Sep 23, 2021 12:09 PM Amit Kapila wrote: > > On Wed, Sep 22, 2021 at 5:03 PM Hou Zhijie wrote: > > > > > > Personally, I think we'd better move the code about changing publication's > > > tablelist into AlterPublicati

Re: Added schema level support for publication.

On Thu, Sep 23, 2021 at 12:32 PM houzj.f...@fujitsu.com wrote: > > On Thur, Sep 23, 2021 11:06 AM Greg Nancarrow wrote: > > On Wed, Sep 22, 2021 at 9:33 PM houzj.f...@fujitsu.com > > wrote: > > > > > > > > > > > How do you suggest changing it? > > > > > > Personally, I think we'd better move th

Re: Column Filtering in Logical Replication

On Fri, Sep 24, 2021 at 6:55 PM Alvaro Herrera wrote: > > On 2021-Sep-23, Amit Kapila wrote: > > > Alvaro, do you have any thoughts on these proposed grammar changes? > > Yeah, I think pubobj_name remains a problem in that you don't know its > return type -- could be a String or a RangeVar, and th

Re: Column Filtering in Logical Replication

On Mon, Sep 27, 2021 at 4:41 PM Amit Kapila wrote: > > On Sat, Sep 25, 2021 at 1:15 PM vignesh C wrote: > > > > On Fri, Sep 24, 2021 at 6:55 PM Alvaro Herrera > > wrote: > > > > > > On 2021-Sep-23, Amit Kapila wrote: > > > > > >

Re: Added schema level support for publication.

On Mon, Sep 27, 2021 at 2:46 PM Greg Nancarrow wrote: > > On Mon, Sep 27, 2021 at 2:32 PM vignesh C wrote: > > > > Attached v33 patch has the preprocess_pubobj_list review comment fix > > suggested by Alvaro at [1]. > > A minor point I noticed in the v33-0002 pat

Re: Added schema level support for publication.

On Mon, Sep 27, 2021 at 4:51 PM Greg Nancarrow wrote: > > On Mon, Sep 27, 2021 at 2:32 PM vignesh C wrote: > > > > Attached v33 patch has the preprocess_pubobj_list review comment fix > > suggested by Alvaro at [1]. > > In the v33-0003 patch, there's a c

Re: Added schema level support for publication.

On Tue, Sep 28, 2021 at 4:35 PM tanghy.f...@fujitsu.com wrote: > > On Monday, September 27, 2021 1:32 PM, vignesh C wrote: > > >Attached v33 patch has the preprocess_pubobj_list review comment fix > >suggested by Alvaro at [1]. The > >v33-0006-Alternate-grammar-for

Re: Added schema level support for publication.

On Wed, Sep 29, 2021 at 9:07 AM houzj.f...@fujitsu.com wrote: > > On Tues, Sep 28, 2021 10:46 PM vignesh C wrote: > > Attached v34 patch has the changes for the same. > > Thanks for updating the patch. > Here are a few comments. > > 1) > + *

Re: Added schema level support for publication.

On Wed, Sep 29, 2021 at 10:46 AM Amit Kapila wrote: > > On Tue, Sep 28, 2021 at 8:15 PM vignesh C wrote: > > > > On Mon, Sep 27, 2021 at 12:15 PM houzj.f...@fujitsu.com > > wrote: > > > > Attached v34 patch has the changes for the same. > > >

Re: Added schema level support for publication.

On Wed, Sep 29, 2021 at 11:49 AM Greg Nancarrow wrote: > > On Wed, Sep 29, 2021 at 3:16 PM Amit Kapila wrote: > > > > 4. > > + /* > > + * Check if setting the relation to a different schema will result in the > > + * publication having schema and same schema's table in the publication. > > + */ >

Re: Added schema level support for publication.

On Tue, Oct 5, 2021 at 4:41 PM Amit Kapila wrote: > > On Tue, Oct 5, 2021 at 11:10 AM Greg Nancarrow wrote: > > > > On Tue, Oct 5, 2021 at 3:11 PM Amit Kapila wrote: > > > > > > > Code has been added to prevent a table being set (via ALTER TABLE) to > > > > UNLOGGED if it is part of a publicatio

Re: Added schema level support for publication.

On Tue, Oct 5, 2021 at 6:57 AM Greg Nancarrow wrote: > > On Mon, Oct 4, 2021 at 4:55 AM vignesh C wrote: > > > > Attached v36 patch has the changes for the same. > > > > I have some comments on the v36-0001 patch: > > src/backend/commands/publicationcm

pg_dump does not dump tables created in information_schema schema

Hi, I was able to create a table in "information_schema" schema, but pg_dump does not dumps the table that was created in "information_schema" schema: create table information_schema.t1(c1 int); The similar problem exists in case of create publication, we are able to create publications for table

Re: pg_dump does not dump tables created in information_schema schema

On Thu, Oct 7, 2021 at 9:30 PM Tom Lane wrote: > > "David G. Johnston" writes: > > On Thursday, October 7, 2021, vignesh C wrote: > >> Should tables be allowed to create in "information_schema" schema, if > >> yes should the tables/publicati

Re: Failed transaction statistics to measure the logical replication progress

On Thu, Jul 8, 2021 at 12:25 PM osumi.takami...@fujitsu.com wrote: > > Hello, hackers > > > When the current HEAD fails during logical decoding, the failure > increments txns count in pg_stat_replication_slots - [1] and adds > the transaction size to the sum of bytes in the same repeatedly > on th

Re: Add option --drop-cascade for pg_dump/restore

On Fri, Jul 2, 2021 at 12:11 PM Haotian Wu wrote: > > Hi, > > I agree that —drop-cascade does not make sense for pg_dumpall, so I removed > them. > > > are we expecting more things to appear after the semi-colon? > > No, I was just trying to “reuse” original statement as much as possible. > Appe

Re: Enhanced error message to include hint messages for redundant options error

On Tue, Jul 13, 2021 at 4:25 PM Dean Rasheed wrote: > > On Mon, 12 Jul 2021 at 17:39, vignesh C wrote: > > > > Thanks for your comments, I have made the changes for the same in the > > V10 patch attached. > > Thoughts? > > > > I'm still not happy

Re: Printing backtrace of postgres processes

On Wed, May 12, 2021 at 2:27 AM Robert Haas wrote: > > On Thu, May 6, 2021 at 3:31 PM Tom Lane wrote: > > Andres Freund writes: > > > On 2021-05-06 14:56:09 -0400, Tom Lane wrote: > > >> If we think it's worth having a predefined role for, OK. However, > > >> I don't like the future I see us he

Re: Added schema level support for publication.

On Tue, Jul 13, 2021 at 2:22 PM Greg Nancarrow wrote: > > On Mon, Jul 12, 2021 at 7:24 PM vignesh C wrote: > > > > > > Thanks for reporting this issue. I felt this issue is the same as the issue which Hou San had reported. This issue is fixed in the v10 patch attached

Re: alter table set TABLE ACCESS METHOD

On Thu, Jun 10, 2021 at 1:01 AM Jeff Davis wrote: > > On Wed, 2021-06-09 at 13:47 +0900, Michael Paquier wrote: > > There is a mix of upper and lower-case characters here. It could be > > more consistent. It seems to me that this test should actually check > > that pg_class.relam reflects the ne

Re: Columns correlation and adaptive query optimization

On Fri, Mar 19, 2021 at 10:28 PM Konstantin Knizhnik wrote: > > > > On 19.03.2021 12:17, Yugo NAGATA wrote: > > On Wed, 10 Mar 2021 03:00:25 +0100 > > Tomas Vondra wrote: > > > >> What is being proposed here - an extension suggesting which statistics > >> to create (and possibly creating them aut

Re: [PATCH] Add extra statistics to explain for Nested Loop

On Wed, Apr 14, 2021 at 4:57 PM wrote: > > Thank you for working on this issue. Your comments helped me make this > patch more correct. > > > Lines with "colon" format shouldn't use equal signs, and should use two > > spaces > > between fields. > Done. Now extra line looks like "Loop min_rows: %.0

Re: partial heap only tuples

On Tue, Mar 9, 2021 at 12:09 AM Bossart, Nathan wrote: > > On 3/8/21, 10:16 AM, "Ibrar Ahmed" wrote: > > On Wed, Feb 24, 2021 at 3:22 AM Bossart, Nathan wrote: > >> On 2/10/21, 2:43 PM, "Bruce Momjian" wrote: > >>> I wonder if you should create a Postgres wiki page to document all of > >>> this

Re: Write visibility map during CLUSTER/VACUUM FULL

On Mon, Jun 28, 2021 at 1:52 PM Anna Akenteva wrote: > > On 2019-11-29 05:32, Michael Paquier wrote: > > These comments are unanswered for more than 2 months, so I am marking > > this entry as returned with feedback. > > I'd like to revive this patch. To make further work easier, attaching a > reb

Re: WIP: System Versioned Temporal Table

On Mon, Mar 8, 2021 at 11:04 PM Ibrar Ahmed wrote: > > > > On Thu, Feb 25, 2021 at 3:28 PM Li Japin wrote: >> >> >> On Jan 27, 2021, at 12:39 AM, Surafel Temesgen wrote: >> >> >> >> On Tue, Jan 26, 2021 at 2:33 PM Vik Fearing wrote: >>> >>> I'm still in the weeds of reviewing this patch, but wh

Re: Enhance traceability of wal_level changes for backup management

On Thu, Jan 28, 2021 at 6:14 AM osumi.takami...@fujitsu.com wrote: > > Hello > > > On Thursday, January 21, 2021 11:19 PM I wrote: > > If no one disagree with it, I'll proceed with (1) below. > > > > (1) writing the time or LSN in the control file to indicate when/where > > wal_level > > is chang

Re: Toast compression method options

On Thu, May 6, 2021 at 7:24 PM Dilip Kumar wrote: > > On Mon, May 3, 2021 at 6:27 PM Dilip Kumar wrote: > > > > We have already pushed the configurable lz4 toast compression code[1]. > > In the custom compression thread, we were already having the patch to > > support the compression method optio

Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions

On Sun, Sep 13, 2020 at 9:34 PM Nikolay Shaplov wrote: > > В письме от понедельник, 20 июля 2020 г. 18:36:44 MSK пользователь Georgios > Kokolatos написал: > > Hi! Sorry for really long delay, I was at my summer vacations, and then has > urgent things to finish first. :-( Now I hope we can continu

Re: Polyphase merge is obsolete

On Sat, Jan 23, 2021 at 3:49 AM Heikki Linnakangas wrote: > > On 22/10/2020 14:48, Heikki Linnakangas wrote: > > On 11/09/2017 13:37, Tomas Vondra wrote: > >> I planned to do some benchmarking on this patch, but apparently the > >> patch no longer applies. Rebase please? > > > > Here's a rebase of

Re: ResourceOwner refactoring

On Tue, Mar 9, 2021 at 6:10 PM Heikki Linnakangas wrote: > > On 08/03/2021 18:47, Ibrar Ahmed wrote: > > The patchset does not apply successfully, there are some hunk failures. > > > > http://cfbot.cputube.org/patch_32_2834.log > > > > > > v6-0002-Make-

Re: libpq compression

On Wed, Jul 14, 2021 at 6:31 PM Daniil Zakhlystov wrote: > > **sorry for the noise, but I need to re-send the message because one of the > recipients is blocked on the pgsql-hackers for some reason** > > Hi! > > Done, the patch should apply to the current master now. > > Actually, I have an almos

Re: [PATCH] Allow multiple recursive self-references

On Wed, Mar 31, 2021 at 7:28 PM Denis Hirn wrote: > > Sorry, I didn't append the patch properly. The patch does not apply on Head anymore, could you rebase and post a patch. I'm changing the status to "Waiting for Author". Regards, Vignesh

Re: DROP INDEX CONCURRENTLY on partitioned index

On Wed, Oct 28, 2020 at 6:14 AM Justin Pryzby wrote: > > Forking this thread, since the existing CFs have been closed. > https://www.postgresql.org/message-id/flat/20200914143102.GX18552%40telsasoft.com#58b1056488451f8594b0f0ba40996afd > > On Mon, Sep 14, 2020 at 09:31:03AM -0500, Justin Pryzby wr

Re: [HACKERS] GSoC 2017: Foreign Key Arrays

On Tue, Mar 30, 2021 at 2:14 AM Mark Rofail wrote: > > Hey Alvaro > >> Yes, we should do that. > > I have attached v12 with more tests in “ src/test/regress/sql/gin.sql” > > Changelog: > - v12 (compatible with current master 2021/03/29, commit > 6d7a6feac48b1970c4cd127ee65d4c487acbb5e9) > * a

Re: Implementing Incremental View Maintenance

On Mon, May 17, 2021 at 10:08 AM Yugo NAGATA wrote: > > On Fri, 7 May 2021 14:14:16 +0900 > Yugo NAGATA wrote: > > > On Mon, 26 Apr 2021 16:03:48 +0900 > > Yugo NAGATA wrote: > > > > > On Mon, 26 Apr 2021 15:46:21 +0900 > > > Yugo NAGATA wrote: > > > > > > > On Tue, 20 Apr 2021 09:51:34 +0900 >

Re: Make Append Cost aware of some run time partition prune case

On Thu, Mar 4, 2021 at 9:51 AM Andy Fan wrote: > > >> >> I have implemented a new one, which only handles 1 level of partitioned >> table, and >> only 1 partition key. and only handle the eq operators like partkey = $1 / >> partkey in ($1, $2) >> / parkey = $1 or partkey = $2; The patch works

Re: [PATCH] New default role allowing to change per-role/database settings

On Wed, Apr 7, 2021 at 5:23 PM Michael Banck wrote: > > Hi, > > Am Dienstag, den 06.04.2021, 15:37 +0200 schrieb Michael Banck: > > Am Montag, den 05.04.2021, 14:33 -0400 schrieb Stephen Frost: > > > Should drop the 'DEFAULT_' to match the others since the rename to > > > 'predefined' roles went i

Re: Reduce the number of special cases to build contrib modules on windows

On Mon, Apr 19, 2021 at 5:18 PM David Rowley wrote: > > On Wed, 3 Mar 2021 at 22:37, David Rowley wrote: > > I've attached a rebased patch. > > I've rebased this again. > > I also moved away from using hash tables for storing references and > libraries. I was having some problems getting psql to

Re: Release SPI plans for referential integrity with DISCARD ALL

On Wed, Mar 10, 2021 at 1:49 PM yuzuko wrote: > > Hello, > > I thought about this suggestion again. > > Amit's patch suggested in the thread [1] can eliminate SPI plans from > INSERT/UPDATE triggers, so our memory pressure issue would be solved. > But as far as I can see that thread, Amit's patch

Re: storing an explicit nonce

On Sat, Jun 26, 2021 at 2:52 AM Bruce Momjian wrote: > > On Wed, May 26, 2021 at 05:02:01PM -0400, Bruce Momjian wrote: > > For these reasons, if we decide to go in the direction of using a > > non-LSN nonce, I no longer plan to continue working on this feature. I > > would rather work on things t

Re: VACUUM (DISABLE_PAGE_SKIPPING on)

On Thu, Apr 8, 2021 at 11:40 PM Simon Riggs wrote: > > On Thu, 8 Apr 2021 at 18:15, Alvaro Herrera wrote: > > > > On 2021-Apr-08, Simon Riggs wrote: > > > > > On Thu, 8 Apr 2021 at 16:58, David Steele wrote: > > > > > > It's not clear to me which patch is which, so perhaps move one CF entry > >

Re: POC: Cleaning up orphaned files using undo logs

On Wed, Jun 30, 2021 at 11:10 PM Antonin Houska wrote: > > Antonin Houska wrote: > > > tsunakawa.ta...@fujitsu.com wrote: > > > > > I'm crawling like a snail to read the patch set. Below are my first set > > > of review comments, which are all minor. > > > > Thanks. > > I've added the patch to

Re: Enhanced error message to include hint messages for redundant options error

On Thu, Jul 15, 2021 at 1:40 PM Dean Rasheed wrote: > > On Tue, 13 Jul 2021 at 15:30, vignesh C wrote: > > > > On Tue, Jul 13, 2021 at 4:25 PM Dean Rasheed > > wrote: > > > > > > As it stands, the improvements from (3) seem quite worthwhile. Also,

Re: A qsort template

On Sun, Jul 4, 2021 at 9:58 AM Thomas Munro wrote: > > On Fri, Jul 2, 2021 at 2:32 PM John Naylor > wrote: > > I suspect if we experiment on two extremes of type "heaviness" (accessing > > and comparing trivial or not), such as uint32 and tuplesort, we'll have a > > pretty good idea what the p

Re: Remove redundant initializations

On Mon, Jun 28, 2021 at 3:30 PM Peter Eisentraut wrote: > > There are certain parts of code that laboriously initialize every field > of a struct to (some spelling of) zero, even though the whole struct was > just zeroed (by makeNode() or memset()) a few lines earlier. Besides > being redundant,

Re: Removing unneeded self joins

On Thu, May 27, 2021 at 12:21 PM Andrey V. Lepikhov wrote: > > On 5/8/21 2:00 AM, Hywel Carver wrote: > > On Fri, May 7, 2021 at 8:23 AM Andrey Lepikhov > > mailto:a.lepik...@postgrespro.ru>> wrote: > > Here I didn't work on 'unnecessary IS NOT NULL filter'. > > > > I've tested the new patch,

Re: Rename of triggers for partitioned tables

On Mon, Jun 28, 2021 at 3:46 PM Arne Roland wrote: > > Hi! > > > From: Zhihong Yu > Sent: Saturday, June 26, 2021 20:32 > Subject: Re: Rename of triggers for partitioned tables > > > Hi, Arne: > > It seems the patch no longer applies cleanly on master branch. > > Do you mind updating the patch ?

Re: psql - add SHOW_ALL_RESULTS option

On Sat, Jun 12, 2021 at 3:11 PM Fabien COELHO wrote: > > > Hello Peter, > > >> My overly naive trust in non regression test to catch any issues has been > >> largely proven wrong. Three key features do not have a single tests. Sigh. > >> > >> I'll have some time to look at it over next week-end, b

Re: postgres_fdw - make cached connection functions tests meaningful

On Mon, May 10, 2021 at 6:03 PM Bharath Rupireddy wrote: > > Hi, > > While working on [1], I got to know that there is a new GUC > debug_invalidate_system_caches_always that has been introduced in v14. > It can be used to switch off cache invalidation in > CLOBBER_CACHE_ALWAYS builds which makes c

Re: logical decoding and replication of sequences

On Wed, Jun 23, 2021 at 7:55 PM Tomas Vondra wrote: > > On 6/23/21 4:14 PM, Tomas Vondra wrote: > > A rebased patch, addressing a minor bitrot due to 4daa140a2f5. > > > > Meh, forgot to attach the patch as usual, of course ... The patch does not apply on Head anymore, could you rebase and post a

Re: Split xlog.c

On Tue, Jun 22, 2021 at 2:37 AM Heikki Linnakangas wrote: > > On 17/06/2021 02:00, Andres Freund wrote: > > On 2021-06-16 16:30:45 +0300, Heikki Linnakangas wrote: > >> That's a fairly clean split. StartupXLOG() stays in xlog.c, but much of > >> the > >> code from it has been moved to new functi

Re: Identify missing publications from publisher while create/alter subscription.

On Tue, Jul 6, 2021 at 8:09 PM vignesh C wrote: > > On Wed, Jun 30, 2021 at 8:23 PM vignesh C wrote: > > > > On Sun, Jun 6, 2021 at 11:55 AM vignesh C wrote: > > > > > > On Fri, May 7, 2021 at 6:44 PM vignesh C wrote: > > > > > > > >

Re: [HACKERS] logical decoding of two-phase transactions

On Wed, Jul 14, 2021 at 2:03 PM Peter Smith wrote: > > On Wed, Jul 14, 2021 at 4:23 PM Amit Kapila wrote: > > > > On Mon, Jul 12, 2021 at 9:14 AM Peter Smith wrote: > > > > > > On Sun, Jul 11, 2021 at 8:20 PM Amit Kapila > > > wrote: > > > > > > > > On Fri, Jul 9, 2021 at 4:43 AM Peter Smith

Re: Added schema level support for publication.

On Fri, Jul 16, 2021 at 9:25 AM Greg Nancarrow wrote: > > On Wed, Jul 14, 2021 at 8:17 PM vignesh C wrote: > > > > Thanks for your comments, the attached v11 patch fixes the issues. > > > > Thanks for your work on this. > > I have some minor review comments

Re: Corrected documentation of data type for the logical replication message formats.

On Fri, Jul 16, 2021 at 8:52 AM Peter Smith wrote: > > Hi Vignesh. > > FYI - Because the other patch [1] was pushed ahead of this one, I > think your patch now needs to be updated for the new message types > that were introduced. Thanks, I have made the changes for the same in the v5 patch attach

Re: Add option --drop-cascade for pg_dump/restore

On Tue, Jul 13, 2021 at 9:16 PM Wu Haotian wrote: > > > 2) I felt pg_dump will include the cascade option for plain format and > > pg_restore will include the cascade option from pg_restore for other > > formats. If my understanding is correct, should we document this? > > I may not understand it

Added documentation for cascade and restrict option of drop statistics

Hi, Cascade and restrict options are supported for drop statistics syntax: drop statistics stat1 cascade; drop statistics stat2 restrict; The documentation for this was missing, attached a patch which includes the documentation for these options. Regards, Vignesh From a7f1bf7eb8e1d693274016e9371

Re: psql tab auto-complete for CREATE PUBLICATION

On Fri, Jul 9, 2021 at 1:06 PM Peter Smith wrote: > > I found that the psql tab auto-complete was not working for some cases > of CREATE PUBLICATION [1]. > > CREATE PUBLICATION name > [ FOR TABLE [ ONLY ] table_name [ * ] [, ...] > | FOR ALL TABLES ] > [ WITH ( publication_parameter

Re: Logical replication - schema change not invalidating the relation cache

On Sat, Jul 3, 2021 at 11:23 AM Dilip Kumar wrote: > > On Fri, Jul 2, 2021 at 12:03 PM Dilip Kumar wrote: > > > > Yeah, this looks like a bug. I will look at the patch. > > > > While looking into this, I think the main cause of the problem is that > schema rename does not invalidate the relation

Re: Added documentation for cascade and restrict option of drop statistics

On Mon, 19 Jul 2021, 09:16 Michael Paquier, wrote: > > On Sun, Jul 18, 2021 at 12:37:48PM +0900, Michael Paquier wrote: > > Indeed, good catch. The other commands document that, so let's fix > > it. > > Applied. Thanks for committing this patch. Regards, Vignesh

<    8   9   10   11   12   13   14   15   16   17   >