On Mon, Sep 27, 2021 at 4:51 PM Greg Nancarrow <gregn4...@gmail.com> wrote: > > On Mon, Sep 27, 2021 at 2:32 PM vignesh C <vignes...@gmail.com> wrote: > > > > Attached v33 patch has the preprocess_pubobj_list review comment fix > > suggested by Alvaro at [1]. > > In the v33-0003 patch, there's a couple of error-case tests that have > comments copied from success-case tests: > > +-- should be able to add table to schema publication > ... > +-- should be able to drop table from schema publication > ... > > These should be changed to something similar to that used for other > error-case tests, like: > > +-- fail - can't add a table of the same schema to the schema publication > +-- fail - can't drop a table from the schema publication which isn't > in the publication
Modified > Also, for the following error: > > ERROR: cannot add ... to publication > DETAIL: Table's schema "xxxx" is already part of the publication > or part of the specified schema list. > > there needs to be a test case to test the "... or part of the > specified schema list" case. Added the test This is handled in the v34 patch attached at [1]. [1] - https://www.postgresql.org/message-id/CALDaNm2Z9TfuoCf09YGKfwy7F1NwC4iCXJGTaZS%3DchH6VHtadQ%40mail.gmail.com Regards, Vignesh
