On Mon, Apr 19, 2021 at 5:18 PM David Rowley <dgrowle...@gmail.com> wrote: > > On Wed, 3 Mar 2021 at 22:37, David Rowley <dgrowle...@gmail.com> wrote: > > I've attached a rebased patch. > > I've rebased this again. > > I also moved away from using hash tables for storing references and > libraries. I was having some problems getting psql to compile due to > the order of the dependencies being reversed due to the order being at > the mercy of Perl's hash function. There's mention of this in > Makefile.global.in: > > # libpq_pgport is for use by client executables (not libraries) that use > libpq. > # We force clients to pull symbols from the non-shared libraries libpgport > # and libpgcommon rather than pulling some libpgport symbols from libpq just > # because libpq uses those functions too. This makes applications less > # dependent on changes in libpq's usage of pgport (on platforms where we > # don't have symbol export control for libpq). To do this we link to > # pgport before libpq. This does cause duplicate -lpgport's to appear > # on client link lines, since that also appears in $(LIBS). > # libpq_pgport_shlib is the same idea, but for use in client shared libraries. > > I switched these back to arrays but added an additional check to only > add new items to the array if we don't already have an element with > the same value. > > I've attached the diffs in the *.vcxproj files between patched and unpatched.
The patch does not apply on Head anymore, could you rebase and post a patch. I'm changing the status to "Waiting for Author". Regards, Vignesh
