On Mon, May 17, 2021 at 10:08 AM Yugo NAGATA <nag...@sraoss.co.jp> wrote: > > On Fri, 7 May 2021 14:14:16 +0900 > Yugo NAGATA <nag...@sraoss.co.jp> wrote: > > > On Mon, 26 Apr 2021 16:03:48 +0900 > > Yugo NAGATA <nag...@sraoss.co.jp> wrote: > > > > > On Mon, 26 Apr 2021 15:46:21 +0900 > > > Yugo NAGATA <nag...@sraoss.co.jp> wrote: > > > > > > > On Tue, 20 Apr 2021 09:51:34 +0900 > > > > Yugo NAGATA <nag...@sraoss.co.jp> wrote: > > > > > > > > > On Mon, 19 Apr 2021 17:40:31 -0400 > > > > > Tom Lane <t...@sss.pgh.pa.us> wrote: > > > > > > > > > > > Andrew Dunstan <and...@dunslane.net> writes: > > > > > > > This patch (v22c) just crashed for me with an assertion failure on > > > > > > > Fedora 31. Here's the stack trace: > > > > > > > > > > > > > #2 0x000000000094a54a in ExceptionalCondition > > > > > > > (conditionName=conditionName@entry=0xa91dae > > > > > > > "queryDesc->sourceText != > > > > > > > NULL", errorType=errorType@entry=0x99b468 "FailedAssertion", > > > > > > > fileName=fileName@entry=0xa91468 > > > > > > > "/home/andrew/pgl/pg_head/src/backend/executor/execMain.c", > > > > > > > lineNumber=lineNumber@entry=199) at > > > > > > > /home/andrew/pgl/pg_head/src/backend/utils/error/assert.c:69 > > > > > > > > > > > > That assert just got added a few days ago, so that's why the patch > > > > > > seemed OK before. > > > > > > > > > > Thank you for letting me know. I'll fix it. > > > > > > > > Attached is the fixed patch. > > > > > > > > queryDesc->sourceText cannot be NULL after commit 1111b2668d8, > > > > so now we pass an empty string "" for refresh_matview_datafill() > > > > instead NULL > > > > when maintaining views incrementally. > > > > > > I am sorry, I forgot to include a fix for 8aba9322511. > > > Attached is the fixed version. > > > > Attached is the rebased patch (for 6b8d29419d). > > I attached a rebased patch.
The patch does not apply on Head anymore, could you rebase and post a patch. I'm changing the status to "Waiting for Author". Regards, Vignesh
