Re: RFC: Additional Directory for Extensions

On Mar 3, 2025, at 10:05, David E. Wheeler wrote: > Very nice writeup, thank you. Makes me wish for the bandwidth to get back to > and start refining the PGXN OCI RFC Forgot to link to the POC[1]. The RFC[2] is not OCI-specific, but the POC demonstrates the “full content” version. Will likely

Re: Slot's restart_lsn may point to removed WAL segment after hard restart unexpectedly

Dear Hackers, Let me please introduce a new version of the patch. Patch description: The slot data is flushed to the disk at the beginning of checkpoint. If an existing slot is advanced in the middle of checkpoint execution, its advanced restart LSN is taken to calculate the oldest LSN for WAL s

Re: RFC: Additional Directory for Extensions

On Mar 3, 2025, at 08:39, Gabriele Bartolini wrote: > As promised, here is a blog article that provides more context and > information about what this feature will mean in Kubernetes with > CloudNativePG: > https://www.gabrielebartolini.it/articles/2025/03/the-immutable-future-of-postgresql-e

Re: Change log level for notifying hot standby is waiting non-overflowed snapshot

On 2025-03-03 13:10, Fujii Masao wrote: Thanks for your comments! On 2025/02/03 22:35, torikoshia wrote: Hi, When a hot standby is restarted in a state where subtransactions have overflowed, it may become inaccessible:   $ psql: error: connection to server at "localhost" (::1), port 5433

Re: vacuumdb changes for stats import/export

On Mon, Mar 03, 2025 at 05:58:43PM +0700, John Naylor wrote: > On Sat, Mar 1, 2025 at 3:42 AM Nathan Bossart > wrote: >> On Thu, Feb 27, 2025 at 04:36:04PM +0700, John Naylor wrote: >> > I had to read it several times before I noticed the difference between >> > "* found_objs" and "*found_objs".

Re: PATCH: warn about, and deprecate, clear text passwords

On Tue, Feb 25, 2025 at 11:13:51AM -0500, Greg Sabino Mullane wrote: > On Tue, Feb 25, 2025 at 10:34 AM Nathan Bossart > wrote: >> IMHO a WARNING would really only be appropriate if we are definitely going >> to remove support in the future, and that feels like a bit of a stretch to >> me due to t

Re: Considering fractional paths in Append node

On 03.03.2025 14:17, Alena Rybakina wrote: Hi! Thank you for your work on this subject. I agree with your code but one phrase in commit message was confusing for me: "This change is dedicated to more active usage of IndexScan and parameterised NestLoop paths in partitioned cases under an App

Re: Statistics Import and Export: difference in statistics dumped

On Sat, Mar 1, 2025 at 1:40 AM Jeff Davis wrote: > > On Fri, 2025-02-28 at 14:51 +0530, Ashutosh Bapat wrote: > > 2. We aren't restoring the statistics faithfully - as mentioned in > > Greg's reply. If users dump and restore with autovacuum turned off, > > they will be surprised to see the statist

Re: bug when apply fast default mechanism for adding new column over domain with default value

jian he writes: > within ATExecAddColumn, we can > if (!missingIsNull) >StoreAttrMissingVal(rel, attribute->attnum, missingval, missingIsNull); > to save some cycles? Probably not really worth it: surely that's going to be a very infrequent edge case. We already eliminated cases with a simpl

Re: making EXPLAIN extensible

On Mon, Mar 3, 2025 at 9:14 AM Matthias van de Meent wrote: > I think you meant "some time prior to PostgreSQL 10". > PostgreSQL 9.0 had 5 options, of which COSTS, BUFFERS, and FORMAT were > newly added, so only before 9.0 we had 2 options. > PostgreSQL 9.2 then added TIMING on top of that, for a

Re: lwlocknames.h beautification attempt

On Sun, Mar 2, 2025 at 1:10 AM Gurjeet Singh wrote: > I propose the following change to the generation script, > generate-lwlocknames.pl > > -print $h "#define ${lockname}Lock (&MainLWLockArray[$lockidx].lock)\n"; > +printf $h "#define %-30s %s\n", "${lockname}Lock", > "(&MainLWLockArray

Re: Adding support for SSLKEYLOGFILE in the frontend

> On 28 Feb 2025, at 07:20, Abhishek Chanda wrote: > > Attached a v6 with O_NOFOLLOW removed, I noticed that it failed on > windows. Please let me know if I should do this in any other way that > is portable across platforms. Not sure if there is a portable way to can support. required v

Re: Options to control remote transactions’ access/deferrable modes in postgres_fdw

Ashutosh Bapat writes: > On Sun, Mar 2, 2025 at 5:14 PM Etsuro Fujita wrote: >> To avoid that, I would like to propose a server option, >> inherit_read_only, to open the remote transactions in read-only mode >> if the local transaction is read-only. > Why do we need a server option. Either we sa

[PATCH] Improve selectivity estimation for OR clauses with equality conditions on the same column

hi hackers, When estimating the selectivity of an OR clause without extended statistics, we assume that the conditions are independent. However, it is quite common to see queries like (a = 1 OR a = 2). In such cases, the assumption of independence can lead to a significant underestimation of

Re: making EXPLAIN extensible

First, thanks to all who have said they like this idea. I wasn't expecting this much enthusiasm, to be honest. Woohoo! On Mon, Mar 3, 2025 at 8:27 AM Matheus Alcantara wrote: > It would make sense (or possible) to have some kind of validation that returns > an error when using an option that is a

Re: Parallel CREATE INDEX for GIN indexes

I've pushed the first part of the series (0001 + the cleanup and progress patch). That leaves the two smaller improvement parts (compression + memory limit enforcement) - I intend to push those sometime this week, if possible. Here's a rebased version of the whole patch series, including the two W

Re: Flaky 003_start_stop.pl test

Hi, On 2025-02-24 11:26:56 +0100, Jelte Fennema-Nio wrote: > The test introduced in bb86141 turns out to be flaky in CI[1] with the > following error message: > > [03:40:43.047] stderr: > [03:40:43.047] # Failed test 'connect : matches' > [03:40:43.047] # at > /tmp/cirrus-ci-build/src/test/postmas

Re: dblink: Add SCRAM pass-through authentication

On Fri, Feb 21, 2025 at 6:48 AM Matheus Alcantara wrote: > Hi, thanks for all the reviews. Attached v3 with some fixes. Thanks! I keep getting pulled away from my review of 0002, so I'll just comment on 0001 to get things moving again; sorry for the delay. > I agree, I've just declared outside o

Re: PATCH: warn about, and deprecate, clear text passwords

On Mon, Mar 3, 2025 at 11:33 AM Nathan Bossart wrote: > I think it would be good to hear some other opinions on whether we should > consider sending clear-text passwords to the server as either 1) fully > supported, 2) deprecated but with no intent to remove anytime soon, or 3) > deprecated with

Re: Log connection establishment timings

On 2025/03/04 1:14, Bertrand Drouvot wrote: === 2 +/* + * Validate the input for the log_connections GUC. + */ +bool +check_log_connections(char **newval, void **extra, GucSource source) +{ This function is pretty close to check_debug_io_direct() for example and its overall content, memory m

Re: per backend WAL statistics

Hi, On Mon, Mar 03, 2025 at 10:48:23AM +0900, Michael Paquier wrote: > On Fri, Feb 28, 2025 at 09:26:08AM +, Bertrand Drouvot wrote: > > Also attaching the patch I mentioned up-thread to address some of Rahila's > > comments ([1]): It adds a AuxiliaryPidGetProc() call in > > pgstat_fetch_stat

Re: Commit fest 2025-03

On Tue, 25 Feb 2025 at 21:49, vignesh C wrote: > > If any of these are ready, please add them to the CommitFest page. If > you think some are trivial and don’t need to be added, that’s fine > too. > Looking forward to a productive CommitFest! March 2025 commitfest has started, the current status

Re: Selectively invalidate caches in pgoutput module

On Mon, Mar 3, 2025 at 1:27 PM Hayato Kuroda (Fujitsu) wrote: > > Hi, this is a fork thread from [1]. I want to propose a small optimization for > logical replication system. > > Background > == > > When the ALTER PUBLICATION command is executed, all entries in > RelationSyncCache > will

Re: SQL:2011 application time

On 26.02.25 06:15, Paul Jungwirth wrote: I agree with that last principle: it shouldn't matter how the primary keys are split up. But it seems to me that "matches" in the standard should include the period. It does for NO ACTION, so why not RESTRICT? That's why your example of expanding the ref

Re: Proposal: Filter irrelevant change before reassemble transactions during logical decoding

On Thu, Feb 20, 2025 at 8:42 PM Hayato Kuroda (Fujitsu) wrote: > > Dear Ajin, > > Here are my comments. I must play with patches to understand more. > > 01. > ``` > extern bool ReorderBufferFilterByRelFileLocator(ReorderBuffer *rb, > TransactionId xid, >

Re: Use Python "Limited API" in PL/Python

On 15.01.25 23:20, Peter Eisentraut wrote: On 15.01.25 12:28, Jakob Egger wrote: On 14.01.2025, at 16:51, Jakob Egger wrote: I've tried to create a patch with this change. I'm attaching it to this message so that cfbot picks it up. (I was unable to reproduce the issue locally) Apologies, pl

Re: Considering fractional paths in Append node

On 2/3/2025 09:53, Alexander Korotkov wrote: Hi, Andrei! On Fri, Dec 6, 2024 at 10:13 AM Andrei Lepikhov wrote: On 12/6/24 13:48, Andrei Lepikhov wrote: On 11/2/24 01:18, Nikita Malakhov wrote: I've corrected failing test and created a patch at Commitfest: https://commitfest.postgresql.org/

Re: Add an option to skip loading missing publication to avoid logical replication failure

On Mon, Mar 3, 2025 at 2:30 PM vignesh C wrote: > > On Tue, 25 Feb 2025 at 15:32, vignesh C wrote: > > > > The attached script has the script that was used for testing. Here the > > NUM_RECORDS count should be changed accordingly for each of the tests > > and while running the test with the patch

Re: Considering fractional paths in Append node

Hi! Thank you for your work on this subject. I agree with your code but one phrase in commit message was confusing for me: "This change is dedicated to more active usage of IndexScan and parameterised NestLoop paths in partitioned cases under an Append node, as it already works with plain t

Re: Add an option to skip loading missing publication to avoid logical replication failure

On Tue, 25 Feb 2025 at 15:32, vignesh C wrote: > > The attached script has the script that was used for testing. Here the > NUM_RECORDS count should be changed accordingly for each of the tests > and while running the test with the patch change uncomment the drop > publication command. I have don

Re: long-standing data loss bug in initial sync of logical replication

On 3/3/25 8:41 AM, Zhijie Hou (Fujitsu) wrote: A nitpick with the data for the Concurrent Transaction (2000) case. The results show that the HEAD's data appears worse than the patch data, which seems unusual. However, I confirmed that the details in the attachment are as expected, so, this seems

Re: making EXPLAIN extensible

Hi! I agree with your idea to expand the explain. On 28.02.2025 22:26, Robert Haas wrote: 0002 provides hooks that you can use to make your new EXPLAIN options actually do something. In particular, this adds a new hook that is called once per PlanState node, and a new nook that is called once pe

Re: MergeJoin beats HashJoin in the case of multiple hash clauses

On 17/2/2025 01:34, Alexander Korotkov wrote: Hi, Andrei! On Tue, Oct 8, 2024 at 8:00 AM Andrei Lepikhov wrote: Thank you for your work on this subject. I agree with the general direction. While everyone has used conservative estimates for a long time, it's better to change them only when we'

Re: bug when apply fast default mechanism for adding new column over domain with default value

On Mon, Mar 3, 2025 at 6:08 AM Tom Lane wrote: > > jian he writes: > > On Sun, Mar 2, 2025 at 7:54 AM Tom Lane wrote: > >> I think the fundamental problem here is that StoreAttrDefault > >> shouldn't be involved in this in the first place. > > > i've split missingval related code into StoreAttrM

Re: SIMD optimization for list_sort

On Sat, Mar 1, 2025 at 1:23 PM Shankaran, Akash wrote: > Given the same x86-simdsort library is intended to optimize 1) list_sort 2) > tuple sort, it didn't make sense to duplicate the work to integrate it in > pg_vector for list_sort, and then again in postgres for tuple-sort. Thank you for t

Re: per backend WAL statistics

Hi, On Mon, Mar 03, 2025 at 09:17:30AM +, Bertrand Drouvot wrote: > hmm, that would work as long as PGSTAT_BACKEND_FLUSH_ALL represents things > that need to be called from pgstat_report_wal(). But I think that's open > door for issue should be add a new PGSTAT_BACKEND_FLUSH_XXX where XXX is n

Re: Introduce "log_connection_stages" setting.

Hi all, I must admit I haven't seen the [1] either. Thank you for pointing that out, Bertrand. I agree the patch from Melanie is very close to this patch. Melanie, do you think it is realistic to merge the v8-0001-Modularize-log_connections-output.patch from [1] during the current commitfest ? I

Re: vacuumdb changes for stats import/export

On Sat, Mar 1, 2025 at 3:42 AM Nathan Bossart wrote: > > On Thu, Feb 27, 2025 at 04:36:04PM +0700, John Naylor wrote: > > I had to read it several times before I noticed the difference between > > "* found_objs" and "*found_objs". Maybe some extra spacing and breaks > > would help, or other reorg

Re: tests for pg_stat_progress_copy.tuples_skipped

On 2025/01/10 23:50, jian he wrote: hi. seems no regress tests for pg_stat_progress_copy.tuples_skipped. CopyFrom pgstat_progress_update_param(PROGRESS_COPY_TUPLES_SKIPPED, cstate->num_errors); there is coverage for it. but in regress test, we didn't really prin

Re: Support for NO INHERIT to INHERIT state change with named NOT NULL constraints

Thanks Alvaro for the review and fixup patch. I agree with your changes and merged that into the main patch along with a couple of other changes. Please find attached v6 for further review. -- Thanks & Regards, Suraj kharage, enterprisedb.com On Sat, Mar 1,

Re: doc: Mention clock synchronization recommendation for hot_standby_feedback

On 2025/03/03 16:35, Jakub Wartak wrote: Hi Amit, On Mon, Mar 3, 2025 at 6:26 AM Amit Kapila wrote: [..] OK, sure. How about something like: "Note that if the clock on standby is moved ahead or backward, the feedback message may not be sent at the required interval. This can lead to prolo

Re: [BUG]: the walsender does not update its IO statistics until it exits

Hi, On Mon, Mar 03, 2025 at 10:51:19AM +0900, Michael Paquier wrote: > On Fri, Feb 28, 2025 at 10:39:31AM +, Bertrand Drouvot wrote: > > That sounds a good idea to measure the impact of those extra calls and see > > if we'd need to mitigate the impacts. I'll collect some data. So I did some t

Re: Allow io_combine_limit up to 1MB

On Wed, Feb 12, 2025 at 3:24 PM Thomas Munro wrote: > On Wed, Feb 12, 2025 at 3:22 PM Andres Freund wrote: > > On 2025-02-12 13:59:21 +1300, Thomas Munro wrote: > > > How about just maintaining it in a new variable > > > effective_io_combine_limit, whenever either of them is assigned? > > > > Yea

Re: Options to control remote transactions’ access/deferrable modes in postgres_fdw

Hi Fujita-san, On Sun, Mar 2, 2025 at 5:14 PM Etsuro Fujita wrote: > > Hi, > > postgres_fdw opens remote transactions in read/write mode in a local > transaction even if the local transaction is read-only. I noticed > that this leads to surprising behavior like this: > > CREATE TABLE test (a in

Re: pg_stat_statements and "IN" conditions

> On Mon, Mar 03, 2025 at 12:56:24PM GMT, Álvaro Herrera wrote: > In the meantime, here's v28 which is Dmitry's v27 plus pgindent. No > other changes. Dmitry, were you planning to submit a new version? Nope, there was nothing I wanted to add so far.

Re: RFC: Additional Directory for Extensions

As promised, here is a blog article that provides more context and information about what this feature will mean in Kubernetes with CloudNativePG: https://www.gabrielebartolini.it/articles/2025/03/the-immutable-future-of-postgresql-extensions-in-kubernetes-with-cloudnativepg/ Thanks, Gabriele On

Re: pg_stat_statements and "IN" conditions

On 2025-Feb-18, Sami Imseih wrote: > > It's not a question about whether it's possible to implement this, > > but about whether it makes sense. In case of plain constants it's > > straightforward -- they will not change anything meaningfully and > > hence could be squashed from the query. Now for

Re: Add connection active, idle time to pg_stat_activity

Hello, I've rebased the patch according to the CI bot's requirements. Please have a look. Regards, Sergey From 4974c8c9440bbd6d7f9e37e882990602d69b495f Mon Sep 17 00:00:00 2001 From: Sergey Dudoladov Date: Mon, 3 Mar 2025 13:19:56 +0100 Subject: [PATCH] Adds pg_stat_session view to track statisti

RE: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.

Dear Shubham, I did a quick check and have a comment in drop_publication(). ``` + /* For cleanup purposes */ + dbinfos.dbinfo->made_publication = true; + ``` Please do not modify randomly. Currently, made_publication is set to false when the command fails. No need to set to true here

Re: making EXPLAIN extensible

Hi, +1 for the idea. I Haven't reviewed the patches yet, but I would like to share some thoughts. On Fri, Feb 28, 2025 at 5:32 PM Robert Haas wrote: > > > One thing I am wondering is whether extensions should be required to > > prefix their EXPLAIN option with the extension name to avoid > > coll

Re: Sample rate added to pg_stat_statements

On 20.02.2025 04:04, Sami Imseih wrote: In my opinion, sample rate is a better fit for pg_stat_statements, since the queries that you care about the most are usually the most frequently executed. Sampling them will still provide enough good data without the risk of not capturing statistics about

Re: Add -k/--link option to pg_combinebackup

Thanks for the new round of reviews! > 1) The new file 010_links.pl added should be included to meson.build also Added 010_links.pl to src/bin/pg_combinebackup/meson.build. > 2) Since it is a new file, "Copyright (c) 2021-2025" should be > "Copyright (c) 2025" Done! > 3) Since it is a single s

Re: Log connection establishment timings

Hi, On Fri, Feb 28, 2025 at 05:42:37PM -0500, Melanie Plageman wrote: > And all of these places we have to be super > careful that the GUCs have already been read before using > log_connections, so it seems a bit unsafe to check log_connections > (the global variable) in a function. Yeah, that co

Re: making EXPLAIN extensible

On Fri, 28 Feb 2025 at 20:26, Robert Haas wrote: > > Prior to PostgreSQL 10, EXPLAIN had just 2 options: VACUUM and > ANALYZE. I think you meant "some time prior to PostgreSQL 10". PostgreSQL 9.0 had 5 options, of which COSTS, BUFFERS, and FORMAT were newly added, so only before 9.0 we had 2 opti

Re: bug when apply fast default mechanism for adding new column over domain with default value

On Mon, Mar 3, 2025 at 4:45 PM jian he wrote: > > looking at DefineRelation comments: > * We can set the atthasdef flags now in the tuple descriptor; this just > * saves StoreAttrDefault from having to do an immediate update of the > * pg_attribute rows. > this seems not right? > De

Re: Introduce "log_connection_stages" setting.

On Mon, Mar 3, 2025 at 5:43 AM Sergey Dudoladov wrote: > > I must admit I haven't seen the [1] either. Thank you for pointing that out, > Bertrand. > I agree the patch from Melanie is very close to this patch. > > Melanie, do you think it is realistic to merge the > v8-0001-Modularize-log_connec

Re: Doc: clarify possibility of ephemeral discrepancies between state and wait_event in pg_stat_activity

Thanks for the update. This LGTM! and I will mark as RFC. -- Sami

Re: Trigger more frequent autovacuums of heavy insert tables

On Mon, Mar 03, 2025 at 12:18:37PM -0500, Melanie Plageman wrote: > I noticed the docs wording is kind of different than that in > postgresql.conf.sample. The docs wording mentions that the scale > factor gets added to the threshold and postgresql.conf.sample does not > (in master as well). I just

Re: PATCH: warn about, and deprecate, clear text passwords

On Mon, Mar 3, 2025 at 11:33 AM Nathan Bossart wrote: > I think it would be good to hear some other opinions on whether we should > consider sending clear-text passwords to the server as either 1) fully > supported, 2) deprecated but with no intent to remove anytime soon, or 3) > deprecated with t

Re: scalability bottlenecks with (many) partitions (and more)

On 3/3/25 19:10, Andres Freund wrote: > Hi, > > On 2024-09-21 20:33:49 +0200, Tomas Vondra wrote: >> I've finally pushed this, after many rounds of careful testing to ensure >> no regressions, and polishing. > > One minor nit: I don't like that FP_LOCK_SLOTS_PER_BACKEND is now non-constant > w

Re: Ubsan complaint on kestrel

Hi, On 2025-03-03 15:00:43 -0500, Tom Lane wrote: > Andres Freund writes: > > I just upgraded buildfarm animal kestrel (a buildfarm animal running with > > ubsan) to a newer version of clang. Unfortunately this causes it to fail. > > ... > > Tom, do you see any reason to not instead do the typec

Re: Flaky 003_start_stop.pl test

On Tue, Mar 4, 2025 at 5:48 AM Andres Freund wrote: > On 2025-02-24 11:26:56 +0100, Jelte Fennema-Nio wrote: > > [1]: https://cirrus-ci.com/task/5571017969500160?logs=test_world#L256 > > A possibly related test failure is: > > https://cirrus-ci.com/task/5005337046024192?logs=check_world#L259 They

Re: scalability bottlenecks with (many) partitions (and more)

Hi, On 2025-03-03 21:31:42 +0100, Tomas Vondra wrote: > On 3/3/25 19:10, Andres Freund wrote: > > On 2024-09-21 20:33:49 +0200, Tomas Vondra wrote: > >> I've finally pushed this, after many rounds of careful testing to ensure > >> no regressions, and polishing. > > > > One minor nit: I don't like

Re: what's going on with lapwing?

On Mon, Mar 3, 2025 at 2:53 PM Tom Lane wrote: > Robert Haas writes: > > lapwing has been failing sepgsql-check for over a month, but there's > > no log file: > > I believe it hasn't been updated with the buildfarm client changes > needed to run sepgsql-check since aeb8ea361. OK, thanks. The own

Re: Ubsan complaint on kestrel

Andres Freund writes: > I just upgraded buildfarm animal kestrel (a buildfarm animal running with > ubsan) to a newer version of clang. Unfortunately this causes it to fail. > ... > Tom, do you see any reason to not instead do the typecase inside > string_compare()? No. Have at it.

Re: Trigger more frequent autovacuums of heavy insert tables

On Mon, Mar 3, 2025 at 1:11 PM Nathan Bossart wrote: > > "fraction of unfrozen pages before insert vacuum" > > That more closely matches the other scale factor parameters. It's > admittedly quite terse, but so are the vast majority of other descriptions > in the sample file. I don't thin

Re: making EXPLAIN extensible

On 28/02/2025 20:26, Robert Haas wrote: Prior to PostgreSQL 10, EXPLAIN had just 2 options: VACUUM and ANALYZE. Now, we're up to 12 options, which is already quite a lot, and there's plenty more things that somebody might like to do. However, not all of those things necessarily need to be part of

Re: why there is not VACUUM FULL CONCURRENTLY?

On 2025-Feb-26, Antonin Houska wrote: > @@ -403,39 +381,38 @@ cluster_rel(Relation OldHeap, Oid indexOid, > ClusterParams *params) >* would work in most respects, but the index would only get marked as >* indisclustered in the current database, leading to unexpected > behavior >

Re: Statistics Import and Export

On Sat, Mar 1, 2025 at 4:23 PM Tom Lane wrote: > That particular argument needs to be rejected vociferously. Okay, I will concede that part of my argument. And for the record, I've written pg_dump output parsing programs many times over the years, and seen others in the wild. It's not uncommon

Re: SQL:2023 JSON simplified accessor support

Hi Matheus, On Mon, Mar 3, 2025 at 1:43 PM Matheus Alcantara wrote: > On Mon, Mar 3, 2025 at 4:16 PM Matheus Alcantara > wrote: > > > > Hi Alex, > > > > The code comments and the commit messages help a lot when reviewing! > Thanks for > > the new version. > > > > The code LGTM and check-world i

Re: Add Pipelining support in psql

(My previous message did not reach the lists, so re-sending with some edits.) On Fri, Feb 28, 2025 at 05:31:00PM +0100, Daniel Verite wrote: > The following invocations don't respect the desired output destination > and formats (ignoring them), when a pipeline is active: > > select ... \bind \g f

Re: Statistics Import and Export: difference in statistics dumped

On Mon, 2025-03-03 at 22:04 +0530, Ashutosh Bapat wrote: > But while we have hold of reltuples wasting a chance to > update it in pg_class does not look right to me. To me, autovacuum=off is a pretty clear signal that the user doesn't want this kind of side-effect to happen. Am I missing something

Re: New commitfest app release on March 4th

On Mon, 17 Feb 2025 at 10:17, Jelte Fennema-Nio wrote: > > The next release of the commitfest app will take place March 4th. > > The user facing changes are: > 1. The form for creating a commitfest entry now contains all the > commitfest entry fields, instead of redirecting to the entries edit > p

Re: Change log level for notifying hot standby is waiting non-overflowed snapshot

On 2025-03-04 03:17, Fujii Masao wrote: Agreed and I feel that a message suggesting something like "check if there are any overflowing transactions on the primary side" would make it useful. I’m wondering if this message might still be confusing for users. Would they immediately understand wh

Re: pg_trgm comparison bug on cross-architecture replication due to different char implementation

On Wed, Feb 26, 2025 at 3:12 AM Dagfinn Ilmari Mannsåker wrote: > > Masahiko Sawada writes: > > > On Tue, Feb 25, 2025 at 3:03 PM Dagfinn Ilmari Mannsåker > > wrote: > >> > >> Hi, > >> > >> While working on another round of the long option and fat comma style > >> cleanup, I noticed that the tes

Re: what's going on with lapwing?

On Mon, Mar 03, 2025 at 03:52:30PM -0500, Robert Haas wrote: > On Mon, Mar 3, 2025 at 2:53 PM Tom Lane wrote: > > Robert Haas writes: > > > lapwing has been failing sepgsql-check for over a month, but there's > > > no log file: > > > > I believe it hasn't been updated with the buildfarm client ch

Re: Log connection establishment timings

On Mon, Mar 3, 2025 at 11:14 AM Bertrand Drouvot wrote: > > > On Fri, Feb 28, 2025 at 05:52:35PM -0500, Melanie Plageman wrote: > > +bool > +check_log_connections(char **newval, void **extra, GucSource source) > +{ > > This function is pretty close to check_debug_io_direct() for example and its >

Re: Update docs for UUID data type

On Fri, Feb 28, 2025 at 1:44 PM Andy Alsup wrote: > > Masahiko, > > I like the change you've made. Pushed. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com

Re: Add -k/--link option to pg_combinebackup

On Mon, Mar 3, 2025 at 9:00 AM Israel Barth Rubio wrote: > > 2) Since it is a new file, "Copyright (c) 2021-2025" should be > > "Copyright (c) 2025" > > Done! For the record, this proposed change is not a project policy, AIUI. I don't care very much what we do here, but -1 for kibitzing the range

Re: Parallel heap vacuum

On Mon, Mar 3, 2025 at 1:28 AM Masahiko Sawada wrote: > > On Tue, Feb 25, 2025 at 4:49 PM Masahiko Sawada wrote: > > > > On Tue, Feb 25, 2025 at 2:44 PM Melanie Plageman > > wrote: > > > > > > On Tue, Feb 25, 2025 at 5:14 PM Masahiko Sawada > > > wrote: > > > > > > > > Given that we have only

Re: Adding NetBSD and OpenBSD to Postgres CI

On Tue, Mar 4, 2025 at 11:39 AM Andres Freund wrote: > On 2025-03-04 11:35:30 +1300, Thomas Munro wrote: > > I propose to turn these on by default tomorrow, unless someone speaks > > up with reasons why we shouldn't. > I'm worried about enabling them by default eating up CI credits even > faster.

Re: [PoC] Federated Authn/z with OAUTHBEARER

On Fri, Feb 28, 2025 at 4:37 PM Thomas Munro wrote: > In case it's relevant, it was green for me, but I also ran it in > combination with my 3x-go-faster patch on that other thread. . o O { > Timing/race stuff? Normally the build farm shakes that stuff out a > bit more reliably than CI, but I dou

Re: ci: Allow running mingw tests by default via environment variable

On Fri, Apr 26, 2024 at 12:02 AM Nazir Bilal Yavuz wrote: > On Sat, 13 Apr 2024 at 05:12, Andres Freund wrote: > > I propose that we instead run the task automatically if > > $REPO_MINGW_TRIGGER_BY_DEFAULT is set, typically in cirrus' per-repository > > configuration. > > > > Unfortunately that's

Re: per backend WAL statistics

On Mon, Mar 03, 2025 at 09:17:30AM +, Bertrand Drouvot wrote: > On Mon, Mar 03, 2025 at 10:48:23AM +0900, Michael Paquier wrote: >> Something that's still not quite right is that the WAL receiver and >> the WAL summarizer do not call pgstat_report_wal() at all, so we don't >> report much data a

Re: Introduce "log_connection_stages" setting.

On Mon, Mar 3, 2025 at 9:40 AM Melanie Plageman wrote: > > I'd certainly like to merge it in 18. The patch itself needs more > work, which I'm planning on doing this week. I think we have a > reasonable amount of consensus on using GUC_LIST_INPUT. > > I am less sure about merging log_disconnection

Re: Add assertion for failed alloc to palloc0() and palloc_extended()

On Mon, Mar 03, 2025 at 01:13:05PM +0900, Michael Paquier wrote: > In short, LGTM. Will apply if there are no objections. And applied as 40d3f8274499. -- Michael signature.asc Description: PGP signature

Re: Ubsan complaint on kestrel

Hi, On 2025-03-03 16:49:09 -0500, Tom Lane wrote: > Andres Freund writes: > > I wish the sanitizer treated mismatches of void * arguments against a "real > > type" different from other mismatches, but ... > > Indeed. I think we have enough coverage of that via compile-time > checks, though -- i

Re: Ubsan complaint on kestrel

Andres Freund writes: > ../../../../../home/andres/src/postgresql/src/backend/nodes/nodeFuncs.c:2712:6: > runtime error: call to function assign_query_collations_walker through > pointer to incorrect function type 'bool (*)(struct Node *, void *)' > /srv/dev/build/postgres/m-dev-assert-clang-san

Re: Adding NetBSD and OpenBSD to Postgres CI

On Sun, Mar 2, 2025 at 1:37 AM Thomas Munro wrote: > On Sat, Mar 1, 2025 at 6:24 AM Nazir Bilal Yavuz wrote: > > I think I found the problem, sd0j's fstype is not a swap. It worked like > > that: > > > > $ disklabel -E sd0 > > $ umount /usr/obj > > $ disklabel -E sd0 # prompts are: m -> j -> \n

Re: Adding NetBSD and OpenBSD to Postgres CI

On Mon, Mar 3, 2025 at 2:36 PM Thomas Munro wrote: > One non-reason to hold off is a > one-off report[1] from Jacob about an unexplained failure of the oauth > tests on NetBSD, but I'd prefer to see it flap if it's going to so we > can collect clues and tackle it. Agreed. --Jacob

Re: Adding NetBSD and OpenBSD to Postgres CI

Hi, On 2025-03-04 11:35:30 +1300, Thomas Munro wrote: > On Sun, Mar 2, 2025 at 1:37 AM Thomas Munro wrote: > > On Sat, Mar 1, 2025 at 6:24 AM Nazir Bilal Yavuz wrote: > > > I think I found the problem, sd0j's fstype is not a swap. It worked like > > > that: > > > > > > $ disklabel -E sd0 > > >

RE: Improve CRC32C performance on SSE4.2

Hi John, > You raised some interesting points, which deserve a thoughtful response. After > sleeping on it, however I came to the conclusion that a sweeping change in > runtime checks, with either of our approaches, has downsides and unresolved > questions. Perhaps we can come back to it at a lat

Re: PATCH: warn about, and deprecate, clear text passwords

On Mon, 3 Mar 2025 at 12:07, Greg Sabino Mullane wrote: > On Mon, Mar 3, 2025 at 11:33 AM Nathan Bossart > wrote: > >> I think it would be good to hear some other opinions on whether we should >> consider sending clear-text passwords to the server as either 1) fully >> supported, 2) deprecated b

Handle interrupts while waiting on Append's async subplans

While working on the big interrupts refactoring, I noticed that ExecAppendAsyncEventWait() doesn't include WL_LATCH_SET in the wait set. As a result, it will not wake up on an interrupt like a query cancel request or sinval catchup. I'm surprised this has gone unnoticed for so long. It's prett

Re: lwlocknames.h beautification attempt

On 2025-Mar-01, Gurjeet Singh wrote: > I propose the following change to the generation script, > generate-lwlocknames.pl > > -print $h "#define ${lockname}Lock (&MainLWLockArray[$lockidx].lock)\n"; > +printf $h "#define %-30s %s\n", "${lockname}Lock", > "(&MainLWLockArray[$lockidx].lock

Re: Change log level for notifying hot standby is waiting non-overflowed snapshot

On 2025/03/04 0:20, torikoshia wrote: On 2025-03-03 13:10, Fujii Masao wrote: Thanks for your comments! On 2025/02/03 22:35, torikoshia wrote: Hi, When a hot standby is restarted in a state where subtransactions have overflowed, it may become inaccessible:    $ psql: error: connection t

Re: Make COPY format extendable: Extract COPY TO format implementations

On Sun, Mar 2, 2025 at 4:19 PM Sutou Kouhei wrote: > > Hi, > > In <3191030.1740932...@sss.pgh.pa.us> > "Re: Make COPY format extendable: Extract COPY TO format implementations" > on Sun, 02 Mar 2025 11:27:20 -0500, > Tom Lane wrote: > > >> While review another thread (Emitting JSON to file u

what's going on with lapwing?

lapwing has been failing sepgsql-check for over a month, but there's no log file: https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=lapwing&dt=2025-03-03%2016%3A29%3A50&stg=contrib-sepgsql-check I feel like something must be broken with logfile collection in the buildfarm client, beca

Re: SQL:2023 JSON simplified accessor support

On Mon, Mar 3, 2025 at 4:16 PM Matheus Alcantara wrote: > > Hi Alex, > > The code comments and the commit messages help a lot when reviewing! Thanks > for > the new version. > > The code LGTM and check-world is happy. I've also performed some tests and > everything looks good! > > Just some minor

Re: Log connection establishment timings

Hi, On Fri, Feb 28, 2025 at 05:52:35PM -0500, Melanie Plageman wrote: > On Fri, Feb 28, 2025 at 12:54 AM Bertrand Drouvot > wrote: > > > > On Thu, Feb 27, 2025 at 05:55:19PM -0500, Melanie Plageman wrote: > > > It still needs polishing (e.g. I need to figure out where to put the new > > > guc ho

  1   2   >