On Mon, Mar 3, 2025 at 5:43 AM Sergey Dudoladov <sergey.dudola...@gmail.com> wrote: > > I must admit I haven't seen the [1] either. Thank you for pointing that out, > Bertrand. > I agree the patch from Melanie is very close to this patch. > > Melanie, do you think it is realistic to merge the > v8-0001-Modularize-log_connections-output.patch from [1] during the current > commitfest ?
I'd certainly like to merge it in 18. The patch itself needs more work, which I'm planning on doing this week. I think we have a reasonable amount of consensus on using GUC_LIST_INPUT. I am less sure about merging log_disconnections into log_connections. I think it makes sense in principle. But, in 18, when people satisfied with existing behavior change log_connections from 'on' to 'all' to comply with the new format, they will get the disconnections messages. I am still somewhat nervous about merging the patch in general and people being surprised because they didn't pay attention to the discussion and now log_connections is different and they would have -1'd if they'd been paying attention. - Melanie