On Mon, Mar 3, 2025 at 4:16 PM Matheus Alcantara <matheusssil...@gmail.com> wrote: > > Hi Alex, > > The code comments and the commit messages help a lot when reviewing! Thanks > for > the new version. > > The code LGTM and check-world is happy. I've also performed some tests and > everything looks good! > > Just some minor points about this new version: > > ## v9-0005 > > Typo on commit message title > > ## v9-0006 > > > + * The following functions create various types of JsonPathParseItem nodes, > > + * which are used to build JsonPath expressions for jsonb simplified > > accessor. > > > Just to avoid misinterpretation I think that we can replace "The following > functions" with "The make_jsonpath_item_* functions" since we can have more > functions in the future that are not fully related with these. Does that make > sense? >
Sorry, I've forgotten to include a question. Do you have anything in mind about documentation changes for this patch? -- Matheus Alcantara
